Re: [Musicpd-dev-team] [PATCH 1/2] ConfigData: Add support for signed integers

2013-10-19 Thread Max Kellermann
On 2013/10/19 15:38, Sebastian Thorarensen se...@naju.se wrote: +unsigned +block_param::GetUnsignedValue() const +{ + long value2 = GetIntValue(); This explicitly limits the range of unsigned integers to 2^31. Why that? I admit that the existing code is bad as well, by using strtol()

Re: [Musicpd-dev-team] [PATCH 1/2] ConfigData: Add support for signed integers

2013-10-19 Thread Sebastian Thorarensen
On Sat, 19 Oct 2013, Max Kellermann wrote: This explicitly limits the range of unsigned integers to 2^31. Why that? To save three lines of code and but I missed that it would limit the range, so it was by mistake. -- Sebastian Thorarensen