Re: RFR JDK-8087113: Websocket API and implementation

2016-04-03 Thread Simone Bordet
Hi, On Fri, Mar 25, 2016 at 5:21 PM, Pavel Rappo wrote: > Hi, > > Could you please review my change for JDK-8087113 > >http://cr.openjdk.java.net/~prappo/8087113/webrev.03/ > > This webrev contains initial implementation and basic tests for WebSocket API. >

Re: RFR JDK-8087113: Websocket API and implementation

2016-04-03 Thread Anthony Vanelverdinghe
Hi Pavel Here are my suggestions concerning the public types: java.net.http.WebSocket - order the arguments of static Builder newBuilder(URI uri, HttpClient client, Listener listener) consistently with the 2-argument method: static Builder newBuilder(URI uri, Listener listener, HttpClient