Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref) [v2]

2020-12-11 Thread Daniel Fuchs
On Fri, 11 Dec 2020 08:06:53 GMT, Alan Bateman wrote: >> Marked as reviewed by dfuchs (Reviewer). > > I think Daniel is going to sponsor this. Sorry - I lost track of this - thanks of reminding me. I will sponsor later today. - PR: https://git.openjdk.java.net/jdk/pull/779

Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref) [v2]

2020-12-11 Thread Alan Bateman
On Fri, 27 Nov 2020 09:59:29 GMT, Daniel Fuchs wrote: >> Сергей Цыпанов has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commit

Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref) [v2]

2020-11-27 Thread Daniel Fuchs
On Wed, 25 Nov 2020 08:53:18 GMT, Сергей Цыпанов wrote: >> Hello, while working with `java.net.URL` I've found unused package-private >> method `URL.set(String protocol, String host, int port, String file, String >> ref)` which can be safely removed from JDK. Testing: tier1, tier2 >> >> Could

Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref) [v2]

2020-11-25 Thread Сергей Цыпанов
> Hello, while working with `java.net.URL` I've found unused package-private > method `URL.set(String protocol, String host, int port, String file, String > ref)` which can be safely removed from JDK. Testing: tier1, tier2 > > Could someone crate an issue for tracking of this simple change? Сер