[PATCH v2 3/5] net: add Hisilicon Network Subsystem hnae framework support

2015-09-16 Thread huangdaode
HNAE (Hisilicon Network Acceleration Engine) is a framework to provide a unified ring buffer interface for Hisilicon Network Acceleration Engines. With the interface, upper layer can work as ethernet driver, ODP driver or other service driver on purpose. Signed-off-by: huangdaode Signed-off-by:

[PATCH v2 2/5] net: add Hisilicon Network Subsystem MDIO support

2015-09-16 Thread huangdaode
The MDIO support for Hisilicon Network Subsystem. It is used in Hislicon hip04, hip05 and Hi1610 SoC to control the external PHY Signed-off-by: huangdaode Signed-off-by: Yisen Zhuang Signed-off-by: Kenneth Lee --- drivers/net/ethernet/hisilicon/Kconfig | 10 +- drivers/net/ethernet/hisil

[PATCH v2 0/5] net: Hisilicon Network Subsystem support

2015-09-16 Thread huangdaode
This is V2 of Hisilicon Network Subsystem(HNS) patchesets taking care about LKML comments. Please find out the changes from the change logs. This patchset is rebased on mainline kernel Linux 4.3-rc1 branch. [PATCH v2 1/5] Device Tree Binding Documentation [PATCH v2 2/5] Merge MDIO Module [PATCH

[PATCH v2 1/5] net: add Hisilicon Network Subsystem support (config and documents)

2015-09-16 Thread huangdaode
The Hisilicon Network Subsystem is a long term evolution IP which is supposed to be used in Hisilicon ICT SoC. The IP, which is called hns for short, is a TCP/IP acceleration engine, which can directly decode TCP/IP stream and distribute them to different ring buffers. HNS can be configured to wor

[PATCH v2 5/5] net: add Hisilicon Network Subsystem basic ethernet support

2015-09-16 Thread huangdaode
This is to add basic ethernet support for HNS. It is one of the way to use the HNS acceleration engine. But most of the decoding/encoding capability of the AE cannot be used in this way. This submit contains the basic feature as a ethernet driver. More will be added later. Signed-off-by: huangdao

Re: [PATCH net-next 2/3] net: Add FIB table id to rtable

2015-09-16 Thread Simon Horman
[Cc: linux...@vger.kernel.org] On Tue, Sep 15, 2015 at 12:01:59PM -0700, David Miller wrote: > From: David Ahern > Date: Wed, 2 Sep 2015 13:58:35 -0700 > > > Add the FIB table id to rtable to make the information available for > > IPv4 as it is for IPv6. > > > > Signed-off-by: David Ahern >

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-09-16 Thread Christoph Paasch
Hello, On 10/08/15 - 11:00:15, David Miller wrote: > From: Daniel Borkmann > Date: Fri, 7 Aug 2015 00:26:41 +0200 > > Linus reports the following deadlock on rtnl_mutex; triggered only > > once so far (extract): > ... > > It seems so far plausible that the recursive call into rtnetlink_rcv() >

[PATCH nf-next 11/15] ipvs: ensure that ICMP cannot be sent in reply to ICMP

2015-09-16 Thread Simon Horman
From: Alex Gartrell Check the header for icmp before sending a PACKET_TOO_BIG Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_xmit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip

[GIT-PULL nf-next 00/15] IPVS Updates for v4.4

2015-09-16 Thread Simon Horman
Hi Pablo, please consider these IPVS Updates for v4.4. The updates include the following from Alex Gartrell: * Scheduling of ICMP * Sysctl to ignore tunneled packets; and hence some packet-looping scenarios The following changes since commit 851345c5bbb4644911f7c351c042559a71f57d19: netfilter

[PATCH nf-next 08/15] ipvs: Use outer header in ip_vs_bypass_xmit_v6

2015-09-16 Thread Simon Horman
From: Alex Gartrell The ip_vs_iphdr may refer to an internal header, so use the outer one instead. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_xmit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ne

[PATCH nf-next 04/15] ipvs: pull out ip_vs_try_to_schedule function

2015-09-16 Thread Simon Horman
From: Alex Gartrell This is necessary as we'll be trying to schedule icmp later and we'll want to share this code. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_core.c | 60 ++--- 1 file ch

[PATCH nf-next 12/15] ipvs: support scheduling inverse and icmp TCP packets

2015-09-16 Thread Simon Horman
From: Alex Gartrell In the event of an icmp packet, take only the ports instead of trying to grab the full header. In the event of an inverse packet, use the source address and port. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/i

[PATCH nf-next 13/15] ipvs: support scheduling inverse and icmp UDP packets

2015-09-16 Thread Simon Horman
From: Alex Gartrell In the event of an icmp packet, take only the ports instead of trying to grab the full header. In the event of an inverse packet, use the source address and port. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/i

[PATCH nf-next 03/15] ipvs: Handle inverse and icmp headers in ip_vs_leave

2015-09-16 Thread Simon Horman
From: Alex Gartrell Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_core.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/i

[PATCH nf-next 02/15] ipvs: Add hdr_flags to iphdr

2015-09-16 Thread Simon Horman
From: Alex Gartrell These flags contain information like whether or not the addresses are inverted or from icmp. The first will allow us to drop an inverse param all over the place, and the second will later be useful in scheduling icmp. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov

[PATCH nf-next 01/15] ipvs: replace ip_vs_fill_ip4hdr with ip_vs_fill_iph_skb_off

2015-09-16 Thread Simon Horman
From: Alex Gartrell This removes some duplicated code and makes the ICMPv6 path look more like the ICMP path. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- include/net/ip_vs.h | 49 + net/netfilter/ipvs/ip_vs_c

[PATCH nf-next 09/15] ipvs: sh: support scheduling icmp/inverse packets consistently

2015-09-16 Thread Simon Horman
From: Alex Gartrell "source_hash" the dest fields if it's an inverse packet. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_sh.c | 45 --- 1 file changed, 21 insertions(+), 24 deletions(

[PATCH nf-next 07/15] ipvs: add schedule_icmp sysctl

2015-09-16 Thread Simon Horman
From: Alex Gartrell This sysctl will be used to enable the scheduling of icmp packets. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- include/net/ip_vs.h| 11 +++ net/netfilter/ipvs/ip_vs_ctl.c | 8 +++- 2 files changed, 18 in

[PATCH nf-next 15/15] ipvs: add sysctl to ignore tunneled packets

2015-09-16 Thread Simon Horman
From: Alex Gartrell This is a way to avoid nasty routing loops when multiple ipvs instances can forward to eachother. Signed-off-by: Alex Gartrell Signed-off-by: Simon Horman --- Documentation/networking/ipvs-sysctl.txt | 10 ++ include/net/ip_vs.h | 11 ++

[PATCH nf-next 14/15] ipvs: support scheduling inverse and icmp SCTP packets

2015-09-16 Thread Simon Horman
From: Alex Gartrell In the event of an icmp packet, take only the ports instead of trying to grab the full header. In the event of an inverse packet, use the source address and port. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/i

[PATCH nf-next 10/15] ipvs: attempt to schedule icmp packets

2015-09-16 Thread Simon Horman
From: Alex Gartrell Invoke the try_to_schedule logic from the icmp path and update it to the appropriate ip_vs_conn_put function. The schedule functions have been updated to reject the packets immediately for now. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Ho

[PATCH nf-next 05/15] ipvs: drop inverse argument to conn_{in,out}_get

2015-09-16 Thread Simon Horman
From: Alex Gartrell No longer necessary since the information is included in the ip_vs_iphdr itself. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- include/net/ip_vs.h | 12 net/netfilter/ipvs/ip_vs_conn.c | 12

[PATCH nf-next 06/15] ipvs: Make ip_vs_schedule aware of inverse iph'es

2015-09-16 Thread Simon Horman
From: Alex Gartrell This is necessary to schedule icmp later. Signed-off-by: Alex Gartrell Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_core.c | 50 + 1 file changed, 36 insertions(+), 14 deletions(-) diff --git

Re: kernel 4.2 : "bridge vlan" command return empty result (works with kernel 4.1.3)

2015-09-16 Thread roopa
On 9/16/15, 8:36 PM, Alexandre DERUMIER wrote: he problem went away on my box with the following patch. I will submit an official patch in a bit. Hi, I confirm that your patch fix the problem for me too. Thanks for confirming. -- To unsubscribe from this list: send the line "unsubscribe netdev

[PATCH net] fjes: fix off-by-one error at fjes_hw_update_zone_task()

2015-09-16 Thread Taku Izumi
Dan Carpenter reported off-by-one error of fjes at http://www.mail-archive.com/netdev@vger.kernel.org/msg77520.html Actually this is a bug. ep_shm_info[epidx].{es_status, zone} should be update inside for loop. This patch fixes this bug. Reported-by: Dan Carpenter Signed-off-by: Taku Izumi ---

Re: Possible netlink autobind regression

2015-09-16 Thread Herbert Xu
On Wed, Sep 16, 2015 at 10:02:00PM -0700, Cong Wang wrote: > > This part doesn't look correct, seems it is checking if this is a kernel > netlink socket rather than if it is bound. But I am not sure... Good point. I've changed it so that bound is only set for non-kernel sockets. ---8<--- netlink

Re: Possible netlink autobind regression

2015-09-16 Thread Cong Wang
On Wed, Sep 16, 2015 at 8:41 PM, Herbert Xu wrote: > On Thu, Sep 17, 2015 at 11:08:45AM +0800, Herbert Xu wrote: >> >> Good catch! I think your explanation makes perfect sense. Linus >> ran into this previously too after suspend-and-resume. > > Unfortunately you can't just postpone the setting of

Re: Possible netlink autobind regression

2015-09-16 Thread Herbert Xu
On Thu, Sep 17, 2015 at 11:08:45AM +0800, Herbert Xu wrote: > > Good catch! I think your explanation makes perfect sense. Linus > ran into this previously too after suspend-and-resume. Unfortunately you can't just postpone the setting of portid because once you pass it onto rhashtable the portid

Re: kernel 4.2 : "bridge vlan" command return empty result (works with kernel 4.1.3)

2015-09-16 Thread Alexandre DERUMIER
>>he problem went away on my box with the following patch. I >>will submit an official patch in a bit. Hi, I confirm that your patch fix the problem for me too. Regards, Alexandre - Mail original - De: "roopa" À: "aderumier" Cc: "netdev" , "Scott Feldman" Envoyé: Mardi 15 Septembre

Re: Possible netlink autobind regression

2015-09-16 Thread Herbert Xu
On Wed, Sep 16, 2015 at 10:29:09PM -0400, Tejun Heo wrote: > > Anyways, after the patch, it seems something like the following could > happen. Good catch! I think your explanation makes perfect sense. Linus ran into this previously too after suspend-and-resume. I'll look into it. Thanks! -- Em

Possible netlink autobind regression

2015-09-16 Thread Tejun Heo
Hello, We're seeing processes piling up on audit_cmd_mutex and after some digging it turns out sometimes audit_receive() ends up recursing into itself causing an A-A deadlock on audit_cmd_mutex. Here's the backtrace. PID: 1939995 TASK: 88085bdde360 CPU: 27 COMMAND: "crond" #0 [8803

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread KY Srinivasan
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, September 16, 2015 2:39 PM > To: KY Srinivasan ; David Laight > ; Haiyang Zhang ; > Vitaly Kuznetsov ; netdev@vger.kernel.org > Cc: David S. Miller ; linux-ker...@vger.kernel.org; > Jason Wa

Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Ying Xue
On 08/07/2015 03:59 PM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda Reviewed-by: Ying Xue > --- > net/tipc/serve

Re: list of all network namespaces

2015-09-16 Thread Rick Jones
On 09/16/2015 05:46 PM, Ani Sinha wrote: Hi guys just a stupid question. Is it possible to get a list of all active network namespaces in the kernel through /proc or some other interface? Presumably you could copy what "ip netns" does, which appears to be to look in /var/run/netns . At least

list of all network namespaces

2015-09-16 Thread Ani Sinha
Hi guys just a stupid question. Is it possible to get a list of all active network namespaces in the kernel through /proc or some other interface? thanks ani -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH net-next v2] net: Initialize table in fib result

2015-09-16 Thread Florian Fainelli
On 16/09/15 09:16, David Ahern wrote: > The root cause is use of res.table uninitialized. > > Thanks to Nikolay for noticing the uninitialized use amongst the maze of > gotos. > > As Nikolay pointed out the second initialization is not required to fix > the oops, but rather to fix a related probl

Re: [PATCH net-next v2] net: Initialize table in fib result

2015-09-16 Thread Sergey Senozhatsky
On (09/16/15 10:16), David Ahern wrote: [..] > The root cause is use of res.table uninitialized. > > Thanks to Nikolay for noticing the uninitialized use amongst the maze of > gotos. > > As Nikolay pointed out the second initialization is not required to fix > the oops, but rather to fix a relate

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread KY Srinivasan
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, September 16, 2015 4:49 PM > To: KY Srinivasan ; David Laight > ; Haiyang Zhang ; > Vitaly Kuznetsov ; netdev@vger.kernel.org > Cc: David S. Miller ; linux-ker...@vger.kernel.org; > Jason Wa

[PATCH net-next 1/2] net: bcmgenet: Implement TX coalescing control knobs

2015-09-16 Thread Florian Fainelli
Configuring the ethtool tx-frames property, which translates into N packets before a TX interrupt is the simplest configuration scheme because it requires no locking neither at the softare nor hardware level, and is completely indepedent from the link speed. Since ethtool does not allow per-tx queu

[PATCH net-next 0/2] net: bcmgenet: Interrupt coalescing

2015-09-16 Thread Florian Fainelli
Hi David, Petri, Jaedon, This patch series adds support for interrupt coalescing for GENET adapters. Florian Fainelli (2): net: bcmgenet: Implement TX coalescing control knobs net: bcmgenet: Implement RX coalescing control knobs drivers/net/ethernet/broadcom/genet/bcmgenet.c | 150 +

[PATCH net-next 2/2] net: bcmgenet: Implement RX coalescing control knobs

2015-09-16 Thread Florian Fainelli
Add support for the ethtool rx-frames coalescing parameter which allows defining the number of RX interrupts per frames received. The RDMA engine supports a configurable timeout with a resolution of approximately 8.192 us. We can no longer enable the BDONE/PDONE interrupts as those would fire for

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Alexander Duyck
On 09/16/2015 03:57 PM, KY Srinivasan wrote: -Original Message- From: Alexander Duyck [mailto:alexander.du...@gmail.com] Sent: Wednesday, September 16, 2015 2:39 PM To: KY Srinivasan ; David Laight ; Haiyang Zhang ; Vitaly Kuznetsov ; netdev@vger.kernel.org Cc: David S. Miller ; linux-k

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread Sergey Senozhatsky
On (09/16/15 07:07), David Ahern wrote: > Hi Sergey: > Hi, sorry for long reply. Baremetal. So grabbing the backtrace is a bit complicated. But it looks very close to what Richard Alpe has posted. in IRQ RIP is at ip_route_input_noref [0.877597] [] arp_process+0x39c/0x690 [0.877597]

[PATCH net 5/6] lan78xx: Create lan78xx_get_mdix_status() and lan78xx_set_mdix_status() for MDIX control.

2015-09-16 Thread Woojung.Huh
Create lan78xx_get_mdix_status() and lan78xx_set_mdix_status() for MDIX control. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 90 +++ 1 file changed, 52 insertions(+), 38 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/

[PATCH net 6/6] lan78xx: Remove not defined MAC_CR_GMII_EN_ bit from MAC_CR.

2015-09-16 Thread Woojung.Huh
Remove not defined MAC_CR_GMII_EN_ bit from MAC_CR. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 3 --- drivers/net/usb/lan78xx.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 9102c71..bfac0db 100644 --- a/drivers/n

[PATCH net 4/6] lan78xx: Remove phy defines in lan78xx.h and use defines in include/linux/microchipphy.h

2015-09-16 Thread Woojung.Huh
Remove phy defines in lan78xx.h and use defines in include/linux/microchipphy.h. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 80 +-- drivers/net/usb/lan78xx.h | 192 -- 2 files changed, 40 insertions(+), 232 deletions(-)

[PATCH net 2/6] lan78xx: Add PHYLIB and MICROCHIP_PHY as default config.

2015-09-16 Thread Woojung.Huh
Add PHYLIB and MICROCHIP_PHY as default configuration for lan78xx. Signed-off-by: Woojung Huh --- drivers/net/usb/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index 1610b79..d9ca7aa 100644 --- a/drivers/net/usb/Kconfig +++ b/driv

[PATCH net 3/6] lan78xx: Update to use phylib instead of mii_if_info.

2015-09-16 Thread Woojung.Huh
Update to use phylib instead of mii_if_info. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 618 +++--- 1 file changed, 256 insertions(+), 362 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index d0d8790..04e6f

[PATCH net 1/6] lan78xx: Check device ready bit (PMT_CTL_READY_) after reset the PHY

2015-09-16 Thread Woojung.Huh
Check device ready bit (PMT_CTL_READY_) after reset the PHY. Device may not be ready even if PHY_RST_ is cleared depends on configuration. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/lan78xx.c b/driv

Re: [net-next:master 6/12] include/linux/usb/cdc.h:23: error: redefinition of 'struct usb_cdc_parsed_header'

2015-09-16 Thread Fengguang Wu
On Wed, Sep 16, 2015 at 10:54:54AM -0700, David Miller wrote: > From: Fengguang Wu > Date: Wed, 16 Sep 2015 21:06:58 +0800 > > > On Tue, Sep 15, 2015 at 01:27:42PM -0700, David Miller wrote: > >> From: kbuild test robot > >> Date: Wed, 16 Sep 2015 03:57:11 +0800 > >> > >> > All error/warnings (

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Alexander Duyck
On 09/16/2015 10:55 AM, KY Srinivasan wrote: -Original Message- From: David Laight [mailto:david.lai...@aculab.com] Sent: Wednesday, September 16, 2015 9:25 AM To: Haiyang Zhang ; Vitaly Kuznetsov ; netdev@vger.kernel.org Cc: David S. Miller ; linux-ker...@vger.kernel.org; KY Srinivasan

Re: [PATCH RFC 0/3] Allow postponed netfilter handling for socket matches

2015-09-16 Thread Florian Westphal
Daniel Mack wrote: > I'm re-addressing the issue of matching socket meta information for > non-established sockets that has been discussed a while ago: > > http://article.gmane.org/gmane.comp.security.firewalls.netfilter.devel/56877 > > Being able to reliably match on net_cls cgroup ids is cru

Re: [PATCH] net: qdisc: enhance default_qdisc documentation

2015-09-16 Thread Cong Wang
On Tue, Sep 15, 2015 at 1:33 AM, Phil Sutter wrote: > Aside from some lingual cleanup, point out which interfaces are not or > partly covered by this setting. > > Signed-off-by: Phil Sutter Acked-by: Cong Wang It also worth to explain what the default qdisc means, but we can do that in another

[PATCH net-next v2] xen-netfront: always set num queues if possible

2015-09-16 Thread Charles (Chas) Williams
If netfront connects with two (or more) queues and then reconnects with only one queue it fails to delete or rewrite the multi-queue-num-queues key and netback will try to use the wrong number of queues. Always write the num-queues field if the backend has multi-queue support. Signed-off-by: Chas

[PATCH v2] atm: deal with setting entry before mkip was called

2015-09-16 Thread Sasha Levin
If we didn't call ATMARP_MKIP before ATMARP_ENCAP the VCC descriptor is non-existant and we'll end up dereferencing a NULL ptr: [1033173.491930] kasan: GPF could be caused by NULL-ptr deref or user memory accessirq event stamp: 123386 [1033173.493678] general protection fault: [#1] PREEMPT S

Re: [PATCH net-next] net: fix cdc-phonet.c dependency and build error

2015-09-16 Thread David Miller
From: Randy Dunlap Date: Wed, 16 Sep 2015 11:32:41 -0700 > From: Randy Dunlap > > Fix build error caused by missing Kconfig dependency: > > ERROR: "cdc_parse_cdc_header" [drivers/net/usb/cdc-phonet.ko] undefined! > > Reported-by: Fengguang Wu > Signed-off-by: Randy Dunlap Applied, thanks R

[PATCH net-next] net: fix cdc-phonet.c dependency and build error

2015-09-16 Thread Randy Dunlap
1 deletion(-) --- linux-next-20150916.orig/drivers/net/usb/Kconfig +++ linux-next-20150916/drivers/net/usb/Kconfig @@ -541,7 +541,7 @@ config USB_NET_INT51X1 config USB_CDC_PHONET tristate "CDC Phonet support" - depends on PHONET + depends on PHONET && USB_USBNET

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread David Miller
From: David Laight Date: Wed, 16 Sep 2015 16:25:03 + > Am I right in thinking this is adding an extra 96 unused bytes to the front > of almost all skb just so that hyper-v can make its link level header > contiguous with whatever follows (IP header ?). > > Doesn't sound ideal. Agreed, this

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread KY Srinivasan
> -Original Message- > From: David Laight [mailto:david.lai...@aculab.com] > Sent: Wednesday, September 16, 2015 9:25 AM > To: Haiyang Zhang ; Vitaly Kuznetsov > ; netdev@vger.kernel.org > Cc: David S. Miller ; linux-ker...@vger.kernel.org; > KY Srinivasan ; Jason Wang > Subject: RE: [PA

Re: [net-next:master 6/12] include/linux/usb/cdc.h:23: error: redefinition of 'struct usb_cdc_parsed_header'

2015-09-16 Thread David Miller
From: Fengguang Wu Date: Wed, 16 Sep 2015 21:06:58 +0800 > On Tue, Sep 15, 2015 at 01:27:42PM -0700, David Miller wrote: >> From: kbuild test robot >> Date: Wed, 16 Sep 2015 03:57:11 +0800 >> >> > All error/warnings (new ones prefixed by >>): >> > >> >In file included from drivers/usb/gadg

Re: [PATCH] ARCNET: fix hard_header_len limit

2015-09-16 Thread David Miller
From: Michael Grzeschik Date: Wed, 16 Sep 2015 14:47:13 +0200 > I have the cleanup patches from Joe Perches and several ARCNET patches > on top, waiting to be posted on the list. What is your Opinion to my > Maintainer Request I send some weeks ago? Please just repost this patch anew, thanks. --

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Alexander Duyck
On 09/16/2015 09:25 AM, David Laight wrote: From: Haiyang Zhang Sent: 16 September 2015 17:09 -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, September 16, 2015 11:50 AM To: netdev@vger.kernel.org Cc: David S. Miller ; linux-ker...@vger.kernel.org

Re: [PATCH] man ip-link: Add more explanation about vlan reordering

2015-09-16 Thread Vadim Kochan
On Wed, Aug 26, 2015 at 04:27:48PM +0100, Jeremy Harris wrote: > On 17/08/15 20:22, Vadim Kochan wrote: > > +.BR reorder_hdr " is " on > > +then VLAN header will be not inserted immediately but only before passing > > to the > > +physical device (if this device does not support VLAN offloading), t

[PATCH iproute2] man ip-link: Fix wording in VLAN reorder_hdr explanation

2015-09-16 Thread Vadim Kochan
From: Vadim Kochan Signed-off-by: Vadim Kochan --- man/man8/ip-link.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 1896eb6..4928249 100644 --- a/man/man8/ip-link.8.in +++ b/man/man8/ip-link.8.in @@ -327,7 +327,7 @@ ph

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread David Laight
From: Haiyang Zhang > Sent: 16 September 2015 17:09 > > -Original Message- > > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > Sent: Wednesday, September 16, 2015 11:50 AM > > To: netdev@vger.kernel.org > > Cc: David S. Miller ; linux-ker...@vger.kernel.org; > > KY Srinivasan ; Haiy

Re: [PATCH net-next v2] net: Initialize table in fib result

2015-09-16 Thread Nikolay Aleksandrov
On 09/16/2015 06:16 PM, David Ahern wrote: > Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., > from Richard: > > [0.877040] BUG: unable to handle kernel NULL pointer dereference at > 0056 > [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 > [0.

[PATCH net-next v2] net: Initialize table in fib result

2015-09-16 Thread David Ahern
Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., from Richard: [0.877040] BUG: unable to handle kernel NULL pointer dereference at 0056 [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 [0.877597] PGD 3fa14067 PUD 3fa6e067 PMD 0 [0.877597] Oo

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, September 16, 2015 11:50 AM > To: netdev@vger.kernel.org > Cc: David S. Miller ; linux-ker...@vger.kernel.org; > KY Srinivasan ; Haiyang Zhang > ; Jason Wang > Subject: [PATCH net-next RFC] net:

Re: [PATCH net-next] net: Initialize table in fib result

2015-09-16 Thread Fabio Estevam
On Wed, Sep 16, 2015 at 12:38 PM, David Ahern wrote: > The root cause is use of res.table uninitialized. > > Thanks to Nikolay for noticing the uninitialized use amongst the maze of > gotos. > > Fixes: b7503e0cdb5d ("net: Add FIB table id to rtable") > Reported-by: Sergey Senozhatsky > Reported-

Re: [PATCH net-next] net: Initialize table in fib result

2015-09-16 Thread David Ahern
On 9/16/15 9:56 AM, Nikolay Aleksandrov wrote: Just to have it documented: I don't think we need the second NULLing, but it doesn't hurt. I think we do. After the second one there is a goto to local_input which uses res.table. The second goto is reachable 'if !IN_DEV_FORWARD(in_dev)' in which

[PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Vitaly Kuznetsov
Commit b08cc79155fc26d0d112b1470d1ece5034651a4b ("hv_netvsc: Eliminate memory allocation in the packet send path") introduced skb headroom request for Hyper-V netvsc driver: max_needed_headroom = sizeof(struct hv_netvsc_packet) + sizeof(struct rndis_message)

[PATCH RFC 1/3] netfilter: add socket to struct nft_pktinfo

2015-09-16 Thread Daniel Mack
The high-level netfilter hook API already enables users to pass a socket, but that information is lost when the chains are walked. In order to let internal eval callbacks use the passed filter rather than skb->sk, add a pointer of type 'struct sock' to 'struct nft_pktinfo' and set that field via n

Re: [PATCH net-next] net: Initialize table in fib result

2015-09-16 Thread Nikolay Aleksandrov
On 09/16/2015 05:38 PM, David Ahern wrote: > Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., > from Richard: > > [0.877040] BUG: unable to handle kernel NULL pointer dereference at > 0056 > [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 > [0.

[PATCH RFC 2/3] netfilter: nft_meta: mark skbs for postponed filter processing

2015-09-16 Thread Daniel Mack
When the cgroup matching code in nft_meta is called without a socket to look at, it currently bails out and lets the packet pass. This is bad, because the reason for skb->sk being NULL is simply that the packet was directed to a socket that hasn't been looked up yet by early demux. This patch does

[PATCH RFC 3/3] net: tcp_ipv4: re-run netfilter chains for marked skbs

2015-09-16 Thread Daniel Mack
When an skb has been marked for later re-iteration through netfilter, do that after __inet_lookup_skb() has been called. This allows packets sent to unconnected sockets to be filtered reliably. Note that this will never happen for subsequent packets in the same stream, as skb->sk will be set due t

[PATCH RFC 0/3] Allow postponed netfilter handling for socket matches

2015-09-16 Thread Daniel Mack
I'm re-addressing the issue of matching socket meta information for non-established sockets that has been discussed a while ago: http://article.gmane.org/gmane.comp.security.firewalls.netfilter.devel/56877 Being able to reliably match on net_cls cgroup ids is crucial in order to build a per-app

[PATCH net-next] net: Initialize table in fib result

2015-09-16 Thread David Ahern
Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., from Richard: [0.877040] BUG: unable to handle kernel NULL pointer dereference at 0056 [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 [0.877597] PGD 3fa14067 PUD 3fa6e067 PMD 0 [0.877597] Oo

Re: IPv6 routing/fragmentation panic

2015-09-16 Thread Florian Westphal
David Woodhouse wrote: > > if (frag->len > mtu || > > ((frag->len & 7) && frag->next) || > > - skb_headroom(frag) < hlen) > > + skb_headroom(frag) < (hlen + hroom)) > >

[PATCH net] ipv6: ip6_fragment: fix headroom tests and skb leak

2015-09-16 Thread Florian Westphal
David Woodhouse reports skb_under_panic when we try to push ethernet header to fragmented ipv6 skbs: skbuff: skb_under_panic: text:c1277f1e len:1294 put:14 head:dec98000 data:dec97ffc tail:0xdec9850a end:0xdec98f40 dev:br-lan [..] ip6_finish_output2+0x196/0x4da David further debugged this: [.

Re: Experiences with slub bulk use-case for network stack

2015-09-16 Thread Christoph Lameter
On Wed, 16 Sep 2015, Jesper Dangaard Brouer wrote: > > Hint, this leads up to discussing if current bulk *ALLOC* API need to > be changed... > > Alex and I have been working hard on practical use-case for SLAB > bulking (mostly slUb), in the network stack. Here is a summary of > what we have lear

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread David Ahern
On 9/16/15 9:00 AM, Fabio Estevam wrote: On Wed, Sep 16, 2015 at 6:24 AM, Sergey Senozhatsky wrote: added by b7503e0cdb5dbec5d201aa69dc14679b5ae8 net: Add FIB table id to rtable Add the FIB table id to rtable to make the information available for IPv4 as it is for IPv6.

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread Fabio Estevam
at virtual address 0007 pgd = c0004000 [0007] *pgd= Internal error: Oops: 1 [#1] PREEMPT ARM Modules linked in: CPU: 0 PID: 0 Comm: swapper Not tainted 4.3.0-rc1-next-20150916-dirty #96 Hardware name: Freescale i.MX25 (Device Tree Support) task: c06ac1d0 ti: c06a8000 task.ti:

Re: [PATCH 2/2] airo: Implement netif_carrier_on/off

2015-09-16 Thread Sergei Shtylyov
Hello. On 9/15/2015 6:18 PM, Ondrej Zary wrote: Add calls to netif_carrier_on and netif_carrier_off Signed-off-by: Ondrej Zary --- drivers/net/wireless/airo.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread Richard Alpe
On 2015-09-16 15:57, David Ahern wrote: > On 9/16/15 7:53 AM, Richard Alpe wrote: I to get an Oops in ip_route_input_noref(). It happens occasionally during bootup. KVM environment using virtio driver. Let me know if you need any additional info or if you want me to try t

Re: IPv6 routing/fragmentation panic

2015-09-16 Thread David Woodhouse
On Wed, 2015-09-16 at 15:27 +0200, Florian Westphal wrote: > @@ -599,7 +600,7 @@ int ip6_fragment(struct sock *sk, struct sk_buff > *skb, > /* Correct geometry. */ > if (frag->len > mtu || > ((frag->len & 7) && frag->next)

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread Richard Alpe
On 2015-09-16 15:53, Richard Alpe wrote: > On 2015-09-16 15:07, David Ahern wrote: >> On 9/16/15 5:50 AM, Richard Alpe wrote: >>> On 2015-09-16 11:24, Sergey Senozhatsky wrote: >>>> Hi, >>>> >>>> 4.3.0-rc1-next-20150916 >>>> >

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread David Ahern
On 9/16/15 7:59 AM, Richard Alpe wrote: Sorry about that kvm cmdline was a copy-paste error. Here's the right one using virtio. I was just about to respond to that as well... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread David Ahern
On 9/16/15 7:53 AM, Richard Alpe wrote: I to get an Oops in ip_route_input_noref(). It happens occasionally during bootup. KVM environment using virtio driver. Let me know if you need any additional info or if you want me to try to bisect it. Starting network... ... [0.877040] BUG: unable

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread Richard Alpe
On 2015-09-16 15:07, David Ahern wrote: > On 9/16/15 5:50 AM, Richard Alpe wrote: >> On 2015-09-16 11:24, Sergey Senozhatsky wrote: >>> Hi, >>> >>> 4.3.0-rc1-next-20150916 >>> >>> oops after removal of rndis usb device > > Hi Sergey: &g

Re: IPv6 routing/fragmentation panic

2015-09-16 Thread David Woodhouse
On Wed, 2015-09-16 at 15:27 +0200, Florian Westphal wrote: > > David, could you test this? I'd do an official patch submission > then. Compiles. Doesn't fix the problem. -- dwmw2 smime.p7s Description: S/MIME cryptographic signature

[PATCH net] bna: check for dma mapping errors

2015-09-16 Thread Ivan Vecera
Check for DMA mapping errors, recover from them and register them in ethtool stats like other errors. Cc: Rasesh Mody Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna_tx_rx.c| 2 ++ drivers/net/ethernet/brocade/bna/bna_types.h| 1 + drivers/net/ethernet/brocade/bna/

Re: IPv6 routing/fragmentation panic

2015-09-16 Thread Florian Westphal
David Woodhouse wrote: > On Wed, 2015-09-16 at 01:48 +0200, Florian Westphal wrote: > > > > What I don't understand is why you see this with fragmented ipv6 > > packets only (and not with all ipv6 forwarded skbs). > > > > Something like this copy-pastry from ip_finish_output2 should fix it: >

Re: [PATCH v2] solos-pci: Increase headroom on received packets

2015-09-16 Thread Eric Dumazet
On Wed, 2015-09-16 at 12:35 +0100, David Woodhouse wrote: > A comment in include/linux/skbuff.h says that: > > * Various parts of the networking layer expect at least 32 bytes of > * headroom, you should not reduce this. > > This was demonstrated by a panic when handling fragmented IPv6 packets

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread David Ahern
On 9/16/15 3:24 AM, Sergey Senozhatsky wrote: Hi, 4.3.0-rc1-next-20150916 oops after removal of rndis usb device Sergey: Can you send me the oops output? Thanks, David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-09-16 Thread Marcelo Ricardo Leitner
On Thu, Aug 27, 2015 at 08:40:29AM +0200, Jiri Pirko wrote: > Thu, Aug 27, 2015 at 08:36:03AM CEST, da...@davemloft.net wrote: > >From: Jiri Pirko > >Date: Thu, 27 Aug 2015 08:27:04 +0200 > > > >> I'm not saying it is not possible, it certainly is. But I think that > >> for example rocker internal

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread David Ahern
On 9/16/15 5:50 AM, Richard Alpe wrote: On 2015-09-16 11:24, Sergey Senozhatsky wrote: Hi, 4.3.0-rc1-next-20150916 oops after removal of rndis usb device Hi Sergey: Is this with KVM or baremetal? -8<- thanks for the analysis addr2line -e vmlinux -i 0x8146c0b1 net/i

Re: [net-next:master 6/12] include/linux/usb/cdc.h:23: error: redefinition of 'struct usb_cdc_parsed_header'

2015-09-16 Thread Fengguang Wu
On Tue, Sep 15, 2015 at 01:27:42PM -0700, David Miller wrote: > From: kbuild test robot > Date: Wed, 16 Sep 2015 03:57:11 +0800 > > > All error/warnings (new ones prefixed by >>): > > > >In file included from drivers/usb/gadget/function/u_ether.h:20, > > from drivers/usb/

Re: [PATCH] ARCNET: fix hard_header_len limit

2015-09-16 Thread Michael Grzeschik
On Wed, Aug 05, 2015 at 05:34:51PM +0200, Michael Grzeschik wrote: > On Thu, Jul 30, 2015 at 11:16:36AM -0700, David Miller wrote: > > From: Michael Grzeschik > > Date: Thu, 30 Jul 2015 15:34:36 +0200 > > > > > The commit <9c7077622dd9> ("packet: make packet_snd fail on len smaller > > > than l2

Re: [ANNOUNCE] libnftnl 1.0.4 release

2015-09-16 Thread Jan Engelhardt
On Wednesday 2015-09-16 13:50, Pablo Neira Ayuso wrote: >The Netfilter project proudly presents: > >libnftnl 1.0.4 $ git diff libnftnl-1.0.3..libnftnl-1.0.4 src/libnftnl.map diff --git a/src/libnftnl.map b/src/libnftnl.map index be7b998..14ec88c 100644 --- a/src/libnftnl.map +++ b/src/lib

Re: [linux-next] oops in ip_route_input_noref

2015-09-16 Thread Richard Alpe
On 2015-09-16 11:24, Sergey Senozhatsky wrote: > Hi, > > 4.3.0-rc1-next-20150916 > > oops after removal of rndis usb device > > ... > 8146c052: 00 > 8146c053: 0f b6 55 8a movzbl -0x76(%rbp),%edx > 8146c057:

  1   2   >