Re: [RFC PATCH kernel] Revert "net/mlx4_core: Add port attribute when tracking counters"

2015-09-21 Thread Alexey Kardashevskiy
On 09/20/2015 11:51 PM, Or Gerlitz wrote: On Tue, Sep 15, 2015 at 1:41 PM, Alexey Kardashevskiy wrote: Any luck with that? I am checking with the team if they can set a PPC node to try and reproduce the crash, on x86 they don't see it. Somehow I cannot reproduce it anymore on v4.2 kernel wh

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

2015-09-21 Thread Jiri Pirko
Tue, Sep 22, 2015 at 03:36:28AM CEST, vivien.dide...@savoirfairelinux.com wrote: >Hi Jiri, > >On Sep. Monday 21 (39) 08:25 PM, Jiri Pirko wrote: >> Mon, Sep 21, 2015 at 07:13:58PM CEST, vivien.dide...@savoirfairelinux.com >> wrote: >> >Hi Jiri, Scott, >> > >> >On Sep. Monday 21 (39) 10:09 AM, Jiri

Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter

2015-09-21 Thread Alexander Duyck
On 09/21/2015 09:14 PM, Jarod Wilson wrote: Alexander Duyck wrote: On 09/21/2015 10:11 AM, Jarod Wilson wrote: Some pci changes upcoming in 4.3 seem to cause additional disconnects, which can happen at unfortuitous times for igb, leading to issues such as this, where the disconnect happened jus

Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter

2015-09-21 Thread Mark Rustad
On 9/21/15 9:14 PM, Jarod Wilson wrote: > Just switching to adapter->io_addr everywhere seems to not work as > noted above. :\ Note that I'm also chasing this from the other end > with the author of the pci patches that seem to have triggered this, > so the real bug might be over in pci-land, bu

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 8:21 PM, Eric Dumazet wrote: > On Mon, 2015-09-21 at 19:49 -0700, Pravin Shelar wrote: >> On Mon, Sep 21, 2015 at 7:14 PM, Eric Dumazet wrote: >> > On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: >> >> On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: >> >> > F

Re: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

2015-09-21 Thread Harini Katakam
Hi Richard, On Tue, Sep 22, 2015 at 12:09 AM, Richard Cochran wrote: > On Mon, Sep 21, 2015 at 11:19:32PM +0530, Harini Katakam wrote: >> Ping > > 1) trim your replies > > 2) put the PTP maintainer on PTP patches for review > I'm sorry I missed that. Will do so in the future. Regards, Harini --

Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter

2015-09-21 Thread Jarod Wilson
Alexander Duyck wrote: On 09/21/2015 10:11 AM, Jarod Wilson wrote: Some pci changes upcoming in 4.3 seem to cause additional disconnects, which can happen at unfortuitous times for igb, leading to issues such as this, where the disconnect happened just before igb_configure_tx_ring(): [ 414.4401

Re: linux-next: build failure after merge of the bluetooth tree

2015-09-21 Thread David Miller
From: Stephen Rothwell Date: Tue, 22 Sep 2015 11:20:15 +1000 > From: Stephen Rothwell > Subject: drivers/net/ieee802154/at86rf230.c: seq_printf() now returns NULL > > Signed-off-by: Stephen Rothwell > Cc: Alexander Aring > Cc: Stefan Schmidt > Cc: Marcel Holtmann > Signed-off-by: Andrew Mor

[PATCH v2] netlink: Replace rhash_portid with bound

2015-09-21 Thread Herbert Xu
On Mon, Sep 21, 2015 at 02:20:22PM -0400, Tejun Heo wrote: > > store_release and load_acquire are different from the usual memory > barriers and can't be paired this way. You have to pair store_release > and load_acquire. Besides, it isn't a particularly good idea to OK I've decided to drop the

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Eric Dumazet
On Mon, 2015-09-21 at 19:49 -0700, Pravin Shelar wrote: > On Mon, Sep 21, 2015 at 7:14 PM, Eric Dumazet wrote: > > On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: > >> On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: > >> > From: Pravin B Shelar > >> > Date: Sun, 20 Sep 2015 23:53:17

[PATCH net v2] openvswitch: Zero flows on allocation.

2015-09-21 Thread Jesse Gross
When support for megaflows was introduced, OVS needed to start installing flows with a mask applied to them. Since masking is an expensive operation, OVS also had an optimization that would only take the parts of the flow keys that were covered by a non-zero mask. The values stored in the remaining

[PATCH net-next] Driver: Vmxnet3: Extend register dump support

2015-09-21 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare Signed-off-by: Bhavesh Davda Acked-by: Srividya Murali --- drivers/net/vmxnet3/vmxnet3_ethtool.c | 118 ++ drivers/net/vmxnet3/vmxnet3_int.h | 4 +- 2 files changed, 92 insertions(+), 30 deletions(-) diff --git a/drivers/ne

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 7:14 PM, Eric Dumazet wrote: > On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: >> On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: >> > From: Pravin B Shelar >> > Date: Sun, 20 Sep 2015 23:53:17 -0700 >> > >> >> VXLAN device can receive skb with checksum parti

Re: DSA: phy polling

2015-09-21 Thread Andrew Lunn
On Mon, Sep 14, 2015 at 11:42:54AM +0100, Russell King - ARM Linux wrote: > Andrew, > > I think you're the current maintainer of the Marvell DSA code, as being > the most recent author of changes to it. :) Hi Russell Sorry for the slow reply, i've been on vacation. Humm, i suppose i might be th

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Eric Dumazet
On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: > On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: > > From: Pravin B Shelar > > Date: Sun, 20 Sep 2015 23:53:17 -0700 > > > >> VXLAN device can receive skb with checksum partial. But the checksum > >> offset could be in outer header whi

Re: 4.1.0, kernel panic, pppoe_release

2015-09-21 Thread Denys Fedoryshchenko
Hi, Sorry for late reply, was not able to push new kernel on pppoes without permissions (it's production servers), just got OK. I am testing patch on another pppoe server with 9k users, for ~3 days, seems fine. I will test today also on server that was experiencing crashes within 1 day. On 2

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

2015-09-21 Thread Vivien Didelot
Hi Jiri, On Sep. Monday 21 (39) 08:25 PM, Jiri Pirko wrote: > Mon, Sep 21, 2015 at 07:13:58PM CEST, vivien.dide...@savoirfairelinux.com > wrote: > >Hi Jiri, Scott, > > > >On Sep. Monday 21 (39) 10:09 AM, Jiri Pirko wrote: > >> Mon, Sep 21, 2015 at 09:23:24AM CEST, sfel...@gmail.com wrote: > >> >O

Re: [PATCH] net: dsa: actually force the speed on the CPU port

2015-09-21 Thread Andrew Lunn
On Mon, Sep 21, 2015 at 09:42:59PM +0100, Russell King wrote: > Commit 54d792f257c6 ("net: dsa: Centralise global and port setup > code into mv88e6xxx.") merged in the 4.2 merge window broke the link > speed forcing for the CPU port of Marvell DSA switches. The original > code was: > > /*

Re: linux-next: build failure after merge of the bluetooth tree

2015-09-21 Thread Stephen Rothwell
Hi Gustavo, On Mon, 14 Sep 2015 10:22:34 +1000 Stephen Rothwell wrote: > > On Mon, 14 Sep 2015 10:14:28 +1000 Stephen Rothwell > wrote: > > > > I applied the patches that Andrew has had in his post merge series > > (but I think you were sent a rolled up version): > > Actually it was sent by A

Re: [PATCH net] openvswitch: Zero flows on allocation.

2015-09-21 Thread Jesse Gross
On Sun, Sep 20, 2015 at 11:24 PM, David Miller wrote: > From: Jesse Gross > Date: Fri, 18 Sep 2015 19:06:14 -0700 > >> @@ -80,7 +80,7 @@ struct sw_flow *ovs_flow_alloc(void) >> struct flow_stats *stats; >> int node; >> >> - flow = kmem_cache_alloc(flow_cache, GFP_KERNEL); >> +

Re: [PATCH v3] geneve: ensure ECN info is handled properly in all tx/rx paths

2015-09-21 Thread Jesse Gross
On Mon, Sep 21, 2015 at 7:29 AM, John W. Linville wrote: > Partially due to a pre-exising "thinko", the new metadata-based tx/rx > paths were handling ECN propagation differently than the traditional > tx/rx paths. This patch removes the "thinko" (involving multiple > ip_hdr assignments) on the r

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: > From: Pravin B Shelar > Date: Sun, 20 Sep 2015 23:53:17 -0700 > >> VXLAN device can receive skb with checksum partial. But the checksum >> offset could be in outer header which is pulled on receive. > > Such a scenerio is a bug. > > Anything

[PATCH v3 0/2] [net] af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag

2015-09-21 Thread Aaron Conole
This patch set implements a bugfix for kernel.org bugzilla #12323, allowing MSG_PEEK to return all queued data on the unix domain socket, not just the data contained in a single SKB. This is the v3 version of this patch, which includes a suggested modification by Eric Dumazet to convert the unix_

[PATCH v3 1/2] [net] af_unix: Convert the unix_sk macro to an inline function for type safety

2015-09-21 Thread Aaron Conole
As suggested by Eric Dumazet in http://marc.info/?l=linux-netdev&m=144276759421433&w=2 This change replaces the #define with a static inline function to enjoy complaints by the compiler when misusing the API. Signed-off-by: Aaron Conole --- include/net/af_unix.h | 6 +- 1 file changed, 5 in

[PATCH v3 2/2] [net] af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag

2015-09-21 Thread Aaron Conole
AF_UNIX sockets now return multiple skbs from recv() when MSG_PEEK flag is set. This is referenced in kernel bugzilla #12323 @ https://bugzilla.kernel.org/show_bug.cgi?id=12323 As described both in the BZ and lkml thread @ http://lkml.org/lkml/2008/1/8/444 calling recv() with MSG_PEEK on an AF_UN

Re: [net-next PATCH 0/4] Add support for reading macid when DT macid not found

2015-09-21 Thread David Miller
From: Mugunthan V N Date: Mon, 21 Sep 2015 15:56:49 +0530 > Did a boot test on dra7-evm [1] and am437x-gp-evm [2]. > Pushed a branch [3] for others to test the patch. > > [1]: http://pastebin.ubuntu.com/12513420/ > [2]: http://pastebin.ubuntu.com/12513428/ > [3]: git://git.ti.com/~mugunthanvnm/t

Re: [RFC net-next 4/4] net: ipv6: Initial support for VRFs

2015-09-21 Thread David Ahern
On 9/21/15 6:08 PM, Tom Herbert wrote: diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c index 9aadd57808a5..11980ee57507 100644 --- a/net/ipv6/datagram.c +++ b/net/ipv6/datagram.c @@ -142,6 +142,10 @@ static int __ip6_datagram_connect(struct sock *sk, struct sockaddr *uaddr, int a

Re: pull-request: can-next 2015-09-17

2015-09-21 Thread David Miller
From: Marc Kleine-Budde Date: Mon, 21 Sep 2015 09:20:21 +0200 > this is a pull request of 8 patches for net-next/master. > > All 8 patches are by me and cleanup the flexcan driver. Pulled, thanks Marc. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread David Miller
From: Pravin B Shelar Date: Sun, 20 Sep 2015 23:53:17 -0700 > VXLAN device can receive skb with checksum partial. But the checksum > offset could be in outer header which is pulled on receive. Such a scenerio is a bug. Anything that pulls off a header should use a utility function such as skb_p

Re: [PATCH net-next v2 5/7] rocker: add FDB cleanup timer

2015-09-21 Thread David Miller
From: sfel...@gmail.com Date: Sun, 20 Sep 2015 08:48:27 -0700 > From: Scott Feldman > > Add a timer to each rocker switch to do FDB entry cleanup by ageing out > expired entries. The timer scheduling algo is copied from the bridge > driver, for the most part, to keep the firing of the timer to

Re: [RFC net-next 4/4] net: ipv6: Initial support for VRFs

2015-09-21 Thread Tom Herbert
On Mon, Sep 21, 2015 at 4:32 PM, David Ahern wrote: > Add basic support for VRFs to IPv6 stack. This is a good start point. > ping to and from a VRF works. Basic tcp and udp clients and server all > work fine with VRFs. > > Signed-off-by: David Ahern > --- > net/ipv6/addrconf.c | 4 +++- > ne

Re: [PATCH 05/15] RDS: increase size of hash-table to 8K

2015-09-21 Thread santosh shilimkar
On 9/21/2015 4:05 PM, David Miller wrote: From: Santosh Shilimkar Date: Sat, 19 Sep 2015 19:04:42 -0400 Even with per bucket locking scheme, in a massive parallel system with active rds sockets which could be in excess of multiple of 10K, rds_bin_lookup() workload is siginificant because of sm

[RFC net-next 0/4] net: VRF support in IPv6 stack

2015-09-21 Thread David Ahern
Initial support for VRFs in IPv6 stack. Patches apply on top of the L3 Master Device patches sent on Friday: http://www.spinics.net/lists/netdev/msg343533.html All patches can be found here github.com/dsahern/linux.git vrf/ipv6-l3mdev-rfc1 David Ahern (4): l3mdev: ipv6 support net: Re

[RFC net-next 4/4] net: ipv6: Initial support for VRFs

2015-09-21 Thread David Ahern
Add basic support for VRFs to IPv6 stack. This is a good start point. ping to and from a VRF works. Basic tcp and udp clients and server all work fine with VRFs. Signed-off-by: David Ahern --- net/ipv6/addrconf.c | 4 +++- net/ipv6/datagram.c | 4 net/ipv6/icmp.c | 6 +- ne

[RFC net-next 1/4] l3mdev: ipv6 support

2015-09-21 Thread David Ahern
Add lookup of cached IPv6 route to l3mdev operations. Signed-off-by: David Ahern --- include/net/l3mdev.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/include/net/l3mdev.h b/include/net/l3mdev.h index 8befd629f8ac..2ee593662ef4 100644 --- a/inc

[RFC net-next 3/4] net: VRF device: Initial IPv6 support

2015-09-21 Thread David Ahern
Start point for IPv6 support by the VRF device. Signed-off-by: David Ahern --- drivers/net/vrf.c | 226 +- 1 file changed, 225 insertions(+), 1 deletion(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 9e3afe011396..ea08a280ae2e 100

[RFC net-next 2/4] net: Remove use of IFF_SLAVE with L3 devices

2015-09-21 Thread David Ahern
Use of IFF_SLAVE flag causes problems with IPv6. addrconf_notify does not respond to netdev events for devices with IFF_SLAVE set. This breaks DAD, neighbor discovery and spirals to non-working death for IPv6. L3 master devices will have IFF_MASTER and IFF_L3MDEV set. L3 slave devices will only ha

Re: [PATCH net] tcp/dccp: fix timewait races in timer handling

2015-09-21 Thread David Miller
From: Eric Dumazet Date: Sat, 19 Sep 2015 09:08:34 -0700 > From: Eric Dumazet > > When creating a timewait socket, we need to arm the timer before > allowing other cpus to find it. The signal allowing cpus to find > the socket is setting tw_refcnt to non zero value. > > As we set tw_refcnt in

Re: [PATCH net] inet: fix races in reqsk_queue_hash_req()

2015-09-21 Thread David Miller
From: Eric Dumazet Date: Sat, 19 Sep 2015 09:48:04 -0700 > From: Eric Dumazet > > Before allowing lockless LISTEN processing, we need to make > sure to arm the SYN_RECV timer before the req socket is visible > in hash tables. > > Also, req->rsk_hash should be written before we set rsk_refcnt >

Re: [PATCH net-next] sunvnet:Invoke SET_NETDEV_DEV() to set up the vdev in vnet_new()

2015-09-21 Thread David Miller
From: Sowmini Varadhan Date: Fri, 18 Sep 2015 17:47:55 -0400 > `ls /sys/devices/channel-devices/vnet-port-0-0/net' is missing without > this change, and applications like NetworkManager are looking in > sysfs for the information. > > Signed-off-by: Sowmini Varadhan This is a bug, so applied to

[PATCH net-next] tcp: factorize sk_txhash init

2015-09-21 Thread Eric Dumazet
From: Eric Dumazet Neal suggested to move sk_txhash init into tcp_create_openreq_child(), called both from IPv4 and IPv6. This opportunity was missed in commit 58d607d3e52f ("tcp: provide skb->hash to synack packets") Signed-off-by: Eric Dumazet Signed-off-by: Neal Cardwell --- net/ipv4/tcp_

Re: [PATCH net-next] net: bcmgenet: Remove duplicate test for tx_coalesce_usecs_high

2015-09-21 Thread David Miller
From: Florian Fainelli Date: Fri, 18 Sep 2015 14:16:53 -0700 > We were checking twice for ec->tx_coalesce_usecs_high, remove the > duplicate test. > > Reported-by: Julia Lawall > Reported-by: kbuild-...@01.org > Fixes: 2f9130709d2c19 ("net: bcmgenet: Implement TX coalescing control knobs") > Si

Re: [PATCH v2] geneve: remove vlan-related feature assignment

2015-09-21 Thread David Miller
From: "John W. Linville" Date: Fri, 18 Sep 2015 16:20:32 -0400 > The code handling vlan tag insertion was dropped in commit 371bd1061d29 > ("geneve: Consolidate Geneve functionality in single module."). Now we > need to drop the related vlan feature bits in the netdev structure. > > Signed-off-

Re: [PATCH] geneve: use network byte order for destination port config parameter

2015-09-21 Thread David Miller
From: "John W. Linville" Date: Fri, 18 Sep 2015 15:59:10 -0400 > This is primarily for consistancy with vxlan and other tunnels which > use network byte order for similar parameters. > > Signed-off-by: John W. Linville This doesn't apply to any of my trees. Can you respin it against 'net'? T

Re: [PATCH net-next] tcp: send loss probe after 1s if no RTT available

2015-09-21 Thread David Miller
From: Yuchung Cheng Date: Fri, 18 Sep 2015 11:40:33 -0700 > This patch makes TLP to use 1 sec timer by default when RTT is > not available due to SYN/ACK retransmission or SYN cookies. > > Prior to this change, the lack of RTT prevents TLP so the first > data packets sent can only be recovered b

Re: [PATCH net-next] tcp: usec resolution SYN/ACK RTT

2015-09-21 Thread David Miller
From: Yuchung Cheng Date: Fri, 18 Sep 2015 11:36:14 -0700 > Currently SYN/ACK RTT is measured in jiffies. For LAN the SYN/ACK > RTT is often measured as 0ms or sometimes 1ms, which would affect > RTT estimation and min RTT samping used by some congestion control. > > This patch improves SYN/ACK

Re: [PATCH] usbnet: New driver for QinHeng CH9200 devices

2015-09-21 Thread David Miller
From: Matthew Garrett Date: Sun, 20 Sep 2015 02:25:38 -0700 > From: Matthew Garrett > > There's a bunch of cheap USB 10/100 devices based on QinHeng chipsets. The > vendor driver supports the CH9100 and CH9200 devices, but the majority of > the code is of the if (ch9100) {} else {} form, with t

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-21 Thread David Miller
From: Robert Jarzmik Date: Fri, 18 Sep 2015 18:36:56 +0200 > Which brings me to wonder which is the more correct : > (a) replace to reproduce the same calculation > Previously mtt was compared to a difference of 76ns steps (as 307ns / 4 = > 76ns): > while ((sched_clock() - si->las

Re: [PATCH 0/2] net: phy: Fix module autoload for OF platform drivers

2015-09-21 Thread David Miller
From: Luis de Bethencourt Date: Fri, 18 Sep 2015 18:15:53 +0200 > These patches add the missing MODULE_DEVICE_TABLE() for OF to export > the information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier Canillas can be found here:

Re: [PATCH 0/6] net: Fix module autoload for OF platform drivers

2015-09-21 Thread David Miller
From: Luis de Bethencourt Date: Fri, 18 Sep 2015 17:53:32 +0200 > Hi, > > These patches add the missing MODULE_DEVICE_TABLE() for OF to export > the information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier Canillas can be fou

Re: [PATCH 05/15] RDS: increase size of hash-table to 8K

2015-09-21 Thread David Miller
From: Santosh Shilimkar Date: Sat, 19 Sep 2015 19:04:42 -0400 > Even with per bucket locking scheme, in a massive parallel > system with active rds sockets which could be in excess of multiple > of 10K, rds_bin_lookup() workload is siginificant because of smaller > hashtable size. > > With some

Re: 197b:0250 JMicron JMC250 Gigabit ethernet doesn't work

2015-09-21 Thread Guo-Fu Tseng
Dear druchaty: Woule it get link if you set set the speed to 100M? If it is, then it is a HW-PHY bug, nothing we can do in driver except set the speed to 100M. On Sat, 19 Sep 2015 21:01:28 +0300, wrote > [1.] One line summary of the problem: 197b:0250 JMicron JMC250 Gigabit > ethernet doesn't

Re: [PATCH] lib: fix data race in rhashtable_rehash_one

2015-09-21 Thread Eric Dumazet
On Tue, 2015-09-22 at 00:25 +0200, Thomas Graf wrote: > On 09/21/15 at 07:51am, Eric Dumazet wrote: > > The important part here is that we rehash an item, so we need to make > > sure to maintain consistent ->next field, and need to prevent compiler > > from using ->next as a temporary variable. > >

Re: [PATCH net-next V2 0/5] s390: qeth and iucv patches

2015-09-21 Thread David Miller
From: Ursula Braun Date: Fri, 18 Sep 2015 16:06:47 +0200 > here is version 2 of some s390 related qeth patches for net-next. The patch by > Thomas Richter adds a new feature to the qeth layer2 code; the remaining > patches are minor improvements. > Version 2 of patch 4 uses the desired indentatio

Re: pull request: bluetooth-next 2015-09-18

2015-09-21 Thread David Miller
From: Johan Hedberg Date: Fri, 18 Sep 2015 13:54:55 +0300 > Here's the first bluetooth-next pull request for the 4.4 kernel: > > - ieee802154 cleanups & fixes > - debugfs support for the at86rf230 driver > - Support for quirky (seemingly counterfeit) CSR Bluetooth controllers > - Power manag

Re: [PATCH RFC 0/3] kcm: Kernel Connection Multiplexor (KCM)

2015-09-21 Thread Sowmini Varadhan
On (09/21/15 15:36), Tom Herbert wrote: > segments. What we need to do, which you're probably doing for RDS, is > do message delineation on the stream as a sequence of: > > 1) Read protocol header to determine message length (BPF used here) right, that's what rds does- first reads the sizeof(rds_

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Miller
From: David Ahern Date: Mon, 21 Sep 2015 16:23:13 -0600 > With the new flag a AND kernel that supports it ip will only show the > table id IF it is not main: > > root@vm-wheezy2:~# ./ip route get 10.0.0.20 > 10.0.0.20 dev eth0 src 10.0.0.2 > cache > > root@vm-wheezy2:~# ./ip route get 10.2

Re: [PATCH RFC 0/3] kcm: Kernel Connection Multiplexor (KCM)

2015-09-21 Thread Tom Herbert
On Mon, Sep 21, 2015 at 2:26 PM, Sowmini Varadhan wrote: > On (09/21/15 10:33), Tom Herbert wrote: >> > >> > Some things that were not clear to me from the patch-set: >> > >> > The doc statses that we re-assemble packets the "stated length" - >> > but how will the receiver know the "stated length"

Re: [PATCH] lib: fix data race in rhashtable_rehash_one

2015-09-21 Thread Thomas Graf
On 09/21/15 at 07:51am, Eric Dumazet wrote: > The important part here is that we rehash an item, so we need to make > sure to maintain consistent ->next field, and need to prevent compiler > from using ->next as a temporary variable. > > ptr->next = 1UL | ((base + offset) << 1); > > Is dangerous

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Ahern
On 9/21/15 4:03 PM, David Miller wrote: From: David Ahern Date: Mon, 21 Sep 2015 16:03:00 -0600 On 9/21/15 3:58 PM, David Miller wrote: I think if it always gave MAIN in older kernels, iproute should continue to do so. You can't just remove the table ID output just because you disagree with

Re: [PATCH 1/7] phy: fix of_mdio_find_bus() device refcount leak

2015-09-21 Thread David Miller
From: Russell King - ARM Linux Date: Mon, 21 Sep 2015 20:32:07 +0100 > In the case of the mdio mux code, I'm dropping the reference when > either (a) we've encountered an error during initialisation and > we're cleaning up, or (b) when the mdio mux code is being torn down > after the mdiomux bus

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Miller
From: David Ahern Date: Mon, 21 Sep 2015 16:03:00 -0600 > On 9/21/15 3:58 PM, David Miller wrote: >> I think if it always gave MAIN in older kernels, iproute should >> continue >> to do so. >> >> You can't just remove the table ID output just because you disagree >> with >> the semantics given by

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Ahern
On 9/21/15 3:58 PM, David Miller wrote: I think if it always gave MAIN in older kernels, iproute should continue to do so. You can't just remove the table ID output just because you disagree with the semantics given by old kernels. Current semantics are maintained. Kernel was hardcoded to ret

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Miller
From: David Ahern Date: Mon, 21 Sep 2015 15:28:53 -0600 > On 9/21/15 3:19 PM, Stephen Hemminger wrote: >>> @@ -1638,6 +1638,8 @@ static int iproute_get(int argc, char **argv) >>> if (req.r.rtm_family == AF_UNSPEC) >>> req.r.rtm_family = AF_INET; >>> >>> + req.r.rtm_flags |= RTM_

Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter

2015-09-21 Thread Alexander Duyck
On 09/21/2015 10:11 AM, Jarod Wilson wrote: Some pci changes upcoming in 4.3 seem to cause additional disconnects, which can happen at unfortuitous times for igb, leading to issues such as this, where the disconnect happened just before igb_configure_tx_ring(): [ 414.440115] igb :15:00.0: e

Re: [PATCH 4/7] 8139cp: Fix TSO/scatter-gather descriptor setup

2015-09-21 Thread David Woodhouse
On Mon, 2015-09-21 at 23:01 +0200, Francois Romieu wrote: > > Can you pile a patch to replace BUG with WARN_ON_ONCE(1) ? Let's avoid having three copies of the same damn code, while we're at it... http://git.infradead.org/users/dwmw2/linux-8139cp.git has this and the appropriate minor fixes to su

Re: [iproute PATCH] man: tc.8: mention Fair Queue scheduler

2015-09-21 Thread Stephen Hemminger
On Wed, 9 Sep 2015 15:41:08 +0200 Phil Sutter wrote: > This is rather a placeholder to let users know fq exists at all. > > Signed-off-by: Phil Sutter > --- > man/man8/tc.8 | 4 > 1 file changed, 4 insertions(+) > > diff --git a/man/man8/tc.8 b/man/man8/tc.8 > index feafa05..0081625 100

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread David Ahern
On 9/21/15 3:19 PM, Stephen Hemminger wrote: @@ -1638,6 +1638,8 @@ static int iproute_get(int argc, char **argv) if (req.r.rtm_family == AF_UNSPEC) req.r.rtm_family = AF_INET; + req.r.rtm_flags |= RTM_F_LOOKUP_TABLE; + if (rtnl_talk(&rth, &req.n, &req.n, siz

Re: [PATCH RFC 0/3] kcm: Kernel Connection Multiplexor (KCM)

2015-09-21 Thread Sowmini Varadhan
On (09/21/15 10:33), Tom Herbert wrote: > > > > Some things that were not clear to me from the patch-set: > > > > The doc statses that we re-assemble packets the "stated length" - > > but how will the receiver know the "stated length"? > > BPF program returns the length of the next message. In my

Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id

2015-09-21 Thread Stephen Hemminger
On Mon, 21 Sep 2015 11:19:48 -0700 David Ahern wrote: > Currently 'ip route get' does not show the table the lookup result comes > from and prior to kernel commit c36ba6603a11 the response from the kernel > was hardcoded to the main table. From the discussion this appears to be > a leftover from

Re: [PATCH 7/7] 8139cp: Avoid gratuitous writes to TxPoll register when already running

2015-09-21 Thread David Woodhouse
On Mon, 2015-09-21 at 22:54 +0200, Francois Romieu wrote: > David Woodhouse : > [...] > > I'm actually having second thoughts about this one since realising that > > QEMU doesn't implement it correctly. The workaround isn't *that* horrid > > but it's not clear it's enough of a performance win — or

Re: [PATCH 4/7] 8139cp: Fix TSO/scatter-gather descriptor setup

2015-09-21 Thread David Woodhouse
On Mon, 2015-09-21 at 23:01 +0200, Francois Romieu wrote: > Can you pile a patch to replace BUG with WARN_ON_ONCE(1) ? OK. I can probably contrive a userspace program using AF_PACKET and PACKET_VNET_HDR to trigger it, too¹ :) -- dwmw2 ¹ http://comments.gmane.org/gmane.linux.network/254981 sm

KASan warning with ping call stack

2015-09-21 Thread subashab
We are seeing a Kernel address sanitizer (KASan) out of bounds warning during a stability test. The call stack is as follows - <3>BUG: KASan: out of bounds on stack in csum_partial_copy_fromiovecend+0xac/0x36c at addr ffc019537d38 <3>Read of size 8 by task Thread-208/7505 <0>page:ffbac23d4

Re: [PATCH 4/7] 8139cp: Fix TSO/scatter-gather descriptor setup

2015-09-21 Thread Francois Romieu
David Woodhouse : [...] > diff --git a/drivers/net/ethernet/realtek/8139cp.c > b/drivers/net/ethernet/realtek/8139cp.c > index 058f835..07621b5 100644 > --- a/drivers/net/ethernet/realtek/8139cp.c > +++ b/drivers/net/ethernet/realtek/8139cp.c [...] > @@ -865,20 +864,20 @@ static netdev_tx_t cp_st

Re: [PATCH 7/7] 8139cp: Avoid gratuitous writes to TxPoll register when already running

2015-09-21 Thread Francois Romieu
David Woodhouse : [...] > I'm actually having second thoughts about this one since realising that > QEMU doesn't implement it correctly. The workaround isn't *that* horrid > but it's not clear it's enough of a performance win — or whether it's > entirely necessary for catching my TX stall. It don

Re: [PATCH 1/7] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms

2015-09-21 Thread David Woodhouse
On Mon, 2015-09-21 at 22:25 +0200, Francois Romieu wrote: > David Woodhouse : > > From: David Woodhouse > > > > The TX timeout handling has been observed to trigger RX IRQ storms. And > > since cp_interrupt() just keeps saying that it handled the interrupt, > > the machine then dies. Fix the ret

[PATCH] netlink: Replace rhash_portid with load_acquire protected boolean

2015-09-21 Thread Tejun Heo
Hello, Here's an updated version of Herbert's patch which always uses load_acquire through a helper. Thanks. - 8< - The commit 1f770c0a09da855a2b51af6d19de97fb955eca85 ("netlink: Fix autobind race condition that leads to zero port ID") created some new races that can occur due to inconsis

[PATCH] net: dsa: actually force the speed on the CPU port

2015-09-21 Thread Russell King
Commit 54d792f257c6 ("net: dsa: Centralise global and port setup code into mv88e6xxx.") merged in the 4.2 merge window broke the link speed forcing for the CPU port of Marvell DSA switches. The original code was: /* MAC Forcing register: don't force link, speed, duplex * or flow

Re: [iproute2 PATCH] ip-link: do not support 'ip link add dev help'

2015-09-21 Thread Phil Sutter
On Mon, Sep 21, 2015 at 10:13:49PM +0200, Christoph Schulz wrote: > Phil Sutter schrieb am Mon, 21 Sep 2015 21:33:01 +0200: > > > Commit 0532555 ('Support "ip link add help" for rtnl_link API') added a > > check for specified help parameter. Though due to the place where it has > > been added to,

Re: [PATCH 1/7] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms

2015-09-21 Thread Francois Romieu
David Woodhouse : > From: David Woodhouse > > The TX timeout handling has been observed to trigger RX IRQ storms. And > since cp_interrupt() just keeps saying that it handled the interrupt, > the machine then dies. Fix the return value from cp_interrupt(), and > the offending IRQ gets disabled a

Re: [iproute2 PATCH] ip-link: do not support 'ip link add dev help'

2015-09-21 Thread Christoph Schulz
Hello! Phil Sutter schrieb am Mon, 21 Sep 2015 21:33:01 +0200: Commit 0532555 ('Support "ip link add help" for rtnl_link API') added a check for specified help parameter. Though due to the place where it has been added to, it is not possible anymore to force a given parameter to be interpreted

Re: [PATCH 1/7] phy: fix of_mdio_find_bus() device refcount leak

2015-09-21 Thread Russell King - ARM Linux
On Mon, Sep 21, 2015 at 12:01:59PM -0700, David Miller wrote: > From: Russell King > Date: Fri, 18 Sep 2015 10:54:55 +0100 > > > Update the comment, and arrange for the only user of this function > > to drop this refcount when disposing of a reference to it. > > mdio_mux is not the only user of

[iproute2 PATCH] ip-link: do not support 'ip link add dev help'

2015-09-21 Thread Phil Sutter
Commit 0532555 ('Support "ip link add help" for rtnl_link API') added a check for specified help parameter. Though due to the place where it has been added to, it is not possible anymore to force a given parameter to be interpreted as interface name by prefixing it with 'dev '. Fix this by forcing

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

2015-09-21 Thread Jiri Pirko
Mon, Sep 21, 2015 at 06:34:33PM CEST, sfel...@gmail.com wrote: >On Mon, Sep 21, 2015 at 1:09 AM, Jiri Pirko wrote: >> Mon, Sep 21, 2015 at 09:23:24AM CEST, sfel...@gmail.com wrote: >>>On Sat, Sep 19, 2015 at 5:29 AM, Jiri Pirko wrote: Jiri Pirko (6): switchdev: rename "trans" to "tran

Re: [PATCH RFC 0/3] Allow postponed netfilter handling for socket matches

2015-09-21 Thread Florian Westphal
Daniel Mack wrote: > >> LOCAL_IN, for ingress only? In a sense, it would be called from the > >> protocol handlers, just as my patches do right now, but instead of > >> conditionally re-iterating the same rules again, we would walk a > >> different chain? > > > > Yes, something like that. Obviou

Re: [PATCH 1/7] phy: fix of_mdio_find_bus() device refcount leak

2015-09-21 Thread David Miller
From: Russell King Date: Fri, 18 Sep 2015 10:54:55 +0100 > Update the comment, and arrange for the only user of this function > to drop this refcount when disposing of a reference to it. mdio_mux is not the only user of of_mdio_find_bus(), DSA uses it as well. So if anything this commit message

Re: [PATCH v2 1/5] net: add Hisilicon Network Subsystem support (config and documents)

2015-09-21 Thread Rob Herring
On 09/17/2015 01:51 AM, huangdaode wrote: > The Hisilicon Network Subsystem is a long term evolution IP which is > supposed to be used in Hisilicon ICT SoC. The IP, which is called hns > for short, is a TCP/IP acceleration engine, which can directly decode > TCP/IP stream and distribute them to dif

Re: [PATCH V6 net-next 2/2] smc: introduce socket family AF_SMC

2015-09-21 Thread David Miller
From: Ursula Braun Date: Mon, 14 Sep 2015 12:42:46 +0200 > +#ifdef CONFIG_S390 > +#include > +#endif Please keep s390'isms out of this code. > +void smc_link_up(struct smc_link_group *lgr) > +{ > + struct smc_roce_defs rocdefs; > + struct smc_link *link = NULL; > + int i; > + u

Re: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

2015-09-21 Thread Richard Cochran
On Mon, Sep 21, 2015 at 11:19:32PM +0530, Harini Katakam wrote: > Ping 1) trim your replies 2) put the PTP maintainer on PTP patches for review Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordo

[PATCH next 12/84] ipvs: Pass ipvs not net to ip_vs_service_find

2015-09-21 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- include/net/ip_vs.h | 2 +- net/netfilter/ipvs/ip_vs_ctl.c| 5 ++--- net/netfilter/ipvs/ip_vs_proto_sctp.c | 4 ++-- net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++-- net/netfilter/ipvs/ip_vs_proto_udp.c | 6 -- 5 files changed,

[PATCH next 60/84] ipvs: Pass ipvs into ip_vs_conn_fill_param_proto

2015-09-21 Thread Eric W. Biederman
Move the ugly hack net_ipvs(skb_net(skb)) up a layer in the call stack so it is easier to remove. Signed-off-by: "Eric W. Biederman" --- net/netfilter/ipvs/ip_vs_conn.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

2015-09-21 Thread Jiri Pirko
Mon, Sep 21, 2015 at 07:13:58PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Hi Jiri, Scott, > >On Sep. Monday 21 (39) 10:09 AM, Jiri Pirko wrote: >> Mon, Sep 21, 2015 at 09:23:24AM CEST, sfel...@gmail.com wrote: >> >On Sat, Sep 19, 2015 at 5:29 AM, Jiri Pirko wrote: >> >> Jiri Pirko (6): >>

[PATCH next 35/84] ipvs: Pass ipvs not net to make_send_sock

2015-09-21 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- net/netfilter/ipvs/ip_vs_sync.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c index 0b2e01aa764a..dc987762ca2c 100644 --- a/net/netfilter/ipvs/ip_vs_sync.c +++ b/n

[PATCH next 23/84] ipvs: Cache ipvs in ip_vs_in_icmp and ip_vs_in_icmp_v6

2015-09-21 Thread Eric W. Biederman
Storte the value of net_ipvs in a variable named ipvs so that when there are more users struct netns_ipvs in ip_vs_in_cmp and ip_vs_in_icmp_v6 they won't need to compute the value again. Signed-off-by: "Eric W. Biederman" --- net/netfilter/ipvs/ip_vs_core.c | 8 ++-- 1 file changed, 6 insert

[PATCH next 53/84] ipvs: Pass ipvs not net into ip_vs_app_inc_new

2015-09-21 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- net/netfilter/ipvs/ip_vs_app.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_app.c b/net/netfilter/ipvs/ip_vs_app.c index f20f72c4ac80..951516b7783b 100644 --- a/net/netfilter/ipvs/ip_vs_app.c +++ b/net/ne

[PATCH next 15/84] ipvs: Pass ipvs not net to ip_vs_trash_cleanup

2015-09-21 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- net/netfilter/ipvs/ip_vs_ctl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index 24dceaccb0a1..b66ab765f36d 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/net

[PATCH next 30/84] ipvs: Pass ipvs not net to ip_vs_genl_find_service

2015-09-21 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- net/netfilter/ipvs/ip_vs_ctl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index ea650ed62a50..01c3a1a75d16 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/

[PATCH next 45/84] ipvs: Pass ipvs not net to ip_vs_genl_set_config

2015-09-21 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- net/netfilter/ipvs/ip_vs_ctl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index dba75ec2ed53..4042a6f449cb 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/net

[PATCH next 70/84] ipvs: Pass ipvs into ensure_mtu_is adequate

2015-09-21 Thread Eric W. Biederman
This allows two different ways for computing/guessing net to be removed from ensure_mtu_is_adequate. Signed-off-by: "Eric W. Biederman" --- net/netfilter/ipvs/ip_vs_xmit.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfil

[PATCH next 59/84] ipvs: Pass ipvs not net into init_netns and exit_netns

2015-09-21 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- include/net/ip_vs.h | 4 ++-- net/netfilter/ipvs/ip_vs_proto.c | 4 ++-- net/netfilter/ipvs/ip_vs_proto_sctp.c | 6 ++ net/netfilter/ipvs/ip_vs_proto_tcp.c | 6 ++ net/netfilter/ipvs/ip_vs_proto_udp.c | 6 ++ 5 files chan

  1   2   3   >