Re: [patch net-next] mlxsw: core: Fix temperature sensor index during initialization

2015-12-11 Thread David Miller
From: Jiri Pirko Date: Fri, 11 Dec 2015 18:26:00 +0100 > From: Jiri Pirko > > Sensor index should be passed instead of 0. For now, this does not make > a difference, since there is so far only one temperature sensor > exposed by HW. > > Fixes: 89309da39 ("mlxsw: core: Implement temperature hwm

Re: [patch net-next] mlxsw: reg: Fix max temperature getting

2015-12-11 Thread David Miller
From: Jiri Pirko Date: Fri, 11 Dec 2015 16:10:39 +0100 > From: Jiri Pirko > > Fix copy & paste error in MTPM unpack helper. > > Fixes: 85926f877040 ("mlxsw: reg: Add definition of temperature management > registers") > Signed-off-by: Jiri Pirko Applied. -- To unsubscribe from this list: sen

Re: [PATCH net 0/4] mpls: fixes for nexthops without via addresses

2015-12-11 Thread David Miller
From: Robert Shearman Date: Thu, 10 Dec 2015 19:30:47 + > These four fixes all apply to the case of having an mpls route with an > output device, but without a nexthop. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to ma

Re: [PATCH net v2] sfc: only use RSS filters if we're using RSS

2015-12-11 Thread David Miller
From: Bert Kenward Date: Fri, 11 Dec 2015 09:39:32 + > Without this, filter insertion on a VF would fail if only one channel > was in use. This would include the unicast station filter and therefore > no traffic would be received. > > Signed-off-by: Bert Kenward Applied, thank you. -- To u

Re: [PATCH net-next V1 0/9] mlx5 improved flow steering management

2015-12-11 Thread David Miller
From: Saeed Mahameed Date: Thu, 10 Dec 2015 17:12:36 +0200 > First two patches fixes some minor issues in recently > introduced SRIOV code. > > The other seven patches modifies the driver's code that > manages flow steering rules with Connectx-4 devices. Series applied, thanks. -- To unsubscri

Re: [PATCH net] uapi: export ila.h

2015-12-11 Thread David Miller
From: Stephen Hemminger Date: Thu, 10 Dec 2015 09:14:20 -0800 > The file ila.h used for lightweight tunnels is being used by iproute2 > but is not exported yet. > > Signed-off-by: Stephen Hemminger Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsu

Re: [PATCH v2 0/2] net: thunderx: Support for pass-2 hw features

2015-12-11 Thread David Miller
From: Sunil Goutham Date: Thu, 10 Dec 2015 13:25:18 +0530 > From: Sunil Goutham > > This patch set adds support for new features added in pass-2 revision > of hardware like TSO and count based interrupt coalescing. > > Changes from v1: > - Addressed comments received regarding boolean bit fiel

Re: [PATCH net v2 0/4] bnxt_en: Bug fix and add tx timeout recovery.

2015-12-11 Thread David Miller
From: Michael Chan Date: Wed, 9 Dec 2015 19:35:40 -0500 > Fix a bitmap declaration bug and add missing tx timeout recovery. > > v2: Fixed white space error. Thanks Dave. Series applied, thanks Michael. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

Re: [PATCH net 2/2] openvswitch: Respect conntrack zone even if invalid

2015-12-11 Thread David Miller
From: Joe Stringer Date: Wed, 9 Dec 2015 14:07:40 -0800 > If userspace executes ct(zone=1), and the connection tracker determines > that the packet is invalid, then the ct_zone flow key field is populated > with the default zone rather than the zone that was specified. Even > though connection t

Re: [PATCH net 1/2] openvswitch: Fix helper reference leak

2015-12-11 Thread David Miller
From: Joe Stringer Date: Wed, 9 Dec 2015 14:07:39 -0800 > If the actions (re)allocation fails, or the actions list is larger than the > maximum size, and the conntrack action is the last action when these > problems are hit, then references to helper modules may be leaked. Fix > the issue. > >

Re: [PATCH v3 1/4] geneve: Add geneve udp port offload for ethernet devices

2015-12-11 Thread Tom Herbert
On Tue, Dec 8, 2015 at 10:12 AM, Anjali Singhai Jain wrote: > Add ndo_ops to add/del UDP ports to a device that supports geneve > offload. > > v3: Add some more comments about the use of the new ndo ops. > > Signed-off-by: Anjali Singhai Jain > Signed-off-by: Kiran Patil > --- > drivers/net/gen

Re: [PATCHv2 net] phy: micrel: Fix finding PHY properties in MAC node.

2015-12-11 Thread David Miller
From: Andrew Lunn Date: Wed, 9 Dec 2015 19:56:31 +0100 > commit 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, > not the bus' parent.") changed the parenting of PHY devices, making > them a child of the MDIO bus, instead of the MAC device. This broken > the Micrel PHY driver which

Re: [PATCH net-next v3 0/4] mvneta: Introduce RSS support and XPS configuration

2015-12-11 Thread David Miller
From: Gregory CLEMENT Date: Wed, 9 Dec 2015 18:23:47 +0100 > this series is the first step add RSS support on mvneta. Series applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [PATCHv2 net-next] ipv6: allow routes to be configured with expire values

2015-12-11 Thread David Miller
From: Xin Long Date: Thu, 10 Dec 2015 00:27:53 +0800 > Add the support for adding expire value to routes, requested by > Tom Gundersen for systemd-networkd, and NetworkManager > wants it too. > > add it by using the field rta_expires of rta_cacheinfo > > Signed-off-by: Xin Long > Signed-off-

Re: [PATCH net] ipv6: sctp: clone options to avoid use after free

2015-12-11 Thread David Miller
From: Eric Dumazet Date: Wed, 09 Dec 2015 07:25:06 -0800 > From: Eric Dumazet > > SCTP is lacking proper np->opt cloning at accept() time. > > TCP and DCCP use ipv6_dup_options() helper, do the same > in SCTP. > > We might later factorize this code in a common helper to avoid > future mistake

Re: [PATCH net-next] mpls_iptunnel: add static qualifier to mpls_output

2015-12-11 Thread David Miller
From: Roopa Prabhu Date: Wed, 9 Dec 2015 06:56:41 -0800 > From: Roopa Prabhu > > This gets rid of the following compile warn: > net/mpls/mpls_iptunnel.c:40:5: warning: no previous prototype for > mpls_output [-Wmissing-prototypes] > > Signed-off-by: Roopa Prabhu Applied, thank you. -- To un

Re: [PATCH net-next] cxgb4: Handle clip return values

2015-12-11 Thread David Miller
From: Hariprasad Shenai Date: Wed, 9 Dec 2015 17:16:35 +0530 > Add a warn message when clip table overflows. If clip table isn't > allocated, return from cxgb4_clip_release() to avoid panic. > Disable offload if clip isn't enabled in the hardware. > > Signed-off-by: Hariprasad Shenai Applied,

Re: [patch -next] mlxsw: core: remove an unneeded condition

2015-12-11 Thread David Miller
From: Dan Carpenter Date: Wed, 9 Dec 2015 13:41:29 +0300 > We already know "err" is zero so there is no need to check. > > Signed-off-by: Dan Carpenter Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More major

Re: [patch -next] mlxsw: spectrum: fix some error handling

2015-12-11 Thread David Miller
From: Dan Carpenter Date: Wed, 9 Dec 2015 13:33:51 +0300 > The "err = " assignment is missing here. > > Fixes: 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave') > Signed-off-by: Dan Carpenter Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: [PATCH (net-next.git) 16/18] stmmac: do not perform zero-copy for rx frames

2015-12-11 Thread David Miller
From: Giuseppe Cavallaro Date: Wed, 9 Dec 2015 09:37:52 +0100 > @@ -98,6 +98,10 @@ static int buf_sz = DEFAULT_BUFSIZE; > module_param(buf_sz, int, S_IRUGO | S_IWUSR); > MODULE_PARM_DESC(buf_sz, "DMA buffer size"); > > +static int minrx = 256; > +module_param(minrx, int, S_IRUGO | S_IWUSR); >

Re: [PATCH 1/1] net: bonding: remove redudant brackets

2015-12-11 Thread David Miller
From: Date: Wed, 9 Dec 2015 11:30:42 +0800 > From: yzhu1 > > It is not necessary to use two brackets. As such, the redudant brackets > are removed. > > CC: Jay Vosburgh > CC: Veaceslav Falico > CC: Andy Gospodarek > Signed-off-by: yzhu1 Does not apply to the net-next tree. -- To unsubscri

Re: [PATCH v3 4/4] geneve: Add geneve_get_rx_port support

2015-12-11 Thread David Miller
From: Anjali Singhai Jain Date: Tue, 8 Dec 2015 10:12:14 -0800 > This patch adds an op that the drivers can call into to get existing > geneve ports. > > Signed-off-by: Anjali Singhai Jain Add the new geneve infrastructure in one patch, then add the call from the driver in another. This look

Re: [PATCH v3 1/4] geneve: Add geneve udp port offload for ethernet devices

2015-12-11 Thread David Miller
From: Anjali Singhai Jain Date: Tue, 8 Dec 2015 10:12:11 -0800 > @@ -1013,6 +1013,20 @@ typedef u16 (*select_queue_fallback_t)(struct > net_device *dev, > * a new port starts listening. The operation is protected by the > * vxlan_net->sock_lock. > * > + * void (*ndo_add_geneve_port)(s

Re: [PATCH net-next v2] Driver for IBM System i/p VNIC protocol

2015-12-11 Thread David Miller
From: Thomas Falcon Date: Tue, 8 Dec 2015 11:52:19 -0600 > +static long h_reg_sub_crq(unsigned long unit_address, unsigned long token, > + unsigned long length, unsigned long *number, > + unsigned long *irq) > +{ > + long rc; > + unsigned long

Re: [RFC 1/1] drivers/net: fix eisa_driver probe section mismatch

2015-12-11 Thread David Miller
From: Fabian Frederick Date: Tue, 8 Dec 2015 18:36:25 +0100 > Some eisa_driver structures use __init probe functions which generates > a warning and could crash if function is called after being deleted. I can't apply this to my networking tree because you included SCSI changes in it. -- To uns

Re: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-11 Thread David Miller
From: Ben Hutchings Date: Tue, 08 Dec 2015 19:00:52 + > On Tue, 2015-12-08 at 10:02 -0800, Shannon Nelson wrote: >> On Mon, Dec 7, 2015 at 8:42 PM,   wrote: >> > From: Kan Liang >> > >> > Intrdouce "queue" option for coalesce getting and setting. > [...] >> > --- a/net/core/ethtool.c >> > +

Re: [PATCH 2/2] netcp: add more __le32 annotations

2015-12-11 Thread David Miller
From: Arnd Bergmann Date: Tue, 08 Dec 2015 16:32:59 +0100 > The handling of epib and psdata remains a bit unclear in the driver, > as we access the same fields both as CPU-endian and through DMA > from the device. > > Sparse warns about this: > ti/netcp_core.c:1147:21: warning: incorrect type in

Re: [PATCH 1/2] netcp: try to reduce type confusion in descriptors

2015-12-11 Thread David Miller
From: Arnd Bergmann Date: Tue, 08 Dec 2015 16:32:27 +0100 > The netcp driver produces tons of warnings when CONFIG_LPAE is enabled > on ARM: > > drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_tx_map_skb': > drivers/net/ethernet/ti/netcp_core.c:1084:13: warning: passing argument 1 of >

Re: [PATCH net 1/2] xfrm: add rcu grace period in xfrm_policy_destroy()

2015-12-11 Thread David Miller
From: Steffen Klassert Date: Thu, 10 Dec 2015 13:34:22 +0100 > On Tue, Dec 08, 2015 at 10:58:29PM -0500, David Miller wrote: >> From: Eric Dumazet >> Date: Tue, 8 Dec 2015 07:22:01 -0800 >> >> > We will soon switch sk->sk_policy[] to RCU protection, >> > as SYNACK packets are sent while listen

Re: [linux-next] iwl_mvm_get_key_sta_id() suspicious RCU usage

2015-12-11 Thread Sergey Senozhatsky
On (12/12/15 09:05), Sergey Senozhatsky wrote: > On (12/11/15 14:49), Johannes Berg wrote: > > On Fri, 2015-12-11 at 22:44 +0900, Sergey Senozhatsky wrote: > > > > > [ 6385.246300] drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1226 > > > suspicious rcu_dereference_protected() usage! > > > > > > >

Re: [PATCH net 1/4] mpls: validate L2 via address length

2015-12-11 Thread roopa
On 12/11/15, 2:51 PM, roopa wrote: > On 12/10/15, 11:30 AM, Robert Shearman wrote: >> If an L2 via address for an mpls nexthop is specified, the length of >> the L2 address must match that expected by the output device, >> otherwise it could access memory beyond the end of the via address >> buffer

Re: [linux-next] iwl_mvm_get_key_sta_id() suspicious RCU usage

2015-12-11 Thread Sergey Senozhatsky
On (12/11/15 14:49), Johannes Berg wrote: > On Fri, 2015-12-11 at 22:44 +0900, Sergey Senozhatsky wrote: > > > [ 6385.246300] drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1226 > > suspicious rcu_dereference_protected() usage! > > > > Funny, Laura Abbott also reported this bug earlier today :) >

Re: Checksum offload queries

2015-12-11 Thread Tom Herbert
>> If your device is trying do offload more than one checksum on its own > >> accord without being asked to do so by the stack it is doing the > wrong >> thing! > From the stack's perspective: yes, it is doing the wrong thing. (I've > been discussing with colleagues today how we could change tha

Re: [PATCH net 1/4] mpls: validate L2 via address length

2015-12-11 Thread roopa
On 12/10/15, 11:30 AM, Robert Shearman wrote: > If an L2 via address for an mpls nexthop is specified, the length of > the L2 address must match that expected by the output device, > otherwise it could access memory beyond the end of the via address > buffer in the route. > > This check was present

Re: [PATCH] iwlwifi: mvm: protect RCU dereference in iwl_mvm_get_key_sta_id

2015-12-11 Thread Laura Abbott
On 12/11/2015 12:13 AM, Johannes Berg wrote: From: Johannes Berg Properly protect the RCU dereference in iwl_mvm_get_key_sta_id() when coming from iwl_mvm_update_tkip_key() which cannot hold the mvm->mutex by moving the call into the RCU critical section. Modify the check to use rcu_dereference

[PATCH] net: add Qualcomm IPC router

2015-12-11 Thread Bjorn Andersson
From: Courtney Cavin Add an implementation of Qualcomm's IPC router protocol, used to communicate with service providing remote processors. Signed-off-by: Courtney Cavin --- Downstream this code also includes a large part of a service discovery mechanism, controlled through a set of custom ioc

pull request: bluetooth-next 2015-12-11

2015-12-11 Thread Johan Hedberg
Hi Dave, (resending since I forgot to sign the previous one) Here's another set of Bluetooth & 802.15.4 patches for the 4.5 kernel: - 6LoWPAN debugfs support - New 802.15.4 driver for ADF7242 MAC IEEE802154 - Initial code for 6LoWPAN Generic Header Compression (GHC) support - Refactor Blueto

pull request: bluetooth-next 2015-12-11

2015-12-11 Thread Johan Hedberg
Hi Dave, Here's another set of Bluetooth & 802.15.4 patches for the 4.5 kernel: - 6LoWPAN debugfs support - New 802.15.4 driver for ADF7242 MAC IEEE802154 - Initial code for 6LoWPAN Generic Header Compression (GHC) support - Refactor Bluetooth LE scan & advertising behind dedicated workqueue

Re: [RFCv3 bluetooth-next 4/4] 6lowpan: iphc: add support for stateful compression

2015-12-11 Thread Alexander Aring
On Fri, Dec 11, 2015 at 08:11:42PM +0100, Stefan Schmidt wrote: > Hello. > > On 11/12/15 18:05, Alexander Aring wrote: > >Hi, > > > >status update here. > > > >I implemented successful basic 6CO RA messages at sending and > >processing inside radvd. > > > >There might also the question if processi

[PATCH] wan: wanxl: add pci_disable_device in case of error

2015-12-11 Thread Saurabh Sengar
If there is 'no suitable DMA available' error, device should be disabled before returning Signed-off-by: Saurabh Sengar --- drivers/net/wan/wanxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index e73f138..a20d688 100644 --- a/drivers/ne

Re: [RFCv3 bluetooth-next 4/4] 6lowpan: iphc: add support for stateful compression

2015-12-11 Thread Stefan Schmidt
Hello. On 11/12/15 18:05, Alexander Aring wrote: Hi, status update here. I implemented successful basic 6CO RA messages at sending and processing inside radvd. There might also the question if processing 6CO inside kernel or userspace? I put the basic functionality inside userspace for now.

[PATCH net-next 1/2] ppp: define "ppp" device type

2015-12-11 Thread Guillaume Nault
Let PPP devices be identified as such in /sys/class/net//uevent. Signed-off-by: Guillaume Nault --- drivers/net/ppp/ppp_generic.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index 9a863c6..1cd7651 100644 --- a/drivers/ne

[PATCH net-next 0/2] Minor PPP devices improvements

2015-12-11 Thread Guillaume Nault
Let PPP devices be friendlier to user space by registering their device type and reporting their interface naming scheme. Guillaume Nault (2): ppp: define "ppp" device type ppp: declare ppp devices as enumerated interfaces drivers/net/ppp/ppp_generic.c | 9 +++-- 1 file changed, 7 insert

[PATCH net-next 2/2] ppp: declare ppp devices as enumerated interfaces

2015-12-11 Thread Guillaume Nault
Let user space be aware of the naming scheme used by ppp interfaces (visible in /sys/class/net//name_assign_type). Signed-off-by: Guillaume Nault --- drivers/net/ppp/ppp_generic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/pp

Re: use-after-free in sctp_do_sm

2015-12-11 Thread Vlad Yasevich
On 12/11/2015 09:03 AM, Marcelo Ricardo Leitner wrote: > On Fri, Dec 11, 2015 at 11:51:21AM -0200, Marcelo Ricardo Leitner wrote: >> Em 11-12-2015 11:35, Dmitry Vyukov escreveu: >>> On Wed, Dec 9, 2015 at 5:41 PM, Marcelo Ricardo Leitner >>> wrote: On Wed, Dec 09, 2015 at 01:03:56PM -0200, Ma

Re: [PATCH 1/1] net: sctp: dynamically enable or disable pf state

2015-12-11 Thread Vlad Yasevich
On 12/11/2015 04:05 AM, zyjzyj2...@gmail.com wrote: > From: Zhu Yanjun > > As we all know, the vale of pf_retrans >= max_retrans_path can > disable pf state. The variables of pf_retrans and max_retrans_path > can be changed by the user space application. > > Sometimes the user expects to disable

[patch net-next] mlxsw: core: Fix temperature sensor index during initialization

2015-12-11 Thread Jiri Pirko
From: Jiri Pirko Sensor index should be passed instead of 0. For now, this does not make a difference, since there is so far only one temperature sensor exposed by HW. Fixes: 89309da39 ("mlxsw: core: Implement temperature hwmon interface") Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mel

Re: [PATCH v3 4/4] VSOCK: Add Makefile and Kconfig

2015-12-11 Thread Alex Bennée
Stefan Hajnoczi writes: > From: Asias He > > Enable virtio-vsock and vhost-vsock. > > Signed-off-by: Asias He > Signed-off-by: Stefan Hajnoczi > --- > v3: > * Don't put vhost vsock driver into staging > * Add missing Kconfig dependencies (Arnd Bergmann ) > --- > drivers/vhost/Kconfig | 10

Re: [RFCv3 bluetooth-next 4/4] 6lowpan: iphc: add support for stateful compression

2015-12-11 Thread Alexander Aring
On Fri, Dec 11, 2015 at 06:05:41PM +0100, Alexander Aring wrote: > Hi, > > status update here. > > I implemented successful basic 6CO RA messages at sending and > processing inside radvd. > > There might also the question if processing 6CO inside kernel or > userspace? I put the basic functional

Re: [RFCv3 bluetooth-next 4/4] 6lowpan: iphc: add support for stateful compression

2015-12-11 Thread Alexander Aring
Hi, status update here. I implemented successful basic 6CO RA messages at sending and processing inside radvd. There might also the question if processing 6CO inside kernel or userspace? I put the basic functionality inside userspace for now. I will send patches for this in the next days. Anyw

Re: Double free of dst_entry in ipv4_dst_destroy()

2015-12-11 Thread Eric Dumazet
On Fri, 2015-12-11 at 07:48 -0800, Eric Dumazet wrote: > On Fri, 2015-12-11 at 06:23 -0800, Eric Dumazet wrote: > > On Sun, 2015-12-06 at 17:58 -0800, Eric Dumazet wrote: > > > On Sun, 2015-12-06 at 13:03 -0800, Eric Dumazet wrote: > > > > > > > But then when later we promote a skb->dst to a refct

rhashtable concurrent writers issue, 4.2+

2015-12-11 Thread Colin Ian King
Hi, After testing with commit 7def0f952eccdd0edb3c504f4dab35ee0d3aba1f ("lib: fix data race in rhashtable_rehash_one") on the current 4.4-rc4 kernel, I believe I am still seeing race conditions that seem to bite concurrent readers. The reproducer is found in my stress-ng system stress tool: git:

RE: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-11 Thread KY Srinivasan
> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Vitaly Kuznetsov > Sent: Friday, December 11, 2015 5:53 AM > To: Haiyang Zhang > Cc: o...@aepfle.de; netdev@vger.kernel.org; jasow...@redhat.com; > driverdev-de...@linuxdriverproject

RE: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-11 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, December 11, 2015 8:53 AM > To: Haiyang Zhang > Cc: da...@davemloft.net; netdev@vger.kernel.org; o...@aepfle.de; > jasow...@redhat.com; driverdev-de...@linuxdriverproject.org; linux- > ker...@vger.

Re: use-after-free in sctp_do_sm

2015-12-11 Thread Marcelo Ricardo Leitner
Em 11-12-2015 12:30, Dmitry Vyukov escreveu: On Fri, Dec 11, 2015 at 3:03 PM, Marcelo Ricardo Leitner wrote: On Fri, Dec 11, 2015 at 11:51:21AM -0200, Marcelo Ricardo Leitner wrote: Em 11-12-2015 11:35, Dmitry Vyukov escreveu: On Wed, Dec 9, 2015 at 5:41 PM, Marcelo Ricardo Leitner wrote: O

Re: Double free of dst_entry in ipv4_dst_destroy()

2015-12-11 Thread Eric Dumazet
On Fri, 2015-12-11 at 06:23 -0800, Eric Dumazet wrote: > On Sun, 2015-12-06 at 17:58 -0800, Eric Dumazet wrote: > > On Sun, 2015-12-06 at 13:03 -0800, Eric Dumazet wrote: > > > > > But then when later we promote a skb->dst to a refctounted one > > > (skb_dst_force(), we might make sure we abort th

[patch net-next] mlxsw: reg: Fix max temperature getting

2015-12-11 Thread Jiri Pirko
From: Jiri Pirko Fix copy & paste error in MTPM unpack helper. Fixes: 85926f877040 ("mlxsw: reg: Add definition of temperature management registers") Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

Another pppoe-related crash

2015-12-11 Thread Andrew
I've got another pppoe-related crash on one PPPoE BRAS. Kernel is 4.1.13 with patch "pppoe: fix memory corruption in padt work structure" Crash place: (gdb) list *unregister_sysctl_table+0x1a 0xc118f26a is in unregister_sysctl_table (/var/testpoint/LEAF/source/i486-unknown-linux-uclibc/linux

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-12-11 Thread Johannes Berg
On Sun, 2015-11-15 at 15:31 +0800, Dave Young wrote: > cfg80211 module prints a lot of messages like below. Actually > printing once is acceptable but sometimes it will print again and > again, it looks very annoying. It is better to change these detail > messages to debugging only. > Despite the

Another pppoe-related crash

2015-12-11 Thread Andrew
I've got another pppoe-related crash on one PPPoE BRAS. Kernel is 4.1.13 with patch "pppoe: fix memory corruption in padt work structure" Crash place: (gdb) list *unregister_sysctl_table+0x1a 0xc118f26a is in unregister_sysctl_table (/var/testpoint/LEAF/source/i486-unknown-linux-uclibc/linux

Re: use-after-free in sctp_do_sm

2015-12-11 Thread Dmitry Vyukov
On Fri, Dec 11, 2015 at 3:03 PM, Marcelo Ricardo Leitner wrote: > On Fri, Dec 11, 2015 at 11:51:21AM -0200, Marcelo Ricardo Leitner wrote: >> Em 11-12-2015 11:35, Dmitry Vyukov escreveu: >> >On Wed, Dec 9, 2015 at 5:41 PM, Marcelo Ricardo Leitner >> > wrote: >> >>On Wed, Dec 09, 2015 at 01:03:56PM

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-12-11 Thread Johannes Berg
On Mon, 2015-11-23 at 09:37 +0800, Dave Young wrote: > Seems there're a lot of other wireless messages. Should we refactor > them as well? I still did not get chance to see where is the code. > (My wireless driver being used is iwlwifi) Most are probably from net/mac80211/. > # dmesg|grep "Limi

Re: Double free of dst_entry in ipv4_dst_destroy()

2015-12-11 Thread Eric Dumazet
On Sun, 2015-12-06 at 17:58 -0800, Eric Dumazet wrote: > On Sun, 2015-12-06 at 13:03 -0800, Eric Dumazet wrote: > > > But then when later we promote a skb->dst to a refctounted one > > (skb_dst_force(), we might make sure we abort the operation if __refcnt > > == 0 ( and DST_NOCACHE is in dst->fla

[PATCH v2] ixgbe: on recv increment rx.ring->stats.yields

2015-12-11 Thread Pavel Tikhomirov
It seem to be non intentionaly changed to tx in commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address multiple issues") Lock is taken from ixgbe_low_latency_recv, and there under this lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment tx counter. Yield stats can

Re: use-after-free in sctp_do_sm

2015-12-11 Thread Marcelo Ricardo Leitner
On Fri, Dec 11, 2015 at 11:51:21AM -0200, Marcelo Ricardo Leitner wrote: > Em 11-12-2015 11:35, Dmitry Vyukov escreveu: > >On Wed, Dec 9, 2015 at 5:41 PM, Marcelo Ricardo Leitner > > wrote: > >>On Wed, Dec 09, 2015 at 01:03:56PM -0200, Marcelo Ricardo Leitner wrote: > >>>On Wed, Dec 09, 2015 at 03:

Re: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-11 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Haiyang Zhang writes: > >> In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the >> locking for MSD (Multi-Send Data) field was removed. This could cause a >> race condition between RNDIS control messages and data packets processing, >> because the

Re: use-after-free in sctp_do_sm

2015-12-11 Thread Marcelo Ricardo Leitner
Em 11-12-2015 11:35, Dmitry Vyukov escreveu: On Wed, Dec 9, 2015 at 5:41 PM, Marcelo Ricardo Leitner wrote: On Wed, Dec 09, 2015 at 01:03:56PM -0200, Marcelo Ricardo Leitner wrote: On Wed, Dec 09, 2015 at 03:41:29PM +0100, Dmitry Vyukov wrote: On Tue, Dec 8, 2015 at 8:22 PM, Dmitry Vyukov wr

Re: [linux-next] iwl_mvm_get_key_sta_id() suspicious RCU usage

2015-12-11 Thread Johannes Berg
On Fri, 2015-12-11 at 22:44 +0900, Sergey Senozhatsky wrote: > [ 6385.246300] drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1226 > suspicious rcu_dereference_protected() usage! > Funny, Laura Abbott also reported this bug earlier today :) I've sent out a fix, you can see it here: https://patchwo

Re: [PATCH] ixgbe: on recv increment rx.ring->stats.yields instead of tx

2015-12-11 Thread Sergei Shtylyov
Hello. On 12/11/2015 10:24 AM, Pavel Tikhomirov wrote: It seem to be non intentionaly changed to tx in ms commit: adc810900a703ee78fe88fd65e086d359fec04b2 ixgbe: Refactor busy poll socket code to address multiple issues scripts/checkpatch.pl now enforces uniform style of the commit citing,

[linux-next] iwl_mvm_get_key_sta_id() suspicious RCU usage

2015-12-11 Thread Sergey Senozhatsky
Hi, linux-next 20151211 [ 6385.246285] === [ 6385.246288] [ INFO: suspicious RCU usage. ] [ 6385.246294] 4.4.0-rc4-next-20151211-dbg-00015-g7b65ef3-dirty #302 Not tainted [ 6385.246296] --- [ 6385.246300] drivers/net/wireless/intel/iwlwifi

Re: [PATCH v3 3/4] VSOCK: Introduce vhost-vsock.ko

2015-12-11 Thread Alex Bennée
Stefan Hajnoczi writes: > From: Asias He > > VM sockets vhost transport implementation. This module runs in host > kernel. As per previous checkpatch comments. > > Signed-off-by: Asias He > Signed-off-by: Stefan Hajnoczi > --- > v3: > * Remove unneeded variable used to store return value >

Re: use-after-free in sctp_do_sm

2015-12-11 Thread Dmitry Vyukov
On Wed, Dec 9, 2015 at 5:41 PM, Marcelo Ricardo Leitner wrote: > On Wed, Dec 09, 2015 at 01:03:56PM -0200, Marcelo Ricardo Leitner wrote: >> On Wed, Dec 09, 2015 at 03:41:29PM +0100, Dmitry Vyukov wrote: >> > On Tue, Dec 8, 2015 at 8:22 PM, Dmitry Vyukov wrote: >> > > On Tue, Dec 8, 2015 at 6:40

Re: [PATCH] ath9k: fix inconsistent indenting on return statement

2015-12-11 Thread Kalle Valo
Colin King writes: > From: Colin Ian King > > minor change, indenting is one tab out. > > Signed-off-by: Colin Ian King Applied to ath.git, thanks. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More ma

Re: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

2015-12-11 Thread Stefan Schmidt
Hello. On 11/12/15 14:07, SF Markus Elfring wrote: this slipped through, but now it does no longer apply. Applying: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" error: patch failed: drivers/net/ieee802154/atusb.c:310 error: drivers/net/ieee802154/atusb.c:

Re: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

2015-12-11 Thread SF Markus Elfring
not apply > Patch failed at 0001 ieee802154-atusb: Delete an unnecessary check before the > function call "kfree_skb" How can this hiccup happen? A command like the following is still working for me on source files for the software "Linux next-20151211". elfring@Sonne:~/

Re: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-11 Thread Vitaly Kuznetsov
Haiyang Zhang writes: > In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the > locking for MSD (Multi-Send Data) field was removed. This could cause a > race condition between RNDIS control messages and data packets processing, > because these two types of traffic are not sy

[iproute PATCH] ip{,6}tunnel: have a shared stats parser/printer

2015-12-11 Thread Phil Sutter
This has a slight side-effect of not aborting when /proc/net/dev is malformed, but OTOH stats are not parsed for uninteresting interfaces. Signed-off-by: Phil Sutter --- ip/ip6tunnel.c | 21 ++--- ip/iptunnel.c | 21 ++--- ip/tunnel.c| 28

Re: [v2] wlcore/wl12xx: spi: fix oops on firmware load

2015-12-11 Thread Kalle Valo
> The maximum chunks used by the function is > (SPI_AGGR_BUFFER_SIZE / WSPI_MAX_CHUNK_SIZE + 1). > The original commands array had space for > (SPI_AGGR_BUFFER_SIZE / WSPI_MAX_CHUNK_SIZE) commands. > When the last chunk is used (len > 4 * WSPI_MAX_CHUNK_SIZE), the last > command is stored outside

Re: iwlegacy: mark il_adjust_beacon_interval as noinline

2015-12-11 Thread Kalle Valo
> With the new optimized do_div() code, some versions of gcc > produce obviously incorrect code that leads to a link error > in iwlegacy/common.o: > > drivers/built-in.o: In function `il_send_rxon_timing': > :(.text+0xa6b4d4): undefined reference to `ilog2_NaN' > :(.text+0xa6b4f0): undefined

Re: [v2] rtlwifi: fix memory leak for USB device

2015-12-11 Thread Kalle Valo
> Free skb for received frames with a wrong checksum. This can happen > pretty rapidly, exhausting all memory. > > This fixes a memleak (detected with kmemleak). Originally found while > using monitor mode, but it also appears during managed mode (once the > link is up). > > Cc: sta...@vger.kern

Re: prism54: fix compare_const_fl.cocci warnings

2015-12-11 Thread Kalle Valo
> Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscr

Re: mwifiex: fix semicolon.cocci warnings

2015-12-11 Thread Kalle Valo
> Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: brcm80211: fix compare_const_fl.cocci warnings

2015-12-11 Thread Kalle Valo
> Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscr

[PATCH net-next 7/8] qeth: repair SBAL elements calculation

2015-12-11 Thread Ursula Braun
When sending skbs, qeth determines the number of qdio SBAL elements required. If qeth sends a fragmented skb, the SBAL element number calculation is wrong, because the fragmented data part is added twice in qeth_l3_tso_elements(). This patch makes sure fragmented data is handled in qeth_elements_fo

[PATCH net-next 0/8] s390 network patches

2015-12-11 Thread Ursula Braun
Hi Dave, here are some s390 related patches for net-next. Most important is the skb_linearize af_iucv patch from Eugene solving traffic problems in certain scenarios. The remaining patches are minor improvements. Thanks, Ursula Eugene Crosser (2): iucv: prevent information leak in iucv_message

[PATCH net-next 3/8] MAINTAINERS: switch to alternate IBM mail address

2015-12-11 Thread Ursula Braun
Signed-off-by: Ursula Braun --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8eba565..ab79736 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9125,7 +9125,7 @@ F:drivers/s390/block/dasd* F: block/partitions/ibm.c

[PATCH net-next 1/8] iucv: prevent information leak in iucv_message

2015-12-11 Thread Ursula Braun
From: Eugene Crosser Initialize storage for the future IUCV header that will be included in the transmitted packet. Some of the header fields are unused with HiperSockets transport, and will contain data left from some other functions. Signed-off-by: Eugene Crosser Signed-off-by: Ursula Braun

[PATCH net-next 5/8] qeth use common function qeth_get_setassparms_cmd

2015-12-11 Thread Ursula Braun
From: Thomas Richter There have been 2 identical versions of function qeth_get_setassparms_cmd() for layer 2 and layer 3. Remove the layer 3 function qeth_l3_get_setassparms_cmd() and call the common one named qeth_get_setassparms_cmd() located in qeth_core_main.c Signed-off-by: Thomas Richter

[PATCH net-next 8/8] qeth: get rid of redundant 0-termination

2015-12-11 Thread Ursula Braun
From: Rasmus Villemoes 0-termination is redundant, since sprintf has done that. Signed-off-by: Rasmus Villemoes Signed-off-by: Ursula Braun --- drivers/s390/net/qeth_core_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_cor

[PATCH net-next 6/8] qeth: initialize net_device with carrier off

2015-12-11 Thread Ursula Braun
/sys/class/net//operstate for an active qeth network interface offen shows "unknown", which translates to "state UNKNOWN in output of "ip link show". It is caused by a missing initialization of the __LINK_STATE_NOCARRIER bit in the net_device state field. This patch adds a netif_carrier_off() invoc

[PATCH net-next 4/8] s390-ctcm: Delete unnecessary checks before the function call "channel_remove"

2015-12-11 Thread Ursula Braun
From: Markus Elfring The channel_remove() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Ursula Braun --- drivers/s3

[PATCH net-next 2/8] iucv: call skb_linearize() when needed

2015-12-11 Thread Ursula Braun
From: Eugene Crosser When the linear buffer of the received sk_buff is shorter than the header, use skb_linearize(). sk_buffs with short linear buffer happen on the sending side under high traffic, and some kernel configurations, when allocated buffer starts just before page boundary, and IUCV tr

Re: [PATCH net-next v4 4/4] ila: Add generic ILA translation facility

2015-12-11 Thread Florian Westphal
Tom Herbert wrote: > +static struct nf_hook_ops ila_nf_hook_ops[] __read_mostly = { > + { > + .hook = ila_nf_input, > + .pf = NFPROTO_IPV6, > + .hooknum = NF_INET_PRE_ROUTING, > + .priority = -1, [..] > +int ila_xlat_init(void) [..] > + for

Re: brcmfmac: only lock and unlock fws if fws is not null

2015-12-11 Thread Kalle Valo
> From: Colin Ian King > > There is a null ptr check for fws to set bcmc_credit_check, however, > there a lock and unlock on fws should only performed if fwts is > also not null to also avoid a potential null pointer deference. > > Signed-off-by: Colin Ian King > Acked-by: Arend van Spriel T

[PATCH 2/7] iucv: call skb_linearize() when needed

2015-12-11 Thread Ursula Braun
From: Eugene Crosser When the linear buffer of the received sk_buff is shorter than the header, use skb_linearize(). sk_buffs with short linear buffer happen on the sending side under high traffic, and some kernel configurations, when allocated buffer starts just before page boundary, and IUCV tr

[PATCH net-next 0/7] s390 network patches

2015-12-11 Thread Ursula Braun
Hi Dave, here are some s390 related patches for net-next. Most important is the skb_linearize af_iucv patch from Eugene solving traffic problems in certain scenarios. The remaining patches are minor improvements. Thanks, Ursula Eugene Crosser (2): iucv: prevent information leak in iucv_message

[PATCH 4/7] s390-ctcm: Delete unnecessary checks before the function call "channel_remove"

2015-12-11 Thread Ursula Braun
From: Markus Elfring The channel_remove() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Ursula Braun --- drivers/s3

[PATCH 6/7] qeth: repair SBAL elements calculation

2015-12-11 Thread Ursula Braun
When sending skbs, qeth determines the number of qdio SBAL elements required. If qeth sends a fragmented skb, the SBAL element number calculation is wrong, because the fragmented data part is added twice in qeth_l3_tso_elements(). This patch makes sure fragmented data is handled in qeth_elements_fo

[PATCH 3/7] switch to alternate IBM mail address

2015-12-11 Thread Ursula Braun
Signed-off-by: Ursula Braun --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8eba565..f62648e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9125,7 +9125,7 @@ F:drivers/s390/block/dasd* F: block/partitions/ibm.c

[PATCH 5/7] qeth: initialize net_device with carrier off

2015-12-11 Thread Ursula Braun
/sys/class/net//operstate for an active qeth network interface offen shows "unknown", which translates to "state UNKNOWN in output of "ip link show". It is caused by a missing initialization of the __LINK_STATE_NOCARRIER bit in the net_device state field. This patch adds a netif_carrier_off() invoc

  1   2   >