RE: [PATCH] tehuti: possible leak in bdx_probe

2007-10-14 Thread Alexander Indenbaum
> -Original Message- > From: Florin Malita [mailto:[EMAIL PROTECTED] > > If pci_enable_device fails, bdx_probe returns without freeing the > allocated pci_nic structure. > > Coverity CID 1908. > > Signed-off-by: Florin Malita <[EMAIL PROTECTED]> Looks

RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread Alexander Indenbaum
> Ok, so you do irq acquire/release in open/close so that bit is fine. > The code might actually work as is, sorry for the noise. It is no noise at all. Thank you for your feedback. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED

RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread Alexander Indenbaum
dev resources among others calls free_irq(). That's why I'm pretty sure that we do not hold any reference to netdev after unregister_netdev() finishes and we can free_netdev() without any worry :) What do you think, does it still look fishy? Alexander Indenbaum - To unsubscribe from thi

RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread Alexander Indenbaum
goto err_dma; > >but rather write > > err = pci_request_regions(pdev, BDX_DRV_NAME); > if (err) > goto err_dma; Thank you again for your help, Alexander Indenbaum - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html