Re: [PATCH net-next] __netif_receive_skb_core: don't untag vlan from skb on DSA master

2020-09-14 Thread David Miller
From: Vladimir Oltean Date: Sat, 12 Sep 2020 02:26:07 +0300 > A DSA master interface has upper network devices, each representing an > Ethernet switch port attached to it. Demultiplexing the source ports and > setting skb->dev accordingly is done through the catch-all ETH_P_XDSA > packet_type han

Re: [PATCH net-next v5 0/6] net-next: dsa: mt7530: add support for MT7531

2020-09-14 Thread David Miller
From: Landen Chao Date: Fri, 11 Sep 2020 21:48:50 +0800 > This patch series adds support for MT7531. > > MT7531 is the next generation of MT7530 which could be found on Mediatek > router platforms such as MT7622 or MT7629. > > It is also a 7-ports switch with 5 giga embedded phys, 2 cpu ports,

Re: [PATCH net] ipv4: Initialize flowi4_multipath_hash in data path

2020-09-14 Thread David Miller
From: David Ahern Date: Sun, 13 Sep 2020 12:43:39 -0600 > From: David Ahern > > flowi4_multipath_hash was added by the commit referenced below for > tunnels. Unfortunately, the patch did not initialize the new field > for several fast path lookups that do not initialize the entire flow > struct

Re: [PATCH v2 0/4] net: lantiq: Fix bugs in NAPI handling

2020-09-14 Thread David Miller
From: Hauke Mehrtens Date: Sat, 12 Sep 2020 21:36:25 +0200 > This fixes multiple bugs in the NAPI handling. > > Changes since: > v1: > - removed stable tag from "net: lantiq: use netif_tx_napi_add() for TX NAPI" > - Check the NAPI budged in "net: lantiq: Use napi_complete_done()" > - Add extr

Re: [PATCH net-next] drivers/net/wan/x25_asy: Remove an unnecessary x25_type_trans call

2020-09-14 Thread David Miller
From: Xie He Date: Fri, 11 Sep 2020 19:18:07 -0700 > x25_type_trans only needs to be called before we call netif_rx to pass > the skb to upper layers. > > It does not need to be called before lapb_data_received. The LAPB module > does not need the fields that are set by calling it. > > In the o

Re: [PATCH] rndis_host: increase sleep time in the query-response loop

2020-09-14 Thread David Miller
From: Olympia Giannou Date: Fri, 11 Sep 2020 14:17:24 + > Some WinCE devices face connectivity issues via the NDIS interface. They > fail to register, resulting in -110 timeout errors and failures during the > probe procedure. > > In this kind of WinCE devices, the Windows-side ndis driver n

Re: [PATCH net-next v2] net: try to avoid unneeded backlog flush

2020-09-14 Thread David Miller
From: Paolo Abeni Date: Thu, 10 Sep 2020 23:33:18 +0200 > flush_all_backlogs() may cause deadlock on systems > running processes with FIFO scheduling policy. > > The above is critical in -RT scenarios, where user-space > specifically ensure no network activity is scheduled on > the CPU running t

Re: [PATCH net-next 5/8] bridge: Add SWITCHDEV_FDB_FLUSH_TO_BRIDGE notifier

2020-09-14 Thread David Miller
From: Julian Wiedmann Date: Thu, 10 Sep 2020 19:23:48 +0200 > From: Alexandra Winter > > so the switchdev can notifiy the bridge to flush non-permanent fdb entries > for this port. This is useful whenever the hardware fdb of the switchdev > is reset, but the netdev and the bridgeport are not de

Re: [PATCH net-next 0/5] mlxsw: Derive SBIB from maximum port speed & MTU

2020-09-14 Thread David Miller
From: Ido Schimmel Date: Sun, 13 Sep 2020 18:46:04 +0300 > From: Ido Schimmel > > Petr says: > > Internal buffer is a part of port headroom used for packets that are > mirrored due to triggers that the Spectrum ASIC considers "egress". Besides > ACL mirroring on port egresss this includes also

Re: [PATCH net-next v5 0/6] 8390: core cleanups

2020-09-14 Thread David Miller
From: Armin Wolf Date: Mon, 14 Sep 2020 23:01:22 +0200 > The purpose of this patchset is to do some > cleanups in lib8390.c and 8390.c A lot of these changes are borderline beneficial, at best. You are adding include files to foo.c files that are already included by lib8390.c already (which the

Re: [net-next v2 0/5][pull request] 40GbE Intel Wired LAN Driver Updates 2020-09-14

2020-09-14 Thread David Miller
From: Tony Nguyen Date: Mon, 14 Sep 2020 10:32:19 -0700 > This series contains updates to i40e driver only. > > Li RongQing removes binding affinity mask to a fixed CPU and sets > prefetch of Rx buffer page to occur conditionally. > > Björn provides AF_XDP performance improvements by not prefet

Re: [PATCH net-next 0/5] rxrpc: Fixes for the connection manager rewrite

2020-09-14 Thread David Miller
From: David Howells Date: Mon, 14 Sep 2020 16:30:46 +0100 > > Here are some fixes for the connection manager rewrite: > > (1) Fix a goto to the wrong place in error handling. > > (2) Fix a missing NULL pointer check. > > (3) The stored allocation error needs to be stored signed. > > (4)

Re: [PATCH net-next] hinic: add vxlan segmentation and cs offload support

2020-09-14 Thread David Miller
From: Luo bin Date: Mon, 14 Sep 2020 21:48:23 +0800 > Add NETIF_F_GSO_UDP_TUNNEL and NETIF_F_GSO_UDP_TUNNEL_CSUM features > to support vxlan segmentation and checksum offload. Ipip and ipv6 > tunnel packets are regarded as non-tunnel pkt for hw and as for other > type of tunnel pkts, checksum off

Re: [PATCH net-next] net: pxa168_eth: remove unused variable 'retval' int pxa168_eth_change_mtu()

2020-09-14 Thread David Miller
From: Zhang Changzhong Date: Mon, 14 Sep 2020 21:19:12 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/marvell/pxa168_eth.c:1190:6: warning: > variable 'retval' set but not used [-Wunused-but-set-variable] > 1190 | int retval; > | ^~ > > Funct

Re: [PATCH net-next] net: qlcnic: remove unused variable 'val' in qlcnic_83xx_cam_unlock()

2020-09-14 Thread David Miller
From: Zhang Changzhong Date: Mon, 14 Sep 2020 21:24:39 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:661:6: warning: > variable 'val' set but not used [-Wunused-but-set-variable] > 661 | u32 val; > | ^~~ > > After

Re: [PATCH net-next] net: fec: ptp: remove unused variable 'ns' in fec_time_keep()

2020-09-14 Thread David Miller
From: Zhang Changzhong Date: Mon, 14 Sep 2020 21:14:24 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/freescale/fec_ptp.c:523:6: warning: > variable 'ns' set but not used [-Wunused-but-set-variable] > 523 | u64 ns; > | ^~ > > After commit 6605b7

Re: [PATCH net-next] net: dnet: remove unused variable 'tx_status 'in dnet_start_xmit()

2020-09-14 Thread David Miller
From: Zhang Changzhong Date: Mon, 14 Sep 2020 21:08:37 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/dnet.c:510:6: warning: > variable 'tx_status' set but not used [-Wunused-but-set-variable] > u32 tx_status, irq_enable; > ^ > > After commit

Re: [PATCH net-next] tcp: remove SOCK_QUEUE_SHRUNK

2020-09-14 Thread David Miller
From: Eric Dumazet Date: Mon, 14 Sep 2020 03:20:27 -0700 > SOCK_QUEUE_SHRUNK is currently used by TCP as a temporary state > that remembers if some room has been made in the rtx queue > by an incoming ACK packet. > > This is later used from tcp_check_space() before > considering to send EPOLLOUT

Re: [PATCH net-next v2] net/packet: Fix a comment about hard_header_len and headroom allocation

2020-09-14 Thread David Miller
From: Xie He Date: Mon, 14 Sep 2020 00:41:54 -0700 > This comment is outdated and no longer reflects the actual implementation > of af_packet.c. > > Reasons for the new comment: > > 1. > > In af_packet.c, the function packet_snd first reserves a headroom of > length (dev->hard_header_len + dev

Re: [PATCH net-next v2 00/13] mptcp: introduce support for real multipath xmit

2020-09-14 Thread David Miller
From: Paolo Abeni Date: Mon, 14 Sep 2020 10:01:06 +0200 > This series enable MPTCP socket to transmit data on multiple subflows > concurrently in a load balancing scenario. > > First the receive code path is refactored to better deal with out-of-order > data (patches 1-7). An RB-tree is introduc

Re: [RESEND net-next v2 00/12]drivers: net: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread David Miller
From: Allen Pais Date: Mon, 14 Sep 2020 13:01:19 +0530 > From: Allen Pais > > ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > introduced a new tasklet initialization API. This series converts > all the net/* drivers to use the new tasklet_setup() API > > This series is base

Re: [net-next v3 00/20] ethernet: convert tasklets to use new tasklet_setup API

2020-09-14 Thread David Miller
From: Allen Pais Date: Mon, 14 Sep 2020 12:59:19 +0530 > From: Allen Pais > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > introduced a new tasklet initialization API. This series converts > all the crypto modules to use the new tasklet_setup() API > > This series is ba

Re: [PATCH] tulip: switch from 'pci_' to 'dma_' API

2020-09-13 Thread David Miller
From: Christophe JAILLET Date: Sun, 13 Sep 2020 14:55:46 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] tulip: dmfe: switch from 'pci_' to 'dma_' API

2020-09-13 Thread David Miller
From: Christophe JAILLET Date: Sun, 13 Sep 2020 14:38:34 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] tulip: de2104x: switch from 'pci_' to 'dma_' API

2020-09-13 Thread David Miller
From: Christophe JAILLET Date: Sun, 13 Sep 2020 14:44:53 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] tulip: uli526x: switch from 'pci_' to 'dma_' API

2020-09-13 Thread David Miller
From: Christophe JAILLET Date: Sun, 13 Sep 2020 14:30:42 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH v2] net: fix uninit value error in __sys_sendmmsg

2020-09-13 Thread David Miller
From: Anant Thazhemadam Date: Sun, 13 Sep 2020 16:33:13 +0530 > diff --git a/net/socket.c b/net/socket.c > index 0c0144604f81..1e6f9b54982c 100644 > --- a/net/socket.c > +++ b/net/socket.c > @@ -2398,6 +2398,7 @@ static int ___sys_sendmsg(struct socket *sock, struct > user_msghdr __user *msg, >

Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()

2020-09-13 Thread David Miller
From: Tariq Toukan Date: Sun, 13 Sep 2020 13:12:05 +0300 > > > On 9/13/2020 4:22 AM, David Miller wrote: >> From: Luo Jiaxing >> Date: Sat, 12 Sep 2020 16:08:15 +0800 >> >>> We found a set but not used variable 'ring_cons' in mlx4_en_xmit(),

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-13 Thread David Miller
From: Shay Agroskin Date: Sun, 13 Sep 2020 11:16:34 +0300 > ENA logs are adjusted to display the full ENA representation to > distinct each ENA device in case of multiple interfaces. > Using dev_err/warn/info function family for logging provides uniform > printing with clear distinction of the dr

Re: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg

2020-09-13 Thread David Miller
From: Anant Thazhemadam Date: Sun, 13 Sep 2020 11:50:52 +0530 > My apologies. I think I ended up overlooking the build warning. You "think" you overlooked the build warning? You don't actually know? If you aren't willing to even make sure the build is clean after your changes, why should we be

Re: [PATCH net-next] net: mvpp2: set SKBTX_IN_PROGRESS

2020-09-13 Thread David Miller
From: Russell King Date: Sun, 13 Sep 2020 08:05:52 +0100 > Richard Cochran points out that SKBTX_IN_PROGRESS should be set when > the skbuff is queued for timestamping. Add this. > > Signed-off-by: Russell King Applied.

Re: [PATCH] tulip: windbond-840: Fix a debug message

2020-09-13 Thread David Miller
From: Christophe JAILLET Date: Sun, 13 Sep 2020 09:01:07 +0200 > 'w89c840_open()' is incorrectly reported in a debug message. Use __func__ > instead. > > While at it, fix some style issue in the same function. > > Signed-off-by: Christophe JAILLET Applied.

Re: [PATCH] tulip: windbond-840: switch from 'pci_' to 'dma_' API

2020-09-13 Thread David Miller
From: Christophe JAILLET Date: Sun, 13 Sep 2020 08:57:11 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: dl2k: switch from 'pci_' to 'dma_' API

2020-09-13 Thread David Miller
From: Christophe JAILLET Date: Sun, 13 Sep 2020 08:14:17 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH V2] natsemi: switch from 'pci_' to 'dma_' API

2020-09-13 Thread David Miller
From: Christophe JAILLET Date: Sun, 13 Sep 2020 07:46:28 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-12 Thread David Miller
From: Geert Uytterhoeven Date: Sat, 12 Sep 2020 14:33:59 +0200 > "dev" is not the bridge device, but the physical Ethernet interface, which > may already be suspended during s2ram. Hmmm, ok. Looking more deeply NETDEV_CHANGE causes br_port_carrier_check() to run which exits early if netif_runni

Re: [PATCH] rocker: switch from 'pci_' to 'dma_' API

2020-09-12 Thread David Miller
From: Christophe JAILLET Date: Sat, 12 Sep 2020 13:44:18 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: tehuti: switch from 'pci_' to 'dma_' API

2020-09-12 Thread David Miller
From: Christophe JAILLET Date: Sat, 12 Sep 2020 16:12:32 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] sc92031: switch from 'pci_' to 'dma_' API

2020-09-12 Thread David Miller
From: Christophe JAILLET Date: Sat, 12 Sep 2020 13:28:58 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] tlan: switch from 'pci_' to 'dma_' API

2020-09-12 Thread David Miller
From: Christophe JAILLET Date: Sat, 12 Sep 2020 09:43:58 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [Linux-kernel-mentees] [PATCH net] tipc: Fix memory leak in tipc_group_create_member()

2020-09-12 Thread David Miller
From: Peilin Ye Date: Sat, 12 Sep 2020 06:22:30 -0400 > @@ -291,10 +291,11 @@ static void tipc_group_add_to_tree(struct tipc_group > *grp, > else if (key > nkey) > n = &(*n)->rb_right; > else > - return; > +

Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()

2020-09-12 Thread David Miller
From: Luo Jiaxing Date: Sat, 12 Sep 2020 16:08:15 +0800 > We found a set but not used variable 'ring_cons' in mlx4_en_xmit(), it will > cause a warning when build the kernel. And after checking the commit record > of this function, we found that it was introduced by a previous patch. > > So, We

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-11 Thread David Miller
From: Geert Uytterhoeven Date: Fri, 11 Sep 2020 08:32:55 +0200 > Hi David, > > On Thu, Sep 10, 2020 at 9:20 PM David Miller wrote: >> From: Geert Uytterhoeven >> Date: Tue, 1 Sep 2020 17:02:37 +0200 >> >> > This reverts commit 124eee3f6955f7aa19b9e6ff5

Re: [PATCH v3 net-next] net: phy: mchp: Add support for LAN8814 QUAD PHY

2020-09-11 Thread David Miller
From: Divya Koppera Date: Fri, 11 Sep 2020 18:48:44 +0530 > LAN8814 is a low-power, quad-port triple-speed (10BASE-T/100BASETX/1000BASE-T) > Ethernet physical layer transceiver (PHY). It supports transmission and > reception of data on standard CAT-5, as well as CAT-5e and CAT-6, unshielded > twi

Re: [PATCH net-next] net: hns: use IRQ_NOAUTOEN to avoid irq is enabled due to request_irq

2020-09-11 Thread David Miller
From: Barry Song Date: Fri, 11 Sep 2020 13:55:10 +1200 > Rather than doing request_irq and then disabling the irq immediately, it > should be safer to use IRQ_NOAUTOEN flag for the irq. It removes any gap > between request_irq() and disable_irq(). > > Cc: Salil Mehta > Reviewed-by: Yunsheng Lin

Re: [PATCH] net: ethernet: ti: cpsw_new: fix suspend/resume

2020-09-11 Thread David Miller
From: Grygorii Strashko Date: Thu, 10 Sep 2020 23:52:29 +0300 > Add missed suspend/resume callbacks to properly restore networking after > suspend/resume cycle. > > Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based > driver part 1 - dual-emac") > Signed-off-by: Grygorii St

Re: [PATCH net-next v3 0/9] net: ethernet: ti: ale: add static configuration

2020-09-11 Thread David Miller
From: Grygorii Strashko Date: Thu, 10 Sep 2020 23:27:58 +0300 > As existing, as newly introduced CPSW ALE versions have differences in > supported features and ALE table formats. Especially it's actual for the > recent AM65x/J721E/J7200 and future AM64x SoCs, which supports more > features like:

Re: [PATCH v2 net-next 0/4] DSA tag_8021q cleanup

2020-09-11 Thread David Miller
From: Vladimir Oltean Date: Thu, 10 Sep 2020 19:48:53 +0300 > From: Vladimir Oltean > > This small series tries to consolidate the VLAN handling in DSA a little > bit. It reworks tag_8021q to be minimally invasive to the dsa_switch_ops > structure. This makes the rest of the code a bit easier t

Re: [PATCH net] net: ipa: fix u32_replace_bits by u32p_xxx version

2020-09-11 Thread David Miller
From: Vadym Kochan Date: Thu, 10 Sep 2020 18:41:52 +0300 > Looks like u32p_replace_bits() should be used instead of > u32_replace_bits() which does not modifies the value but returns the > modified version. > > Fixes: 2b9feef2b6c2 ("soc: qcom: ipa: filter and routing tables") > Signed-off-by: Va

Re: [net-next] crypto/chcr: move nic TLS functionality to drivers/net

2020-09-11 Thread David Miller
From: Rohit Maheshwari Date: Thu, 10 Sep 2020 19:51:47 +0530 > This patch moves complete nic tls offload (kTLS) code from crypto > directory to drivers/net/ethernet/chelsio/inline_crypto/ch_ktls > directory. nic TLS is made a separate ULD of cxgb4. > > Signed-off-by: Rohit Maheshwari Applied,

Re: [PATCH net v1] hinic: fix rewaking txq after netif_tx_disable

2020-09-11 Thread David Miller
From: Luo bin Date: Thu, 10 Sep 2020 22:04:40 +0800 > When calling hinic_close in hinic_set_channels, all queues are > stopped after netif_tx_disable, but some queue may be rewaken in > free_tx_poll by mistake while drv is handling tx irq. If one queue > is rewaken core may call hinic_xmit_frame

Re: [PATCH net v1] taprio: Fix allowing too small intervals

2020-09-11 Thread David Miller
From: Vinicius Costa Gomes Date: Wed, 9 Sep 2020 17:03:11 -0700 > It's possible that the user specifies an interval that couldn't allow > any packet to be transmitted. This also avoids the issue of the > hrtimer handler starving the other threads because it's running too > often. > > The soluti

Re: [RESEND net 0/4][pull request] Intel Wired LAN Driver Updates 2020-09-09

2020-09-11 Thread David Miller
From: Tony Nguyen Date: Fri, 11 Sep 2020 16:22:03 -0700 > This series contains updates to i40e and igc drivers. > > Stefan Assmann changes num_vlans to u16 to fix may be used uninitialized > error and propagates error in i40_set_vsi_promisc() for i40e. > > Vinicius corrects timestamping latency

Re: [PATCH v2 net-next 0/7] sfc: encap offloads on EF10

2020-09-11 Thread David Miller
From: Jakub Kicinski Date: Fri, 11 Sep 2020 16:07:26 -0700 > On Fri, 11 Sep 2020 23:37:10 +0100 Edward Cree wrote: >> EF10 NICs from the 8000 series onwards support TX offloads (checksumming, >> TSO) on VXLAN- and NVGRE-encapsulated packets. This series adds driver >> support for these offload

Re: [PATCH net-next] octeontx2-af: Constify npc_kpu_profile_{action,cam}

2020-09-11 Thread David Miller
From: Rikard Falkeborn Date: Sat, 12 Sep 2020 00:00:15 +0200 > These are never modified, so constify them to allow the compiler to > place them in read-only memory. This moves about 25kB to read-only > memory as seen by the output of the size command. > > Before: >textdata bss de

Re: [PATCH net-next 0/3] sfc: misc cleanups

2020-09-11 Thread David Miller
From: Jakub Kicinski Date: Fri, 11 Sep 2020 14:00:38 -0700 > On Fri, 11 Sep 2020 19:43:26 +0100 Edward Cree wrote: >> Clean up a few nits I noticed while working on TXQ stuff. > > Reviewed-by: Jakub Kicinski Series applied.

Re: [PATCH net-next] bridge: mcast: Fix incomplete MDB dump

2020-09-11 Thread David Miller
From: Ido Schimmel Date: Fri, 11 Sep 2020 16:24:47 +0300 > From: Ido Schimmel > > Each MDB entry is encoded in a nested netlink attribute called > 'MDBA_MDB_ENTRY'. In turn, this attribute contains another nested > attributed called 'MDBA_MDB_ENTRY_INFO', which encodes a single port > group ent

Re: [PATCH] ipv6: remove redundant assignment to variable err

2020-09-11 Thread David Miller
From: Colin King Date: Fri, 11 Sep 2020 11:35:09 +0100 > From: Colin Ian King > > The variable err is being initialized with a value that is never read and > it is being updated later with a new value. The initialization is redundant > and can be removed. Also re-order variable declarations in

Re: [PATCH net] enetc: Fix mdio bus removal on PF probe bailout

2020-09-11 Thread David Miller
From: Claudiu Manoil Date: Fri, 11 Sep 2020 13:16:35 +0300 > This is the correct resolution for the conflict from > merging the "net" tree fix: > commit 26cb7085c898 ("enetc: Remove the mdio bus on PF probe bailout") > with the "net-next" new work: > commit 07095c025ac2 ("net: enetc: Use DT proto

Re: [PATCH v1 0/2] ag71xx: add ethtool and flow control support

2020-09-11 Thread David Miller
From: Oleksij Rempel Date: Fri, 11 Sep 2020 10:25:26 +0200 > The main target of this patches is to provide flow control support > for ag71xx driver. To be able to validate this functionality, I also > added ethtool support with HW counters. So, this patches was validated > with iperf3 and counter

Re: [PATCH net-next] drivers/net/wan/x25_asy: Remove an unused flag "SLF_OUTWAIT"

2020-09-11 Thread David Miller
From: Xie He Date: Thu, 10 Sep 2020 23:35:03 -0700 > The "SLF_OUTWAIT" flag defined in x25_asy.h is not actually used. > It is only cleared at one place in x25_asy.c but is never read or set. > So we can remove it. > > Signed-off-by: Xie He Applied, it looks like this code wss based upon the s

Re: [PATCH net-next] net/socket.c: Remove an unused header file

2020-09-11 Thread David Miller
From: Xie He Date: Thu, 10 Sep 2020 23:07:20 -0700 > This header file is not actually used in this file. Let's remove it. How did you test this assertion? As Jakub showed, the dlci_ioctl_set() function needs to be declared because socket.c references it. All of your visual scanning of the code

Re: [PATCH net-next] net: dsa: b53: Configure VLANs while not filtering

2020-09-11 Thread David Miller
From: Florian Fainelli Date: Fri, 11 Sep 2020 11:28:27 -0700 > > > On 9/10/2020 9:19 PM, Florian Fainelli wrote: >> Update the B53 driver to support VLANs while not filtering. This >> requires us to enable VLAN globally within the switch upon driver >> initial configuration (dev->vlan_enabled).

Re: [PATCH net-next] net: stmmac: set get_rx_header_len() as void for it didn't have any error code to return

2020-09-11 Thread David Miller
From: Luo Jiaxing Date: Fri, 11 Sep 2020 11:55:58 +0800 > We found the following warning when using W=1 to build kernel: > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variable > ‘ret’ set but not used [-Wunused-but-set-variable] > int ret, coe = priv->hw->rx_csum; > >

Re: [PATCH net-next v4 0/8] Add GVE Features.

2020-09-11 Thread David Miller
From: Jakub Kicinski Date: Fri, 11 Sep 2020 13:55:33 -0700 > On Fri, 11 Sep 2020 10:38:43 -0700 David Awogbemila wrote: >> Note: Patch 4 in v3 was dropped. >> >> Patch 4 (patch 5 in v3): Start/stop timer only when report stats is >> enabled/disabled. >> Patch 7 (patc

Re: pull-request: wireless-drivers-next-2020-09-11

2020-09-11 Thread David Miller
From: Kalle Valo Date: Fri, 11 Sep 2020 15:27:13 + > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. Pulled, thanks a lot Kalle.

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-11 Thread David Miller
From: Allen Date: Fri, 11 Sep 2020 15:30:41 +0530 >> Just add a backpointer to the netdev from the netdev_priv() if you >> absolutely have too. >> > > How does this look? Looks good.

Re: [PATCH 0/8] drivers: net: convert tasklets to use new tasklet_setup()

2020-09-11 Thread David Miller
From: Allen Date: Fri, 11 Sep 2020 11:26:52 +0530 > Will you pick these up or should I send these out again when I > have fixed the two patches on the other thread. Always resend.

Re: [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip

2020-09-10 Thread David Miller
From: Lucy Yan Date: Thu, 10 Sep 2020 12:05:09 -0700 > Increase Rx ring size to address issue where hardware is reaching > the receive work limit. > > Before: > > [ 102.223342] de2104x :17:00.0 eth0: rx work limit reached > [ 102.245695] de2104x :17:00.0 eth0: rx work limit reached >

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-10 Thread David Miller
From: Nathan Chancellor Date: Thu, 10 Sep 2020 10:48:27 -0700 > Clang warns (trimmed for brevity): > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:3073:7: warning: > variable 'link' is used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > if (val

Re: [PATCH net-next 00/10] net/smc: updates 2020-09-10

2020-09-10 Thread David Miller
From: Karsten Graul Date: Thu, 10 Sep 2020 18:48:19 +0200 > Please apply the following patch series for smc to netdev's net-next tree. > > This patch series is a mix of various improvements and cleanups. > The patches 1 and 10 improve the handling of large parallel workloads. > Patch 8 corrects

Re: [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups

2020-09-10 Thread David Miller
From: Krzysztof Kozlowski Date: Thu, 10 Sep 2020 18:12:11 +0200 > Changes since v2: > 1. Fix dtschema ID after rename (patch 1/8). > 2. Apply patch 9/9 (defconfig change). > > Changes since v1: > 1. Rename dtschema file and add additionalProperties:false, as Rob >suggested, > 2. Add Marek's

Re: [PATCH net-next 0/6] Fix some kernel-doc warnings for hns

2020-09-10 Thread David Miller
From: Wang Hai Date: Thu, 10 Sep 2020 22:56:14 +0800 > Fix some kernel-doc warnings for hns. Series applied to net-next, thanks.

Re: [PATCH] net: mvpp2: ptp: Fix unused variables

2020-09-10 Thread David Miller
From: Alex Dewar Date: Thu, 10 Sep 2020 14:49:10 +0100 > In the functions mvpp2_isr_handle_xlg() and > mvpp2_isr_handle_gmac_internal(), the bool variable link is assigned a > true value in the case that a given bit of val is set. However, if the > bit is unset, no value is assigned to link and i

Re: [PATCH net-next] net: cxgb3: Fix some kernel-doc warnings

2020-09-10 Thread David Miller
From: Wang Hai Date: Thu, 10 Sep 2020 21:36:16 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:2209: warning: Excess function > parameter 'adapter' description in 'clear_sge_ctxt' > drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:2975: warning:

Re: [PATCH net] netlink: fix doc about nlmsg_parse/nla_validate

2020-09-10 Thread David Miller
From: Nicolas Dichtel Date: Thu, 10 Sep 2020 15:34:39 +0200 > There is no @validate argument. > > CC: Johannes Berg > Fixes: 3de644035446 ("netlink: re-add parse/validate functions in strict > mode") > Signed-off-by: Nicolas Dichtel Applied, thank you.

Re: [PATCH V4 net-next 0/4] Enhance current features in ena driver

2020-09-10 Thread David Miller
From: Date: Thu, 10 Sep 2020 13:07:09 + > From: Sameeh Jubran > > This series adds the following: > * Exposes new device stats using ethtool. > * Adds and exposes the stats of xdp TX queues through ethtool. > > V3: Fix indentation in patches #3 and #4 > V2: Drop the need for casting stat_o

Re: [PATCH net] net: DCB: Validate DCB_ATTR_DCB_BUFFER argument

2020-09-10 Thread David Miller
From: Petr Machata Date: Thu, 10 Sep 2020 14:09:05 +0200 > The parameter passed via DCB_ATTR_DCB_BUFFER is a struct dcbnl_buffer. The > field prio2buffer is an array of IEEE_8021Q_MAX_PRIORITIES bytes, where > each value is a number of a buffer to direct that priority's traffic to. > That value i

Re: [PATCH net 0/2] net: Fix bridge enslavement failure

2020-09-10 Thread David Miller
From: Ido Schimmel Date: Thu, 10 Sep 2020 14:01:25 +0300 > From: Ido Schimmel > > Patch #1 fixes an issue in which an upper netdev cannot be enslaved to a > bridge when it has multiple netdevs with different parent identifiers > beneath it. > > Patch #2 adds a test case using two netdevsim ins

Re: [PATCH v2] macsec: Support 32bit PN netlink attribute for XPN links

2020-09-10 Thread David Miller
From: Era Mayflower Date: Thu, 10 Sep 2020 09:56:09 + > - pn_len = secy->xpn ? MACSEC_XPN_PN_LEN : MACSEC_DEFAULT_PN_LEN; > - if (nla_len(tb_sa[MACSEC_SA_ATTR_PN]) != pn_len) { > - pr_notice("macsec: nl: upd_rxsa: bad pn length: %d != > %d\n", > -

Re: [PATCH net] net: mvneta: fix possible use-after-free in mvneta_xdp_put_buff

2020-09-10 Thread David Miller
From: Lorenzo Bianconi Date: Thu, 10 Sep 2020 11:08:01 +0200 > Release first buffer as last one since it contains references > to subsequent fragments. This code will be optimized introducing > multi-buffer bit in xdp_buff structure. > > Fixes: ca0e014609f05 ("net: mvneta: move skb build after d

Re: [PATCH v2] net: Correct the comment of dst_dev_put()

2020-09-10 Thread David Miller
From: Miaohe Lin Date: Thu, 10 Sep 2020 04:41:53 -0400 > Since commit 8d7017fd621d ("blackhole_netdev: use blackhole_netdev to > invalidate dst entries"), we use blackhole_netdev to invalidate dst entries > instead of loopback device anymore. > > Signed-off-by: Miaohe Lin Applied, thanks.

Re: [PATCH net] s390/qeth: delay draining the TX buffers

2020-09-10 Thread David Miller
From: Julian Wiedmann Date: Thu, 10 Sep 2020 11:05:18 +0200 > Wait until the QDIO data connection is severed. Otherwise the device > might still be processing the buffers, and end up accessing skb data > that we already freed. > > Fixes: 8b5026bc1693 ("s390/qeth: fix qdio teardown after early in

Re: [PATCH] net: Fix broken NETIF_F_CSUM_MASK spell in netdev_features.h

2020-09-10 Thread David Miller
From: Miaohe Lin Date: Thu, 10 Sep 2020 04:46:40 -0400 > Remove the weird space inside the NETIF_F_CSUM_MASK. > > Signed-off-by: Miaohe Lin Applied.

Re: [PATCH net-next 0/3] tcp: add tos reflection feature

2020-09-10 Thread David Miller
From: Wei Wang Date: Wed, 9 Sep 2020 17:50:45 -0700 > This patch series adds a new tcp feature to reflect TOS value received in > SYN, and send it out in SYN-ACK, and eventually set the TOS value of the > established socket with this reflected TOS value. This provides a way to > set the traffic

Re: [PATCH net-next] net: mventa: drop mvneta_stats from mvneta_swbm_rx_frame signature

2020-09-10 Thread David Miller
From: Lorenzo Bianconi Date: Wed, 9 Sep 2020 23:05:23 +0200 > Remove mvneta_stats from mvneta_swbm_rx_frame signature since now stats > are accounted in mvneta_run_xdp routine > > Signed-off-by: Lorenzo Bianconi Applied, thanks.

Re: [net-next v4 0/5] devlink flash update overwrite mask

2020-09-10 Thread David Miller
From: Jacob Keller Date: Wed, 9 Sep 2020 15:26:48 -0700 > This series introduces support for a new attribute to the flash update > command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. I think you really need to get rid of BIT() usage in the UAPI header as Jakub mentioned.

Re: [PATCH net-next 0/3] netpoll: make sure napi_list is safe for RCU traversal

2020-09-10 Thread David Miller
From: Jakub Kicinski Date: Wed, 9 Sep 2020 10:37:50 -0700 > This series is a follow-up to the fix in commit 96e97bc07e90 ("net: > disable netpoll on fresh napis"). To avoid any latent race conditions > convert dev->napi_list to a proper RCU list. We need minor restructuring > because it looks l

Re: [PATCH v2 net] hdlc_ppp: add range checks in ppp_cp_parse_cr()

2020-09-10 Thread David Miller
From: Dan Carpenter Date: Wed, 9 Sep 2020 12:46:48 +0300 > There are a couple bugs here: > 1) If opt[1] is zero then this results in a forever loop. If the value >is less than 2 then it is invalid. > 2) It assumes that "len" is more than sizeof(valid_accm) or 6 which can >result in memor

Re: [PATCH v2 RESEND] net: phy: call phy_disable_interrupts() in phy_attach_direct() instead

2020-09-10 Thread David Miller
From: Yoshihiro Shimoda Date: Wed, 9 Sep 2020 14:43:14 +0900 > Since the micrel phy driver calls phy_init_hw() as a workaround, > the commit 9886a4dbd2aa ("net: phy: call phy_disable_interrupts() > in phy_init_hw()") disables the interrupt unexpectedly. So, > call phy_disable_interrupts() in phy

Re: [PATCH net 1/2] hv_netvsc: Switch the data path at the right time during hibernation

2020-09-10 Thread David Miller
From: Dexuan Cui Date: Tue, 8 Sep 2020 21:07:32 -0700 > When netvsc_resume() is called, the mlx5 VF NIC has not been resumed yet, > so in the future the host might sliently fail the call netvsc_vf_changed() > -> netvsc_switch_datapath() there, even if the call works now. > > Call netvsc_vf_chan

Re: [PATCH net 2/2] hv_netvsc: Cache the current data path to avoid duplicate call and message

2020-09-10 Thread David Miller
From: Dexuan Cui Date: Tue, 8 Sep 2020 21:08:19 -0700 > The previous change "hv_netvsc: Switch the data path at the right time > during hibernation" adds the call of netvsc_vf_changed() upon > NETDEV_CHANGE, so it's necessary to avoid the duplicate call and message > when the VF is brought UP or

Re: [PATCH net-next v2 0/2] mlx4: avoid devlink port type not set warnings

2020-09-10 Thread David Miller
From: Jakub Kicinski Date: Tue, 8 Sep 2020 15:21:12 -0700 > This small set addresses the issue of mlx4 potentially not setting > devlink port type when Ethernet or IB driver is not built, but > port has that type. > > v2: > - add patch 1 Series applied, thank you.

Re: [PATCH net-next] net: mvneta: rely on MVNETA_MAX_RX_BUF_SIZE for pkt split in mvneta_swbm_rx_frame()

2020-09-10 Thread David Miller
From: Lorenzo Bianconi Date: Tue, 8 Sep 2020 20:23:31 +0200 > In order to easily change the rx buffer size, rely on > MVNETA_MAX_RX_BUF_SIZE instead of PAGE_SIZE in mvneta_swbm_rx_frame > routine for rx buffer split. Currently this is not an issue since we set > MVNETA_MAX_RX_BUF_SIZE to PAGE_SI

[PATCH] connector: Move maintainence under networking drivers umbrella.

2020-09-10 Thread David Miller
Evgeniy does not have the time nor capacity to maintain the connector subsystem any longer, so just move it under networking as that is effectively what has been happening lately. Signed-off-by: David S. Miller --- MAINTAINERS | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff -

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-10 Thread David Miller
From: Yunsheng Lin Date: Tue, 8 Sep 2020 19:02:34 +0800 > Currently there is concurrent reset and enqueue operation for the > same lockless qdisc when there is no lock to synchronize the > q->enqueue() in __dev_xmit_skb() with the qdisc reset operation in > qdisc_deactivate() called by dev_deacti

Re: [PATCH v3] net: dsa: microchip: look for phy-mode in port nodes

2020-09-10 Thread David Miller
From: Helmut Grohne Date: Tue, 8 Sep 2020 10:01:38 +0200 > Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode > property should be specified on port nodes. However, the microchip > drivers read it from the switch node. > > Let the driver use the per-port property and fall b

Re: [MPTCP][PATCH v2 net 0/2] mptcp: fix subflow's local_id/remote_id issues

2020-09-10 Thread David Miller
From: Geliang Tang Date: Tue, 8 Sep 2020 10:49:37 +0800 > v2: > - add Fixes tags; > - simply with 'return addresses_equal'; > - use 'reversed Xmas tree' way. Series applied, thanks.

Re: [MPTCP][PATCH net] mptcp: fix kmalloc flag in mptcp_pm_nl_get_local_id

2020-09-10 Thread David Miller
From: Geliang Tang Date: Wed, 9 Sep 2020 11:01:24 +0800 > mptcp_pm_nl_get_local_id may be called in interrupt context, so we need to > use GFP_ATOMIC flag to allocate memory to avoid sleeping in atomic context. ... > Fixes: 01cacb00b35cb ("mptcp: add netlink-based PM") > Signed-off-by: Geliang

Re: [PATCH net-next v2 0/3] Allow more than 255 IPv4 multicast interfaces

2020-09-10 Thread David Miller
From: Paul Davey Date: Tue, 8 Sep 2020 10:04:05 +1200 > Currently it is not possible to use more than 255 multicast interfaces > for IPv4 due to the format of the igmpmsg header which only has 8 bits > available for the VIF ID. There is space available in the igmpmsg > header to store the full

<    2   3   4   5   6   7   8   9   10   11   >