Re: [PATCH] tipc: fix shutdown() of connection oriented socket

2020-09-10 Thread David Miller
From: Tetsuo Handa Date: Sat, 5 Sep 2020 15:14:47 +0900 > I confirmed that the problem fixed by commit 2a63866c8b51a3f7 ("tipc: fix > shutdown() of connectionless socket") also applies to stream socket. > > -- > #include > #include > #include > > int main(int argc, char *argv[]) > {

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-10 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 1 Sep 2020 17:02:37 +0200 > This reverts commit 124eee3f6955f7aa19b9e6ff5c9b6d37cb3d1e2c. > > Inami-san reported that this commit breaks bridge support in a Xen > environment, and that reverting it fixes this. > > During system resume, bridge ports are no lo

Re: [PATCH net-next 0/6] chelsio/chtls:Fix inline tls bugs

2020-09-09 Thread David Miller
From: Vinay Kumar Yadav Date: Thu, 10 Sep 2020 01:55:34 +0530 > Sending bug fixes in net-next tree because chtls directory restructure > changes is available only in net-next not in net. Since when is file movement a reason to not submit bugs to the correct tree? I'm not doing this sorry, pleas

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-09 Thread David Miller
From: Saeed Mahameed Date: Wed, 9 Sep 2020 19:22:02 + > Maxim really tried here to avoid this without huge performance > degradation (~6.4% reduce in packet rate), due to the refactoring > patches gcc yields non optimal code, as we explained in the commit > messages and cover-letter > > Our

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-09 Thread David Miller
From: Allen Date: Thu, 10 Sep 2020 00:06:47 +0530 >> >> > @@ -1562,10 +1562,11 @@ static void ace_watchdog(struct net_device *data, >> > unsigned int txqueue) >> > } >> > >> > >> > -static void ace_tasklet(unsigned long arg) >> > +static void ace_tasklet(struct tasklet_struct *t) >> > { >> > -

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-09 Thread David Miller
From: Shannon Nelson Date: Wed, 9 Sep 2020 10:58:19 -0700 > I'm suggesting that this implementation using the existing devlink > logging services should suffice until someone can design, implement, > and get accepted a different bit of plumbing.  Unfortunately, that's > not a job that I can get t

Re: [PATCH net-next v2] net: dsa: b53: Report VLAN table occupancy via devlink

2020-09-09 Thread David Miller
From: Florian Fainelli Date: Wed, 9 Sep 2020 10:49:31 -0700 > We already maintain an array of VLANs used by the switch so we can > simply iterate over it to report the occupancy via devlink. > > Signed-off-by: Florian Fainelli Applied.

Re: [PATCH v3 net 0/3] net: qed disable aRFS in NPAR and 100G

2020-09-09 Thread David Miller
From: Igor Russkikh Date: Wed, 9 Sep 2020 20:43:07 +0300 > This patchset fixes some recent issues found by customers. > > v3: > resending on Dmitry's behalf > > v2: > correct hash in Fixes tag Series applied, thank you.

Re: [PATCH net-next v4 0/6] Marvell PP2.2 PTP support

2020-09-09 Thread David Miller
From: Russell King - ARM Linux admin Date: Wed, 9 Sep 2020 17:25:02 +0100 > This series adds PTP support for PP2.2 hardware to the mvpp2 driver. > Tested on the Macchiatobin eth1 port. > > Note that on the Macchiatobin, eth0 uses a separate TAI block from > eth1, and there is no hardware synchro

Re: [PATCH net-next v3 0/6] devlink show controller number

2020-09-09 Thread David Miller
From: Jakub Kicinski Date: Wed, 9 Sep 2020 08:34:42 -0700 > On Wed, 9 Sep 2020 07:50:32 +0300 Parav Pandit wrote: >> From: Parav Pandit >> >> Hi Jakub, Dave, >> >> Currently a devlink instance that supports an eswitch handles eswitch >> ports of two type of controllers. >> (1) controller disc

Re: [PATCH net-next] net: pxa168_eth: remove redundant null check before clk_disable_unprepare()

2020-09-09 Thread David Miller
From: Zhang Changzhong Date: Wed, 9 Sep 2020 22:06:37 +0800 > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Applied.

Re: [PATCH net-next] net: stmmac: dwmac-intel-plat: remove redundant null check before clk_disable_unprepare()

2020-09-09 Thread David Miller
From: Zhang Changzhong Date: Wed, 9 Sep 2020 22:09:00 +0800 > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Applied.

Re: [PATCH v3 0/5] SMSC: Cleanups and clock setup

2020-09-09 Thread David Miller
From: Marco Felsch Date: Wed, 9 Sep 2020 15:44:56 +0200 > this small series cleans the smsc-phy code a bit and adds the support to > specify the phy clock source. Adding the phy clock source support is > also the main purpose of this series. > > Each file has its own changelog. > > Thanks a lo

Re: [PATCH net-next 1/5] net: ipa: use atomic exchange for suspend reference

2020-09-09 Thread David Miller
From: Alex Elder Date: Wed, 9 Sep 2020 08:43:44 -0500 > There is exactly one reference here; the "reference" is > essentially a Boolean flag. So the value is always either > 0 or 1. Aha, then why not use a bitmask and test_and_set_bit() et al.?

Re: [PATCH net-next] net: cavium: Fix a bunch of kerneldoc parameter issues

2020-09-09 Thread David Miller
From: Wang Hai Date: Wed, 9 Sep 2020 21:21:09 +0800 > Rename ptp to ptp_info. > > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/net/ethernet/cavium/common/cavium_ptp.c:94: warning: Excess function > parameter 'ptp' description in 'cavium_ptp_adjfine' > drivers/net/ethernet/cavium/c

Re: pull-request: wireless-drivers-2020-09-09

2020-09-09 Thread David Miller
From: Kalle Valo Date: Wed, 9 Sep 2020 12:11:28 + > here's a pull request to net tree, more info below. Please let me know if > there > are any problems. ... > The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: > > Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) > >

Re: [PATCH net 0/2] wireguard fixes for 5.9-rc5

2020-09-09 Thread David Miller
From: "Jason A. Donenfeld" Date: Wed, 9 Sep 2020 13:58:13 +0200 > Yesterday, Eric reported a race condition found by syzbot. This series > contains two commits, one that fixes the direct issue, and another that > addresses the more general issue, as a defense in depth. > > 1) The basic problem

Re: [PATCH net-next] cxgb4/ch_ipsec: Registering xfrmdev_ops with cxgb4

2020-09-09 Thread David Miller
From: Ayush Sawal Date: Wed, 9 Sep 2020 16:06:20 +0530 > As ch_ipsec was removed without clearing xfrmdev_ops and netdev > feature(esp-hw-offload). When a recalculation of netdev feature is > triggered by changing tls feature(tls-hw-tx-offload) from user > request, it causes a page fault due to

Re: [PATCH v3 0/4] ksz9477 dsa switch driver improvements

2020-09-09 Thread David Miller
From: Paul Barker Date: Wed, 9 Sep 2020 11:04:13 +0100 > These changes were made while debugging the ksz9477 driver for use on a > custom board which uses the ksz9893 switch supported by this driver. The > patches have been runtime tested on top of Linux 5.8.4, I couldn't > runtime test them on

Re: [PATCH 00/13] Netfilter updates for net-next

2020-09-09 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 9 Sep 2020 11:42:06 +0200 > The following patchset contains Netfilter updates for net-next: ... > Please, pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git Pulled, thanks a lot.

Re: [PATCH] hsr: avoid newline at end of message in NL_SET_ERR_MSG_MOD

2020-09-09 Thread David Miller
From: Ye Bin Date: Wed, 9 Sep 2020 17:38:21 +0800 > clean follow coccicheck warning: > net//hsr/hsr_netlink.c:94:8-42: WARNING avoid newline at end of message > in NL_SET_ERR_MSG_MOD > net//hsr/hsr_netlink.c:87:30-57: WARNING avoid newline at end of message > in NL_SET_ERR_MSG_MOD > net//hsr/hsr_

Re: [PATCH v2 07/20] ethernet: dlink: convert tasklets to use new tasklet_setup() API

2020-09-09 Thread David Miller
From: Allen Pais Date: Wed, 9 Sep 2020 14:14:57 +0530 > @@ -1312,10 +1311,11 @@ static irqreturn_t intr_handler(int irq, void > *dev_instance) > return IRQ_RETVAL(handled); > } > > -static void rx_poll(unsigned long data) > +static void rx_poll(struct tasklet_struct *t) > { > - st

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-09 Thread David Miller
From: Allen Pais Date: Wed, 9 Sep 2020 14:14:51 +0530 > @@ -1562,10 +1562,11 @@ static void ace_watchdog(struct net_device *data, > unsigned int txqueue) > } > > > -static void ace_tasklet(unsigned long arg) > +static void ace_tasklet(struct tasklet_struct *t) > { > - struct net_devic

Re: [PATCH net 0/2] net: skb_put_padto() fixes

2020-09-09 Thread David Miller
From: Eric Dumazet Date: Wed, 9 Sep 2020 01:27:38 -0700 > sysbot reported a bug in qrtr leading to use-after-free. > > First patch fixes the issue. > > Second patch addes __must_check attribute to avoid similar > issues in the future. Series applied and queued up for -stable, thanks!

Re: [PATCH V3 net-next 0/4] Enhance current features in ena driver

2020-09-09 Thread David Miller
From: Date: Wed, 9 Sep 2020 06:46:23 + > From: Sameeh Jubran > > This series adds the following: > * Exposes new device stats using ethtool. > * Adds and exposes the stats of xdp TX queues through ethtool. > > V2: Drop the need for casting stat_offset > V1: Use unsigned long for pointer ma

Re: [PATCH net-next] net: dsa: b53: Report VLAN table occupancy via devlink

2020-09-09 Thread David Miller
From: Vladimir Oltean Date: Wed, 9 Sep 2020 19:03:37 +0300 > On Tue, Sep 08, 2020 at 09:32:34PM -0700, Florian Fainelli wrote: >> @@ -977,6 +977,53 @@ int b53_get_sset_count(struct dsa_switch *ds, int port, >> int sset) >> } >> EXPORT_SYMBOL(b53_get_sset_count); >> >> +enum b53_devlink_resou

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-08 Thread David Miller
From: David Miller Date: Tue, 08 Sep 2020 20:28:36 -0700 (PDT) > From: Saeed Mahameed > Date: Tue, 8 Sep 2020 18:27:48 -0700 > >> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c >> @@ -232,6 +232,29

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-08 Thread David Miller
From: Saeed Mahameed Date: Tue, 8 Sep 2020 18:27:48 -0700 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > @@ -232,6 +232,29 @@ mlx5e_txwqe_build_dsegs(struct mlx5e_txqsq *sq, struct > sk_buff *skb, > return -ENOMEM; > } >

Re: [PATCH net-next 1/5] net: ipa: use atomic exchange for suspend reference

2020-09-08 Thread David Miller
From: Alex Elder Date: Tue, 8 Sep 2020 19:21:23 -0500 > We take a single IPA clock reference to keep the clock running > until we get a system suspend operation. When a system suspend > request arrives, we drop that reference, and if that's the last > reference (likely) we'll proceed with suspe

Re: [PATCH trivial] nfc: pn533/usb.c: fix spelling of "functions"

2020-09-08 Thread David Miller
From: Randy Dunlap Date: Tue, 8 Sep 2020 17:13:25 -0700 > From: Randy Dunlap > > Fix typo/spello of "functions". > > Signed-off-by: Randy Dunlap Applied to net-next.

Re: [PATCH trivial] net: ethernet/neterion/vxge: fix spelling of "functionality"

2020-09-08 Thread David Miller
From: Randy Dunlap Date: Tue, 8 Sep 2020 17:14:44 -0700 > From: Randy Dunlap > > Fix typo/spello of "functionality". > > Signed-off-by: Randy Dunlap Applied to net-next.

Re: [PATCH v2] net: phy: call phy_disable_interrupts() in phy_attach_direct() instead

2020-09-08 Thread David Miller
From: Yoshihiro Shimoda Date: Wed, 9 Sep 2020 08:55:38 +0900 > Changes from v1: > - Fix build error. When such a fundamental build failure is fixed (it could never have built for anyone, even you), I want it explained why this happened and how this was functionally tested if it did not even c

Re: [PATCH net-next] ipv6: add tos reflection in TCP reset and ack

2020-09-08 Thread David Miller
From: Wei Wang Date: Tue, 8 Sep 2020 14:29:02 -0700 > Currently, ipv6 stack does not do any TOS reflection. To make the > behavior consistent with v4 stack, this commit adds TOS reflection in > tcp_v6_reqsk_send_ack() and tcp_v6_send_reset(). We clear the lower > 2-bit ECN value of the received

Re: [PATCH net] ip: fix tos reflection in ack and reset packets

2020-09-08 Thread David Miller
From: Wei Wang Date: Tue, 8 Sep 2020 14:09:34 -0700 > Currently, in tcp_v4_reqsk_send_ack() and tcp_v4_send_reset(), we > echo the TOS value of the received packets in the response. > However, we do not want to echo the lower 2 ECN bits in accordance > with RFC 3168 6.1.5 robustness principles.

Re: [PATCH net-next 0/3] rxrpc: Allow more calls to same peer

2020-09-08 Thread David Miller
From: David Howells Date: Tue, 08 Sep 2020 21:50:51 +0100 > Here are some development patches for AF_RXRPC that allow more simultaneous > calls to be made to the same peer with the same security parameters. The > current code allows a maximum of 4 simultaneous calls, which limits the afs > files

Re: [PATCH] net: tc35815: switch from 'pci_' to 'dma_' API

2020-09-08 Thread David Miller
From: Christophe JAILLET Date: Tue, 8 Sep 2020 22:27:47 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] hippi: switch from 'pci_' to 'dma_' API

2020-09-08 Thread David Miller
From: Christophe JAILLET Date: Tue, 8 Sep 2020 22:08:39 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH net-next] sfc: coding style cleanups in mcdi_port_common.c

2020-09-08 Thread David Miller
From: Edward Cree Date: Tue, 8 Sep 2020 20:22:19 +0100 > The code recently moved into this file contained a number of coding style > issues, about which checkpatch and xmastree complained. Fix them. > > Signed-off-by: Edward Cree Applied, thanks Edward.

Re: pull-request: ieee802154 for net 2020-09-08

2020-09-08 Thread David Miller
From: Stefan Schmidt Date: Tue, 8 Sep 2020 19:42:16 +0200 > An update from ieee802154 for your *net* tree. > > A potential memory leak fix for ca8210 from Liu Jian, > a check on the return for a register read in adf7242 > and finally a user after free fix in the softmac tx > function from Eric

Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

2020-09-08 Thread David Miller
From: Jakub Kicinski Date: Tue, 8 Sep 2020 10:36:24 -0700 > We run into a unused variable warning in bridge code when > variable is only used inside the condition of > rcu_dereference_protected(). > > #define mlock_dereference(X, br) \ > rcu_dereference_protected(X, lockdep_is_held(&br->

Re: [PATCH net] MAINTAINERS: remove John Allen from ibmvnic

2020-09-08 Thread David Miller
From: Jakub Kicinski Date: Tue, 8 Sep 2020 09:30:12 -0700 > John's email has bounced and Thomas confirms he no longer > works on ibmvnic. > > Signed-off-by: Jakub Kicinski Applied, thanks.

Re: [PATCH] fib: fix fib_rule_ops indirect call wrappers when CONFIG_IPV6=m

2020-09-08 Thread David Miller
From: Brian Vazquez Date: Tue, 8 Sep 2020 09:18:12 -0700 > If CONFIG_IPV6=m, the IPV6 functions won't be found by the linker: > > ld: net/core/fib_rules.o: in function `fib_rules_lookup': > fib_rules.c:(.text+0x606): undefined reference to `fib6_rule_match' > ld: fib_rules.c:(.text+0x611): unde

Re: [PATCH 0/5] Netfilter fixes for net

2020-09-08 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 8 Sep 2020 17:09:42 +0200 > The following patchset contains Netfilter fixes for net: > > 1) Allow conntrack entries with l3num == NFPROTO_IPV4 or == NFPROTO_IPV6 >only via ctnetlink, from Will McVicker. > > 2) Batch notifications to userspace to improve n

Re: [PATCH net-next] net: wimax: i2400m: fix 'msg_skb' kernel-doc warning in i2400m_msg_to_dev()

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 22:03:33 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/wimax/i2400m/control.c:709: warning: Excess function parameter > 'msg_skb' description in 'i2400m_msg_to_dev' > > This parameter is not in use. Remove it. > > Reported-by: Hu

Re: [PATCH net-next] bnx2x: Fix some kernel-doc warnings

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 22:01:58 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:4238: warning: Excess > function parameter 'netdev' description in 'bnx2x_setup_tc' > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:4238:

Re: [PATCH net-next] netlabel: Fix some kernel-doc warnings

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 22:05:43 +0800 > Fixes the following W=1 kernel build warning(s): > > net/netlabel/netlabel_calipso.c:438: warning: Excess function parameter > 'audit_secid' description in 'calipso_doi_remove' > net/netlabel/netlabel_calipso.c:605: warning: Excess function

Re: [PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 21:59:15 +0800 > Fixes the following W=1 kernel build warning(s): > > net/ipv4/cipso_ipv4.c:510: warning: Excess function parameter 'audit_secid' > description in 'cipso_v4_doi_remove' > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied.

Re: [PATCH] net: phy: call phy_disable_interrupts() in phy_attach_direct() instead

2020-09-08 Thread David Miller
From: Yoshihiro Shimoda Date: Tue, 8 Sep 2020 20:27:20 +0900 > @@ -1423,6 +1419,10 @@ int phy_attach_direct(struct net_device *dev, struct > phy_device *phydev, > if (err) > goto error; > > + ret = phy_disable_interrupts(phydev); > + if (ret) > + return

Re: [PATCH net] ipv6: avoid lockdep issue in fib6_del()

2020-09-08 Thread David Miller
From: Eric Dumazet Date: Tue, 8 Sep 2020 01:20:23 -0700 > syzbot reported twice a lockdep issue in fib6_del() [1] > which I think is caused by net->ipv6.fib6_null_entry > having a NULL fib6_table pointer. > > fib6_del() already checks for fib6_null_entry special > case, we only need to return e

Re: [net-next] net: smsc911x: Remove unused variables

2020-09-08 Thread David Miller
From: Wei Xu Date: Tue, 8 Sep 2020 11:49:25 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/smsc/smsc911x.c: In function ‘smsc911x_rx_fastforward’: > drivers/net/ethernet/smsc/smsc911x.c:1199:16: warning: variable ‘temp’ set > but not used [-Wunused-but-set-v

Re: [PATCH net-next 0/7] net: hns3: misc updates

2020-09-08 Thread David Miller
From: Jakub Kicinski Date: Tue, 8 Sep 2020 12:05:38 -0700 > On Tue, 8 Sep 2020 10:59:47 +0800 Huazhong Tan wrote: >> There are some misc updates for the HNS3 ethernet driver. >> >> #1 narrows two local variable range in hclgevf_reset_prepare_wait(). >> #2 adds reset failure check in periodic ser

Re: [PATCH v2] net: tracepoint: fix print wrong sysctl_mem value

2020-09-08 Thread David Miller
From: Dust Li Date: Tue, 8 Sep 2020 10:09:39 +0800 > @@ -98,7 +98,7 @@ TRACE_EVENT(sock_exceed_buf_limit, > > TP_STRUCT__entry( > __array(char, name, 32) > - __field(long *, sysctl_mem) > + __array(long, sysctl_mem, 3) > __field(long, a

Re: [PATCH v2 net] net: dsa: link interfaces with the DSA master to get rid of lockdep warnings

2020-09-08 Thread David Miller
From: Vladimir Oltean Date: Tue, 8 Sep 2020 02:48:42 +0300 > Since commit 845e0ebb4408 ("net: change addr_list_lock back to static > key"), cascaded DSA setups (DSA switch port as DSA master for another > DSA switch port) are emitting this lockdep warning: ... > Since DSA never made use of the

Re: [PATCH] net: sched: skip an unnecessay check

2020-09-08 Thread David Miller
From: t...@redhat.com Date: Mon, 7 Sep 2020 11:04:38 -0700 > From: Tom Rix > > Reviewing the error handling in tcf_action_init_1() > most of the early handling uses > > err_out: > if (cookie) { > kfree(cookie->data); > kfree(cookie); > } > > before cook

Re: [PATCH net-next v2 2/9] net: ethernet: ti: ale: add static configuration

2020-09-08 Thread David Miller
From: Grygorii Strashko Date: Mon, 7 Sep 2020 17:31:36 +0300 > + ale_dev_id = cpsw_ale_match_id(cpsw_ale_id_match, params->dev_id); > + if (ale_dev_id) { > + params->ale_entries = ale_dev_id->tbl_entries; > + params->major_ver_mask = ale_dev_id->major_ver_mask; ...

[GIT] Networking

2020-09-03 Thread David Miller
1) Use netif_rx_ni() when necessary in batman-adv stack, from Jussi Kivilinna. 2) Fix loss of RTT samples in rxrpc, from David Howells. 3) Memory leak in hns_nic_dev_probe(), from Dignhao Liu. 4) ravb module cannot be unloaded, fix from Yuusuke Ashizuka. 5) We disable BH for too lokng in s

Re: [PATCH RESEND] smsc9420: switch from 'pci_' to 'dma_' API

2020-09-03 Thread David Miller
From: Christophe JAILLET Date: Thu, 3 Sep 2020 22:10:55 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH RESEND] epic100: switch from 'pci_' to 'dma_' API

2020-09-03 Thread David Miller
From: Christophe JAILLET Date: Thu, 3 Sep 2020 22:05:09 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH net 0/4] net/smc: fixes 2020-09-03

2020-09-03 Thread David Miller
From: Karsten Graul Date: Thu, 3 Sep 2020 21:53:14 +0200 > Please apply the following patch series for smc to netdev's net tree. > > Patch 1 fixes the toleration of older SMC implementations. Patch 2 > takes care of a problem that happens when SMCR is used after SMCD > initialization failed. Pa

Re: [PATCH net-next v2] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread David Miller
From: Dan Murphy Date: Thu, 3 Sep 2020 14:51:12 -0500 > Fix spacing issues reported for misaligned switch..case and extra new > lines. > > Also updated the file header to comply with networking commet style. > > Reviewed-by: Florian Fainelli > Signed-off-by: Dan Murphy Applied, thank you.

Re: [PATCH net-next] ip: expose inet sockopts through inet_diag

2020-09-03 Thread David Miller
From: Wei Wang Date: Tue, 1 Sep 2020 15:10:08 -0700 > Expose all exisiting inet sockopt bits through inet_diag for debug purpose. > Corresponding changes in iproute2 ss will be submitted to output all > these values. > > Signed-off-by: Wei Wang > Signed-off-by: Eric Dumazet > Signed-off-by: M

Re: [PATCH net-next 0/2] Allow more than 255 IPv4 multicast interfaces

2020-09-03 Thread David Miller
From: Paul Davey Date: Wed, 2 Sep 2020 15:22:20 +1200 > Currently it is not possible to use more than 255 multicast interfaces > for IPv4 due to the format of the igmpmsg header which only has 8 bits > available for the VIF ID. There is enough space for the full VIF ID in > the Netlink cache no

Re: [PATCH net-next 0/3] net: dsa: bcm_sf2: Clock support

2020-09-03 Thread David Miller
From: Florian Fainelli Date: Tue, 1 Sep 2020 15:59:10 -0700 > This patch series adds support for controlling the SF2 switch core and > divider clock (where applicable). Series applied, thank you.

Re: [PATCH net-next 0/3] net: systemport: Clock support

2020-09-03 Thread David Miller
From: Florian Fainelli Date: Tue, 1 Sep 2020 14:43:45 -0700 > This patch series makes the SYSTEMPORT driver request and manage its > main and Wake-on-LAN clocks appropriately. Series applied, thanks.

Re: [PATCH net-next] ethtool: fix error handling in ethtool_phys_id

2020-09-03 Thread David Miller
From: Edward Cree Date: Tue, 1 Sep 2020 18:52:32 +0100 > If ops->set_phys_id() returned an error, previously we would only break > out of the inner loop, which neither stopped the outer loop nor returned > the error to the user (since 'rc' would be overwritten on the next pass > through the lo

Re: [PATCH] selftests/net: improve descriptions for XFAIL cases in psock_snd.sh

2020-09-03 Thread David Miller
From: Po-Hsu Lin Date: Tue, 1 Sep 2020 23:09:23 +0800 > Before changing this it's a bit confusing to read test output: > raw csum_off with bad offset (fails) > ./psock_snd: write: Invalid argument > > Change "fails" in the test case description to "expected to fail", so > that the test outp

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-03 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 1 Sep 2020 17:02:37 +0200 > This reverts commit 124eee3f6955f7aa19b9e6ff5c9b6d37cb3d1e2c. Heiner, please review this. Thank you. > Inami-san reported that this commit breaks bridge support in a Xen > environment, and that reverting it fixes this. > > Durin

Re: [PATCH] chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4

2020-09-03 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 1 Sep 2020 16:58:41 +0200 > While CHELSIO_INLINE_CRYPTO is a guard symbol, and just enabling it does > not cause any additional code to be compiled in, all configuration > options protected by it depend on CONFIG_CHELSIO_T4. Hence it doesn't > make much sense

Re: [PATCH net-next 0/6] Convert mvpp2 to split PCS support

2020-09-03 Thread David Miller
From: Russell King - ARM Linux admin Date: Tue, 1 Sep 2020 14:47:46 +0100 > This series converts the mvpp2 driver to use the split PCS support > that has been merged into phylink last time around. I've been running > this for some time here and, apart from the recent bug fix sent to > net-next, h

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-03 Thread David Miller
From: Michael Chan Date: Thu, 3 Sep 2020 14:28:54 -0400 > If tg3_reset_task() fails, the device state is left in an inconsistent > state with IFF_RUNNING still set but NAPI state not enabled. A > subsequent operation, such as ifdown or AER error can cause it to > soft lock up when it tries to d

Re: [PATCH net-next 0/6] l2tp: miscellaneous cleanups

2020-09-03 Thread David Miller
From: James Chapman Date: Thu, 3 Sep 2020 14:39:30 +0100 > On 03/09/2020 09:54, Tom Parkin wrote: >> This series of patches makes the following cleanups and improvements to >> the l2tp code: >> >> * various API tweaks to remove unused parameters from function calls >> * lightly refactor the l

Re: [PATCH net-next 0/3] mlxsw: Expose critical and emergency module alarms

2020-09-03 Thread David Miller
From: Ido Schimmel Date: Thu, 3 Sep 2020 16:41:43 +0300 > Amit says: > > Extend hwmon interface with critical and emergency module alarms. ... Looks good, series applied, thanks.

Re: [PATCH] tipc: fix shutdown() of connectionless socket

2020-09-03 Thread David Miller
From: Wouter Verhelst Date: Thu, 3 Sep 2020 14:05:15 +0200 > That's fine, because NBD doesn't deal with SOCK_DGRAM sockets anyway > (i.e., passing a SOCK_DGRAM socket to the NBD device is undefined > behavior). Then why doesn't NBD simply reject such sockets?

Re: [PATCH 0/2] Minor improvements to b53 dmesg output

2020-09-03 Thread David Miller
From: Paul Barker Date: Thu, 3 Sep 2020 12:26:19 +0100 > These changes were made while debugging the b53 driver for use on a > custom board. They've been runtime tested on a patched 4.14.y kernel > which supports this board as well as build tested with 5.9-rc3. The > changes are straightforward

Re: [PATCH] doc: net: dsa: Fix typo in config code sample

2020-09-03 Thread David Miller
From: Paul Barker Date: Thu, 3 Sep 2020 09:49:25 +0100 > In the "single port" example code for configuring a DSA switch without > tagging support from userspace the command to bring up the "lan2" link > was typo'd. > > Signed-off-by: Paul Barker Applied, thank you.

Re: [PATCH net-next v2 00/15] net: bridge: mcast: initial IGMPv3 support (part 1)

2020-09-02 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 2 Sep 2020 23:17:46 +0300 > i. e. this doesn't exclude IPv6 or makes it worse for it, on the > contrary the ops needed to > implement MLDv2 state transitions are in this set, they just need to > be extended for v6. > The new br_ip src group field contains also

Re: [PATCH net-next v2 00/15] net: bridge: mcast: initial IGMPv3 support (part 1)

2020-09-02 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 2 Sep 2020 23:08:40 +0300 > Once all the infra (with fast-path) for IGMPv3 is in, MLDv2 should > be a much easier change, but I must admit given the amount of work > this required I haven't yet looked into MLDv2 in details. The > majority of the changes would

Re: [PATCH net-next] Sysctl parameter to disable TCP RST packet to unknown socket

2020-09-02 Thread David Miller
From: Mihail Milev Date: Wed, 2 Sep 2020 21:56:56 +0200 > What? > > Create a new sysctl parameter called tcp_disable_rst_unkn_socket, > which by default is set to 0 - "disabled". When this parameter is > set to 1 - "enabled", it suppresses sending a TCP RST packet as a > response to received TC

Re: [PATCH net] net: dp83867: Fix WoL SecureOn password

2020-09-02 Thread David Miller
From: Dan Murphy Date: Wed, 2 Sep 2020 14:27:04 -0500 > Fix the registers being written to as the values were being over written > when writing the same registers. > > Fixes: caabee5b53f5 ("net: phy: dp83867: support Wake on LAN") > Signed-off-by: Dan Murphy Applied and queued up for -stable,

Re: [PATCH net-next v2 4/9] gve: Add support for dma_mask register

2020-09-02 Thread David Miller
From: David Awogbemila Date: Wed, 2 Sep 2020 11:42:37 -0700 > I don't think there is a specific 24-bit device in mind here, only > that we have seen 32-bit addressing use cases where the guest ran out > of SWIOTLB space and restricting to GFP_DMA32 helped.. so we thought > it would be natural for

Re: [PATCH net] nfp: flower: fix ABI mismatch between driver and firmware

2020-09-02 Thread David Miller
From: Simon Horman Date: Wed, 2 Sep 2020 17:04:58 +0200 > From: Louis Peens > > Fix an issue where the driver wrongly detected ipv6 neighbour updates > from the NFP as corrupt. Add a reserved field on the kernel side so > it is similar to the ipv4 version of the struct and has space for the >

Re: [PATCH net-next 1/5] sfc: add and use efx_tx_send_pending in tx.c

2020-09-02 Thread David Miller
From: Edward Cree Date: Wed, 2 Sep 2020 15:35:53 +0100 > + tx_queue->xmit_more_available = true; I don't understand why you're setting xmit_more_available unconditionally to true now instead of setting it to 'xmit_more' as seen by this transmit attempt. Why would you want to signal that xmi

Re: [PATCH v2] tipc: fix shutdown() of connectionless socket

2020-09-02 Thread David Miller
From: Tetsuo Handa Date: Wed, 2 Sep 2020 22:44:16 +0900 > syzbot is reporting hung task at nbd_ioctl() [1], for there are two > problems regarding TIPC's connectionless socket's shutdown() operation. ... > One problem is that wait_for_completion() from flush_workqueue() from > nbd_start_device_i

Re: [PATCH v2 net-next 0/6] ionic: struct cleanups

2020-09-02 Thread David Miller
From: Shannon Nelson Date: Tue, 1 Sep 2020 11:20:18 -0700 > This patchset has a few changes for better cacheline use, > to cleanup a page handling API, and to streamline the > Adminq/Notifyq queue handling. Lastly, we also have a couple > of fixes pointed out by the friendly kernel test robot.

Re: [PATCH net] ipv6: Fix sysctl max for fib_multipath_hash_policy

2020-09-02 Thread David Miller
From: Ido Schimmel Date: Wed, 2 Sep 2020 16:16:59 +0300 > From: Ido Schimmel > > Cited commit added the possible value of '2', but it cannot be set. Fix > it by adjusting the maximum value to '2'. This is consistent with the > corresponding IPv4 sysctl. > > Before: > > # sysctl -w net.ipv6.f

Re: [RFC net-next] udp: add a GSO type for UDPv6

2020-09-02 Thread David Miller
From: Huazhong Tan Date: Wed, 2 Sep 2020 20:15:11 +0800 > In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled > separately, for example, checksum offload, so add new GSO type > SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands > for UDPv4. > > Signed-off-by: Huazhong Tan

Re: [PATCH net] drivers/net/wan/hdlc: Change the default of hard_header_len to 0

2020-09-02 Thread David Miller
From: Xie He Date: Wed, 2 Sep 2020 05:07:06 -0700 > Change the default value of hard_header_len in hdlc.c from 16 to 0. > > Currently there are 6 HDLC protocol drivers, among them: > > hdlc_raw_eth, hdlc_cisco, hdlc_ppp, hdlc_x25 set hard_header_len when > attaching the protocol, overriding th

Re: [PATCH net] net: gemini: Fix another missing clk_disable_unprepare() in probe

2020-09-02 Thread David Miller
From: Dan Carpenter Date: Wed, 2 Sep 2020 14:56:31 +0300 > We recently added some calls to clk_disable_unprepare() but we missed > the last error path if register_netdev() fails. > > I made a couple cleanups so we avoid mistakes like this in the future. > First I reversed the "if (!ret)" conditi

Re: [PATCH net-next] selftests: mptcp: fix typo in mptcp_connect usage

2020-09-02 Thread David Miller
From: Davide Caratti Date: Wed, 2 Sep 2020 13:44:24 +0200 > in mptcp_connect, 's' selects IPPROTO_MPTCP / IPPROTO_TCP as the value of > 'protocol' in socket(), and 'm' switches between different send / receive > modes. Fix die_usage(): swap 'm' and 's' and add missing 'sendfile' mode. > > Signe

Re: [PATCH net-next v2 00/15] net: bridge: mcast: initial IGMPv3 support (part 1)

2020-09-02 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 2 Sep 2020 14:25:14 +0300 > Here're the sets that will come next (in order): > - Fast path patch-set which adds support for (S, G) mdb entries needed >for IGMPv3 forwarding, entry add source (kernel, user-space etc) >needed for IGMPv3 entry managemen

Re: [PATCH] net: bcmgenet: fix mask check in bcmgenet_validate_flow()

2020-09-02 Thread David Miller
From: Denis Efremov Date: Wed, 2 Sep 2020 14:18:45 +0300 > VALIDATE_MASK(eth_mask->h_source) is checked twice in a row in > bcmgenet_validate_flow(). Add VALIDATE_MASK(eth_mask->h_dest) > instead. > > Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows") > Cc: sta...@vger.k

Re: [PATCH net 3/3] hinic: fix bug of send pkts while setting channels

2020-09-02 Thread David Miller
From: Luo bin Date: Wed, 2 Sep 2020 17:41:45 +0800 > @@ -531,6 +531,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct > net_device *netdev) > struct hinic_txq *txq; > struct hinic_qp *qp; > > + if (unlikely(!netif_carrier_ok(netdev))) { > + dev_kfree_sk

Re: [PATCH] amd-xgbe: Add support for new port mode

2020-09-02 Thread David Miller
From: Shyam Sundar S K Date: Wed, 2 Sep 2020 09:28:07 + > Add support for a new port mode that is a backplane connection without > support for auto negotiation. > > Signed-off-by: Shyam Sundar S K Applied, thank you.

Re: [net-next v2 1/4] tipc: optimize key switching time and logic

2020-09-02 Thread David Miller
From: Tuong Tong Lien Date: Wed, 2 Sep 2020 06:16:44 + > Yes, the netlink extack message is fine but the fact is that we > currently do not obtain such message from the user space tool > (i.e. iproute2/tipc). So, if really needed, we will have to update > the tool as well... For now, I will r

Re: [net-next PATCH 0/2 v2] RTL8366 stabilization

2020-09-01 Thread David Miller
From: Florian Fainelli Date: Tue, 1 Sep 2020 15:42:40 -0700 > > > On 9/1/2020 3:39 PM, David Miller wrote: >> From: Linus Walleij >> Date: Tue, 1 Sep 2020 21:08:52 +0200 >> >>> This stabilizes the RTL8366 driver by checking validity >>> of the p

Re: [PATCH] net: usb: dm9601: Add USB ID of Keenetic Plus DSL

2020-09-01 Thread David Miller
From: Kamil Lorenc Date: > I received an error from Peter Korsgaard's mailserver informing that his > email address does not exist. Should I do something with that fact? Probably need a MAINTAINERS update. Is there any other email address by which Peter can be reached?

Re: [net-next PATCH 0/2 v2] RTL8366 stabilization

2020-09-01 Thread David Miller
From: Linus Walleij Date: Tue, 1 Sep 2020 21:08:52 +0200 > This stabilizes the RTL8366 driver by checking validity > of the passed VLANs and refactoring the member config > (MC) code so we do not require strict call order and > de-duplicate some code. > > Changes from v1: incorporate review com

Re: [PATCH net-next] octeontx2-pf: Add UDP segmentation offload support

2020-09-01 Thread David Miller
From: Date: Tue, 1 Sep 2020 15:01:42 +0530 > From: Sunil Goutham > > Defines UDP segmentation algorithm in hardware and supports > offloading UDP segmentation. > > Signed-off-by: Sunil Goutham Applied, thank you.

Re: [PATCH] net: usb: dm9601: Add USB ID of Keenetic Plus DSL

2020-09-01 Thread David Miller
From: Kamil Lorenc Date: Tue, 1 Sep 2020 10:57:38 +0200 > Keenetic Plus DSL is a xDSL modem that uses dm9620 as its USB interface. > > Signed-off-by: Kamil Lorenc Applied, thanks.

Re: [PATCH net-next] vhost: fix typo in error message

2020-09-01 Thread David Miller
From: Yunsheng Lin Date: Tue, 1 Sep 2020 10:39:09 +0800 > "enable" should be "disable" when the function name is > vhost_disable_notify(), which does the disabling work. > > Signed-off-by: Yunsheng Lin Applied to 'net'.

<    3   4   5   6   7   8   9   10   11   12   >