Re: [PATCH] SUNRPC: Add a check for gss_release_msg

2021-04-20 Thread J. Bruce Fields
On Tue, Apr 20, 2021 at 09:15:23AM +0200, Greg KH wrote: > If you look at the code, this is impossible to have happen. > > Please stop submitting known-invalid patches. Your professor is playing > around with the review process in order to achieve a paper in some > strange and bizarre way. > > T

Re: [PATCH] SUNRPC: Add a check for gss_release_msg

2021-04-07 Thread J. Bruce Fields
On Tue, Apr 06, 2021 at 07:16:56PM -0500, Aditya Pakki wrote: > In gss_pipe_destroy_msg(), in case of error in msg, gss_release_msg > deletes gss_msg. The patch adds a check to avoid a potential double > free. We're already dereferenced msg. Nothing has set gss_msg to NULL. It's the gss_msg->cou

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

2021-03-19 Thread J. Bruce Fields
that takes a number and > > outputs it in various formats is also a possible solution. For now, it > > seems reasonable to put this here since this particular code path is the > > one that has repeatedly come up in production. > > > > Signed-off-by: Chris Down > &g

Re: [RFC][PATCH 00/18] crypto: Add generic Kerberos library

2020-11-12 Thread J. Bruce Fields
On Thu, Nov 12, 2020 at 12:57:45PM +, David Howells wrote: > > Hi Herbert, Bruce, > > Here's my first cut at a generic Kerberos crypto library in the kernel so > that I can share code between rxrpc and sunrpc (and cifs?). > > I derived some of the parts from the sunrpc gss library and added

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

2020-11-09 Thread J. Bruce Fields
On Mon, Nov 09, 2020 at 12:36:15PM -0500, Chuck Lever wrote: > > On Nov 9, 2020, at 12:32 PM, Trond Myklebust > > wrote: > > On Mon, 2020-11-09 at 12:12 -0500, Chuck Lever wrote: > >> I assume you mean the client side only. Those issues aren't a factor > >> on the server. Not setting SOCK_ZEROCOP

Re: [PATCH] net/sunrpc: Fix return value from proc_do_xprt()

2020-11-07 Thread J. Bruce Fields
On Sat, Nov 07, 2020 at 01:49:40PM +, Alex Dewar wrote: > On Fri, Nov 06, 2020 at 05:07:21PM -0500, J. Bruce Fields wrote: > > Whoops, got 3 independent patches for this and overlooked this one. See > > https://lore.kernel.org/linux-nfs/20201106205959.gb26...@fieldses.org/T/

Re: [PATCH] net/sunrpc: Fix return value from proc_do_xprt()

2020-11-06 Thread J. Bruce Fields
Whoops, got 3 independent patches for this and overlooked this one. See https://lore.kernel.org/linux-nfs/20201106205959.gb26...@fieldses.org/T/#t --b. On Sat, Oct 24, 2020 at 03:52:40PM +0100, Alex Dewar wrote: > Commit c09f56b8f68d ("net/sunrpc: Fix return value for sysctl > sunrpc.transports"

Re: [PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-19 Thread J. Bruce Fields
On Mon, Oct 19, 2020 at 03:46:39PM +, Martijn de Gouw wrote: > Hi > > On 19-10-2020 17:23, J. Bruce Fields wrote: > > On Mon, Oct 19, 2020 at 01:42:27PM +0200, Martijn de Gouw wrote: > >> When the passed token is longer than 4032 bytes, the remaining part > >>

Re: gssapi, crypto and afs/rxrpc

2020-10-19 Thread J. Bruce Fields
On Fri, Oct 16, 2020 at 05:18:26PM +0100, David Howells wrote: > Hi Herbert, Dave, Trond, > > I've written basic gssapi-derived security support for AF_RXRPC: > > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rxgk > > I've borrowed some bits from net

Re: [PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-19 Thread J. Bruce Fields
On Mon, Oct 19, 2020 at 01:42:27PM +0200, Martijn de Gouw wrote: > When the passed token is longer than 4032 bytes, the remaining part > of the token must be copied from the rqstp->rq_arg.pages. But the > copy must make sure it happens in a consecutive way. Thanks. Apologies, but I don't immediat

Re: general protection fault in cache_clean

2020-09-16 Thread J. Bruce Fields
On Tue, Sep 15, 2020 at 01:04:20AM -0700, syzbot wrote: > syzbot found the following issue on: > > HEAD commit:581cb3a2 Merge tag 'f2fs-for-5.9-rc5' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11f5c01190 > kernel config: ht

Re: [PATCH] gss_krb5: Fix memleak in krb5_make_rc4_seq_num

2020-08-29 Thread J. Bruce Fields
This code is rarely if ever used, and there are pending patches to remove it completely, so I don't think it's worth trying to fix a rare memory leak at this point. --b. On Thu, Aug 27, 2020 at 04:02:50PM +0800, Dinghao Liu wrote: > When kmalloc() fails, cipher should be freed > just like when kr

Re: [PATCH] net: sunrpc: delete repeated words

2020-08-25 Thread J. Bruce Fields
Applied, thanks.--b. On Sat, Aug 22, 2020 at 06:07:38PM -0700, Randy Dunlap wrote: > Drop duplicate words in net/sunrpc/. > Also fix "Anyone" to be "Any one". > > Signed-off-by: Randy Dunlap > Cc: "J. Bruce Fields" > Cc: Chuck Lever >

Re: [RFC PATCH 3/7] SUNRPC: remove RC4-HMAC-MD5 support from KerberosV

2020-07-02 Thread J. Bruce Fields
Acked-by: J. Bruce Fields On Thu, Jul 02, 2020 at 12:19:43PM +0200, Ard Biesheuvel wrote: > The RC4-HMAC-MD5 KerberosV algorithm is based on RFC 4757 [0], which > was specifically issued for interoperability with Windows 2000, but was > never intended to receive the same level of sup

Re: [PATCH -next] sunrpc: use kmemdup_nul() in gssp_stringify()

2020-06-08 Thread J. Bruce Fields
Thanks, applied.--b. On Fri, May 08, 2020 at 08:40:00PM +0800, Chen Zhou wrote: > It is more efficient to use kmemdup_nul() if the size is known exactly > . > > According to doc: > "Note: Use kmemdup_nul() instead if the size is known exactly." > > Signed-off-by: Chen Zhou > --- > net/sunrpc/a

Re: [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' by sysfs

2020-05-11 Thread J. Bruce Fields
On Fri, May 08, 2020 at 09:32:59AM +0800, Xiongfeng Wang wrote: > When I cat parameter '/sys/module/sunrpc/parameters/pool_mode', it > displays as follows. It is better to add a newline for easy reading. Applying for 5.8. I assume Trond's getting the other patch. --b. > > [root@hulk-202 ~]# ca

Re: [PATCH net-next] sunrpc: Remove unused function ip_map_update

2020-05-06 Thread J. Bruce Fields
Thanks, applying for 5.8.--b. On Tue, May 05, 2020 at 04:45:37PM +0800, YueHaibing wrote: > commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related > code.") > left behind this, remove it. > > Signed-off-by: YueHaibing > --- > net/sunrpc/svcauth_unix.c | 9 - > 1 f

Re: [PATCH v2 0/3] auth_gss: netns refcount leaks when use-gss-proxy==1

2019-05-14 Thread J. Bruce Fields
Whoops, I was slow to test these. I'm getting failuring krb5 nfs mounts, and the following the server's logs. Dropping the three patches for now. --b. [ 40.894408] remove_proc_entry: removing non-empty directory 'net/rpc', leaking at least 'use-gss-proxy' [ 40.897352] WARNING: CPU: 2 PID:

Re: general protection fault in encode_rpcb_string

2018-04-17 Thread J. Bruce Fields
On Mon, Apr 16, 2018 at 09:02:01PM -0700, syzbot wrote: > syzbot hit the following crash on bpf-next commit > 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 +) > Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net > syzbot dashboard link: > https://syzkaller.appspo

Re: [PATCH] sunrpc: remove incorrect HMAC request initialization

2018-03-28 Thread J . Bruce Fields
Applying, thanks!--b. On Wed, Mar 28, 2018 at 10:57:22AM -0700, Eric Biggers wrote: > make_checksum_hmac_md5() is allocating an HMAC transform and doing > crypto API calls in the following order: > > crypto_ahash_init() > crypto_ahash_setkey() > crypto_ahash_digest() > > This is wron

Re: NFS mounts failing when keytab present on client

2018-03-28 Thread J. Bruce Fields
On Wed, Mar 28, 2018 at 02:03:34PM -0400, J. Bruce Fields wrote: > Thanks, got it. Do you know how to find a commit id for that change? > It's not entirely fair to blame the crypto change for what was really a > latent nfs bug, but it might still be worth adding a Fixes: line ju

Re: NFS mounts failing when keytab present on client

2018-03-28 Thread J. Bruce Fields
On Wed, Mar 28, 2018 at 10:50:51AM -0700, Eric Biggers wrote: > On Wed, Mar 28, 2018 at 11:46:28AM -0400, J. Bruce Fields wrote: > > On Tue, Mar 27, 2018 at 03:29:50PM -0700, Eric Biggers wrote: > > > Hi Michael, > > > > > > On Tue, Mar 27, 2018 at 1

Re: NFS mounts failing when keytab present on client

2018-03-28 Thread J. Bruce Fields
On Tue, Mar 27, 2018 at 03:29:50PM -0700, Eric Biggers wrote: > Hi Michael, > > On Tue, Mar 27, 2018 at 11:06:14PM +0100, Michael Young wrote: > > NFS mounts stopped working on one of my computers after a kernel update from > > 4.15.3 to 4.15.4. I traced the problem to the commit > > [46e8d06e423c

Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

2018-03-26 Thread J. Bruce Fields
; > > Signed-off-by: Kirill Tkhai > > It might make sense to take these and the other NFS patches through > the net tree, since the pernet_operations don't yet have the async > field in my tree (and I therefore can't compile once these are > applied). Ditto for the nfsd patch, so, for what it's worth: Acked-by: J. Bruce Fields for that patch.--b. --b.

Re: [PATCH net-next nfs 0/6] Converting pernet_operations (part #7)

2018-03-15 Thread J. Bruce Fields
On Thu, Mar 15, 2018 at 04:32:30PM +0300, Kirill Tkhai wrote: > Trond, Anna, Bruce, Jeff, David and other NFS and RXRPC people, > could you please provide your vision on this patches? Whoops, sorry, I haven't been paying attention. Do you have a pointer to documentation? I'm unclear what the act

Re: [PATCH 0/4] make function arg and structures as const

2017-11-10 Thread J. Bruce Fields
On Fri, Nov 10, 2017 at 10:09:46AM -0500, Anna Schumaker wrote: > > > On 11/09/2017 09:21 PM, J. Bruce Fields wrote: > > On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: > >> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: > >>> Make t

Re: [PATCH 0/4] make function arg and structures as const

2017-11-09 Thread J. Bruce Fields
On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: > On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: > > Make the function argument as const. After thing change, make > > the cache_detail structures as const. > > > > Bhumika Goyal (4): > > sunrpc: make the function arg as const

Re: [PATCH v3 01/21] grace: replace BUG_ON by WARN_ONCE in exit_net hook

2017-11-09 Thread J. Bruce Fields
Applied for 4.15, thanks.--b. On Mon, Nov 06, 2017 at 04:22:48PM +0300, Vasily Averin wrote: > Signed-off-by: Vasily Averin > --- > fs/nfs_common/grace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c > index 420d3a0..1b

Re: [PATCH v3 02/21] lockd: added cleanup checks in exit_net hook

2017-11-09 Thread J. Bruce Fields
Applied.--b. On Mon, Nov 06, 2017 at 04:23:24PM +0300, Vasily Averin wrote: > Signed-off-by: Vasily Averin > --- > fs/lockd/svc.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c > index 809cbcc..2a48558 100644 > --- a/fs/lockd/svc.c > +++ b/

Re: [PATCH v3 01/21] grace: replace BUG_ON by WARN_ONCE in exit_net hook

2017-11-06 Thread J. Bruce Fields
I'm assuming you want me to apply this (and the following lockd patch), but I'm not clear why this is part of a bigger series going to netdev. --b. On Mon, Nov 06, 2017 at 04:22:48PM +0300, Vasily Averin wrote: > Signed-off-by: Vasily Averin > --- > fs/nfs_common/grace.c | 4 +++- > 1 file chan

Re: [PATCH] net: sunrpc: svcauth_gss: use BUG_ON instead of if condition followed by BUG

2017-10-24 Thread J. Bruce Fields
On Tue, Oct 24, 2017 at 02:18:52PM -0400, Jeff Layton wrote: > On Tue, 2017-10-24 at 13:53 -0400, J. Bruce Fields wrote: > > On Tue, Oct 24, 2017 at 01:26:49PM -0400, Weston Andros Adamson wrote: > > > Is there a reason to BUG() in these places? Couldn't we WARN_ON_ONCE and

Re: [PATCH] net: sunrpc: svcauth_gss: use BUG_ON instead of if condition followed by BUG

2017-10-24 Thread J. Bruce Fields
ly. (Except for that read_u32... return, I wonder if we're missing a check there.) --b. > > -dros > > > On Oct 23, 2017, at 4:31 PM, J. Bruce Fields wrote: > > > > In the past we've avoided BUG_ON(X) where X might have side effects, on > > the theo

Re: [PATCH] net: sunrpc: svcauth_gss: use BUG_ON instead of if condition followed by BUG

2017-10-23 Thread J. Bruce Fields
In the past we've avoided BUG_ON(X) where X might have side effects, on the theory that it should actually be OK just to compile out BUG_ON()s. Has that changed? In any case, I don't find that this improves readability; dropping. --b. On Mon, Oct 23, 2017 at 01:16:35PM -0500, Gustavo A. R. Silva

Re: [PATCH] sunrcp: make function _svc_create_xprt static

2017-10-16 Thread J . Bruce Fields
Thanks, applied for 4.15.--b. On Mon, Oct 16, 2017 at 02:40:21PM +0100, Colin King wrote: > From: Colin Ian King > > The function _svc_create_xprt is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol '_svc_create_xprt' was n

Re: [PATCH 00/18] use ARRAY_SIZE macro

2017-10-05 Thread J. Bruce Fields
On Mon, Oct 02, 2017 at 09:33:12PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 15:22:24 -0400 > bfie...@fieldses.org (J. Bruce Fields) wrote: > > > Mainly I'd just like to know which you're asking for. Do you want me to > > apply this, or to ACK it so someo

Re: [PATCH 00/18] use ARRAY_SIZE macro

2017-10-02 Thread J. Bruce Fields
On Mon, Oct 02, 2017 at 07:35:54AM +0200, Greg KH wrote: > On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote: > > On Mon, 2 Oct 2017 09:01:31 +1100 > > "Tobin C. Harding" wrote: > > > > > > In order to reduce the size of the To: and Cc: lines, each patch of the > > > > series is sent

Re: [PATCH] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-25 Thread J. Bruce Fields
On Fri, Aug 18, 2017 at 06:00:47AM -0400, Vadim Lomovtsev wrote: > While running nfs/connectathon tests kernel NULL-pointer exception > has been observed due to races in svcsock.c. > > Race is appear when kernel accepts connection by kernel_accept > (which creates new socket) and start queuing ing

Re: [PATCH v4] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-24 Thread J. Bruce Fields
On Wed, Aug 23, 2017 at 06:33:42AM -0400, Jeff Layton wrote: > I think this one looks fine. Bruce, do you mind picking this one up? It > might also be reasonable for stable... Yep, thanks to you both, I'll plan to send a pull request tonight or tomorrow. --b.

Re: [PATCH][net-next] svcrdma: fix an incorrect check on -E2BIG and -EINVAL

2017-07-13 Thread J. Bruce Fields
On Thu, Jul 13, 2017 at 01:53:10PM -0400, Chuck Lever wrote: > > > On Jul 13, 2017, at 1:51 PM, Colin King wrote: > > > > From: Colin Ian King > > > > The current check will always be true and will always jump to > > err1, this looks dubious to me. I believe && should be used > > instead of ||

Re: [PATCH] virtio_net: lower limit on buffer size

2017-06-05 Thread J. Bruce Fields
On Sat, Jun 03, 2017 at 11:17:30PM +0300, Sergei Shtylyov wrote: > On 06/02/2017 11:25 PM, J. Bruce Fields wrote: > > >>>commit d85b758f72b0 "virtio_net: fix support for small rings" > >> > >> Commit d85b758f72b0 ("virtio_net: fix support for s

Re: [PATCH] virtio_net: lower limit on buffer size

2017-06-02 Thread J. Bruce Fields
before helps. > > > >Fixes: d85b758f72b0 "virtio_net: fix support for small rings" > > Fixes: d85b758f72b0 ("virtio_net: fix support for small rings") I may be bikeshedding, but, personally I never do the parens--they're redundant given the quotes, and

Re: [PATCH] virtio_net: lower limit on buffer size

2017-06-01 Thread J. Bruce Fields
s to break some setups - > it's not yet clear why, but increasing buffer size > back to what it was before helps. > > Fixes: d85b758f72b0 "virtio_net: fix support for small rings" > Reported-by: Mikulas Patocka > Reported-by: "J. Bruce Fields" > Signed

Re: [RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

2016-03-19 Thread J. Bruce Fields
On Fri, Mar 18, 2016 at 04:46:23PM -0400, Tejun Heo wrote: > Hello, Jeff. > > On Thu, Mar 17, 2016 at 09:32:16PM -0400, Jeff Layton wrote: > > > * Are network devices expected to be able to serve as a part of > > > storage stack which is depended upon for memory reclamation? > > > > I think the

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-23 Thread J. Bruce Fields
On Fri, Oct 23, 2015 at 04:14:10AM +, Kosuke Tatsukawa wrote: > J. Bruce Fields wrote: > > On Fri, Oct 16, 2015 at 02:28:10AM +, Kosuke Tatsukawa wrote: > >> Tatsukawa Kosuke wrote: > >> > J. Bruce Fields wrote: > >> >> On Thu, Oct 15, 201

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-22 Thread J. Bruce Fields
On Fri, Oct 16, 2015 at 02:28:10AM +, Kosuke Tatsukawa wrote: > Tatsukawa Kosuke wrote: > > J. Bruce Fields wrote: > >> On Thu, Oct 15, 2015 at 11:44:20AM +, Kosuke Tatsukawa wrote: > >>> Tatsukawa Kosuke wrote: > >>> > J. Bruce Fields wrote: &

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-15 Thread J. Bruce Fields
On Thu, Oct 15, 2015 at 11:44:20AM +, Kosuke Tatsukawa wrote: > Tatsukawa Kosuke wrote: > > J. Bruce Fields wrote: > >> Thanks for the detailed investigation. > >> > >> I think it would be worth adding a comment if that might help someone > >>

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-14 Thread J. Bruce Fields
On Wed, Oct 14, 2015 at 03:57:13AM +, Kosuke Tatsukawa wrote: > J. Bruce Fields wrote: > > On Mon, Oct 12, 2015 at 10:41:06AM +, Kosuke Tatsukawa wrote: > >> J. Bruce Fields wrote: > >> > On Fri, Oct 09, 2015 at 06:29:44AM +, Kosuke Tatsukawa w

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-12 Thread J. Bruce Fields
On Mon, Oct 12, 2015 at 10:41:06AM +, Kosuke Tatsukawa wrote: > J. Bruce Fields wrote: > > On Fri, Oct 09, 2015 at 06:29:44AM +, Kosuke Tatsukawa wrote: > >> Neil Brown wrote: > >> > Kosuke Tatsukawa writes: > >> > > >> >> The

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-09 Thread J. Bruce Fields
On Fri, Oct 09, 2015 at 06:29:44AM +, Kosuke Tatsukawa wrote: > Neil Brown wrote: > > Kosuke Tatsukawa writes: > > > >> There are several places in net/sunrpc/svcsock.c which calls > >> waitqueue_active() without calling a memory barrier. Add a memory > >> barrier just as in wq_has_sleeper()

Re: [PATCH] sunrpc: avoid warning in gss_key_timeout

2015-10-09 Thread J. Bruce Fields
On Fri, Oct 09, 2015 at 04:13:45PM +0200, Arnd Bergmann wrote: > The gss_key_timeout() function causes a harmless warning in some > configurations, e.g. ARM imx_v6_v7_defconfig with gcc-5.2, if the > compiler cannot figure out the state of the 'expire' variable across > an rcu_read_unlock(): > > n

Re: [PATCH 01/19] SUNRPC: fix variable type

2015-09-25 Thread J. Bruce Fields
ACK. Assuming Trond gets this.--b. On Thu, Sep 24, 2015 at 04:00:09PM +0200, Andrzej Hajda wrote: > Due to incorrect len type bc_send_request returned always zero. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > >

Re: [PATCH 14/39] SUNRPC: drop null test before destroy functions

2015-09-14 Thread J. Bruce Fields
ACK, but assuming Trond takes this one.--b. On Sun, Sep 13, 2015 at 02:15:07PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) > \(kmem_cache_dest

Re: [PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()

2015-06-19 Thread J. Bruce Fields
Thanks, applying.--b. On Tue, Jun 16, 2015 at 09:57:52PM +0200, Fabian Frederick wrote: > Don't opencode sg_init_one() > > Signed-off-by: Fabian Frederick > --- > net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/net/sunrpc/a

Re: [RFC 00/10] NFS: add AF_VSOCK support to NFS client

2015-06-10 Thread J. Bruce Fields
On Wed, Jun 10, 2015 at 05:43:15PM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 08, 2015 at 05:02:47PM -0400, J. Bruce Fields wrote: > > On Thu, Jun 04, 2015 at 05:45:43PM +0100, Stefan Hajnoczi wrote: > > > The approach in this series > > > --- &g

Re: [RFC 00/10] NFS: add AF_VSOCK support to NFS client

2015-06-08 Thread J. Bruce Fields
On Thu, Jun 04, 2015 at 05:45:43PM +0100, Stefan Hajnoczi wrote: > This patch series enables AF_VSOCK address family support in the NFS client. > Please use the https://github.com/stefanha/linux.git vsock-nfs branch, which > contains the dependencies for this series. > > The AF_VSOCK address famil

Re: [git patches] net driver fixes

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 01:42:57PM -0800, David Miller wrote: > From: "J. Bruce Fields" <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 16:23:02 -0500 > > > On Wed, Feb 20, 2008 at 01:15:30PM -0800, David Miller wrote: > > > From: Jeff Garzik <[EMAIL PROTEC

Re: [git patches] net driver fixes

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 01:15:30PM -0800, David Miller wrote: > From: Jeff Garzik <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 11:55:57 -0500 > > > > > Note: this is based off of Linus's latest commit > > (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous > > submissions are now u

Re: [PATCH] IPv6 support for NFS server

2008-01-18 Thread J. Bruce Fields
On Fri, Jan 18, 2008 at 03:50:56PM +0100, Aurélien Charbon wrote: > OK Bruce I have added this comment before the patch. > I have also done the changes pointed by Brian. > Please let me know if there is still something to change. Thanks. For the future, if you could just make the comment part of

Re: [PATCH] IPv6 support for NFS server

2008-01-17 Thread J. Bruce Fields
On Thu, Jan 17, 2008 at 06:04:35PM +0100, Aurélien Charbon wrote: > Hi Bruce. > > Thanks for your comments. > Here is the patch with some cleanups. Thanks for the revisions. We need to submit this with a patch comment that: - Explains more precisely what this does (fixes export

Re: [PATCH] IPv6 support for NFS server

2008-01-15 Thread J. Bruce Fields
Mostly just more trivial stuff for now, apologies: On Tue, Jan 15, 2008 at 05:32:21PM -0500, J. Bruce Fields wrote: > diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c > index cbbc594..e29b431 100644 > --- a/fs/nfsd/export.c > +++ b/fs/nfsd/export.c > @@ -35,6 +35,7 @@ > #in

Re: [PATCH] IPv6 support for NFS server

2008-01-15 Thread J. Bruce Fields
On Tue, Dec 11, 2007 at 07:00:08PM +0100, Aurélien Charbon wrote: > Brian Haley wrote: > >> In an email back on October 29th I sent-out a similar patch with a new >> ipv6_addr_set_v4mapped() inline - it might be useful to pull that >> piece into your patch since it cleans it up a bit to get rid

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-07 Thread J. Bruce Fields
On Sat, Jan 05, 2008 at 09:39:35PM +, Al Viro wrote: > On Sat, Jan 05, 2008 at 01:06:17PM -0800, Arjan van de Ven wrote: > > The http://www.kerneloops.org website collects kernel oops and > > warning reports from various mailing lists and bugzillas as well as > > with a client users can install

Re: 2.6.24-rc6-mm1

2008-01-03 Thread J. Bruce Fields
On Thu, Jan 03, 2008 at 04:37:46PM +0100, Torsten Kaiser wrote: > On Jan 2, 2008 10:57 PM, J. Bruce Fields <[EMAIL PROTECTED]> wrote: > > On Thu, Jan 03, 2008 at 08:51:54AM +1100, Herbert Xu wrote: > > > The two specific trees of interest would be git-nfsd and git-net. &

Re: 2.6.24-rc6-mm1

2008-01-02 Thread J. Bruce Fields
On Thu, Jan 03, 2008 at 08:51:54AM +1100, Herbert Xu wrote: > On Wed, Jan 02, 2008 at 07:29:59PM +0100, Torsten Kaiser wrote: > > > > Vanilla 2.6.24-rc6 seems stable. I did not see any crash or warnings. > > OK that's great. The next step would be to try excluding specific git > trees from mm to

Re: 2.6.24-rc6-mm1

2007-12-30 Thread J. Bruce Fields
On Fri, Dec 28, 2007 at 03:07:46PM -0800, Andrew Morton wrote: > On Fri, 28 Dec 2007 23:53:49 +0100 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > > > On Dec 23, 2007 5:27 PM, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > > > On Dec 23, 2007 8:30 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > >

Re: [PATCH] IPv6 support for NFS server

2007-12-10 Thread J. Bruce Fields
On Mon, Dec 10, 2007 at 07:34:41PM +0100, Aurélien Charbon wrote: > > Here is a cleanup for the ip_map caching patch in nfs server. > > It prepares for IPv6 text-based mounts and exports. > > Tests: tested with only IPv4 network and basic nfs ops (mount, file > creation and modification) Thanks!

Re: [BUG] New Kernel Bugs

2007-11-15 Thread J. Bruce Fields
On Thu, Nov 15, 2007 at 01:50:43PM +1100, Neil Brown wrote: > Virtual Folders. > > I use VM mode in EMACS, but I believe some other mail readers have the > same functionality. > I have a virtual folder called "nfs" which shows me all mail in my > inbox which has the string 'nfs' or 'lockd' in a To

Re: [BUG] New Kernel Bugs

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 09:38:20AM -0800, Randy Dunlap wrote: > On Wed, 14 Nov 2007 15:08:47 +0100 Ingo Molnar wrote: > > so please stop this "too busy and too noisy" nonsense already. It was > > nonsense 10 years ago and it's nonsense today. In 10 years the kernel > > grew from a 1 million lines

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

2007-10-31 Thread J. Bruce Fields
On Wed, Oct 31, 2007 at 10:06:18AM +0100, Aurélien Charbon wrote: > Thank you Brian > Sorry, I did not see what you sent. > > I have tested it with an IPv4 configuration. It's OK. > So Neil, Bruce, you can take this one for review. Did you miss Neil's question about the nfsctl stuff? (Do we reall

Re: [PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

2007-10-30 Thread J. Bruce Fields
Thanks for working on this. Could you run linux/scripts/checkpatch.pl on your patch and fix the problems it complains about? On Tue, Oct 30, 2007 at 06:05:42PM +0100, Aurélien Charbon wrote: > static void update(struct cache_head *cnew, struct cache_head *citem) > { > @@ -149,22 +157,24 @@ static

Re: Distributed storage. Move away from char device ioctls.

2007-09-14 Thread J. Bruce Fields
On Sat, Sep 15, 2007 at 12:08:42AM -0400, Jeff Garzik wrote: > J. Bruce Fields wrote: >> No, servers are required to support ordinary nfs operations to the >> metadata server. >> At least, that's the way it was last I heard, which was a while ago. I >> agree th

Re: Distributed storage. Move away from char device ioctls.

2007-09-14 Thread J. Bruce Fields
On Fri, Sep 14, 2007 at 06:32:11PM -0400, Jeff Garzik wrote: > J. Bruce Fields wrote: >> On Fri, Sep 14, 2007 at 05:14:53PM -0400, Jeff Garzik wrote: >>> J. Bruce Fields wrote: >>>> On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik wrote: >>>>> I&#x

Re: Distributed storage. Move away from char device ioctls.

2007-09-14 Thread J. Bruce Fields
On Fri, Sep 14, 2007 at 05:14:53PM -0400, Jeff Garzik wrote: > J. Bruce Fields wrote: >> On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik wrote: >>> I've been waiting for years for a smart person to come along and write a >>> POSIX-only distributed filesyste

Re: Distributed storage. Move away from char device ioctls.

2007-09-14 Thread J. Bruce Fields
On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik wrote: > My thoughts. But first a disclaimer: Perhaps you will recall me as one > of the people who really reads all your patches, and examines your code and > proposals closely. So, with that in mind... > > I question the value of distrib

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-14 Thread J. Bruce Fields
On Fri, Sep 14, 2007 at 11:12:30AM +0200, Wolfgang Walter wrote: > Am Mittwoch, 12. September 2007 21:55 schrieb J. Bruce Fields: > > On Wed, Sep 12, 2007 at 09:40:57PM +0200, Wolfgang Walter wrote: > > > On Wednesday 12 September 2007, J. Bruce Fields wrote: > > > >

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2007 at 09:40:57PM +0200, Wolfgang Walter wrote: > On Wednesday 12 September 2007, J. Bruce Fields wrote: > > On Wed, Sep 12, 2007 at 04:14:06PM +0200, Neil Brown wrote: > > > So it is in 2.6.21 and later and should probably go to .stable for .21 > > >

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2007 at 04:14:06PM +0200, Neil Brown wrote: > So it is in 2.6.21 and later and should probably go to .stable for .21 > and .22. > > Bruce: for you :-) OK, thanks! But, (as is alas often the case) I'm still confused: > if (!test_and_set_bit(SK_OLD, &svsk->sk_flags)

Re: [NFS] [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2007 at 09:37:29AM -0400, bfields wrote: > So the fact that this changes the behavior means that sk_inuse is taking > on negative values. Uh, no, I misread the tests, sorry. I'm not awake.--b. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

Re: [NFS] [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2007 at 02:07:10PM +0200, Wolfgang Walter wrote: > as already described old temporary sockets (client is gone) of lockd aren't > closed after some time. So, with enough clients and some time gone, there > are 80 open dangling sockets and you start getting messages of the form: > >

Re: [NFS] problems with lockd in 2.6.22.6

2007-09-07 Thread J. Bruce Fields
On Fri, Sep 07, 2007 at 05:49:55PM +0200, Wolfgang Walter wrote: > Hello, > > we upgraded the kernel of a nfs-server from 2.6.17.11 to 2.6.22.6. Since then > we get the message > > lockd: too many open TCP sockets, consider increasing the number of nfsd > threads > lockd: last TCP connect from

Re: [NFS] [3/4] 2.6.23-rc4: known regressions

2007-08-29 Thread J. Bruce Fields
On Wed, Aug 29, 2007 at 05:27:39PM +0200, Michal Piotrowski wrote: > FS > > Subject : [NFSD OOPS] 2.6.23-rc1-git10 > References : http://lkml.org/lkml/2007/8/2/462 > Last known good : ? > Submitter : Andrew Clayton <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : ?

Re: [PATCH 8/8] AFS: Add security support

2007-04-11 Thread J. Bruce Fields
On Wed, Apr 11, 2007 at 09:10:32PM +0100, David Howells wrote: > J. Bruce Fields <[EMAIL PROTECTED]> wrote: > > > Just curious--when is the actual crypto done? There doesn't seem to be > > any in this patch. > > See AF_RXRPC patch: > > ht

Re: [PATCH 8/8] AFS: Add security support

2007-04-11 Thread J. Bruce Fields
On Wed, Apr 11, 2007 at 08:10:37PM +0100, David Howells wrote: > Add security support to the AFS filesystem. Kerberos IV tickets are > added as RxRPC keys are added to the session keyring with the klog > program. open() and other VFS operations then find this ticket with > request_key() and eithe

aironet: "possible irq lock inversion dependency"

2006-07-27 Thread J. Bruce Fields
I get this when I bring up a network interface (a cisco aironet wireless minipci card) on 2.6.18-rc2. Let me know if any additonal information would be useful. --b. Jul 27 15:18:44 puzzle kernel: Jul 27 15:18:44 puzzle kernel: = Jul 27 1

Re: [PATCH] crypto_free_tfm callers do not need to check for NULL

2005-08-30 Thread J. Bruce Fields
On Tue, Aug 30, 2005 at 10:45:54PM +0200, Jesper Juhl wrote: > Since the patch to add a NULL short-circuit to crypto_free_tfm() went in, > there's no longer any need for callers of that function to check for NULL. ... > Feedback, ACK, NACK, etc welcome. I've no problem with the auth_gss or nfsv4