On 3/9/2021 2:52 PM, Jakub Kicinski wrote:
> On Tue, 9 Mar 2021 16:18:58 +0200 Eran Ben Elisha wrote:
DLH_REMEDY_LOCAL_FIX: associated component will undergo a local
un-harmful fix attempt.
(e.g look for lost interrupt in mlx5e_tx_reporter_timeout_recover())
>>>
>>> Should we make
On 2/4/2021 11:10 AM, Jacob Keller wrote:
> I'd rather see the right solution designed here, so if this isn't the
> right direction I want to work with the list to figure out what makes
> the most sense. (Even if that's "minimum security should update
> automatic
On 2/3/2021 6:08 PM, Jakub Kicinski wrote:
> On Wed, 3 Feb 2021 17:34:24 -0800 Jacob Keller wrote:
>> On 2/3/2021 12:41 PM, Jakub Kicinski wrote:
>>> On Thu, 28 Jan 2021 16:43:21 -0800 Tony Nguyen wrote:
>>>> From: Jacob Keller
>>>>
>>>&g
On 2/3/2021 6:08 PM, Jakub Kicinski wrote:
> On Wed, 3 Feb 2021 17:34:24 -0800 Jacob Keller wrote:
>> On 2/3/2021 12:41 PM, Jakub Kicinski wrote:
>>> On Thu, 28 Jan 2021 16:43:21 -0800 Tony Nguyen wrote:
>>>> From: Jacob Keller
>>>>
>>>&g
On 2/3/2021 12:41 PM, Jakub Kicinski wrote:
> On Thu, 28 Jan 2021 16:43:21 -0800 Tony Nguyen wrote:
>> From: Jacob Keller
>>
>> The ice NVM flash has a security revision field for the main NVM bank
>> and the Option ROM bank. In addition to the revision within the
On 2/1/2021 2:34 PM, Jakub Kicinski wrote:
> On Mon, 1 Feb 2021 13:40:27 -0800 Jacob Keller wrote:
>> On 1/29/2021 10:37 PM, Jakub Kicinski wrote:
>>> On Thu, 28 Jan 2021 16:43:27 -0800 Tony Nguyen wrote:
>>>> When reporting the versions via devli
On 1/29/2021 10:37 PM, Jakub Kicinski wrote:
> On Thu, 28 Jan 2021 16:43:27 -0800 Tony Nguyen wrote:
>> When reporting the versions via devlink info, first read the device
>> capabilities. If there is a pending flash update, use this new function
>> to extract the inactive flash versions. Add th
On 1/29/2021 12:23 PM, Willem de Bruijn wrote:
> On Thu, Jan 28, 2021 at 4:45 PM Tony Nguyen
> wrote:
>>
>> From: Aleksandr Loktionov
>>
>> This reverts commit 2ad1274fa35ace5c6360762ba48d33b63da2396c
>>
>> VF queues were not brought up when PF was brought up after being
>> downed if the VF d
On 1/29/2021 1:04 PM, Willem de Bruijn wrote:
> On Fri, Jan 29, 2021 at 4:01 PM Willem de Bruijn
> wrote:
>>
>> On Thu, Jan 28, 2021 at 7:46 PM Tony Nguyen
>> wrote:
>>>
>>> From: Jacob Keller
>>>
>>> The ice flash contains two co
On 1/25/2021 9:29 PM, Leon Romanovsky wrote:
> On Mon, Jan 25, 2021 at 05:01:40PM -0800, Jacob Keller wrote:
>>
>>
>> On 1/25/2021 4:39 PM, Saleem, Shiraz wrote:
>>>> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and
>>>> implem
On 1/25/2021 4:39 PM, Saleem, Shiraz wrote:
>> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and
>> implement private channel OPs
>>
>> On Sun, Jan 24, 2021 at 03:45:51PM +0200, Leon Romanovsky wrote:
>>> On Fri, Jan 22, 2021 at 05:48:12PM -0600, Shiraz Saleem wrote:
F
On 1/21/2021 7:31 PM, Parav Pandit wrote:
>
>
>> From: Samudrala, Sridhar
>> Sent: Friday, January 22, 2021 2:21 AM
>>
>>> $ devlink port show
>>> pci/:06:00.0/65535: type eth netdev ens2f0np0 flavour physical
>>> port 0 splittable false
>>>
>>> $ devlink port add pci/:06:00.0 flavour
On 1/13/2021 6:27 PM, Jakub Kicinski wrote:
> On Wed, 13 Jan 2021 13:12:12 +0100 Jiri Pirko wrote:
>> This patchset introduces support for modular switch systems.
>> NVIDIA Mellanox SN4800 is an example of such. It contains 8 slots
>> to accomodate line cards. Available line cards include:
>> 16
On 1/13/2021 11:39 PM, Jiri Pirko wrote:
> Thu, Jan 14, 2021 at 03:07:18AM CET, and...@lunn.ch wrote:
>>
>> I assume if i prevision for card4ports but actually install a
>> card2ports, all the interfaces stay down?
>
> Yes, the card won't get activated in case or provision mismatch.
>
If you'
On 1/6/2021 5:45 AM, Vladimir Oltean wrote:
> On Tue, Jan 05, 2021 at 08:58:50PM +0200, Vladimir Oltean wrote:
>> This is marked as Request For Comments for a reason.
>
> If nobody has any objections, I will remove the memory leaks I
> introduced to check if anybody is paying attention, and I w
>
Nice to see this step! Everything seems straight forward to me.
Reviewed-by: Jacob Keller
> Jakub Kicinski (4):
> udp_tunnel: hard-wire NDOs to udp_tunnel_nic_*_port() helpers
> udp_tunnel: remove REGISTER/UNREGISTER handling from tunnel drivers
> net: remove
other utility to complain about
using BIT() macros in UAPI..?
Unfortunately this is easy to overlook because the kernel side code
almost always has BIT defined, so you won't get a compilation failure
until you try to use the uapi header in a userspace program.
Reviewed-by: Jacob Keller
>
gt; @@ -4068,6 +4064,7 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int
> vf_id, u8 *mac)
> ret = -EAGAIN;
> goto error_param;
> }
> + vsi = pf->vsi[vf->lan_vsi_idx];
>
Yea, this makes more sense to me.
Reviewed-by: Jacob Keller
> if (is_multicast_ether_addr(mac)) {
> dev_err(&pf->pdev->dev,
>
On 11/30/2020 8:41 AM, Parav Pandit wrote:
> Added documentation for devlink port and port function related commands.
>
> Signed-off-by: Parav Pandit
> Reviewed-by: Jiri Pirko
Good to see this! I saw a couple of minor nits.
- Jake
> ---
> .../networking/devlink/devlink-port.rst | 10
; 6 files changed, 6 insertions(+), 7 deletions(-)
>
Nice to see these cleanups. I noticed a few of these recently while
working on devlink.
Reviewed-by: Jacob Keller
On 11/18/2020 9:02 AM, Parav Pandit wrote:
>
>> From: David Ahern
>> Sent: Wednesday, November 18, 2020 9:51 PM
>>
>> On 11/12/20 12:24 PM, Parav Pandit wrote:
>>> Extended devlink interface for the user to add and delete port.
>>> Extend devlink to connect user requests to driver to add/delet
On 11/18/2020 11:22 AM, Parav Pandit wrote:
>
>
>> From: David Ahern
>> Sent: Wednesday, November 18, 2020 11:33 PM
>>
>>
>> With Connectx-4 Lx for example the netdev can have at most 63 queues
>> leaving 96 cpu servers a bit short - as an example of the limited number of
>> queues that a nic
hink at least one driver has abused the PPS in the past as a
way to request that we enable the PPS hardware, resulting in effectively
using it as a limited form of the EXTTS interface. Hopefully this helps
reduce the confusion here!
Reviewed-by: Jacob Keller
>
> Signed-off-by: Ahmad Fato
On 11/18/2020 8:22 AM, Christian Eggers wrote:
> Remove driver internal defines for this.
>
> Signed-off-by: Christian Eggers
> Cc: Richard Cochran
> Cc: Kurt Kanzenbach
> ---
> drivers/ptp/ptp_ines.c | 19 +++
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --g
userspace mechanism,
there should be essentially no difference between request_firmware and
request_firmware_direct.
Signed-off-by: Jacob Keller
Acked-by: Shannon Nelson
Acked-by: Vasundhara Volam
Reviewed-by: Jiri Pirko
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
2af-721e-3a54-ef99a666b...@intel.com/
[4]
https://lore.kernel.org/netdev/20201117200820.854115-1-jacob.e.kel...@intel.com/
Jacob Keller (2):
devlink: move request_firmware out of driver
devlink: move flash end and begin to core devlink
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 +--
...
ow no longer possible
to do the wrong thing in this regard. We also save a couple of lines of
code in each driver.
Signed-off-by: Jacob Keller
Acked-by: Vasundhara Volam
Reviewed-by: Jiri Pirko
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
Ch
On 11/13/2020 3:48 PM, Shannon Nelson wrote:
> On 11/13/20 2:45 PM, Jacob Keller wrote:
>> -int ionic_firmware_update(struct ionic_lif *lif, const char *fw_name,
>> +int ionic_firmware_update(struct ionic_lif *lif, const struct firmware *fw,
>>s
On 11/17/2020 12:08 PM, Jacob Keller wrote:
> All drivers which implement the devlink flash update support, with the
> exception of netdevsim, use either request_firmware or
> request_firmware_direct to locate the firmware file. Rather than having
> each driver do this separately as
ow no longer possible
to do the wrong thing in this regard. We also save a couple of lines of
code in each driver.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Michael Chan
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
drivers/net/ethernet/bro
userspace mechanism,
there should be essentially no difference between request_firmware and
request_firmware_direct.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Michael Chan
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
.../net/ethernet/broadcom
...@intel.com/
[2]
https://lore.kernel.org/netdev/20201113224559.3910864-1-jacob.e.kel...@intel.com/
[3]
https://lore.kernel.org/netdev/6352e9d3-02af-721e-3a54-ef99a666b...@intel.com/
Jacob Keller (2):
devlink: move request_firmware out of driver
devlink: move flash end and begin to
On 11/14/2020 8:10 PM, Jakub Kicinski wrote:
> On Fri, 13 Nov 2020 14:51:36 -0800 Jacob Keller wrote:
>> On 11/13/2020 2:32 PM, Jacob Keller wrote:
>>>
>>>
>>> On 11/13/2020 1:34 PM, Jacob Keller wrote:
>>>> Well, at least with ice, the e
On 11/13/2020 2:32 PM, Jacob Keller wrote:
>
>
> On 11/13/2020 1:34 PM, Jacob Keller wrote:
>> Well, at least with ice, the experience is pretty bad. I tried out with
>> a garbage file name on one of my test systems. This was on a slightly
>> older kernel without
userspace mechanism,
there should be essentially no difference between request_firmware and
request_firmware_direct.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Michael Chan
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
This is a follow to the
On 11/13/2020 1:34 PM, Jacob Keller wrote:
> Well, at least with ice, the experience is pretty bad. I tried out with
> a garbage file name on one of my test systems. This was on a slightly
> older kernel without this patch applied, and the device had a pending
> update that had
On 11/13/2020 1:12 PM, Jakub Kicinski wrote:
> On Thu, 12 Nov 2020 16:01:42 -0800 Jacob Keller wrote:
>> All drivers which implement the devlink flash update support, with the
>> exception of netdevsim, use either request_firmware or
>> request_firmware_direct to loc
userspace mechanism,
there should be essentially no difference between request_firmware and
request_firmware_direct.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Michael Chan
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
This is a follow to the
On 11/2/2020 3:07 PM, Saeed Mahameed wrote:
> On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote:
>> From: Jacob Keller
>>
>> When printing messages with ice_debug, align the printed string to
>> the
>> origin line of the message in order to ease debugging
On 10/27/2020 4:03 PM, Jakub Kicinski wrote:
> On Tue, 27 Oct 2020 15:56:35 -0700 Jacob Keller wrote:
>> Hi Jakub,
>>
>> It looks like net-next just pulled in a change to checkpatch.pl which
>> causes it to break:
>>
>> $ ./scripts/checkpatch.pl
>&g
Hi Jakub,
It looks like net-next just pulled in a change to checkpatch.pl which
causes it to break:
$ ./scripts/checkpatch.pl
Global symbol "$gitroot" requires explicit package name (did you forget
to declare "my $gitroot"?) at ./scripts/checkpatch.pl line 980.
Execution of ./scripts/checkpatch.p
On 10/26/2020 3:49 PM, Thomas Gleixner wrote:
> On Mon, Oct 26 2020 at 18:22, Nitesh Narayan Lal wrote:
>> On 10/26/20 5:50 PM, Thomas Gleixner wrote:
>>> But I still think that for curing that isolation stuff we want at least
>>> some information from the driver. Alternative solution would be t
On 10/26/2020 3:13 PM, Jakub Kicinski wrote:
> On Mon, 26 Oct 2020 22:50:45 +0100 Thomas Gleixner wrote:
>> On Mon, Oct 26 2020 at 14:11, Jacob Keller wrote:
>>> On 10/26/2020 1:11 PM, Thomas Gleixner wrote:
>>>> On Mon, Oct 26 2020 at 12:21, Jacob Keller wr
On 10/26/2020 1:11 PM, Thomas Gleixner wrote:
> On Mon, Oct 26 2020 at 12:21, Jacob Keller wrote:
>> On 10/26/2020 12:00 PM, Thomas Gleixner wrote:
>>> How does userspace know about the driver internals? Number of management
>>> interrupts, optimal number of interrup
On 10/26/2020 12:00 PM, Thomas Gleixner wrote:
> On Mon, Oct 26 2020 at 14:30, Marcelo Tosatti wrote:
>> On Fri, Oct 23, 2020 at 11:00:52PM +0200, Thomas Gleixner wrote:
>>> So without information from the driver which tells what the best number
>>> of interrupts is with a reduced number of CPUs
On 10/21/2020 5:02 PM, Jakub Kicinski wrote:
> On Wed, 21 Oct 2020 22:25:48 +0200 Thomas Gleixner wrote:
>> On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote:
>>> On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote:
However, IMHO we would still need a logic to prevent the devices fro
Signed-off-by: Jacob Keller
---
Changes since v2
* use clock_gettime on CLOCK_MONOTONIC instead of gettimeofday
* remove use of timersub since we're now using struct timespec
devlink/devlink.c | 105 +-
1 file changed, 104 insertions(+), 1 delet
gt; the specific DDP package.
>
> Add the type field to the ``fw.app.bundle_id`` row.
>
> Fixes: 410d06879c01 ("ice: add the DDP Track ID to devlink info")
> Signed-off-by: Mauro Carvalho Chehab
Yep, looks correct. Thanks for the fix!
Reviewed-by: Jacob Keller
> ---
On 10/5/2020 7:48 AM, Vladimir Oltean wrote:
> Currently skb_dump has a restriction to only dump full packet for the
> first 5 socket buffers, then only headers will be printed. Remove this
> arbitrary and confusing restriction, which is only documented vaguely
> ("up to") in the comments above
On 10/5/2020 12:33 PM, Johannes Berg wrote:
> On Mon, 2020-10-05 at 12:31 -0700, Jakub Kicinski wrote:
>
>> Yea, I think we're both confused. Agreed with the above.
>>
>> Are you suggesting:
>>
>> const struct nla_policy policy[/* no size */] = {
>> [HEADER]= NLA_POLICY(...)
>>
On 10/5/2020 12:31 PM, Jakub Kicinski wrote:
> On Mon, 05 Oct 2020 21:21:36 +0200 Johannes Berg wrote:
But with the difference it seems to me that it'd be possible to get this
mixed up?
>>>
>>> Right, I prefer not to have the unnecessary NLA_REJECTS, so my thinking
>>> was - use the
On 10/4/2020 12:09 AM, Moshe Shemesh wrote:
>
> On 10/3/2020 12:05 PM, Jiri Pirko wrote:
>> Thu, Oct 01, 2020 at 03:59:08PM CEST, mo...@mellanox.com wrote:
>>> Add remote reload stats to hold the history of actions performed due
>>> devlink reload commands initiated by remote host. For example,
On 10/3/2020 8:04 AM, Jakub Kicinski wrote:
> On Sat, 3 Oct 2020 09:51:00 +0200 Jiri Pirko wrote:
>>> enum devlink_attr {
>>> /* don't change the order or add anything between, this is ABI! */
>>> DEVLINK_ATTR_UNSPEC,
>>> @@ -507,6 +524,7 @@ enum devlink_attr {
>>>
>>> DEVLINK_ATTR_R
es without any downtime.
>
Good to see that checked in the core code.
> The no_reset reload limit will have usecase in this patchset to
> implement restricted fw_activate on mlx5.
>
> Signed-off-by: Moshe Shemesh
> ---
Other than the spelling hit and things pointed out by others, this looks
good to me.
Reviewed-by: Jacob Keller
reinit
>
> $devlink dev reload pci/:82:00.0 action fw_activate
> reload_actions_performed:
> driver_reinit fw_activate
>
> Signed-off-by: Moshe Shemesh
Looks straight forward.
Reviewed-by: Jacob Keller
> ---
> RFCv5 -> v1:
> - Rename supported_reload_actio
>
> Signed-off-by: Moshe Shemesh
Reviewed-by: Jacob Keller
tions to determine the clock_index of the PTP devices
in a more robust way.
Signed-off-by: Jacob Keller
---
drivers/ptp/ptp_sysfs.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c
index be076a91e20e..8ba9556c939a 100644
--- a/dri
Signed-off-by: Jacob Keller
---
Changes since v1
* update last status time only when the message changes, allowing an elapsed
time to represent the full operation of downloading or programming the
image.
* Use "\b \b" to erase the elapsed time message properly even when we will
not be
On 9/30/2020 2:55 PM, Shannon Nelson wrote:
> On 9/30/20 2:43 PM, Jacob Keller wrote:
>> On 9/30/2020 2:36 PM, Jakub Kicinski wrote:
>>> On Wed, 30 Sep 2020 14:20:43 -0700 Jacob Keller wrote:
>>>>> Thanks, Jake. In general this seems to work p
On 9/30/2020 2:36 PM, Jakub Kicinski wrote:
> On Wed, 30 Sep 2020 14:20:43 -0700 Jacob Keller wrote:
>>> Thanks, Jake. In general this seems to work pretty well. One thing,
>>> tho'...
>>>
>>> Our fw download is slow (I won't go into the
On 9/29/2020 3:44 PM, Shannon Nelson wrote:
> On 9/29/20 2:56 PM, Jacob Keller wrote:
>> For some devices, updating the flash can take significant time during
>> operations where no status can meaningfully be reported. This can be
>> somewhat confusing to a user who sees d
ettings
overwrite identifiers
Signed-off-by: Jacob Keller
---
devlink/devlink.c | 48 +--
1 file changed, 46 insertions(+), 2 deletions(-)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index 0374175eda3d..5cf2cd194788 100644
--- a/devlink/dev
subsections will be sent
in the overwrite mask, resulting in a request to overwrite all settings and
identifiers stored in the updated flash components.
$devlink dev flash pci/:af:00.0 file flash_image.bin overwrite settings
overwrite identifiers
Jacob Keller (2):
Update kernel headers f
Add support for specifying the overwrite sections to allow in the flash
update command. This is done by adding a new "overwrite" option which
can take either "settings" or "identifiers" passing the overwrite mode
multiple times will combine the fields using bitwise-OR
The recent changes to support an overwrite mask require the _BITUL macro
to be included. The uapi/linux/devlink.h header did not include
resulting in compile failures using the macros that relied
upon it.
Signed-off-by: Jacob Keller
---
include/uapi/linux/devlink.h | 2 ++
1 file changed, 2
Signed-off-by: Jacob Keller
---
This is a respin of an RFC at [1] based on feedback. This version works as I
would expect,
Changes since RFC
* Add fflush, fixing jittery output
* Since we're only comparing the seconds value, use "> 2" instead of "> 3"
so that we
On 9/29/2020 11:45 AM, Jacob Keller wrote:
>
>
> On 9/29/2020 11:07 AM, Ido Schimmel wrote:
>> On Tue, Sep 29, 2020 at 10:56:23AM -0700, Jacob Keller wrote:
>>>
>>>
>>> On 9/29/2020 10:18 AM, Jakub Kicinski wrote:
>>>> On Mon, 28 Sep
On 9/29/2020 11:07 AM, Ido Schimmel wrote:
> On Tue, Sep 29, 2020 at 10:56:23AM -0700, Jacob Keller wrote:
>>
>>
>> On 9/29/2020 10:18 AM, Jakub Kicinski wrote:
>>> On Mon, 28 Sep 2020 16:49:45 -0700 Jacob Keller wrote:
>>>> For some devices, updating
er sources. However, when including the UAPI headers
in a userspace application (such as devlink in iproute2), _BITUL is not
defined.
Fixes: 5d5b4128c4ca ("devlink: introduce flash update overwrite mask")
Signed-off-by: Jacob Keller
---
I believe this is the appropriate fix for the issue
On 9/29/2020 8:33 AM, David Ahern wrote:
> On 9/9/20 3:28 PM, Jacob Keller wrote:
>> This series implements the iproute2 side of the new
>> DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK.
>>
>> This attribute is used to allow userspace to indicate what a device should
>
On 9/29/2020 10:18 AM, Jakub Kicinski wrote:
> On Mon, 28 Sep 2020 16:49:45 -0700 Jacob Keller wrote:
>> For some devices, updating the flash can take significant time during
>> operations where no status can meaningfully be reported. This can be
>> somewhat confusing to a
we do not
receive an error or a new status without that time out, replace it with
the text "timeout reached".
Signed-off-by: Jacob Keller
---
Sending this as an RFC because I doubt this is the best implementation. For
one, I get a weird display issue where the cursor doesn't alway
meout value, make it a macro rather
than a magic number.
Signed-off-by: Jacob Keller
---
drivers/net/ethernet/intel/ice/ice_fw_update.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c
b/drivers/net/ethernet/inte
ate_params bitfield.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: Ido Schimmel
Cc: Danielle Ratson
---
.../net/ethernet/broadcom/bnxt/bnxt_devli
ask values controllable via
a debugfs parameter. This enables testing a flow where the driver
rejects an unsupportable overwrite mask.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
---
drivers/net/netdevsim/dev.c| 10 +-
drivers/net/netdevsim/netdevsim.h
identifiers, this combination is rejected by the driver as not supported
with an appropriate extended ACK message.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
---
Documentation/networking/devlink/ice.rst | 31 +++
drivers/net/ethernet/intel/ice/ice_devlink.c | 19
overwrite mask must set the
DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK in the
supported_flash_update_params field of their devlink_ops.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
---
.../networking/devlink/devlink-flash.rst | 28 +++
include/net/devlink.h
for the netdevsim patch
* Picked up Jakub's reviewed
Jacob Keller (5):
devlink: check flash_update parameter support in net core
devlink: convert flash_update to use params structure
devlink: introduce flash update overwrite mask
netdevsim: add support for flash_update overwrite
unsupported
attribute in the message.
Going forward, any new additional parameter to flash update will require
a bit in the supported_flash_update_params bitfield.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
Cc: Jiri Pirko
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed
On 9/24/2020 8:36 AM, Jakub Kicinski wrote:
> On Wed, 23 Sep 2020 17:10:30 -0700 Jacob Keller wrote:
>>> - printf("RX negotiated: %s\nTX negotiated: %s\n",
>>> - rx_status ? "on" : "off", tx_status
On 9/15/2020 4:52 PM, Jakub Kicinski wrote:
> Help output is quite crowded already with every command
> being prefixed by --debug and --json options, and we're
> about to add a third one.
>
> Add an indirection.
>
> Signed-off-by: Jakub Kicinski
Seems reasonable
quot;tx": true
> }
> } ]
Makes sense, we report all of these as a single dictionary with
key-values. Putting negotiated as a subsection seems reasonable as well.
I guess we could split this so that tx and rx have their own section.
but I think this is good.
This look
On 9/21/2020 3:31 PM, Jacob Keller wrote:
> (This is essentially a resend of v7 because some of the patches didn't hit
> the netdev list last Friday due to an SMTP server issue here)
>
Heh. Apparently it's not fixed yet. I am sorry for those on the CC list
for this spam.
Thanks,
Jake
ate_params bitfield.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: Ido Schimmel
Cc: Danielle Ratson
---
Changes since v6
* Applied param changes to the io
ask values controllable via
a debugfs parameter. This enables testing a flow where the driver
rejects an unsupportable overwrite mask.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
---
drivers/net/netdevsim/dev.c| 10 +-
drivers/net/netdevsim/netdevsim.h
unsupported
attribute in the message.
Going forward, any new additional parameter to flash update will require
a bit in the supported_flash_update_params bitfield.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
Cc: Jiri Pirko
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed
s device" to the netlink error messages for unsupported
attributes
* Removed use of BIT() in the uapi header
* Fixed the commit message for the netdevsim patch
* Picked up Jakub's reviewed tag.
Jacob Keller (5):
devlink: check flash_update parameter support in net core
devlink: conv
overwrite mask must set the
DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK in the
supported_flash_update_params field of their devlink_ops.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
---
.../networking/devlink/devlink-flash.rst | 28 +++
include/net/devlink.h
On 9/18/2020 2:04 PM, David Miller wrote:
> From: Jacob Keller
> Date: Thu, 17 Sep 2020 17:45:24 -0700
>
>> This series introduces support for a new attribute to the flash update
>> command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK.
>>
>> This attribute is a b
On 9/17/2020 9:25 PM, Parav Pandit wrote:
>> From: Jacob Keller
>> Sent: Friday, September 18, 2020 12:13 AM
>>
>>
>> On 9/17/2020 10:20 AM, Parav Pandit wrote:
>>> Extended devlink interface for the user to add and delete port.
>>> Extend d
On 9/17/2020 8:54 PM, Parav Pandit wrote:
>
>
>> From: Jacob Keller
>> Sent: Friday, September 18, 2020 12:00 AM
>>
>>
>> On 9/17/2020 10:20 AM, Parav Pandit wrote:
>>> A PCI sub-function (SF) represents a portion of the device similar to
>&
On 9/17/2020 8:35 PM, Parav Pandit wrote:
> Hi Jacob,
>
>> From: Jacob Keller
>> Sent: Friday, September 18, 2020 12:29 AM
>>
>>
>> We lost this comment in the move it looks like. I think it's still useful to
>> keep for
>> clarity of why
ate_params bitfield.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: Ido Schimmel
Cc: Danielle Ratson
---
.../net/ethernet/broadcom/bnxt/bnxt_devli
unsupported
attribute in the message.
Going forward, any new additional parameter to flash update will require
a bit in the supported_flash_update_params bitfield.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc
identifiers, this combination is rejected by the driver as not supported
with an appropriate extended ACK message.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
---
Documentation/networking/devlink/ice.rst | 31 +++
drivers/net/ethernet/intel/ice/ice_devlink.c | 19
ask values controllable via
a debugfs parameter. This enables testing a flow where the driver
rejects an unsupportable overwrite mask.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
---
drivers/net/netdevsim/dev.c| 10 +-
drivers/net/netdevsim/netdevsim.h
overwrite mask must set the
DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK in the
supported_flash_update_params field of their devlink_ops.
Signed-off-by: Jacob Keller
---
Changes since v5
* Use _BITUL, and remove all uses of BIT()
.../networking/devlink/devlink-flash.rst | 28
s device" to the netlink error messages for unsupported
attributes
* Removed use of BIT() in the uapi header
* Fixed the commit message for the netdevsim patch
* Picked up Jakub's reviewed tag.
Jacob Keller (5):
devlink: check flash_update parameter support in net core
devlink: conv
On 9/17/2020 1:11 PM, Bjorn Helgaas wrote:
> [+cc Ingo, Peter, Juri, Vincent (scheduler maintainers)]
>
> s/hosekeeping/housekeeping/ (in subject)
>
> On Wed, Sep 09, 2020 at 11:08:16AM -0400, Nitesh Narayan Lal wrote:
>> Introduce a new API num_housekeeping_cpus(), that can be used to retriev
On 9/17/2020 12:16 AM, Leon Romanovsky wrote:
> On Thu, Sep 17, 2020 at 10:25:08AM +0800, Herrington wrote:
>> We get 1 warning when building kernel with W=1:
>> drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for
>> ‘pch_ch_control_read’ [-Wmissing-prototypes]
>> u32 pch_ch_contro
1 - 100 of 313 matches
Mail list logo
