Re: [KJ] [PATCH] net/core/flow.c: compare data with memcmp

2006-12-31 Thread Nishanth Aravamudan
t, I don't think either of your comments make the code any clearer than the code on its own, so drop them both. Thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: select(0, ..) is valid ?

2007-05-22 Thread Nishanth Aravamudan
ret = -EFAULT; > > out: > > - kfree(bits); > > + if (bits != stack_fds) > > + kfree(bits); > > out_nofds: > > return ret; > > } > > Andy put this through a couple machines on test.kernel.org and elm3b6 > was fixed, howe

tg3: unable to handle null pointer dereference [Re: Linux 2.6.21-rc6]

2007-04-06 Thread Nishanth Aravamudan
5): > [TG3]: Eliminate the unused TG3_FLAG_SPLIT_MODE flag. > [TG3]: Exit irq handler during chip reset. > [TG3]: Update version and reldate. probably "Exit irq handler during chip reset"? Thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Tec

Re: tg3: unable to handle null pointer dereference

2007-04-06 Thread Nishanth Aravamudan
On 06.04.2007 [17:36:00 -0700], David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Fri, 06 Apr 2007 15:57:13 -0700 > > > On Fri, 2007-04-06 at 14:40 -0700, Nishanth Aravamudan wrote: > > > > > 2.6.21-rc5 is ok. 2.6.21-rc6 re

Re: [PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Nishanth Aravamudan
On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote: > Some architectures like POWER can have a NUMA node_possible_map that > contains sparse entries. This causes memory corruption with openvswitch > since it allocates flow_cache with a multiple of num_possible_nodes() and Couldn't this also be fi

Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread Nishanth Aravamudan
tch node_online_map on boot. > Fixes: 3af229f2071f5b5cb31664be6109561fbe19c861 > > Signed-off-by: Chris J Arges Acked-by: Nishanth Aravamudan > --- > net/openvswitch/flow_table.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/openvswitch/flow_tab

Re: [PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Nishanth Aravamudan
On 21.07.2015 [11:30:58 -0500], Chris J Arges wrote: > On Tue, Jul 21, 2015 at 09:24:18AM -0700, Nishanth Aravamudan wrote: > > On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote: > > > Some architectures like POWER can have a NUMA node_possible_map that > > > contains

[PATCH] net/sunrpc: fix time conversion error

2005-08-01 Thread Nishanth Aravamudan
thout using the xtime_lock. Fixed as well. Patch is compile-tested. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> --- svcsock.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) --- 2.6.13-rc4/net/sunrpc/svcsock.c 2005-07-29 14:11:50.0 -0700 +++ 2.6.1

Re: [PATCH] net/sunrpc: fix time conversion error

2005-08-01 Thread Nishanth Aravamudan
On 02.08.2005 [02:03:59 +0200], Patrick McHardy wrote: > Nishanth Aravamudan wrote: > > On 01.08.2005 [15:11:48 -0600], Josip Loncaric wrote: > > > >>Line 589 of linux-2.6.11.10/net/sunrpc/svcsock.c is obviously wrong: > >> > >>

[-mm PATCH 05/32] net: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_{,un}interruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Also use human-time conversion functions instead of hard-coded division to avoid rounding issues. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> --- ne

[-mm PATCH 20/32] drivers/net: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_interruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> --- drivers/net/8139cp.c |3 - drivers/net/hp100.c