On Thu 08 Apr 2021 at 02:50, Cong Wang wrote:
> On Wed, Apr 7, 2021 at 8:36 AM Vlad Buslov wrote:
>>
>> Action init code increments reference counter when it changes an action.
>> This is the desired behavior for cls API which needs to obtain action
>> referenc
Verify cleanup of failed actions batch change where second action in batch
fails after successful init of first action.
Signed-off-by: Vlad Buslov
---
.../tc-testing/tc-tests/actions/simple.json | 29 +++
1 file changed, 29 insertions(+)
diff --git a/tools/testing/selftests
Verify cleanup of failed actions batch add where second action in batch
fails after successful init of first action.
Signed-off-by: Vlad Buslov
---
.../tc-testing/tc-tests/actions/simple.json | 30 +++
1 file changed, 30 insertions(+)
diff --git a/tools/testing/selftests/tc
Add two new tests for action create/change code.
Vlad Buslov (2):
tc-testing: add simple action test to verify batch add cleanup
tc-testing: add simple action test to verify batch change cleanup
.../tc-testing/tc-tests/actions/simple.json | 59 +++
1 file changed, 59
t release the module reference
when overwriting existing action as this is no longer necessary since both
upper and lower layers obtain and manage their own module references
independently.
Fixes: d349f9976868 ("net_sched: fix RTNL deadlock again caused by
request_module()")
Suggested-by:
o tcf_action_put_many().
Fixes: cae422f379f3 ("net: sched: use reference counting action init")
Reported-by: Kumar Kartikeya Dwivedi
Signed-off-by: Vlad Buslov
---
Notes:
Changes V1 -> V2:
- Extend commit message with reproduction and fix details.
- Don't e
This reverts commit 6855e8213e06efcaf7c02a15e12b1ae64b9a7149.
Following commit in series fixes the issue without introducing regression
in error rollback of tcf_action_destroy().
Signed-off-by: Vlad Buslov
---
net/sched/act_api.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/sched
patch.
Vlad Buslov (3):
Revert "net: sched: bump refcount for new action in ACT replace mode"
net: sched: fix action overwrite reference counting
net: sched: fix err handler in tcf_action_init()
include/net/act_api.h | 12 --
net/sched/a
On Tue 06 Apr 2021 at 01:56, Cong Wang wrote:
> On Sat, Apr 3, 2021 at 3:01 AM Vlad Buslov wrote:
>> So, the following happens in reproduction provided in commit message
>> when executing "tc actions add action simple sdata \"1\" index 1
>> action simple s
On Sat 03 Apr 2021 at 02:14, Cong Wang wrote:
> On Wed, Mar 31, 2021 at 9:41 AM Vlad Buslov wrote:
>>
>> With recent changes that separated action module load from action
>> initialization tcf_action_init() function error handling code was modified
>> to manually re
On Sat 03 Apr 2021 at 01:13, Cong Wang wrote:
> On Wed, Mar 31, 2021 at 9:41 AM Vlad Buslov wrote:
>>
>> Action init code increments reference counter when it changes an action.
>> This is the desired behavior for cls API which needs to obtain action
>> referenc
x27;t been initialized.
Fixes: d349f9976868 ("net_sched: fix RTNL deadlock again caused by
request_module()")
Signed-off-by: Vlad Buslov
---
net/sched/act_api.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/net/sched/act_api.c b/net/
Verify cleanup of failed actions batch add where second action in batch
fails after successful init of first action.
Signed-off-by: Vlad Buslov
---
.../tc-testing/tc-tests/actions/simple.json | 30 +++
1 file changed, 30 insertions(+)
diff --git a/tools/testing/selftests/tc
e counting action init")
Reported-by: Kumar Kartikeya Dwivedi
Signed-off-by: Vlad Buslov
---
include/net/act_api.h | 5 +++--
net/sched/act_api.c | 27 +--
net/sched/cls_api.c | 9 +
3 files changed, 25 insertions(+), 16 deletions(-)
diff --git a/includ
Verify cleanup of failed actions batch change where second action in batch
fails after successful init of first action.
Signed-off-by: Vlad Buslov
---
.../tc-testing/tc-tests/actions/simple.json | 29 +++
1 file changed, 29 insertions(+)
diff --git a/tools/testing/selftests
o net-next.
Vlad Buslov (4):
net: sched: fix action overwrite reference counting
net: sched: fix err handler in tcf_action_init()
tc-testing: add simple action test to verify batch add cleanup
tc-testing: add simple action test to verify batch change cleanup
include/net
On Wed 31 Mar 2021 at 11:37, Kumar Kartikeya Dwivedi wrote:
> Currently, action creation using ACT API in replace mode is buggy. When
> invoking for non-existent action index 42,
>
> tc action replace action bpf obj foo.o sec index 42
>
> kernel creates the action, fills up the netlink r
On Wed 31 Mar 2021 at 07:40, Cong Wang wrote:
> On Mon, Mar 29, 2021 at 3:55 PM Kumar Kartikeya Dwivedi
> wrote:
>> diff --git a/net/sched/act_api.c b/net/sched/act_api.c
>> index b919826939e0..43cceb924976 100644
>> --- a/net/sched/act_api.c
>> +++ b/net/sched/act_api.c
>> @@ -1042,6 +1042,9 @
xist is
handled correctly.
Signed-off-by: Vlad Buslov
---
.../tc-testing/tc-tests/actions/simple.json | 24 +++
1 file changed, 24 insertions(+)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/simple.json
b/tools/testing/selftests/tc-testing/tc-tests/actions/si
--git a/net/sched/act_api.c b/net/sched/act_api.c
> index b919826939e0..43cceb924976 100644
> --- a/net/sched/act_api.c
> +++ b/net/sched/act_api.c
> @@ -1042,6 +1042,9 @@ struct tc_action *tcf_action_init_1(struct net *net,
> struct tcf_proto *tp,
> if (err != ACT_P_CREATED)
> module_put(a_o->owner);
>
> + if (!bind && ovr && err == ACT_P_CREATED)
> + refcount_set(&a->tcfa_refcnt, 2);
> +
> return a;
>
> err_out:
Reviewed-and-tested-by: Vlad Buslov
On Mon 29 Mar 2021 at 15:32, Toke Høiland-Jørgensen wrote:
> Vlad Buslov writes:
>
>> On Thu 25 Mar 2021 at 14:00, Kumar Kartikeya Dwivedi
>> wrote:
>>> This adds functions that wrap the netlink API used for adding,
>>> manipulating, and removing filters
On Thu 25 Mar 2021 at 14:00, Kumar Kartikeya Dwivedi wrote:
> This adds functions that wrap the netlink API used for adding,
> manipulating, and removing filters and actions. These functions operate
> directly on the loaded prog's fd, and return a handle to the filter and
> action using an out p
Hi Kumar,
Thanks for the patch!
On Sun 28 Mar 2021 at 09:45, Kumar Kartikeya Dwivedi wrote:
> When creating an action in replace mode, in tcf_action_add, the refcount
> of existing actions is rightly raised during tcf_idr_check_alloc call,
> but for new actions a dummy placeholder entry is creat
struct mlx5e_encap_entry *e)
> { return -EOPNOTSUPP; }
> #endif
> int mlx5e_tc_tun_route_lookup(struct mlx5e_priv *priv,
Thanks Arnd!
Reviewed-by: Vlad Buslov
ction insertions together")
Reported-by: syzbot+151e3e714d34ae4ce...@syzkaller.appspotmail.com
Signed-off-by: Vlad Buslov
---
include/net/act_api.h | 1 +
net/sched/act_api.c | 2 +-
net/sched/cls_api.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/net/act_api.h b/i
On Tue 16 Feb 2021 at 01:22, Cong Wang wrote:
> On Wed, Feb 10, 2021 at 9:53 PM syzbot
> wrote:
>>
>> syzbot has found a reproducer for the following issue on:
>>
>> HEAD commit:291009f6 Merge tag 'pm-5.11-rc8' of git://git.kernel.org/p..
>> git tree: upstream
>> console output: https:/
checking for positive error values and converting them to
-EINVAL in fib6_tables_dump().
Reported-by: Dan Carpenter
Suggested-by: Ido Schimmel
Signed-off-by: Vlad Buslov
---
net/ipv6/ip6_fib.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6
On Tue 09 Feb 2021 at 10:42, Or Gerlitz wrote:
> On Sat, Feb 6, 2021 at 7:10 AM Saeed Mahameed wrote:
>
>> Vlad Buslov says:
>
>> Implement support for VF tunneling
>
>> Currently, mlx5 only supports configuration with tunnel endpoint IP address
>> on
&g
On Wed 10 Feb 2021 at 15:56, Marcelo Ricardo Leitner
wrote:
> On Tue, Feb 09, 2021 at 06:10:59PM +0200, Or Gerlitz wrote:
>> On Tue, Feb 9, 2021 at 4:26 PM Vlad Buslov wrote:
>> > On Mon 08 Feb 2021 at 22:22, Jakub Kicinski wrote:
>> > > On Mon, 8 Feb 2021 10
y: Dan Carpenter
Thanks, Dan!
Reviewed-by: Vlad Buslov
On Tue 09 Feb 2021 at 21:50, Jakub Kicinski wrote:
> On Tue, 9 Feb 2021 21:17:11 +0200 Vlad Buslov wrote:
>> 4. Decapsulated payload appears on namespaced VF with IP address
>> 5.5.5.5:
>>
>> $ sudo ip netns exec ns0 tcpdump -ni enp8s0f0v1 -vvv -c 3
>
> So
On Tue 09 Feb 2021 at 20:05, Jakub Kicinski wrote:
> On Tue, 9 Feb 2021 16:22:26 +0200 Vlad Buslov wrote:
>> No, tunnel IP is configured on VF. That particular VF is in host
>> namespace. When mlx5 resolves tunneling the code checks if tunnel
>> endpoint IP address is on su
On Mon 08 Feb 2021 at 22:22, Jakub Kicinski wrote:
> On Mon, 8 Feb 2021 10:21:21 +0200 Vlad Buslov wrote:
>> > These operations imply that 7.7.7.5 is configured on some interface on
>> > the host. Most likely the VF representor itself, as that aids with ARP
>> > res
On Mon 08 Feb 2021 at 15:25, Marcelo Ricardo Leitner
wrote:
> On Mon, Feb 08, 2021 at 10:21:21AM +0200, Vlad Buslov wrote:
>>
>> On Sat 06 Feb 2021 at 20:13, Marcelo Ricardo Leitner
>> wrote:
>> > Hi,
>> >
>> > I didn't
On Sat 06 Feb 2021 at 20:13, Marcelo Ricardo Leitner
wrote:
> Hi,
>
> I didn't receive the cover letter, so I'm replying on this one. :-)
>
> This is nice. One thing is not clear to me yet. From the samples on
> the cover letter:
>
> $ tc -s filter show dev enp8s0f0_1 ingress
> filter protocol
On Sun 17 Jan 2021 at 17:15, Jamal Hadi Salim wrote:
> On 2021-01-16 7:56 p.m., Cong Wang wrote:
>> From: Cong Wang
>> tcf_action_init_1() loads tc action modules automatically with
>> request_module() after parsing the tc action names, and it drops RTNL
>> lock and re-holds it before and after r
On Thu 10 Dec 2020 at 00:22, Jakub Kicinski wrote:
> On Wed, 9 Dec 2020 22:54:40 +0200 Vlad Buslov wrote:
>> > Yes, I think the patch I sent should fix this, ETH_P_ARP should not be
>> > dropped ;)
>> >
>> > I am testing this before offical patch submis
On Wed 09 Dec 2020 at 20:50, Eric Dumazet wrote:
> On Wed, Dec 9, 2020 at 7:34 PM Saeed Mahameed wrote:
>>
>> On Wed, 2020-12-09 at 19:05 +0100, Eric Dumazet wrote:
>> > On Wed, Dec 9, 2020 at 6:35 PM Eric Dumazet
>> > wrote:
>> > > Hmm... maybe the ECN stuff has always been buggy then, and nobo
On Tue 01 Dec 2020 at 21:24, Jakub Kicinski wrote:
> On Tue, 1 Dec 2020 20:39:16 +0200 Vlad Buslov wrote:
>> On Tue 01 Dec 2020 at 19:03, Jakub Kicinski wrote:
>> > On Tue, 1 Dec 2020 09:55:37 +0200 Vlad Buslov wrote:
>> >> On Tue 01 Dec 2020 at 04:52, Jakub Kic
On Tue 01 Dec 2020 at 19:03, Jakub Kicinski wrote:
> On Tue, 1 Dec 2020 09:55:37 +0200 Vlad Buslov wrote:
>> On Tue 01 Dec 2020 at 04:52, Jakub Kicinski wrote:
>> > On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote:
>> >> @@ -2262,7 +2260,7 @@ static int tc_d
On Tue 01 Dec 2020 at 04:52, Jakub Kicinski wrote:
> On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote:
>> @@ -2262,7 +2260,7 @@ static int tc_del_tfilter(struct sk_buff *skb, struct
>> nlmsghdr *n,
>>
>> if (prio == 0) {
>> tfilter_notify
Refactor action flags according to recommended kernel upstream naming using
TCA_ACT_ prefix. Implement support for new action terse dump flag.
Vlad Buslov (2):
tc: use TCA_ACT_ prefix for action flags
tc: implement support for action terse dump
include/uapi/linux/rtnetlink.h | 12
In terse mode dump only outputs essential data needed to identify the
action (kind, index) and stats, if requested by the user.
Signed-off-by: Vlad Buslov
Suggested-by: Jamal Hadi Salim
---
man/man8/tc.8 | 2 +-
tc/m_action.c | 9 +
2 files changed, 10 insertions(+), 1 deletion(-)
di
Use TCA_ACT_FLAG_LARGE_DUMP_ON alias according to new preferred naming for
action flags.
Signed-off-by: Vlad Buslov
---
include/uapi/linux/rtnetlink.h | 12 +++-
tc/m_action.c | 4 ++--
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/include/uapi/linux
. Remove the 'rtnl_held' argument in order to simplify the code and
make rtnl lock requirement explicit.
Signed-off-by: Vlad Buslov
---
include/net/pkt_cls.h | 2 +-
net/sched/cls_api.c | 18 --
net/sched/sch_api.c | 4 ++--
3 files changed, 11 insertions(+), 13
Currently both filter and action flags use same "TCA_" prefix which makes
them hard to distinguish to code and confusing for users. Create aliases
for existing action flags constants with "TCA_ACT_" prefix.
Signed-off-by: Vlad Buslov
---
Notes:
Changes V1 -> V2:
On Tue 24 Nov 2020 at 18:24, Jakub Kicinski wrote:
> On Tue, 24 Nov 2020 11:28:37 +0200 Vlad Buslov wrote:
>> > TCA_FLAG_TERSE_DUMP exists only in net-next, we could rename it, right?
>>
>> You are right. I'll send a fix.
>
> You mean v2, not a follow up, right? :)
Yes. Sending the v2.
On Mon 23 Nov 2020 at 23:22, Jakub Kicinski wrote:
> On Sat, 21 Nov 2020 18:09:02 +0200 Vlad Buslov wrote:
>> Currently both filter and action flags use same "TCA_" prefix which makes
>> them hard to distinguish to code and confusing for users. Create aliases
>
Currently both filter and action flags use same "TCA_" prefix which makes
them hard to distinguish to code and confusing for users. Create aliases
for existing action flags constants with "TCA_ACT_" prefix.
Signed-off-by: Vlad Buslov
---
include/uapi/linux/rtnetlink.h |
act_frag.c | 164
> ++
> net/sched/act_mirred.c| 21 --
> 9 files changed, 265 insertions(+), 11 deletions(-)
> create mode 100644 net/sched/act_frag.c
Hi,
I ran our CT tests with this series and kernel debug configs enabled
without any issue.
Tested-by: Vlad Buslov
On Mon 09 Nov 2020 at 16:54, wenxu wrote:
> 在 2020/11/9 21:24, Vlad Buslov 写道:
>> On Sun 08 Nov 2020 at 01:30, we...@ucloud.cn wrote:
>>> From: wenxu
>>>
>>> Currently kernel tc subsystem can do conntrack in act_ct. But when several
>>> fra
On Mon 09 Nov 2020 at 16:50, Marcelo Ricardo Leitner
wrote:
> On Mon, Nov 09, 2020 at 03:24:37PM +0200, Vlad Buslov wrote:
>> On Sun 08 Nov 2020 at 01:30, we...@ucloud.cn wrote:
> ...
>> > @@ -974,9 +974,22 @@ config NET_ACT_TUNNEL_KEY
>> > To compile this c
On Sun 08 Nov 2020 at 01:30, we...@ucloud.cn wrote:
> From: wenxu
>
> Currently kernel tc subsystem can do conntrack in act_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will redirect
> mi
Iproute2 tc classifier terse dump has been accepted with modified syntax.
Update the tests accordingly.
Signed-off-by: Vlad Buslov
Fixes: e7534fd42a99 ("selftests: implement flower classifier terse dump tests")
---
.../testing/selftests/tc-testing/tc-tests/filters/tests.json | 4 ++
On Tue 03 Nov 2020 at 23:59, Jamal Hadi Salim wrote:
> On 2020-11-03 10:07 a.m., Vlad Buslov wrote:
>>
>> On Tue 03 Nov 2020 at 03:48, David Ahern wrote:
>>> On 10/31/20 2:25 PM, Vlad Buslov wrote:
>>>> diff --git a/include/uapi/linux/rtnetlink.h
&
On Fri 06 Nov 2020 at 11:14, we...@ucloud.cn wrote:
> From: wenxu
>
> Currently kernel tc subsystem can do conntrack in act_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will redirect
> mi
On Tue 03 Nov 2020 at 03:48, David Ahern wrote:
> On 10/31/20 2:25 PM, Vlad Buslov wrote:
>> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
>> index 5ad84e663d01..b486f52900f0 100644
>> --- a/include/uapi/linux/rtnetlink.h
>> +++ b/inc
by its own handle).
Move tcf_action_dump_terse() function to the beginning of source file in
order to call it from tcf_dump_walker().
Signed-off-by: Vlad Buslov
Suggested-by: Jamal Hadi Salim
---
Notes:
Changes V1 -> V2:
- Include cookie in action terse dump.
include/uapi/li
On Mon 02 Nov 2020 at 14:26, Jamal Hadi Salim wrote:
> Thanks Vlad. Ive run the basic test and it looks good.
> One thing i discovered while testing is that if the
> cookie is set, we also want it in the dump. Your earlier
> comment that it only costs if it was set is on point.
>
> So please remov
terse mode dump only outputs essential data needed to identify the
action (kind, index) and stats, if requested by the user.
Signed-off-by: Vlad Buslov
Suggested-by: Jamal Hadi Salim
---
include/uapi/linux/rtnetlink.h | 4
man/man8/tc.8 | 2 +-
tc/m_action.c
tcf_action_dump_terse() function to the beginning of source file in
order to call it from tcf_dump_walker().
Signed-off-by: Vlad Buslov
Suggested-by: Jamal Hadi Salim
---
include/uapi/linux/rtnetlink.h | 4 ++
net/sched/act_api.c| 69 ++
2 files changed
On Mon 26 Oct 2020 at 20:01, Jamal Hadi Salim wrote:
> On 2020-10-26 1:46 p.m., Vlad Buslov wrote:
>>
>> On Mon 26 Oct 2020 at 19:12, Jamal Hadi Salim wrote:
>>> On 2020-10-26 7:28 a.m., Vlad Buslov wrote:
>>>>
>>>> On S
On Mon 26 Oct 2020 at 19:12, Jamal Hadi Salim wrote:
> On 2020-10-26 7:28 a.m., Vlad Buslov wrote:
>>
>> On Sat 24 Oct 2020 at 20:40, Jamal Hadi Salim wrote:
>
> [..]
>>>>
>>>> Yes, that makes sense. I guess introducing something like 'tc a
On Mon 26 Oct 2020 at 16:52, David Ahern wrote:
> On 10/26/20 5:28 AM, Vlad Buslov wrote:
>> Patch to make cookie in filter terse dump optional? That would break
>> existing terse dump users that rely on it (OVS).
>
> Maybe I missed something in the discussions. terse dump
On Sat 24 Oct 2020 at 20:40, Jamal Hadi Salim wrote:
> On 2020-10-23 8:48 a.m., Vlad Buslov wrote:
>> On Thu 22 Oct 2020 at 17:05, Jamal Hadi Salim wrote:
>>> On 2020-10-21 4:19 a.m., Vlad Buslov wrote:
>>>>
>>>> On Tue 20 Oct 2020 at 15:29, Jamal Ha
On Mon 26 Oct 2020 at 10:28, Leon Romanovsky wrote:
> On Mon, Oct 26, 2020 at 10:10:31AM +0200, Vlad Buslov wrote:
>> On Mon 26 Oct 2020 at 08:04, Leon Romanovsky wrote:
>> > From: Leon Romanovsky
>> >
>> > The tcf_block_unbind() expects that the caller
On Mon 26 Oct 2020 at 08:04, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> The tcf_block_unbind() expects that the caller will take block->cb_lock
> before calling it, however the code took RTNL lock instead. This causes
> to the following kernel panic.
>
> WARNING: CPU: 1 PID: 13524 at net
From: Vlad Buslov
Modify implementations that return error from action_until->print_aopt()
callback to silently skip actions that don't have their corresponding
TCA_ACT_OPTIONS attribute set (some actions already behave like this).
Print action kind before returning from action_until->
Implement support for terse dump mode which provides only essential
classifier/action info (handle, stats, cookie, etc.). Use new
TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from
kernel.
Vlad Buslov (2):
tc: skip actions that don't have options attribute when printing
From: Vlad Buslov
Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when
user requested it with following example CLI (-br for 'brief'):
$ tc -s -br filter show dev ens1f0 ingress
filter p
On Thu 22 Oct 2020 at 17:05, Jamal Hadi Salim wrote:
> On 2020-10-21 4:19 a.m., Vlad Buslov wrote:
>>
>> On Tue 20 Oct 2020 at 15:29, Jamal Hadi Salim wrote:
>>> On 2020-10-19 11:18 a.m., Vlad Buslov wrote:
>>> My worry is you have a very specific use case for
On Tue 20 Oct 2020 at 15:29, Jamal Hadi Salim wrote:
> On 2020-10-19 11:18 a.m., Vlad Buslov wrote:
>>
>> On Mon 19 Oct 2020 at 16:48, Jamal Hadi Salim wrote:
>>> On 2020-10-18 8:16 a.m., Vlad Buslov wrote:
>
> [..]
>
>>> That could be a good thing, n
On Mon 19 Oct 2020 at 16:48, Jamal Hadi Salim wrote:
> On 2020-10-18 8:16 a.m., Vlad Buslov wrote:
>> On Sat 17 Oct 2020 at 14:20, Jamal Hadi Salim wrote:
>>> On 2020-10-16 12:42 p.m., Vlad Buslov wrote:
>>>
>
>>> Either one sounds appealing - the refact
On Sat 17 Oct 2020 at 14:20, Jamal Hadi Salim wrote:
> On 2020-10-16 12:42 p.m., Vlad Buslov wrote:
>
>>
>> All action print callbacks have arg==NULL check and return at the
>> beginning. To print action type we need either to have dedicated
>> 'brief_dump
On Fri 16 Oct 2020 at 19:07, Jamal Hadi Salim wrote:
> On 2020-10-16 10:42 a.m., Vlad Buslov wrote:
>> From: Vlad Buslov
>>
>> Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
>> tlv with only available flag value TCA_DUMP_FLAGS_TERSE
From: Vlad Buslov
Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when
user requested it with following example CLI (-br for 'brief'):
$ tc -s -brief filter show dev ens1f0 ingress
filte
From: Vlad Buslov
Modify implementations that return error from action_until->print_aopt()
callback to silently skip actions that don't have their corresponding
TCA_ACT_OPTIONS attribute set (some actions already behave like this). This
is necessary to support terse dump mode in followi
Implement support for terse dump mode which provides only essential
classifier/action info (handle, stats, cookie, etc.). Use new
TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from
kernel.
Vlad Buslov (2):
tc: skip actions that don't have options attribute when printing
On Fri 09 Oct 2020 at 15:45, Jamal Hadi Salim wrote:
> On 2020-10-09 8:15 a.m., Vlad Buslov wrote:
>>
>> On Fri 09 Oct 2020 at 15:03, Jamal Hadi Salim wrote:
>
>>> Which test(s)?
>>> I see for example d45e mentioning terse but i dont see corresponding
On Fri 09 Oct 2020 at 15:03, Jamal Hadi Salim wrote:
> On 2020-10-08 11:34 a.m., Vlad Buslov wrote:
>>
>> On Thu 08 Oct 2020 at 15:58, Jamal Hadi Salim wrote:
>>
>>
>> Hi Jamal,
>>
>> The existing terse dump tdc tests will have to be changed accor
On Thu 08 Oct 2020 at 15:58, Jamal Hadi Salim wrote:
> On 2020-10-07 9:40 p.m., David Ahern wrote:
>> On 9/30/20 9:59 AM, Vlad Buslov wrote:
>>> From: Vlad Buslov
>>>
>>> Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
&g
On Wed 30 Sep 2020 at 20:33, Stephen Hemminger
wrote:
> On Wed, 30 Sep 2020 08:57:20 -0700
> David Ahern wrote:
>
>> On 9/30/20 12:36 AM, Vlad Buslov wrote:
>> > From: Vlad Buslov
>> >
>> > Implement support for classifier/action terse dump u
On Wed 30 Sep 2020 at 18:57, David Ahern wrote:
> On 9/30/20 12:36 AM, Vlad Buslov wrote:
>> From: Vlad Buslov
>>
>> Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
>> tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the fla
Implement support for terse dump mode which provides only essential
classifier/action info (handle, stats, cookie, etc.). Use new
TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from
kernel.
Vlad Buslov (2):
tc: skip actions that don't have options attribute when printing
From: Vlad Buslov
Modify implementations that return error from action_until->print_aopt()
callback to silently skip actions that don't have their corresponding
TCA_ACT_OPTIONS attribute set (some actions already behave like this). This
is necessary to support terse dump mode in followi
From: Vlad Buslov
Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when
user requested it with following example CLI (-br for 'brief'):
> tc -s -br filter show dev ens1f0 ingress
In te
From: Vlad Buslov
Modify implementations that return error from action_until->print_aopt()
callback to silently skip actions that don't have their corresponding
TCA_ACT_OPTIONS attribute set (some actions already behave like this). This
is necessary to support terse dump mode in followi
Implement support for terse dump mode which provides only essential
classifier/action info (handle, stats, cookie, etc.). Use new
TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from
kernel.
Vlad Buslov (2):
tc: skip actions that don't have options attribute when printing
From: Vlad Buslov
Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when
user requested it with following example CLI:
> tc -s filter show terse dev ens1f0 ingress
In terse mode dump only outp
On Fri 25 Sep 2020 at 22:22, Cong Wang wrote:
> On Fri, Sep 25, 2020 at 8:24 AM Vlad Buslov wrote:
>> > + if (TC_ACT_EXT_CMP(a->tcfa_action, TC_ACT_GOTO_CHAIN) &&
>> > + !rcu_access_pointer(a->goto_chain)) {
>> >
t+2287853d392e4b423...@syzkaller.appspotmail.com
> Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action")
> Cc: Vlad Buslov
> Cc: Jamal Hadi Salim
> Cc: Jiri Pirko
> Signed-off-by: Cong Wang
> ---
Reviewed-by: Vlad Buslov
And this prepares for the next patch.
>
> Cc: Vlad Buslov
> Cc: Jamal Hadi Salim
> Cc: Jiri Pirko
> Signed-off-by: Cong Wang
> ---
Hi Cong,
Thanks for fixing this!
> include/net/act_api.h | 2 --
> net/sched/act_api.c| 38 ---
se we only need
>> to load modules we need potentially.
>>
>> Reported-and-tested-by: syzbot+80e32b5d1f9923f8a...@syzkaller.appspotmail.com
>> Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action")
>> Cc: Jamal Hadi Salim
>> Cc: Vlad Buslov
>
> Vla
Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action")
> Cc: Jamal Hadi Salim
> Cc: Vlad Buslov
> Cc: Jiri Pirko
> Signed-off-by: Cong Wang
> ---
Thanks for fixing this, Cong! I've verified that all tdc ife tests pass
with this patch.
Reviewed-by: Vlad Buslov
Tested-by: Vlad Buslov
On Thu 03 Sep 2020 at 18:33, syzbot
wrote:
> syzbot has bisected this issue to:
>
> commit 4e8ddd7f1758ca4ddd0c1f7cf3e66fce736241d2
> Author: Vlad Buslov
> Date: Thu Jul 5 14:24:30 2018 +
>
> net: sched: don't release reference on action overwrite
On Wed 24 Jun 2020 at 15:22, Vlad Buslov wrote:
> On Wed 24 Jun 2020 at 13:30, Pablo Neira Ayuso wrote:
>> On Wed, Jun 24, 2020 at 01:22:29PM +0300, Vlad Buslov wrote:
>>> Hi Pablo,
>>>
>>> I've encountered a new issue with indirect offloads infras
On Wed 24 Jun 2020 at 13:30, Pablo Neira Ayuso wrote:
> On Wed, Jun 24, 2020 at 01:22:29PM +0300, Vlad Buslov wrote:
>> Hi Pablo,
>>
>> I've encountered a new issue with indirect offloads infrastructure. The
>> issue is that on driver offload its indirect callback
Hi Pablo,
I've encountered a new issue with indirect offloads infrastructure. The
issue is that on driver offload its indirect callbacks are not removed
from blocks and any following offloads operations on block that has such
callback in its offloads cb list causes call to unmapped address.
Steps
uce dropped frames which is necessary for user. Status
> update shows how many filtered packets increasing and how many dropped
> in those packets.
>
> v2: Changes
> - Update commit comments suggest by Jiri Pirko.
>
> Signed-off-by: Po Liu
> ---
Reviewed-by: Vlad Buslov
On Fri 19 Jun 2020 at 12:41, dsatish wrote:
> A packet reaches OVS user space, only if, either there is no rule in
> datapath/hardware or there is race condition that the flow is added
> to hardware but before it is processed another packet arrives.
>
> It is possible hardware as part of its lim
1 - 100 of 730 matches
Mail list logo
