Re: [PATCH iproute2 net-next v2] iplink: add support for protodown reason

2020-09-06 Thread Roopa Prabhu
On 9/1/20 6:54 PM, David Ahern wrote: On 8/28/20 9:42 PM, Roopa Prabhu wrote: From: Roopa Prabhu This patch adds support for recently added link IFLA_PROTO_DOWN_REASON attribute. IFLA_PROTO_DOWN_REASON enumerates reasons for the already existing IFLA_PROTO_DOWN link attribute. $ cat /etc

Re: [PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning

2020-09-06 Thread Roopa Prabhu
odown reason") Signed-off-by: Randy Dunlap Cc: Roopa Prabhu --- Acked-by: Roopa Prabhu Thanks Randy

[PATCH iproute2 net-next v2] iplink: add support for protodown reason

2020-08-28 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support for recently added link IFLA_PROTO_DOWN_REASON attribute. IFLA_PROTO_DOWN_REASON enumerates reasons for the already existing IFLA_PROTO_DOWN link attribute. $ cat /etc/iproute2/protodown_reasons.d/r.conf 0 mlag 1 evpn 2 vrrp 3 psecurity $ ip link set

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-28 Thread Roopa Prabhu
On 8/23/20 7:20 PM, David Ahern wrote: External email: Use caution opening links or attachments On 8/20/20 9:52 PM, Roopa Prabhu wrote: +void protodown_reason_n2a(int id, char *buf, int len) +{ + if (id < 0 || id >= PROTODOWN_REASON_NUM_BITS || numeric) { since the reason is limi

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-28 Thread Roopa Prabhu
On 8/21/20 6:30 PM, Stephen Hemminger wrote: External email: Use caution opening links or attachments On Fri, 21 Aug 2020 14:09:14 -0700 Roopa Prabhu wrote: On 8/20/20 10:18 PM, Roopa Prabhu wrote: On 8/20/20 9:36 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2020 20:52:02 -0700 Roopa

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-21 Thread Roopa Prabhu
On 8/20/20 10:18 PM, Roopa Prabhu wrote: On 8/20/20 9:36 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2020 20:52:02 -0700 Roopa Prabhu wrote: + if (tb[IFLA_PROTO_DOWN]) { + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN])) + print_bool(PRINT_ANY

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-20 Thread Roopa Prabhu
On 8/20/20 9:36 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2020 20:52:02 -0700 Roopa Prabhu wrote: + if (tb[IFLA_PROTO_DOWN]) { + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN])) + print_bool(PRINT_ANY, +"proto

[PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support for recently added link IFLA_PROTO_DOWN_REASON attribute. IFLA_PROTO_DOWN_REASON enumerates reasons for the already existing IFLA_PROTO_DOWN link attribute. $ cat /etc/iproute2/protodown_reasons.d/r.conf 0 mlag 1 evpn 2 vrrp 3 psecurity $ ip link set

Re: [PATCH ethtool v5] Add QSFP-DD support

2020-08-13 Thread Roopa Prabhu
On 8/13/20 8:08 AM, Adrian Pop wrote: The Common Management Interface Specification (CMIS) for QSFP-DD shares some similarities with other form factors such as QSFP or SFP, but due to the fact that the module memory map is different, the current ethtool version is not able to provide relevant i

Re: VDPA Debug/Statistics

2020-08-11 Thread Roopa Prabhu
On 8/11/20 5:44 AM, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Tue, Aug 11, 2020 at 11:58:23AM +, Eli Cohen wrote: On Tue, Aug 11, 2020 at 11:26:20AM +, Eli Cohen wrote: Hi All Currently, the only statistics we get for a VDPA instance come

Re: [PATCH net] vxlan: fix memleak of fdb

2020-08-01 Thread Roopa Prabhu
;00003610eefa>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fixes: 3ad7a4b141eb ("vxlan: support fdb and learning in COLLECT_METADATA mode") Signed-off-by: Taehee Yoo --- Acked-by: Roopa Prabhu looks right, thanks

[PATCH net-next v2] rtnetlink: add support for protodown reason

2020-07-31 Thread Roopa Prabhu
From: Roopa Prabhu netdev protodown is a mechanism that allows protocols to hold an interface down. It was initially introduced in the kernel to hold links down by a multihoming protocol. There was also an attempt to introduce protodown reason at the time but was rejected. protodown and

Re: [PATCH net-next] rtnetlink: add support for protodown reason

2020-07-30 Thread Roopa Prabhu
On 7/30/20 4:38 PM, David Miller wrote: From: Roopa Prabhu Date: Mon, 27 Jul 2020 12:21:17 -0700 +/** + * dev_get_proto_down_reason - returns protodown reason + * + * @dev: device + */ +u32 dev_get_proto_down_reason(const struct net_device *dev) +{ + return dev->proto_down_rea

Re: [PATCH net-next] rtnetlink: add support for protodown reason

2020-07-27 Thread Roopa Prabhu
On 7/27/20 1:47 PM, Stephen Hemminger wrote: External email: Use caution opening links or attachments On Mon, 27 Jul 2020 12:21:17 -0700 Roopa Prabhu wrote: -+ nla_total_size(1) /* IFLA_PROTO_DOWN */ ++ rtnl_proto_down_size(dev) /* proto down */ Changing the

[PATCH net-next] rtnetlink: add support for protodown reason

2020-07-27 Thread Roopa Prabhu
From: Roopa Prabhu netdev protodown is a mechanism that allows protocols to hold an interface down. It was initially introduced in the kernel to hold links down by a multihoming protocol. There was also an attempt to introduce protodown reason at the time but was rejected. protodown and

[PATCH net] vxlan: fix last fdb index during dump of fdb with nhid

2020-06-24 Thread Roopa Prabhu
From: Roopa Prabhu This patch fixes last saved fdb index in fdb dump handler when handling fdb's with nhid. Fixes: 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries") Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 4 1 file changed, 4 insertions(+) diff --gi

[PATCH iproute2 net-next v2 0/2] support for fdb nexthop groups

2020-06-10 Thread Roopa Prabhu
From: Roopa Prabhu This series adds iproute2 support for recently added kernel fdb nexthop groups example: /* create fdb nexthop group */ $ip nexthop add id 12 via 172.16.1.2 fdb $ip nexthop add id 13 via 172.16.1.3 fdb $ip nexthop add id 102 group 12/13 fdb /* assign nexthop group to fdb

[PATCH iproute2 net-next v2 1/2] ipnexthop: support for fdb nexthops

2020-06-10 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to add and delete ecmp nexthops of type fdb. Such nexthops can be linked to vxlan fdb entries. $ip nexthop add id 12 via 172.16.1.2 fdb $ip nexthop add id 13 via 172.16.1.3 fdb $ip nexthop add id 102 group 12/13 fdb $bridge fdb add 02:02:00:00:00:13

[PATCH iproute2 net-next v2 2/2] bridge: support for nexthop id in fdb entries

2020-06-10 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to assign a nexthop group id to an fdb entry. $bridge fdb add 02:02:00:00:00:13 dev vx10 nhid 102 self Signed-off-by: Roopa Prabhu --- bridge/fdb.c | 22 +++--- man/man8/bridge.8 | 13 ++--- 2 files changed, 29

Re: [PATCH v2 net] nexthop: Fix fdb labeling for groups

2020-06-10 Thread Roopa Prabhu
gt; v2 > - propagate fdb_nh in remove_nh_grp_entry > > Fixes: 38428d68719c ("nexthop: support for fdb ecmp nexthops") > Cc: Roopa Prabhu > Signed-off-by: David Ahern nice cleanups. Thanks David. looks like the patches were just applied, FWIW, Acked-by: Roopa Prabhu

[PATCH iproute2 net-next 2/2] bridge: support for nexthop id in fdb entries

2020-06-08 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to assign a nexthop group id to an fdb entry. $bridge fdb add 02:02:00:00:00:13 dev vx10 nhid 102 self Signed-off-by: Roopa Prabhu --- bridge/fdb.c | 22 +++--- man/man8/bridge.8 | 13 ++--- 2 files changed, 29

[PATCH iproute2 net-next 0/2] support for fdb nexthop groups

2020-06-08 Thread Roopa Prabhu
From: Roopa Prabhu This series adds iproute2 support for recently added kernel fdb nexthop groups example: /* create fdb nexthop group */ $ip nexthop add id 12 via 172.16.1.2 fdb $ip nexthop add id 13 via 172.16.1.3 fdb $ip nexthop add id 102 group 12/13 fdb /* assign nexthop group to fdb

[PATCH iproute2 net-next 1/2] ipnexthop: support for fdb nexthops

2020-06-08 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to add and delete ecmp nexthops of type fdb. Such nexthops can be linked to vxlan fdb entries. $ip nexthop add id 12 via 172.16.1.2 fdb $ip nexthop add id 13 via 172.16.1.3 fdb $ip nexthop add id 102 group 12/13 fdb $bridge fdb add 02:02:00:00:00:13

[PATCH net-next] vxlan: fix dereference of nexthop group in nexthop update path

2020-05-30 Thread Roopa Prabhu
From: Roopa Prabhu fix dereference of nexthop group in fdb nexthop group update validation path. Fixes: 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries") Reported-by: Ido Schimmel Suggested-by: Ido Schimmel Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 4 ++-- 1 fi

Re: [PATCH net-next v2 0/3] vxlan fdb nexthop misc fixes

2020-05-30 Thread Roopa Prabhu
On Sat, May 30, 2020 at 9:59 PM David Miller wrote: > > From: Roopa Prabhu > Date: Sat, 30 May 2020 21:48:38 -0700 > > > Roopa Prabhu (3): > > vxlan: add check to prevent use of remote ip attributes with NDA_NH_ID > > vxlan: few locking fixes in nexthop

[PATCH net-next v2 2/3] vxlan: few locking fixes in nexthop event handler

2020-05-30 Thread Roopa Prabhu
From: Roopa Prabhu - remove fdb from nh_list before the rcu grace period - protect fdb->vdev with rcu - hold spin lock before destroying fdb Fixes: c7cdbe2efc40 ("vxlan: support for nexthop notifiers") Signed-off-by: Roopa Prabhu Reviewed-by: Nikolay Aleksandrov --- drivers/net

[PATCH net-next v2 0/3] vxlan fdb nexthop misc fixes

2020-05-30 Thread Roopa Prabhu
From: Roopa Prabhu Roopa Prabhu (3): vxlan: add check to prevent use of remote ip attributes with NDA_NH_ID vxlan: few locking fixes in nexthop event handler vxlan: fix dereference of nexthop group in nexthop update path drivers/net/vxlan.c | 40

[PATCH net-next v2 1/3] vxlan: add check to prevent use of remote ip attributes with NDA_NH_ID

2020-05-30 Thread Roopa Prabhu
From: Roopa Prabhu NDA_NH_ID represents a remote ip or a group of remote ips. It allows use of nexthop groups in lieu of a remote ip or a list of remote ips supported by the fdb api. Current code ignores the other remote ip attrs when NDA_NH_ID is specified. In the spirit of strict checking

[PATCH net-next v2 3/3] vxlan: fix dereference of nexthop group in nexthop update path

2020-05-30 Thread Roopa Prabhu
From: Roopa Prabhu fix dereference of nexthop group in fdb nexthop group update validation path. Fixes: 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries") Reported-by: Ido Schimmel Suggested-by: Ido Schimmel Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 4 ++-- 1 fi

Re: [PATCH] nexthop: Fix Deletion display

2020-05-30 Thread Roopa Prabhu
On Sat, May 30, 2020 at 5:16 AM Donald Sharp wrote: > > Actually display that deletions are happening > when monitoring nexthops. > > Signed-off-by: Donald Sharp > --- Acked-by: Roopa Prabhu This can go to iproute2 net Thanks Donald. > ip/ipnexthop.c | 2 +- > 1 f

Re: [PATCH net-next 0/2] vxlan fdb nexthop misc fixes

2020-05-30 Thread Roopa Prabhu
On Sat, May 30, 2020 at 6:34 AM Ido Schimmel wrote: > > On Thu, May 28, 2020 at 10:12:34PM -0700, Roopa Prabhu wrote: > > From: Roopa Prabhu > > Hi Roopa, > > I noticed that sparse complains about the following problem in > the original submission (not handled by cu

[PATCH net-next 0/2] vxlan fdb nexthop misc fixes

2020-05-28 Thread Roopa Prabhu
From: Roopa Prabhu Roopa Prabhu (2): vxlan: add check to prevent use of remote ip attributes with NDA_NH_ID vxlan: few locking fixes in nexthop event handler drivers/net/vxlan.c | 36 +--- 1 file changed, 29 insertions(+), 7 deletions(-) -- 2.1.4

[PATCH net-next 2/2] vxlan: few locking fixes in nexthop event handler

2020-05-28 Thread Roopa Prabhu
From: Roopa Prabhu - remove fdb from nh_list before the rcu grace period - protect fdb->vdev with rcu - hold spin lock before destroying fdb Fixes: c7cdbe2efc40 ("vxlan: support for nexthop notifiers") Signed-off-by: Roopa Prabhu Reviewed-by: Nikolay Aleksandrov --- drivers/net

[PATCH net-next 1/2] vxlan: add check to prevent use of remote ip attributes with NDA_NH_ID

2020-05-28 Thread Roopa Prabhu
From: Roopa Prabhu NDA_NH_ID represents a remote ip or a group of remote ips. It allows use of nexthop groups in lieu of a remote ip or a list of remote ips supported by the fdb api. Current code ignores the other remote ip attrs when NDA_NH_ID is specified. In the spirit of strict checking

Re: [PATCH net-next] vxlan: Do not assume RTNL is held in vxlan_fdb_info()

2020-05-24 Thread Roopa Prabhu
] call_timer_fn+0x1c4/0x800 > [ +0.004357] run_timer_softirq+0x129d/0x17e0 > [ +0.004762] __do_softirq+0x24c/0xaef > [ +0.004232] irq_exit+0x167/0x190 > [ +0.003767] smp_apic_timer_interrupt+0x1dd/0x6a0 > [ +0.005340] apic_timer_interrupt+0xf/0x20 > [ +0.004620] >

[PATCH net-next v4 2/5] vxlan: ecmp support for mac fdb entries

2020-05-21 Thread Roopa Prabhu
From: Roopa Prabhu Todays vxlan mac fdb entries can point to multiple remote ips (rdsts) with the sole purpose of replicating broadcast-multicast and unknown unicast packets to those remote ips. E-VPN multihoming [1,2,3] requires bridged vxlan traffic to be load balanced to remote switches

[PATCH net-next v4 4/5] vxlan: support for nexthop notifiers

2020-05-21 Thread Roopa Prabhu
From: Roopa Prabhu vxlan driver registers for nexthop add/del notifiers to cleanup fdb entries pointing to such nexthops. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH net-next v4 1/5] nexthop: support for fdb ecmp nexthops

2020-05-21 Thread Roopa Prabhu
From: Roopa Prabhu This patch introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

[PATCH net-next v4 5/5] selftests: net: add fdb nexthop tests

2020-05-21 Thread Roopa Prabhu
From: Roopa Prabhu This commit adds ipv4 and ipv6 fdb nexthop api tests to fib_nexthops.sh. Signed-off-by: Roopa Prabhu Reviewed-by: David Ahern --- tools/testing/selftests/net/fib_nexthops.sh | 160 +++- 1 file changed, 158 insertions(+), 2 deletions(-) diff --git a

[PATCH net-next v4 3/5] nexthop: add support for notifiers

2020-05-21 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds nexthop add/del notifiers. To be used by vxlan driver in a later patch. Could possibly be used by switchdev drivers in the future. Signed-off-by: Roopa Prabhu --- include/net/netns/nexthop.h | 1 + include/net/nexthop.h | 12 net/ipv4

[PATCH net-next v4 0/5] Support for fdb ECMP nexthop groups

2020-05-21 Thread Roopa Prabhu
From: Roopa Prabhu This series introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

[PATCH net-next v3 5/5] selftests: net: add fdb nexthop tests

2020-05-20 Thread Roopa Prabhu
From: Roopa Prabhu This commit adds ipv4 and ipv6 fdb nexthop api tests to fib_nexthops.sh. Signed-off-by: Roopa Prabhu Reviewed-by: David Ahern --- tools/testing/selftests/net/fib_nexthops.sh | 160 +++- 1 file changed, 158 insertions(+), 2 deletions(-) diff --git a

[PATCH net-next v3 4/5] vxlan: support for nexthop notifiers

2020-05-20 Thread Roopa Prabhu
From: Roopa Prabhu vxlan driver registers for nexthop add/del notifiers to cleanup fdb entries pointing to such nexthops. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH net-next v3 1/5] nexthop: support for fdb ecmp nexthops

2020-05-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

[PATCH net-next v3 0/5] Support for fdb ECMP nexthop groups

2020-05-20 Thread Roopa Prabhu
From: Roopa Prabhu This series introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

[PATCH net-next v3 3/5] nexthop: add support for notifiers

2020-05-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds nexthop add/del notifiers. To be used by vxlan driver in a later patch. Could possibly be used by switchdev drivers in the future. Signed-off-by: Roopa Prabhu --- include/net/netns/nexthop.h | 1 + include/net/nexthop.h | 12 net/ipv4

[PATCH net-next v3 2/5] vxlan: ecmp support for mac fdb entries

2020-05-20 Thread Roopa Prabhu
From: Roopa Prabhu Todays vxlan mac fdb entries can point to multiple remote ips (rdsts) with the sole purpose of replicating broadcast-multicast and unknown unicast packets to those remote ips. E-VPN multihoming [1,2,3] requires bridged vxlan traffic to be load balanced to remote switches

[PATCH net-next v2 4/5] vxlan: support for nexthop notifiers

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu vxlan driver registers for nexthop add/del notifiers to cleanup fdb entries pointing to such nexthops. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH net-next v2 5/5] selftests: net: add fdb nexthop tests

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu This commit adds ipv4 and ipv6 fdb api tests to fib_nexthops.sh. Signed-off-by: Roopa Prabhu --- tools/testing/selftests/net/fib_nexthops.sh | 160 +++- 1 file changed, 158 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net

[PATCH net-next v2 0/5] Support for fdb ECMP nexthop groups

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu This series introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

[PATCH net-next v2 1/5] nexthop: support for fdb ecmp nexthops

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu This patch introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

[PATCH net-next v2 3/5] nexthop: add support for notifiers

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds nexthop add/del notifiers. To be used by vxlan driver in a later patch. Could possibly be used by switchdev drivers in the future. Signed-off-by: Roopa Prabhu --- include/net/netns/nexthop.h | 1 + include/net/nexthop.h | 12 net/ipv4

[PATCH net-next v2 2/5] vxlan: ecmp support for mac fdb entries

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu Todays vxlan mac fdb entries can point to multiple remote ips (rdsts) with the sole purpose of replicating broadcast-multicast and unknown unicast packets to those remote ips. E-VPN multihoming [1,2,3] requires bridged vxlan traffic to be load balanced to remote switches

[PATCH net-next 6/6] selftests: net: add fdb nexthop tests

2020-05-18 Thread Roopa Prabhu
From: Roopa Prabhu This commit adds ipv4 and ipv6 fdb api tests to fib_nexthops.sh. Signed-off-by: Roopa Prabhu --- tools/testing/selftests/net/fib_nexthops.sh | 140 +++- 1 file changed, 138 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net

[PATCH net-next 5/6] vxlan: support for nexthop notifiers

2020-05-18 Thread Roopa Prabhu
From: Roopa Prabhu vxlan driver registers for nexthop add/del notifiers to cleanup fdb entries pointing to such nexthops. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH net-next 2/6] nexthop: support for fdb ecmp nexthops

2020-05-18 Thread Roopa Prabhu
From: Roopa Prabhu This patch introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

[PATCH net-next 0/6] Support for fdb ECMP nexthop groups

2020-05-18 Thread Roopa Prabhu
From: Roopa Prabhu This series introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

[PATCH net-next 3/6] vxlan: ecmp support for mac fdb entries

2020-05-18 Thread Roopa Prabhu
From: Roopa Prabhu Todays vxlan mac fdb entries can point to multiple remote ips (rdsts) with the sole purpose of replicating broadcast-multicast and unknown unicast packets to those remote ips. E-VPN multihoming [1,2,3] requires bridged vxlan traffic to be load balanced to remote switches

[PATCH net-next 1/6] nexthop: dereference nh only once in nexthop_select_path

2020-05-18 Thread Roopa Prabhu
ded for later vxlan patches that exposes the problem) Signed-off-by: Nikolay Aleksandrov Signed-off-by: Roopa Prabhu --- net/ipv4/nexthop.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c index 3957364..992e841 100644 -

[PATCH net-next 4/6] nexthop: add support for notifiers

2020-05-18 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds nexthop add/del notifiers. To be used by vxlan driver in a later patch. Could possibly be used by switchdev drivers in the future. Signed-off-by: Roopa Prabhu --- include/net/netns/nexthop.h | 1 + include/net/nexthop.h | 12 net/ipv4

Re: [RFC PATCH net-next 2/5] vxlan: ecmp support for mac fdb entries

2020-05-04 Thread Roopa Prabhu
On Mon, May 4, 2020 at 8:36 PM David Ahern wrote: > > On 5/4/20 4:28 PM, Roopa Prabhu wrote: > > diff --git a/include/uapi/linux/neighbour.h b/include/uapi/linux/neighbour.h > > index cd144e3..eefcda8 100644 > > --- a/include/uapi/linux/neighbour.h > > +++ b/

Re: [RFC PATCH net-next 1/5] nexthop: support for fdb ecmp nexthops

2020-05-04 Thread Roopa Prabhu
On Mon, May 4, 2020 at 8:23 PM David Ahern wrote: > > On 5/4/20 4:28 PM, Roopa Prabhu wrote: > > include/net/nexthop.h| 14 ++ > > include/uapi/linux/nexthop.h | 1 + > > net/ipv4/nexthop.c | 101 > > +-

Re: [RFC PATCH net-next 1/5] nexthop: support for fdb ecmp nexthops

2020-05-04 Thread Roopa Prabhu
On Mon, May 4, 2020 at 3:28 PM Roopa Prabhu wrote: > > From: Roopa Prabhu > > This patch introduces ecmp nexthops and nexthop groups > for mac fdb entries. In subsequent patches this is used > by the vxlan driver fdb entries. The use case is > E-VPN multihoming [1,2,3] w

[RFC PATCH net-next 4/5] vxlan: support for nexthop notifiers

2020-05-04 Thread Roopa Prabhu
From: Roopa Prabhu vxlan driver registers for nexthop add/del notifiers to cleanup fdb entries pointing to nexthops. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/net

[RFC PATCH net-next 5/5] selftests: net: add fdb nexthop tests

2020-05-04 Thread Roopa Prabhu
From: Roopa Prabhu This commit adds ipv4 and ipv6 basic fdb tests to fib_nexthops.sh. Started with a separate test script for fdb nexthops but seems like its better for basic tests to live in fib_nexthops.sh for overall nexthop API coverage. TODO: - runtime vxlan fdb tests: Its best to add test

[RFC PATCH net-next 3/5] nexthop: add support for notifiers

2020-05-04 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds nexthop add/del notifiers. To be used by vxlan driver in a later patch. Could possibly be used by switchdev drivers in the future. Signed-off-by: Roopa Prabhu --- include/net/netns/nexthop.h | 1 + include/net/nexthop.h | 12 net/ipv4

[RFC PATCH net-next 0/5] Support for fdb ECMP nexthop groups

2020-05-04 Thread Roopa Prabhu
From: Roopa Prabhu This series introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

[RFC PATCH net-next 2/5] vxlan: ecmp support for mac fdb entries

2020-05-04 Thread Roopa Prabhu
From: Roopa Prabhu Todays vxlan mac fdb entries can point to multiple remote ips (rdsts) with the sole purpose of replicating broadcast-multicast and unknown unicast packets to those remote ips. E-VPN multihoming [1,2,3] requires bridged vxlan traffic to be load balanced to remote switches

[RFC PATCH net-next 1/5] nexthop: support for fdb ecmp nexthops

2020-05-04 Thread Roopa Prabhu
From: Roopa Prabhu This patch introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps

Re: [PATCH iproute2 1/7] bridge: Use the same flag names in input and output

2020-04-29 Thread Roopa Prabhu
On Mon, Apr 27, 2020 at 4:51 PM Benjamin Poirier wrote: > > Output the same names for vlan flags as the ones accepted in command input. > > Signed-off-by: Benjamin Poirier > --- Benjamin, It's a good change, but this will break existing users ?. > bridge/vlan.c | 4 ++-- > 1 file changed, 2

Re: [RFC PATCH net-next 12/15] ipv4: Add "in hardware" indication to routes

2019-10-04 Thread Roopa Prabhu
ix is > >> in hardware but forwarding is not offloaded). > > Sounds good. Are you and Roopa OK with the below? > > > > RTM_F_IN_HW - route is in hardware > > RTM_F_OFFLOAD - route is offloaded > > > > For example, host routes will have the first flag set, wh

Re: [RFC PATCH net-next 12/15] ipv4: Add "in hardware" indication to routes

2019-10-03 Thread Roopa Prabhu
On Thu, Oct 3, 2019 at 5:59 AM Ido Schimmel wrote: > > On Wed, Oct 02, 2019 at 08:58:52AM -0700, Roopa Prabhu wrote: > > On Wed, Oct 2, 2019 at 1:41 AM Ido Schimmel wrote: > > > > > > From: Ido Schimmel > > > > > > When performing L3 off

Re: [PATCH iproute2 net-next v3 1/2] bridge: fdb get support

2019-10-02 Thread Roopa Prabhu
On Tue, Oct 1, 2019 at 7:59 AM Stephen Hemminger wrote: > > On Mon, 30 Sep 2019 21:52:22 -0700 > Roopa Prabhu wrote: > > > + > > + if (sscanf(addr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx", > > +abuf, abuf+1, abuf+2, > >

Re: [RFC PATCH net-next 12/15] ipv4: Add "in hardware" indication to routes

2019-10-02 Thread Roopa Prabhu
On Wed, Oct 2, 2019 at 1:41 AM Ido Schimmel wrote: > > From: Ido Schimmel > > When performing L3 offload, routes and nexthops are usually programmed > into two different tables in the underlying device. Therefore, the fact > that a nexthop resides in hardware does not necessarily mean that all >

[PATCH iproute2 net-next v3 0/2] support for bridge fdb and neigh get

2019-09-30 Thread Roopa Prabhu
From: Roopa Prabhu This series adds iproute2 support to lookup a bridge fdb and neigh entry. example: $bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002 02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge $ip neigh get 10.0.2.4 dev test-dummy0 10.0.2.4 dev test-dummy0 lladdr

[PATCH iproute2 net-next v3 1/2] bridge: fdb get support

2019-09-30 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to lookup a bridge fdb entry using recently added support in the kernel using RTM_GETNEIGH (and AF_BRIDGE family). example: $bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002 02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge Signed

[PATCH iproute2 net-next v3 2/2] ipneigh: neigh get support

2019-09-30 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to lookup a neigh entry using recently added support in the kernel using RTM_GETNEIGH example: $ip neigh get 10.0.2.4 dev test-dummy0 10.0.2.4 dev test-dummy0 lladdr de:ad:be:ef:13:37 PERMANENT Signed-off-by: Roopa Prabhu Tested-by: Ivan Vecera

Re: [PATCH iproute2 net-next v2 2/2] ipneigh: neigh get support

2019-09-30 Thread Roopa Prabhu
On Mon, Sep 30, 2019 at 9:42 AM David Ahern wrote: > > On 9/28/19 2:22 PM, Roopa Prabhu wrote: > > + > > + req.ndm.ndm_family = dst.family; > > + if (addattr_l(&req.n, sizeof(req), NDA_DST, &dst.data, dst.bytelen) < > > 0) > >

Re: [PATCH iproute2 net-next v2 0/2] support for bridge fdb and neigh get

2019-09-30 Thread Roopa Prabhu
On Mon, Sep 30, 2019 at 7:57 AM Ivan Vecera wrote: > > On Sat, 28 Sep 2019 13:22:08 -0700 > Roopa Prabhu wrote: > > > From: Roopa Prabhu > > > > This series adds iproute2 support to lookup a bridge fdb and > > neigh entry. > > example: > > $bridg

[PATCH iproute2 net-next v2 1/2] bridge: fdb get support

2019-09-28 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to lookup a bridge fdb entry using recently added support in the kernel using RTM_GETNEIGH (and AF_BRIDGE family). example: $bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002 02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge Signed

[PATCH iproute2 net-next v2 0/2] support for bridge fdb and neigh get

2019-09-28 Thread Roopa Prabhu
From: Roopa Prabhu This series adds iproute2 support to lookup a bridge fdb and neigh entry. example: $bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002 02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge $ip neigh get 10.0.2.4 dev test-dummy0 10.0.2.4 dev test-dummy0 lladdr

[PATCH iproute2 net-next v2 2/2] ipneigh: neigh get support

2019-09-28 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to lookup a neigh entry using recently added support in the kernel using RTM_GETNEIGH example: $ip neigh get 10.0.2.4 dev test-dummy0 10.0.2.4 dev test-dummy0 lladdr de:ad:be:ef:13:37 PERMANENT Signed-off-by: Roopa Prabhu --- ip/ipneigh.c

Re: [PATCH iproute2 net-next 1/2] bridge: fdb get support

2019-09-28 Thread Roopa Prabhu
On Sat, Sep 28, 2019 at 8:46 AM Stephen Hemminger wrote: > > On Fri, 27 Sep 2019 21:48:23 -0700 > Roopa Prabhu wrote: > > Overall, looks good. > > > + if (print_fdb(answer, (void *)stdout) < 0) { > > Cast to void is not necessary in C (it is in C++) thats a

[PATCH iproute2 net-next 2/2] ipneigh: neigh get support

2019-09-27 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to lookup a neigh entry using recently added support in the kernel using RTM_GETNEIGH example: $ip neigh get 10.0.2.4 dev test-dummy0 10.0.2.4 dev test-dummy0 lladdr de:ad:be:ef:13:37 PERMANENT Signed-off-by: Roopa Prabhu --- ip/ipneigh.c

[PATCH iproute2 net-next 1/2] bridge: fdb get support

2019-09-27 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to lookup a bridge fdb entry using recently added support in the kernel using RTM_GETNEIGH (and AF_BRIDGE family). example: $bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002 02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge Signed

[PATCH iproute2 net-next 0/2] support for bridge fdb and neigh get

2019-09-27 Thread Roopa Prabhu
From: Roopa Prabhu This series adds iproute2 support to lookup a bridge fdb and neigh entry. example: $bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002 02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge $ip neigh get 10.0.2.4 dev test-dummy0 10.0.2.4 dev test-dummy0 lladdr

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-30 Thread Roopa Prabhu
On Wed, Aug 28, 2019 at 10:26 PM Michal Kubecek wrote: > > On Wed, Aug 28, 2019 at 09:36:41PM -0700, Roopa Prabhu wrote: > > > > yes, correct. I mentioned that because I was wondering if we can > > think along the same lines for this API. > > eg > > (a)

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-28 Thread Roopa Prabhu
On Wed, Aug 28, 2019 at 12:07 AM Jiri Pirko wrote: > > Tue, Aug 27, 2019 at 05:14:49PM CEST, ro...@cumulusnetworks.com wrote: > >On Tue, Aug 27, 2019 at 2:35 AM Jiri Pirko wrote: > >> > >> Tue, Aug 27, 2019 at 10:22:42AM CEST, da...@davemloft.net wrote: > >> >From: Jiri Pirko > >> >Date: Tue, 27

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-27 Thread Roopa Prabhu
On Tue, Aug 27, 2019 at 2:35 AM Jiri Pirko wrote: > > Tue, Aug 27, 2019 at 10:22:42AM CEST, da...@davemloft.net wrote: > >From: Jiri Pirko > >Date: Tue, 27 Aug 2019 09:08:08 +0200 > > > >> Okay, so if I understand correctly, on top of separate commands for > >> add/del of alternative names, you s

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-12 Thread Roopa Prabhu
On Mon, Aug 12, 2019 at 8:40 AM Stephen Hemminger wrote: > > On Mon, 12 Aug 2019 10:31:39 +0200 > Jiri Pirko wrote: > > > Mon, Aug 12, 2019 at 03:37:26AM CEST, dsah...@gmail.com wrote: > > >On 8/11/19 7:34 PM, David Ahern wrote: > > >> On 8/10/19 12:30 AM, Jiri Pirko wrote: > > >>> Could you plea

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-12 Thread Roopa Prabhu
On Sun, Aug 11, 2019 at 3:10 PM Michal Kubecek wrote: > > On Sat, Aug 10, 2019 at 12:39:31PM -0700, Roopa Prabhu wrote: > > On Sat, Aug 10, 2019 at 8:50 AM Michal Kubecek wrote: > > > > > > On Sat, Aug 10, 2019 at 06:46:57AM -0700, Roopa Prabhu wrote: > >

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-12 Thread Roopa Prabhu
On Mon, Aug 12, 2019 at 1:31 AM Jiri Pirko wrote: > > Mon, Aug 12, 2019 at 03:37:26AM CEST, dsah...@gmail.com wrote: > >On 8/11/19 7:34 PM, David Ahern wrote: > >> On 8/10/19 12:30 AM, Jiri Pirko wrote: > >>> Could you please write me an example message of add/remove? > >> > >> altnames are for ex

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-10 Thread Roopa Prabhu
On Sat, Aug 10, 2019 at 8:50 AM Michal Kubecek wrote: > > On Sat, Aug 10, 2019 at 06:46:57AM -0700, Roopa Prabhu wrote: > > On Fri, Aug 9, 2019 at 8:46 AM Michal Kubecek wrote: > > > > > > On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > > >

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-10 Thread Roopa Prabhu
On Fri, Aug 9, 2019 at 8:46 AM Michal Kubecek wrote: > > On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > > to that point, I am also not sure why we have a new API For multiple > > names. I mean why support more than two names (existing old name and > >

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-09 Thread Roopa Prabhu
On Thu, Aug 8, 2019 at 11:25 PM Jiri Pirko wrote: > > Fri, Aug 09, 2019 at 06:11:30AM CEST, ro...@cumulusnetworks.com wrote: > >On Fri, Jul 19, 2019 at 4:00 AM Jiri Pirko wrote: > >> > >> From: Jiri Pirko > >> > >> Add two commands to add and delete alternative ifnames for net device. > >> Each

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-08 Thread Roopa Prabhu
On Fri, Jul 19, 2019 at 4:00 AM Jiri Pirko wrote: > > From: Jiri Pirko > > Add two commands to add and delete alternative ifnames for net device. > Each net device can have multiple alternative names. > > Signed-off-by: Jiri Pirko > --- > include/linux/netdevice.h | 4 ++ > include/uapi/

Re: [net-next] net: fib_rules: do not flow dissect local packets

2019-07-11 Thread Roopa Prabhu
t; fib_rule_requires_fldissect > > > > Signed-off-by: Petar Penkov > > Roopa, please review. sorry about the delay. I was traveling the last few days. looks ok to me. thanks.

Re: [PATCH net v3] vxlan: do not destroy fdb if register_netdevice() is failed

2019-06-30 Thread Roopa Prabhu
_rtnl_newlink+0xb75/0x1180 > [ 213.554119] ? rtnl_link_unregister+0x230/0x230 > [ ... ] > > Fixes: 0241b836732f ("vxlan: fix default fdb entry netlink notify ordering > during netdev create") > Suggested-by: Roopa Prabhu > Signed-off-by: Taehee Yoo Acke

Re: [PATCH net v2] vxlan: do not destroy fdb if register_netdevice() is failed

2019-06-27 Thread Roopa Prabhu
nl_newlink+0xb75/0x1180 > [ 213.554119] ? rtnl_link_unregister+0x230/0x230 > [ ... ] > > Fixes: 0241b836732f ("vxlan: fix default fdb entry netlink notify ordering > during netdev create") > Suggested-by: Roopa Prabhu > Signed-off-by: Taehee Y

Re: [PATCH net] vxlan: do not destroy fdb if register_netdevice() is failed

2019-06-25 Thread Roopa Prabhu
On Tue, Jun 25, 2019 at 9:08 AM Taehee Yoo wrote: > > On Tue, 25 Jun 2019 at 13:12, Roopa Prabhu wrote: > > > > Hi Roopa, > > Thank you for the review! > > > On Sun, Jun 23, 2019 at 7:18 PM Taehee Yoo wrote: > > > > > > On Mon, 24 Jun 2019 at

  1   2   3   4   5   6   7   8   9   10   >