Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-29 Thread Jarek Poplawski
On Wed, Dec 27, 2006 at 08:16:10AM -0800, Ben Greear wrote: > Jarek Poplawski wrote: > >On Fri, Dec 22, 2006 at 06:05:18AM -0800, Ben Greear wrote: > >>Jarek Poplawski wrote: > >>>On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: > On 20-12-2006 03:13, Ben Greear wrote: > >Th

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-28 Thread Jarek Poplawski
On Wed, Dec 27, 2006 at 08:16:10AM -0800, Ben Greear wrote: ... > The system hangs and does not recover (well, a few processes > continue on the other processor for a few minutes before they > too deadlock...) > > I am guessing this problem has been around for a while, but it > is only triggered w

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-27 Thread Ben Greear
Jarek Poplawski wrote: On Fri, Dec 22, 2006 at 06:05:18AM -0800, Ben Greear wrote: Jarek Poplawski wrote: On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: On 20-12-2006 03:13, Ben Greear wrote: This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in active use. F

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-27 Thread Jarek Poplawski
On Fri, Dec 22, 2006 at 06:05:18AM -0800, Ben Greear wrote: > Jarek Poplawski wrote: > >On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: > >>On 20-12-2006 03:13, Ben Greear wrote: > >>>This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in > >>>active use. > >>> From

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Ben Greear
Jarek Poplawski wrote: On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: On 20-12-2006 03:13, Ben Greear wrote: This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in active use. From the backtrace, I am thinking this might be a generic problem, however. Any id

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Ben Greear
Jarek Poplawski wrote: On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: On 20-12-2006 03:13, Ben Greear wrote: This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in active use. From the backtrace, I am thinking this might be a generic problem, however. Any id

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Jarek Poplawski
On Fri, Dec 22, 2006 at 10:16:30PM +1100, Herbert Xu wrote: > Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > [PATCH] igmp: spin_lock_bh in timer > > > > igmp_timer_expire() uses spin_lock(&im->lock) > > but this lock is also taken by other igmp timers, > > so it should be changed to bh version

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Herbert Xu
Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > [PATCH] igmp: spin_lock_bh in timer > > igmp_timer_expire() uses spin_lock(&im->lock) > but this lock is also taken by other igmp timers, > so it should be changed to bh version. When you're in a timer BH is already disabled. So this patch is redund

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Jarek Poplawski
On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: > [PATCH] igmp: spin_lock_bh in timer > > igmp_timer_expire() uses spin_lock(&im->lock) > but this lock is also taken by other igmp timers, > so it should be changed to bh version. ... but according to theory this doesn't matter. I

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-21 Thread Jarek Poplawski
On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: > On 20-12-2006 03:13, Ben Greear wrote: > > This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in > > active use. > > From the backtrace, I am thinking this might be a generic problem, > > however. > > > > Any ide

[PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-21 Thread Jarek Poplawski
On 20-12-2006 03:13, Ben Greear wrote: > This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in > active use. > From the backtrace, I am thinking this might be a generic problem, > however. > > Any ideas about what this could be? It seems to be reproducible every > day or > two