Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-19 Thread Vivien Didelot
Hi Andrew, On Jun 19, 2015, at 11:05 AM, Andrew Lunn and...@lunn.ch wrote: >> Yes I do have debug too, but via sysfs (with eventually write access) for: >> GLOBAL1, GLOBAL2, cpu port registers, SerDes registers, PVIDs, and VTU. >> Not really standard though. > > We should really get an implementa

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-19 Thread Andrew Lunn
> Yes I do have debug too, but via sysfs (with eventually write access) for: > GLOBAL1, GLOBAL2, cpu port registers, SerDes registers, PVIDs, and VTU. > Not really standard though. We should really get an implementation into mainline. There is no point us all implementing our own. You say your co

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-19 Thread Vivien Didelot
Hi Andrew, On Jun 17, 2015, at 9:11 PM, Andrew Lunn and...@lunn.ch wrote: > On Wed, Jun 17, 2015 at 02:09:52PM -0400, Vivien Didelot wrote: >> Hi Andrew, All, >> >> On 12/06/15 10:18, Andrew Lunn wrote: >> > By default, DSA and CPU ports are configured to the maximum speed the >> > switch support

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-17 Thread Andrew Lunn
On Wed, Jun 17, 2015 at 02:09:52PM -0400, Vivien Didelot wrote: > Hi Andrew, All, > > On 12/06/15 10:18, Andrew Lunn wrote: > > By default, DSA and CPU ports are configured to the maximum speed the > > switch supports. However there can be use cases where the peer device > > port is slower. Allow

DSA: Exposing CPU port [Was: Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex]

2015-06-17 Thread Florian Fainelli
2015-06-17 11:09 GMT-07:00 Vivien Didelot : > Hi Andrew, All, > > On 12/06/15 10:18, Andrew Lunn wrote: >> By default, DSA and CPU ports are configured to the maximum speed the >> switch supports. However there can be use cases where the peer device >> port is slower. Allow a fixed-link property to

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-17 Thread Vivien Didelot
Hi Andrew, All, On 12/06/15 10:18, Andrew Lunn wrote: > By default, DSA and CPU ports are configured to the maximum speed the > switch supports. However there can be use cases where the peer device > port is slower. Allow a fixed-link property to be used with the DSA > and CPU port in the device t

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-15 Thread Florian Fainelli
On 12/06/15 10:18, Andrew Lunn wrote: > By default, DSA and CPU ports are configured to the maximum speed the > switch supports. However there can be use cases where the peer device > port is slower. Allow a fixed-link property to be used with the DSA > and CPU port in the device tree, and use this

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-15 Thread Florian Fainelli
On 12/06/15 11:29, Guenter Roeck wrote: [snip] static int dsa_switch_setup_one(struct dsa_switch *ds, struct >>> device *parent) >>> { >>> struct dsa_switch_driver *drv = ds->drv; >>> @@ -204,6 +234,7 @@ static int dsa_switch_setup_one(struct dsa_switch >>> *ds, struct device *parent) >>>

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Andrew Lunn
On Fri, Jun 12, 2015 at 11:14:25AM -0700, Florian Fainelli wrote: > On 12/06/15 10:18, Andrew Lunn wrote: > > By default, DSA and CPU ports are configured to the maximum speed the > > switch supports. However there can be use cases where the peer device > > port is slower. Allow a fixed-link proper

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Guenter Roeck
On 06/12/2015 11:14 AM, Florian Fainelli wrote: On 12/06/15 10:18, Andrew Lunn wrote: By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA an

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Florian Fainelli
On 12/06/15 10:18, Andrew Lunn wrote: > By default, DSA and CPU ports are configured to the maximum speed the > switch supports. However there can be use cases where the peer device > port is slower. Allow a fixed-link property to be used with the DSA > and CPU port in the device tree, and use this

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Guenter Roeck
Hi Florian, On 06/12/2015 10:18 AM, Andrew Lunn wrote: By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA and CPU port in the device tree,

[PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-12 Thread Andrew Lunn
By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA and CPU port in the device tree, and use this information to configure the port. Signed-of