Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Cong Wang
On Tue, Jul 21, 2015 at 3:52 AM, Eric Dumazet eric.duma...@gmail.com wrote: On Tue, 2015-07-21 at 06:04 -0400, Jamal Hadi Salim wrote: It is worrisome to fix the core code for this. The root cause seems to be codel. Dont have time but in general, reset would be something like: struct

Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Cong Wang
On Tue, Jul 21, 2015 at 1:57 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote: - kfree_skb(skb); + INIT_LIST_HEAD(q-new_flows); + INIT_LIST_HEAD(q-old_flows); + for (i = 0; i q-flows_cnt; i++) { +

Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Eric Dumazet
On Tue, 2015-07-21 at 19:03 -0700, Cong Wang wrote: On Tue, Jul 21, 2015 at 1:57 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote: - kfree_skb(skb); + INIT_LIST_HEAD(q-new_flows); +

Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Eric Dumazet
On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote: - kfree_skb(skb); + INIT_LIST_HEAD(q-new_flows); + INIT_LIST_HEAD(q-old_flows); + for (i = 0; i q-flows_cnt; i++) { + struct fq_codel_flow *flow = q-flows + i; + + while

Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Jamal Hadi Salim
On 07/20/15 15:40, Alex Gartrell wrote: We have an application that invokes tc to delete the root every time the config changes. As a result we stress the cleanup code and were seeing the following panic: crash bt PID: 630839 TASK: 8823c990d280 CPU: 14 COMMAND: tc [... snip

Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-21 Thread Eric Dumazet
On Tue, 2015-07-21 at 06:04 -0400, Jamal Hadi Salim wrote: It is worrisome to fix the core code for this. The root cause seems to be codel. Dont have time but in general, reset would be something like: struct fq_codel_sched_data *q = qdisc_priv(sch); qdisc_reset(q) This only works for very

[PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-20 Thread Alex Gartrell
We have an application that invokes tc to delete the root every time the config changes. As a result we stress the cleanup code and were seeing the following panic: crash bt PID: 630839 TASK: 8823c990d280 CPU: 14 COMMAND: tc [... snip ...] #8 [8820ceec17a0] page_fault at