Re: [PATCH net v2] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-08-08 Thread David Miller
From: Saeed Mahameed Date: Tue, 8 Aug 2017 19:16:52 +0300 > On Thu, Aug 3, 2017 at 11:54 PM, Davide Caratti wrote: >> if the NIC fails to validate the checksum on TCP/UDP, and validation of IP >> checksum is successful, the driver subtracts the

Re: [PATCH net v2] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-08-08 Thread Saeed Mahameed
On Thu, Aug 3, 2017 at 11:54 PM, Davide Caratti wrote: > if the NIC fails to validate the checksum on TCP/UDP, and validation of IP > checksum is successful, the driver subtracts the pseudo-header checksum > from the value obtained by the hardware and sets CHECKSUM_COMPLETE.

Re: [PATCH net v2] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-08-08 Thread Saeed Mahameed
On Tue, Aug 8, 2017 at 7:06 PM, Davide Caratti wrote: > On Tue, 2017-08-08 at 18:07 +0300, Saeed Mahameed wrote: >> > { >> > __u16 length_for_csum = 0; >> > __wsum csum_pseudo_header = 0; >> > + __u8 ipproto = iph->protocol; >> > + >> > + if

Re: [PATCH net v2] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-08-08 Thread Davide Caratti
On Tue, 2017-08-08 at 18:07 +0300, Saeed Mahameed wrote: > >   { > > __u16 length_for_csum = 0; > > __wsum csum_pseudo_header = 0; > > +   __u8 ipproto = iph->protocol; > > + > > +   if (unlikely(ipproto == IPPROTO_SCTP)) > > +   return -1; > > > > Hi Davide

Re: [PATCH net v2] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-08-08 Thread Saeed Mahameed
On Thu, Aug 3, 2017 at 11:54 PM, Davide Caratti wrote: > if the NIC fails to validate the checksum on TCP/UDP, and validation of IP > checksum is successful, the driver subtracts the pseudo-header checksum > from the value obtained by the hardware and sets CHECKSUM_COMPLETE.

Re: [PATCH net v2] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-08-07 Thread David Miller
From: Davide Caratti Date: Thu, 3 Aug 2017 22:54:48 +0200 > if the NIC fails to validate the checksum on TCP/UDP, and validation of IP > checksum is successful, the driver subtracts the pseudo-header checksum > from the value obtained by the hardware and sets