Re: [PATCH] net: eth: altera: fix napi poll_list corruption

2015-09-02 Thread Atsushi Nemoto
On Wed, 2 Sep 2015 11:25:00 -0700, David Miller wrote: > Two lines below this change you are disabling interrupts anyways, > so I would suggest just moving the spin_lock_irqsave() before the > napi_gro_flush() to fix this. > > Many of the checks done by napi_complete_done() (invoked by > napi_com

[PATCH 1/1] net/ipv6: Correct PIM6 mrt_lock handling

2015-09-02 Thread Richard Laing
In the IPv6 multicast routing code the mrt_lock was not being released correctly in the MFC iterator, as a result adding or deleting a MIF would cause a hang because the mrt_lock could not be acquired. This fix is a copy of the code for the IPv4 case and ensures that the lock is released correctly

Re: [PATCH] net: eth: altera: fix napi poll_list corruption

2015-09-02 Thread Eric Dumazet
On Thu, 2015-09-03 at 09:52 +0900, Atsushi Nemoto wrote: > On Wed, 2 Sep 2015 11:25:00 -0700, David Miller wrote: > > Two lines below this change you are disabling interrupts anyways, > > so I would suggest just moving the spin_lock_irqsave() before the > > napi_gro_flush() to fix this. > > > > M

Re: [PATCH 1/1] net/ipv6: Correct PIM6 mrt_lock handling

2015-09-02 Thread Cong Wang
On Wed, Sep 2, 2015 at 6:52 PM, Richard Laing wrote: > In the IPv6 multicast routing code the mrt_lock was not being released > correctly in the MFC iterator, as a result adding or deleting a MIF would > cause a hang because the mrt_lock could not be acquired. > > This fix is a copy of the code fo

Re: [PATCH] net: eth: altera: fix napi poll_list corruption

2015-09-02 Thread David Miller
From: Atsushi Nemoto Date: Thu, 3 Sep 2015 09:52:57 +0900 > On Wed, 2 Sep 2015 11:25:00 -0700, David Miller wrote: >> Two lines below this change you are disabling interrupts anyways, >> so I would suggest just moving the spin_lock_irqsave() before the >> napi_gro_flush() to fix this. >> >> Man

net-next closure?

2015-09-02 Thread Jeff Kirsher
I was just about to send out my last series of patches and noticed you sent Linus your pull request. So I am guessing that your net-next tree is now closed, correct? Just want to make sure before sending anything out and did not want to dump patches on you right before the closure of your net-nex

[PATCH] net: wan: sbni: fix device usage count

2015-09-02 Thread Sudip Mukherjee
dev_get_by_name() will increment the usage count if the matching device is found. But we were not decrementing the count if we have got the device and the device is non-active. Signed-off-by: Sudip Mukherjee --- drivers/net/wan/sbni.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

Re: [PATCH] net: eth: altera: fix napi poll_list corruption

2015-09-02 Thread Atsushi Nemoto
On Wed, 2 Sep 2015 22:32:54 -0700, David Miller wrote: >> I think napi_gro_flush() can be called with irq enabled, so moving the >> spin_lock_irqsave() just before the __napi_complete() (or moving the >> __napi_complete() just after the spin_lock_irqsave()) would be better, >> right? > > It shoul

[net-next PATCH v2] drivers: net: cpsw: Add support to make gpio drive which slave connected to phy

2015-09-02 Thread Mugunthan V N
In DRA72x EVM, by default slave 1 is connected to the onboard phy, but slave 2 pins are also muxed with video input module which is controlled by pcf857x gpio and currently to select slave 0 to connect to phy gpio hogging is used, but with omap2plus_defconfig the pcf857x gpio is built as module. So

Re: [GIT] Networking

2015-09-02 Thread Stephen Rothwell
Hi David, On Wed, 02 Sep 2015 22:35:22 -0700 (PDT) David Miller wrote: > > The following changes since commit 4941b8f0c2b9d88e8a6dacebf8b7faf603b98368: > > Merge tag 'powerpc-4.2-4' of > git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux (2015-08-27 > 17:59:17 -0700) > > are avail

[PATCH 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-02 Thread Robert Jarzmik
Instead of using directly the OS timer through direct register access, use the standard sched_clock(), which will end up in OSCR reading anyway. This is a first step for direct access register removal and machine specific code removal from this driver. Signed-off-by: Robert Jarzmik --- drivers/

[PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-02 Thread Robert Jarzmik
Convert the pxa IRDA driver to readl and writel primitives, and remove another set of direct registers access. This leaves only the DMA registers access, which will be dealt with dmaengine conversion. Signed-off-by: Robert Jarzmik --- drivers/net/irda/pxaficp_ir.c | 210 +

[PATCH 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-02 Thread Robert Jarzmik
Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from raw DMA registers access to pxa_dma dmaengine driver, convert this driver to dmaengine. Signed-off-by: Robert Jarzmik --- drivers/net/irda/pxaficp_ir.c | 145 +- 1 file changed, 102 inse

[PATCH 0/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-02 Thread Robert Jarzmik
Hi, This serie aims at converting pxaficp_ir to dmaengine. This is almost the last driver to be converted, and once this is gone, legacy DMA support in pxa architecture can be gone. Nothing fancy here, standard readl/writel conversion, then dmaengine support. The main trouble is that I cannot te

Re: net-next closure?

2015-09-02 Thread David Miller
From: Jeff Kirsher Date: Wed, 02 Sep 2015 22:50:35 -0700 > I was just about to send out my last series of patches and noticed you > sent Linus your pull request. So I am guessing that your net-next tree > is now closed, correct? Just want to make sure before sending anything > out and did not w

<    1   2