[PATCH] e1000: disable polling before registering netdevice

2007-06-01 Thread Auke Kok
be. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Herbert Xu <[EMAIL PROTECTED]> Cc: Doug Chapman <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b

[PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

2007-06-08 Thread Auke Kok
the msg_enable member of the net_device struct. (3) Ethtool code can just modify the net_device msg_enable for drivers that do not have custom msg_enable get/set handlers so converted drivers lose some code for that as well. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/netde

[PATCH 2/2] [RFC] NET: Convert several drivers to ndev_printk

2007-06-08 Thread Auke Kok
With the generic ndev_printk macros, we can now convert network drivers to use this generic printk family for netdevices. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c| 121 +++-- drivers/net/e1000/e1000.h

[PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

2007-06-11 Thread Auke Kok
the msg_enable member of the net_device struct. (3) Ethtool code can just modify the net_device msg_enable for drivers that do not have custom msg_enable get/set handlers so converted drivers lose some code for that as well. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/netde

[PATCH 2/2] [RFC] NET: Convert several drivers to ndev_printk

2007-06-11 Thread Auke Kok
With the generic ndev_printk macros, we can now convert network drivers to use this generic printk family for netdevices. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c| 135 - drivers/net/e1000/e1000.h

[PATCH] [RFC -v3] NET: Implement a standard ndev_printk family

2007-06-11 Thread Auke Kok
. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/netdevice.h | 54 + net/core/dev.c|5 net/core/ethtool.c| 14 ++-- 3 files changed, 66 insertions(+), 7 deletions(-) diff --git a/include

[PATCH] e100: Fix Tyan motherboard e100 not receiving IPMI commands

2007-07-10 Thread Auke Kok
but this bit is not initialised, and the downlaod only specifies 0x16 bytes to be sent to the NIC (thaht's bytes 00..21d). By initializing the GMRC bit, and extending the download size for D102+ MACs, the problem is resolved. Signed-off-by: David Graham <[EMAIL PROTECTED]> Signed-off

Re: [2.6.18-rc2][e1000][swsusp] - Regression - Suspend to disk and resume breaks e1000

2006-07-16 Thread Auke Kok
Shawn Starr wrote: Hardware IBM ThinkPad T42 E1000 card info: 02:01.0 Ethernet controller: Intel Corporation 82540EP Gigabit Ethernet Controller (Mobile) (rev 03) Subsystem: IBM PRO/1000 MT Mobile Connection Flags: bus master, 66MHz, medium devsel, latency 64, IRQ 9 M

Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails

2006-07-20 Thread Auke Kok
Pavel Machek wrote: Hi! e1000 in thinkpad x60 fails without this dirty hack. What to do with it? Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> NAK, certainly this should never be merged in any tree... this is a known issue that we're tracking here: http://sourceforge.net/tracker/index.php

Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails

2006-07-21 Thread Auke Kok
Theodore Tso wrote: On Fri, Jul 21, 2006 at 06:41:05AM -0700, Andrew Morton wrote: It's completely not acceptable to run when the EEPROM checksum fails - you might even be running with the wrong MAC address, or worse. Lets fix this the right way instead. A printk which helps the user to unders

Re: Runtime power management for network interfaces

2006-07-25 Thread Auke Kok
Alan Stern wrote: During a Power Management session at the Ottawa Linux Symposium, it was generally agreed that network interface drivers ought to automatically suspend their devices (if possible) whenever: (1) The interface is ifconfig'ed down, or (2) No link is available. Presumably

[PATCH] e1000: add forgotten PCI ID for supported device

2006-07-28 Thread Auke Kok
The Intel(R) PRO/1000 82572EI card is fully supported by 7.0.33-k2 and onward. Add the device ID so this card works with 2.6.17.y onward. This device ID was accidentally omitted. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000/e1000_hw.c b/drivers/net

Re: IBM (Lenovo) T60: e1000 driver high latency

2006-07-31 Thread Auke Kok
Thomas Glanzmann wrote: Hello, [ resend because .config and the used kernel version was missing ] Linux Kernel Version: Linus Vanilla Tree; .config attached. I recently aquired a Lenovo (IBM) T60 with a e1000 network card. I experience high latency with this networkcard: Pings last upto 1 s

Re: Runtime power management for network interfaces

2006-07-31 Thread Auke Kok
Randy.Dunlap wrote: On Tue, 25 Jul 2006 09:20:06 -0700 Auke Kok wrote: Alan Stern wrote: During a Power Management session at the Ottawa Linux Symposium, it was generally agreed that network interface drivers ought to automatically suspend their devices (if possible) whenever: (1) The

[RFC] irqbalance: Mark in-kernel irqbalance as obsolete, set to N by default

2006-07-31 Thread Auke Kok
irqbalance is phased out, by marking it OBSOLETE first and (perhaps) removing the code later. The userspace irqbalance daemon written by Arjan van de Ven does a wonderful job and should be used instead. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- Kconfig | 15 +++

Re: e1000 speed/duplex error

2006-08-01 Thread Auke Kok
Jeff Kirsher wrote: On 8/1/06, a1 <[EMAIL PROTECTED]> wrote: Hi, Jeff. JK> OPTION 2: Turn auto-negotiate on the e1000 card and tell it to only JK> advertise 100 Full Duplex. This will allow negotiation between the JK> two lnk partners and the e1000 will advertise that it is only able to JK> d

Re: E1000: bug on error path in e1000_probe()

2006-08-01 Thread Auke Kok
Stephane Doyon wrote: The e1000_probe() function passes references to the netdev structure before it's actually registered. In the (admittedly obscure) case where the netdev registration fails, we are left with a dangling reference. Specifically, e1000_probe() calls netif_carrier_off(n

Re: e1000 speed/duplex error

2006-08-02 Thread Auke Kok
a1 wrote: JK> I agree. Although ethtool does not have that functionality as of yet. JK> Feel free to provide a patch to the ethtool maintainer (Jeff Garzik) JK> if you would like. I will put it on my plate of things to do, but I JK> will admit that it is near the bottom of the list of items to

Re: [2.6.18-rc2][e1000][swsusp] - Regression - Suspend to disk and resume breaks e1000 - RESOLVED Bug #6867

2006-08-02 Thread Auke Kok
Shawn Starr wrote: On Sunday 16 July 2006 12:33 pm, Auke Kok wrote: [adding netdev to the cc] unfortunately I didn't. e1000 has a special e1000_pci_save_state/e1000_pci_restore_state set of routines that save and restore the configuration space. the fact that it works for suspend to memo

Re: e1000 speed/duplex error

2006-08-02 Thread Auke Kok
a1 wrote: Hi, Auke. Auke Kok wrote: AK> Here's that part of the driver documentation: AK> $ modprobe e1000 AutoNeg=0x08 AK> e1000: :00:00.0: e1000_validate_option: AutoNeg advertising 100/FD AK> 99 /* Auto-negotiation Advertisement Override AK> 100 * AK> 101 *

Re: [bug] e100: checksum mismatch on 82551ER rev10

2006-08-02 Thread Auke Kok
[cc-ing netdev] [adding original thread authors back, please do not strip CC] Charlie Brady wrote: Molle Bestefich wrote: The NICs are working perfectly. How can you tell? Do you know if jumbo frames work correctly? Is the device properly checksumming? is flow control working properly? These a

Re: [bug] e100: checksum mismatch on 82551ER rev10

2006-08-02 Thread Auke Kok
Charlie Brady wrote: Let's assume that these things are all true, and the NIC currently does not work perfectly, just imperfectly, but acceptably. With the recent driver change, it now does not work at all. That's surely a bug in the driver. There is no logic in that sentence at all. You're s

Re: [RFC] irqbalance: Mark in-kernel irqbalance as obsolete, set to N by default

2006-08-04 Thread Auke Kok
Andrew Morton wrote: On Mon, 31 Jul 2006 10:35:26 -0700 Auke Kok <[EMAIL PROTECTED]> wrote: We've recently seen a number of user bug reports against e1000 that the in-kernel irqbalance code is detrimental to network latency. The algorithm keeps swapping irq's for NICs from cp

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-08-07 Thread Auke Kok
Linas Vepstas wrote: Resending patch from 23 June 2006; there was some confusion about whether a similar patch had already been applied; seems it wasn't. Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Acked-by: Auke

[Fwd: Fwd: [PATCH] ethtool v4: add full autoneg specify feature]

2006-08-08 Thread Auke Kok
ll supported speed's and duplex's, or one individual speed and duplex. This feature allows the user to choose which supported speed's and duplex's to advertise by using the hex value. -- Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PR

Re: [RFC][PATCH 4/9] e100 driver conversion

2006-08-08 Thread Auke Kok
Peter Zijlstra wrote: Update the driver to make use of the netdev_alloc_skb() API and the NETIF_F_MEMALLOC feature. this should be done in two separate patches. I should take care of the netdev_alloc_skb() part too for e100 (which I've already queued internally), also since ixgb still needs i

Re: [RFC][PATCH 3/9] e1000 driver conversion

2006-08-08 Thread Auke Kok
Peter Zijlstra wrote: Update the driver to make use of the NETIF_F_MEMALLOC feature. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Signed-off-by: Daniel Phillips <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) Inde

Re: [RFC][PATCH 3/9] e1000 driver conversion

2006-08-08 Thread Auke Kok
David Miller wrote: From: Auke Kok <[EMAIL PROTECTED]> Date: Tue, 08 Aug 2006 13:50:33 -0700 can we really delete these?? netdev_alloc_skb() does it for you yeah I didn't spot that patch #2 in that series introduces that code - my bad. Thanks. Auke - To unsubscribe from this

Re: [PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-15 Thread Auke Kok
Brandeburg, Jesse wrote: On Sat, 12 Aug 2006, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Since the e1000 change is non-trivial I'm not going to bypass the driver author on it, sorry. What I did do was put the netdev_alloc_skb() change into my tree, and since

Re: [patch 24/41] drivers/net/e1000/: possible cleanups

2006-08-15 Thread Auke Kok
Brandeburg <[EMAIL PROTECTED]> Cc: Jeff Kirsher <[EMAIL PROTECTED]> Cc: Auke Kok <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.c | 89 ++- drivers/net/e1000/e1000_hw.h | 32 ---

Re: e1000: ethtool -p + cable pull = system wedges hard

2006-08-15 Thread Auke Kok
Jay Vosburgh wrote: Running both 2.6.17.6 plus the e1000 7.2.7 from sourceforge, or the e1000 in netdev-2.6#upstream (7.1.9-k4). Starting up "ethtool -p ethX" then unplugging the cable connected to the identified port is causing my system to completely freeze; even sysrq is unres

Re: [E1000-devel] e1000: ethtool -p + cable pull = system wedges hard

2006-08-15 Thread Auke Kok
Auke Kok wrote: Jay Vosburgh wrote: Running both 2.6.17.6 plus the e1000 7.2.7 from sourceforge, or the e1000 in netdev-2.6#upstream (7.1.9-k4). Starting up "ethtool -p ethX" then unplugging the cable connected to the identified port is causing my system to complet

[PATCH] ethtool: Fix coalesce settings copy+paste typo

2007-11-12 Thread Auke Kok
Coalesce setting errors use the same error messages as the descriptor ring errors. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ethtool.c b/ethtool.c index 6c7a2e3..bb9dd59 100644 --- a/ethtool.c

[PATCH 2/6] e1000: update netstats traffic counters realtime

2007-11-13 Thread Auke Kok
formerly e1000/e1000e only updated traffic counters once every 2 seconds with the register values of bytes/packets. With newer code however in the interrupt and polling code we can real-time fill in these values in the netstats struct for users to see. Signed-off-by: Auke Kok <[EMAIL PROTEC

[PATCH 5/6] e1000: Secondary unicast address support

2007-11-13 Thread Auke Kok
slots, unicast filtering is disabled and all slots can be used for multicast addresses. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 47 ++-- 1 files changed, 31

[PATCH 6/6] e1000: fix schedule while atomic when called from mii-tool

2007-11-13 Thread Auke Kok
deburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index dc4934d..b7c3070 100644 --- a

[PATCH 4/6] e1000e: convert register test macros to functions

2007-11-13 Thread Auke Kok
0 14461387d drivers/net/e1000e/ethtool.o new: $ size drivers/net/e1000e/ethtool.o textdata bss dec hex filename 12498 0 0 1249830d2 drivers/net/e1000e/ethtool.o Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[

[PATCH 3/6] e1000: convert regtest macro's to functions

2007-11-13 Thread Auke Kok
: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c | 84 - 1 files changed, 55 insertions(+), 29 deletions(-) diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e10

[PATCH 1/6] e1000e: update netstats traffic counters realtime

2007-11-13 Thread Auke Kok
formerly e1000/e1000e only updated traffic counters once every 2 seconds with the register values of bytes/packets. With newer code however in the interrupt and polling code we can real-time fill in these values in the netstats struct for users to see. Signed-off-by: Auke Kok <[EMAIL PROTEC

[PATCH] ethtool: fix typo on setting speed 10000

2007-11-26 Thread Auke Kok
From: Jesse Brandeburg <[EMAIL PROTECTED]> fix the typo in speed 1 setting. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ethtool.c

[PATCH] e1000: Fix NAPI state bug when Rx complete

2007-11-27 Thread Auke Kok
Don't exit polling when we have not yet used our budget, this causes the NAPI system to end up with a messed up poll list. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/driver

[PATCH 2/2] e100: cleanup unneeded math

2007-12-05 Thread Auke Kok
No need to convert to bytes and back - cleanup unneeded code. Adapted from fix from 'Roel Kluin <[EMAIL PROTECTED]>' Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/ne

[PATCH 1/2] e1000: fix memcpy in e1000_get_strings

2007-12-05 Thread Auke Kok
and to sizeof(e1000_gstrings_test) / (ETH_GSTRING_LEN * ETH_GSTRING_LEN) A lack of parentheses around defines causes unexpected results due to operator precedences. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e100

[PATCH] e100: free IRQ to remove warningwhenrebooting

2007-12-12 Thread Auke Kok
Adapted from Ian Wienand <[EMAIL PROTECTED]> Explicitly free the IRQ before removing the device to remove a warning "Destroying IRQ without calling free_irq" Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Ian Wienand <[EMAIL PROTECTED]> --- drivers/net/e100.c |

[PATCH] ethtool: update license field in specfile to be correctly defined

2007-12-12 Thread Auke Kok
RPM uses "License" as field and not "Copyright". Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool.spec.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ethtool.spec.in b/ethtoo

[PATCH] e1000: remove no longer used code for pci read/write cfg

2007-12-13 Thread Auke Kok
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.h |2 -- drivers/net/e1000/e1000_main.c | 16 2 files changed, 0 insertions(+), 18 deletion

[PATCH] e1000: Add device IDs of blade version of the 82571 quad port

2007-08-30 Thread Auke Kok
This blade-specific board form factor is identical to the 82571EB board. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |1 + drivers/net/e1000/e1000_hw.c |1 + drivers/net/e1000/e1000_hw.h |1 + drivers/net/e1000/e1000_main.c

[PATCH] e100: timer power saving

2007-09-06 Thread Auke Kok
From: Stephen Hemminger <[EMAIL PROTECTED]> Since E100 timer is 2HZ, use rounding to make timer occur on the correct boundary. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c |3 ++- 1 files changed,

[PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-07 Thread Auke Kok
This incorporates the new napi_struct changes into e1000e. Included bugfix for ifdown hang from Krishna Kumar for e1000. Disabling polling is no longer needed at init time, so remove napi_disable() call from _probe(). Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e

[PATCH] [-MM, FIX V4] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-10 Thread Auke Kok
lling done" improperly back to the stack. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |2 ++ drivers/net/e1000e/netdev.c | 40 2 files changed, 18 insertions(+), 24 deletions(-) diff --git a/drivers/net/

[PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread Auke Kok
This incorporates the new napi_struct changes into ixgbe. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe.h |1 + drivers/net/ixgbe/ixgbe_main.c | 62 +--- 2 files changed, 27 insertions(+), 36 deletions(-) diff -

[PATCH] e1000e: Do not allow requeue of freed skb

2007-09-21 Thread Auke Kok
igned-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/netdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 372da46..03f7472 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/n

[PATCH] ethtool: Add e1000e reg dump support (using e1000 decode function)

2007-10-04 Thread Auke Kok
The e1000 register dump code can print out e1000e register dump information as well, so enable it for e1000e devices. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ethtool.c b/ethtool.c index 651529e..6

[PATCH] e1000e: fix debugging printout code

2007-10-04 Thread Auke Kok
A small bug crawled in the -DDEBUG enabled code. Fix this to properly call the backreference device name. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/hw.h |2 +- drivers/net/e1000e/netdev.c |4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff

[PATCH] e1000e: Fix ethtool register test code

2007-10-04 Thread Auke Kok
A merge/cleanup code accidentally dropped 8254x code in and removed 8257x code here. Undo this mistake and use the pci-e relevant register test similar as to what is in e1000. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/ethtool.c | 14 ++ 1 files chang

[PATCH 1/2] e1000: Simple optimizations in e1000_xmit_frame

2007-10-05 Thread Auke Kok
From: Krishna Kumar <[EMAIL PROTECTED]> Some simple optimizations in e1000_xmit_frame. Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/ne

[PATCH 2/2] e1000e: Simple optimizations in e1000_xmit_frame

2007-10-05 Thread Auke Kok
After an e1000 patch from Krishna Kumar <[EMAIL PROTECTED]>. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/netdev.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c i

[PATCH] e1000e: restore flow control settings properly

2007-10-05 Thread Auke Kok
-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/ethtool.c |1 + drivers/net/e1000e/lib.c | 12 +--- drivers/net/e1000e/netdev.c |1 + 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c

[PATCH] Seved Torstendahl <[EMAIL PROTECTED]> suggested to

2007-04-26 Thread Auke Kok
lt;[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/e100.c b/drivers/net/e100.c index 1dd1a22..7d9984a 100644 --- a/drivers/net/e100.c +++ b/drivers/net/

[PATCH] It appears that some systems still like e100 better if it uses

2007-04-26 Thread Auke Kok
From: Jesse Brandeburg <[EMAIL PROTECTED]> I/O access mode. Setting the new parameter use_io=1 will cause all driver instances to use io mapping to access the register space on the e100 device. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[

[PATCH 1/2] e1000: ROUND_UP macro cleanup in drivers/net/e1000

2007-04-27 Thread Auke Kok
From: Milind Arun Choudhary <[EMAIL PROTECTED]> E1000_ROUNDUP macro cleanup, use ALIGN Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000.h |3 --- drivers/net/e1000/e1000_ethtool.c |

[PATCH 2/2] ixgb: ROUND_UP macro cleanup in drivers/net/ixgb

2007-04-27 Thread Auke Kok
From: Milind Arun Choudhary <[EMAIL PROTECTED]> IXGB_ROUNDUP macro cleanup ,use ALIGN Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb.h |3 --- drivers/net/ixgb/ixgb_ethtool.c |4

[PATCH] [NET] Add constant for FCS/CRC length (frame check sequence)

2007-05-15 Thread Auke Kok
From: Auke Kok <[EMAIL PROTECTED]> About a dozen drivers that have some form of crc checksumming or offloading use this constant, warranting a global define for it. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/if_ether.h |1 + 1 files changed, 1 insertions(+),

[PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Auke Kok
lot better. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: H. Peter Anvin <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drive

[PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Auke Kok
lot better. All #ifdef CONFIG_PCI_MSI's have been removed. Compile tested with both CONFIG_PCI_MSI enabled and disabled. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: H. Peter Anvin <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000.h |4 +--- drivers/net/e1000/e1

[PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-16 Thread Auke Kok
Our 82571 (first PCI-E hardware) causes P-Series hardware to throw issues. Disabling PCI-E completion timeouts in our NIC resolves the issue. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Wen Xiong <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 10 ++ 1 files

[PATCH] ixgb: don't print error if pci_enable_msi() fails, cleanup minor leak

2007-05-17 Thread Auke Kok
From: Auke Kok <[EMAIL PROTECTED]> pci_enable_msi calls can fail for normal operational reasons. Driver should not print an error message in that case. Fix a leak that leaves msi enabled if pci_request_irq fails. We can remove CONFIG_PCI_MSI ifdefs alltogether Signed-off-by: Auke Kok &

[PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Auke Kok
y other call to netif_poll_enable is in e1000_up() which is only reached after a device reset or resume. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Herbert Xu <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/dri

[PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Auke Kok
y other call to netif_poll_enable is in e1000_up() which is only reached after a device reset or resume. Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339 Tested by Doug Chapman <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EM

[PATCH] [NET] ethtool: Add LRO support

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/ethtool.h |8 +++ include/linux/netdevice.h |1 + net/core/ethtool.c| 54 - 3 files changed, 62 insertions(+), 1 deletions(-) diff --git a/include/linux/ethto

[PATCH] ethtool: Add LRO support

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool-copy.h |8 ethtool.8 |8 ++-- ethtool.c | 39 +-- 3 files changed, 47 insertions(+), 8 deletions(-) diff --git a/ethtool-copy.h b/ethtool-copy.h index 3a63224..a

[PATCH] [NET] ethtool: Add support for multiple queues

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/ethtool.h | 23 +++ net/core/ethtool.c | 34 ++ 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h

[PATCH] ethtool: Add support for setting multiple rx/tx queues

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool-copy.h | 23 + ethtool.8 | 23 + ethtool.c | 103 3 files changed, 149 insertions(+), 0 deletions(-) diff --git a/ethtool-copy.h b/e

[PATCH] e1000e: Make a few functions static

2007-08-08 Thread Auke Kok
After moving code around we can reduce namespace usage by making a few functions static. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |2 -- drivers/net/e1000e/lib.c|2 +- drivers/net/e1000e/netdev.c |2 +- drivers/net/e1000e/phy.c

[PATCH] e1000e: remove duplicate shadowing reference to adapter->hw

2007-08-08 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/netdev.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index dd4eca6..741965d 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/

[PATCH] e1000e: Fix header includes

2007-08-08 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c |4 drivers/net/e1000e/e1000.h |7 --- drivers/net/e1000e/es2lan.c |5 + drivers/net/e1000e/ethtool.c |3 ++- drivers/net/e1000e/hw.h |2 ++ drivers/net/e1000e/ich8lan.c

[PATCH] [NET] ethtool: Add LRO support

2007-08-09 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/ethtool.h |8 +++ include/linux/netdevice.h |1 + net/core/ethtool.c| 53 + 3 files changed, 62 insertions(+), 0 deletions(-) diff --git a/include/linux/ethto

[PATCH] ethtool: Add LRO support

2007-08-09 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool-copy.h |8 ethtool.8 |8 ++-- ethtool.c | 39 +-- 3 files changed, 47 insertions(+), 8 deletions(-) diff --git a/ethtool-copy.h b/ethtool-copy.h index 3a63224..a

[PATCH] e1000: Add device IDs of new 82571 board variants

2007-08-09 Thread Auke Kok
This patch adds support for 2 new board variants: - A Quad port fiber 82571 board - A blade version of the 82571 quad copper board Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |2 ++ drivers/net/e1000/e1000_hw.c |5 + drivers/net

[PATCH 6/6] e1000e: Remove two compile warnings

2007-08-10 Thread Auke Kok
000e_phy_has_link_generic': drivers/net/e1000e/phy.c:1324: warning: 'ret_val' may be used uninitialized in this function Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/lib.c |2 +- drivers/net/e1000e/phy.c |2 +- 2 files changed, 2 insertions(+), 2 deletio

[PATCH 1/6] e1000e: Fix header includes [v2]

2007-08-10 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c |4 drivers/net/e1000e/e1000.h |7 --- drivers/net/e1000e/es2lan.c |5 + drivers/net/e1000e/ethtool.c |3 ++- drivers/net/e1000e/hw.h |2 ++ drivers/net/e1000e/ich8lan.c

[PATCH 3/6] e1000e: Use dma_alloc_coherent where possible

2007-08-10 Thread Auke Kok
Instead of using pci_alloc_consistent at GFP_ATOMIC we can be more reliable at startup and use dma_alloc_coherent instead with GFP_KERNEL. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/ethtool.c | 16 drivers/net/e1000e/netdev.c |9 ++--- 2

[PATCH 4/6] e1000e: Use time_after to account for jiffies wrapping

2007-08-10 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/ethtool.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c index d184116..d14cc4b 100644 --- a/drivers/net/e1000e/ethtool.c +++ b/drive

[PATCH 5/6] e1000e: error handling for pci_map_single calls.

2007-08-10 Thread Auke Kok
Add proper error handling for various callers of pci_map_single. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |2 ++ drivers/net/e1000e/ethtool.c | 16 +++--- drivers/net/e1000e/netdev.c | 49 +++--- 3

[PATCH 2/2] ethtool: add register dump support for intel 82598 chipsets (ixgbe driver)

2007-08-15 Thread Auke Kok
From: Nicholas Nunley <[EMAIL PROTECTED]> Signed-off-by: Nicholas Nunley <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- Makefile.am|2 ethtool-util.h |2 ethtool.c |1 ixgbe.c| 1017 +

[PATCH 1/2] ethtool: add register dump support for intel 82575 chipsets (igb driver)

2007-08-15 Thread Auke Kok
From: Nicholas Nunley <[EMAIL PROTECTED]> Signed-off-by: Nicholas Nunley <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- Makefile.am|2 ethtool-util.h |2 ethtool.c |1 igb.c | 864 +

[PATCH 1/3] e1000e: retire last_tx_tso workaround

2007-08-22 Thread Auke Kok
This TSO-related workaround is no longer needed since it's only applicable for 8254x silicon. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h | 15 +++ drivers/net/e1000e/netdev.c | 20 ++-- 2 files changed, 5 insert

[PATCH 2/3] e1000e: Add read code and printout of PBA number (board identifier)

2007-08-22 Thread Auke Kok
The PBA number allows customers and support to directly identify the type of board and characteristics such as different skews. Slightly enhance loading messages by adding module name to printout. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/defines.h

[PATCH 3/3] e1000e: Remove conditional packet split disable flag

2007-08-22 Thread Auke Kok
This flag conflicts with e1000's Kconfig symbol and we'll leave the feature enabled by default for now. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/netdev.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000e/ne

[PATCH] [-MM] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-08-22 Thread Auke Kok
This incorporates the new napi_struct changes into e1000e. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |2 ++ drivers/net/e1000e/netdev.c | 37 ++--- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/d

[PATCH] [-MM, FIX] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-08-23 Thread Auke Kok
This incorporates the new napi_struct changes into e1000e. Included bugfix for ifdown hang from Krishna Kumar for e1000. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |2 ++ drivers/net/e1000e/netdev.c | 35 --- 2 files c

[PATCH 2/2] e1000e: fix error checks

2007-10-15 Thread Auke Kok
From: Adrian Bunk <[EMAIL PROTECTED]> Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/ethtool.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH 1/2] e1000e: Fix debug printk macro

2007-10-15 Thread Auke Kok
Spotted by Joe Perches. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/hw.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000e/hw.h b/drivers/net/e1000e/hw.h index aa82f1a..6451578 100644 --- a/drivers/net/e1000e/hw.h +++ b/d

[PATCH] e1000e: don't poke PHY registers to retreive link status

2007-10-15 Thread Auke Kok
-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/ethtool.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c index b7a7e2a..983b031 100644 --- a/drivers/net/e1000e/eth

[PATCH 1/4] e1000e: Fix jumbo frame receive code.

2007-10-25 Thread Auke Kok
tside of the buffer_info struct anyway. Without this patch all jumbo frames are completely broken and the driver panics. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |4 +- drivers/net/e1000

[PATCH 2/4] e1000e: Fix PBA calculation for jumbo frame packets

2007-10-25 Thread Auke Kok
ach run. Without this patch jumbo's will work but performance will be awkward since the TX size is not adequate for two whole frames. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/netdev.c | 22 +- 1 files changed, 13 insertions(+), 9 dele

[PATCH 4/4] e1000e: Remove legacy jumbo frame receive code

2007-10-25 Thread Auke Kok
The legacy jumbo frame receive code is no longer needed since all hardware can do packet split and we're no longer offering a bypass kernel config option to disable packet split. Remove the unused code. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |

[PATCH 3/4] e1000e: Re-enable SECRC - crc stripping

2007-10-25 Thread Auke Kok
-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/netdev.c | 19 ++- 1 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index e87ed31..03fcc70 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drive

[PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-26 Thread Auke Kok
Trivial replacement - use INT_MAX instead here. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- drivers/net/sk98lin/skethtool.c |4 ++-- drivers/net/skge.c |8 drivers/net/sky2.c |8 3 files changed, 10 inse

[PATCH] pcnet: fix sparse triviality

2007-10-26 Thread Auke Kok
Since data can never exceed u32, it can't even be larger than LONG_MAX/HZ. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- drivers/net/pcnet32.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/pcnet32.c b/drivers/net/pcne

  1   2   3   4   >