Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

2016-06-27 Thread David Decotigny
"10baseKR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_10baseSR4_Full_BIT, > + "10baseSR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_10baseCR4_Full_BIT, > + "10baseCR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_10baseLR4_ER4_Full_BIT, > + "10baseLR4_ER4/Full" }, > }; > int indent; > int did1, new_line_pend, i; > -- > 2.1.4 > Acked-By: David Decotigny

Re: [PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2016-02-18 Thread David Decotigny
vid Decotigny wrote: >> From: David Decotigny >> >> This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by >> the new get_ksettings/set_ksettings callbacks. This API provides >> support for most legacy ethtool_cmd fields, adds support for larger >> lin

[PATCH net-next v9 15/16] net: ethtool: remove unused __ethtool_get_settings

2016-02-24 Thread David Decotigny
From: David Decotigny replaced by __ethtool_get_link_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 45 ++--- 2 files changed, 14 insertions(+), 35 deletions(-) diff --git a/include/linux

[PATCH net-next v9 16/16] net: mlx4: use new ETHTOOL_G/SSETTINGS API

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 357 +--- drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 189 insertions(+), 170

[PATCH net-next v9 12/16] net: 8021q: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 055f0e9..e416a40 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -621,12

[PATCH net-next v9 09/16] net: team: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 00558e1..2769835 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team

[PATCH net-next v9 14/16] net: core: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 4ae17c3..2b3f76f 100644 --- a/net

[PATCH net-next v9 11/16] net: rdma: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index c34c900..931a47b 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma

[PATCH net-next v9 13/16] net: bridge: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index c367b3e..b37a1cc 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -36,10 +36,10

[PATCH net-next v9 10/16] net: fcoe: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index d7597c0..641c60e

[PATCH net-next v9 01/16] net: usnic: remove unused call to ethtool_ops::get_settings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 6cdb4d2..ea003ec 100644 --- a/drivers

[PATCH net-next v9 04/16] tx4939: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx4939.c index e3733cd..402ac2e 100644 --- a/arch/mips

[PATCH net-next v9 00/16] new ETHTOOL_GLINKSETTINGS/SLINKSETTINGS API

2016-02-24 Thread David Decotigny
From: David Decotigny History: v9 - add 'link' in macro, struct and function names - rename ethtool_link_ksettings::parent -> ::base - remove un-needed mlx4 en_dbg_enabled() companion patch - note: bitmap u32[] API patches were merged separately by Kan Liang v8 - bitmap u3

[PATCH net-next v9 08/16] net: macvlan: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 426a2cc..6e953e3 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c

[PATCH net-next v9 05/16] net: usnic: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 1cf19a3..a5bfbba

[PATCH net-next v9 07/16] net: ipvlan: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index a7ca1c5..5802b90 100644 --- a/drivers/net/ipvlan

[PATCH net-next v9 02/16] net: usnic: use __ethtool_get_settings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index ea003ec..1cf19a3 100644

[PATCH net-next v9 03/16] net: ethtool: add new ETHTOOL_xLINKSETTINGS API

2016-02-24 Thread David Decotigny
From: David Decotigny This patch defines a new ETHTOOL_GLINKSETTINGS/SLINKSETTINGS API, handled by the new get_link_ksettings/set_link_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length

[PATCH net-next v9 06/16] net: bonding: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index a6527d5..b6236ff 100644 --- a/drivers/net/bonding

[ethtool PATCH v2 00/12] add support for new ETHTOOL_xLINKSETTINGS ioctls

2016-03-03 Thread David Decotigny
From: David Decotigny This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also fixes a few compilation warnings as well as a heap corruption bug. History: v2 added do_seeprom patch added netdev@ as recipient v1 initial submission

[ethtool PATCH v2 01/12] internal.h: change to new sane powerpc64 kernel headers

2016-03-03 Thread David Decotigny
ng long unsigned int', but argument 3 has type '__u64' [-Werror=format=] ctx->devname, ring_count->data); ^ Signed-off-by: David Decotigny --- internal.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/internal.h b/internal.h index b5ef

[ethtool PATCH v2 05/12] marvell.c: fix strict alias warnings

2016-03-03 Thread David Decotigny
-aliasing] marvell.c:428:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] Note: code appears endian-dependent, not fixed by this commit. Signed-off-by: David Decotigny --- marvell.c | 21 +++-- 1 file changed, 11 insertions

[ethtool PATCH v2 09/12] internal.h: fix build for latest ethtool-copy.h

2016-03-03 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- internal.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal.h b/internal.h index 5f8504d..5df8124 100644 --- a/internal.h +++ b/internal.h @@ -13,6 +13,7 @@ #ifdef HAVE_CONFIG_H #include "et

[ethtool PATCH v2 02/12] ethtool.c: don't ignore fread() return value

2016-03-03 Thread David Decotigny
From: David Decotigny This addresses: ethtool.c:1116:8: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: David Decotigny --- ethtool.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ethtool.c b

[ethtool PATCH v2 12/12] ethtool.c: use v6 socket when v4 is not available

2016-03-03 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ethtool.c b/ethtool.c index e1acf09..4daf538 100644 --- a/ethtool.c +++ b/ethtool.c @@ -4618,6 +4618,9 @@ opt_found: /* Open control socket

[ethtool PATCH v2 06/12] test-common.c: fix test_realloc(NULL, ...)

2016-03-03 Thread David Decotigny
From: Maciej Żenczykowski This fixes: test-common.c: In function 'test_realloc': test-common.c:109:8: error: 'block' may be used uninitialized in this function [-Werror=maybe-uninitialized] block = realloc(block, sizeof(*block) + size); ^ Signed-off

[ethtool PATCH v2 04/12] ethtool.c: do_seeprom checks for params & stdin sanity

2016-03-03 Thread David Decotigny
From: David Decotigny Tested: On qemu e1000: $ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 9 too much data from stdin $ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 11 not enough data from stdin $ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length

[ethtool PATCH v2 03/12] ethtool.c: fix dump_regs heap corruption

2016-03-03 Thread David Decotigny
From: David Decotigny The 'regs' pointer is owned by do_gregs(), but updated internally inside dump_regs() without propagating it back to do_gregs(): later free(regs) in do_gregs() reclaims the wrong area. This commit moves the realloc() inside do_gregs(). Signed-off-by: David

[ethtool PATCH v2 08/12] ethtool-copy.h: sync with net-next

2016-03-03 Thread David Decotigny
From: David Decotigny This cover changes up to: commit 3f1ac7a700d039c61d8d8b99f28d605d489a60cf Author: David Decotigny Date: Wed Feb 24 10:57:59 2016 -0800 net: ethtool: add new ETHTOOL_xLINKSETTINGS API Signed-off-by: David Decotigny --- ethtool-copy.h | 485

[ethtool PATCH v2 10/12] internal.h: TRUE/FALSE macros

2016-03-03 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- internal.h | 8 1 file changed, 8 insertions(+) diff --git a/internal.h b/internal.h index 5df8124..5fd87f1 100644 --- a/internal.h +++ b/internal.h @@ -42,6 +42,14 @@ typedef int32_t s32; #include "ethtool-copy.h"

[ethtool PATCH v2 11/12] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

2016-03-03 Thread David Decotigny
From: David Decotigny More info with kernel SHA1: 8d3f2806f8fbd9b22 "Merge branch 'ethtool-ksettings'". Signed-off-by: David Decotigny --- ethtool.c | 682 +++-- internal.h | 66 ++ test-cmdline.c | 12 +

[ethtool PATCH v2 07/12] test-features.c: add braces around array initialization

2016-03-03 Thread David Decotigny
From: Maciej Żenczykowski This fixes: test-features.c:21:1: error: missing braces around initializer [-Werror=missing-braces] cmd_gssetinfo = { { ETHTOOL_GSSET_INFO, 0, 1ULL << ETH_SS_FEATURES }, 34 }; ^ Signed-off-by: David Decotigny --- test-features.c | 2 +- 1 file chan

[ethtool PATCH v3 00/12] add support for new ETHTOOL_xLINKSETTINGS ioctls

2016-03-04 Thread David Decotigny
From: David Decotigny This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also fixes a few compilation warnings as well as a heap corruption bug. History: v3 TRUE/FALSE obvious-ification v2 added do_seeprom patch added netdev@ as recipient v1 initial

[ethtool PATCH v3 01/12] internal.h: change to new sane powerpc64 kernel headers

2016-03-04 Thread David Decotigny
ng long unsigned int', but argument 3 has type '__u64' [-Werror=format=] ctx->devname, ring_count->data); ^ Signed-off-by: Maciej Żenczykowski Signed-off-by: David Decotigny --- internal.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/inte

[ethtool PATCH v3 04/12] ethtool.c: do_seeprom checks for params & stdin sanity

2016-03-04 Thread David Decotigny
From: David Decotigny Tested: On qemu e1000: $ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 9 too much data from stdin $ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 11 not enough data from stdin $ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length

[ethtool PATCH v3 06/12] test-common.c: fix test_realloc(NULL, ...)

2016-03-04 Thread David Decotigny
Maciej Żenczykowski Signed-off-by: David Decotigny --- test-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-common.c b/test-common.c index adc3cd4..cd63d1d 100644 --- a/test-common.c +++ b/test-common.c @@ -100,7 +100,7 @@ void test_free(void *ptr) void *te

[ethtool PATCH v3 03/12] ethtool.c: fix dump_regs heap corruption

2016-03-04 Thread David Decotigny
From: David Decotigny The 'regs' pointer is owned by do_gregs(), but updated internally inside dump_regs() without propagating it back to do_gregs(): later free(regs) in do_gregs() reclaims the wrong area. This commit moves the realloc() inside do_gregs(). Signed-off-by: David

[ethtool PATCH v3 09/12] internal.h: fix build for latest ethtool-copy.h

2016-03-04 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- internal.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal.h b/internal.h index 5f8504d..5df8124 100644 --- a/internal.h +++ b/internal.h @@ -13,6 +13,7 @@ #ifdef HAVE_CONFIG_H #include "et

[ethtool PATCH v3 10/12] internal.h: TRUE/FALSE macros

2016-03-04 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- internal.h | 8 1 file changed, 8 insertions(+) diff --git a/internal.h b/internal.h index 5df8124..7c44d0e 100644 --- a/internal.h +++ b/internal.h @@ -42,6 +42,14 @@ typedef int32_t s32; #include "ethtool-copy.h"

[ethtool PATCH v3 11/12] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

2016-03-04 Thread David Decotigny
From: David Decotigny More info with kernel SHA1: 8d3f2806f8fbd9b22 "Merge branch 'ethtool-ksettings'". Signed-off-by: David Decotigny --- ethtool.c | 682 +++-- internal.h | 66 ++ test-cmdline.c | 12 +

[ethtool PATCH v3 05/12] marvell.c: fix strict alias warnings

2016-03-04 Thread David Decotigny
-aliasing] marvell.c:428:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] Note: code appears endian-dependent, not fixed by this commit. Signed-off-by: Maciej Żenczykowski Signed-off-by: David Decotigny --- marvell.c | 21

[ethtool PATCH v3 07/12] test-features.c: add braces around array initialization

2016-03-04 Thread David Decotigny
From: Maciej Żenczykowski This fixes: test-features.c:21:1: error: missing braces around initializer [-Werror=missing-braces] cmd_gssetinfo = { { ETHTOOL_GSSET_INFO, 0, 1ULL << ETH_SS_FEATURES }, 34 }; ^ Signed-off-by: Maciej Żenczykowski Signed-off-by: David Decotigny ---

[ethtool PATCH v3 12/12] ethtool.c: use v6 socket when v4 is not available

2016-03-04 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ethtool.c b/ethtool.c index e1acf09..4daf538 100644 --- a/ethtool.c +++ b/ethtool.c @@ -4618,6 +4618,9 @@ opt_found: /* Open control socket

[ethtool PATCH v3 08/12] ethtool-copy.h: sync with net-next

2016-03-04 Thread David Decotigny
From: David Decotigny This cover changes up to: commit 3f1ac7a700d039c61d8d8b99f28d605d489a60cf Author: David Decotigny Date: Wed Feb 24 10:57:59 2016 -0800 net: ethtool: add new ETHTOOL_xLINKSETTINGS API Signed-off-by: David Decotigny --- ethtool-copy.h | 485

[ethtool PATCH v3 02/12] ethtool.c: don't ignore fread() return value

2016-03-04 Thread David Decotigny
From: David Decotigny This addresses: ethtool.c:1116:8: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: David Decotigny --- ethtool.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ethtool.c b

Re: [PATCH net-next v5 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-16 Thread David Decotigny
you think it's preferred. On Wed, Dec 16, 2015 at 8:38 AM, David Miller wrote: > From: David Decotigny > Date: Mon, 14 Dec 2015 13:03:52 -0800 > >> +static int ethtool_get_ksettings(struct net_device *dev, void __user >> *useraddr) >> +{ &g

Re: [ethtool PATCH v4 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

2016-08-23 Thread David Decotigny
On Tue, Aug 23, 2016 at 6:30 AM, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > Enhancing link mode bits to support 25G/50G/100G > for supported and advertised speed mode bits > > Signed-off-by: Vidya Sagar Ravipati > Acked-By: David Decotigny &g

[PATCH v1] mlx4: remove unused fields

2016-09-28 Thread David Decotigny
From: David Decotigny This also can address following UBSAN warnings: [ 36.640343] [ 36.648772] UBSAN: Undefined behaviour in drivers/net/ethernet/mellanox/mlx4/fw.c:857:26 [ 36.656853] shift exponent 64 is

[PATCH iproute2 v1 2/2] iproute2: a non-expected rtnl message is an error

2016-11-11 Thread David Decotigny
--- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index dae793b..10d0afe 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -320,7 +320,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) if (n->nl

[PATCH iproute2 v1 1/2] iproute2: avoid exit in case of error.

2016-11-11 Thread David Decotigny
Be consistent with how non-0 print_route() return values are handled elesewhere: return -1. --- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index 98bfad6..dae793b 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -1743,7 +1743,7 @@ s

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-01 Thread David Decotigny
avid Miller wrote: > From: David Decotigny > Date: Mon, 30 Nov 2015 14:05:41 -0800 > >> This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by >> the new get_ksettings/set_ksettings callbacks. This API provides >> support for most legacy ethtool_cmd fiel

[PATCH net-next v4 18/19] net: mlx4: convenience predicate for debug messages

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index 35de7d2..b04054d

[PATCH net-next v4 15/19] net: bridge: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 8d1d4a2..d1022fd 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -36,10 +36,10

[PATCH net-next v4 00/19] RFC: new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-09 Thread David Decotigny
From: David Decotigny History: v4 - removed typedef for link mode bitmaps - moved bitmap<->u32[] conversion routines to bitmap.c . This is the naive implementation. I have an endian-aware version that uses memcpy/memset as much as possible, but I find it harder to follow (se

[PATCH net-next v4 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-09 Thread David Decotigny
From: David Decotigny This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by the new get_ksettings/set_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length), and removes

[PATCH net-next v4 14/19] net: 8021q: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index fded865..e607fee 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -620,12

[PATCH net-next v4 02/19] test_bitmap: unit tests for lib/bitmap.c

2015-12-09 Thread David Decotigny
From: David Decotigny This is mainly testing bitmap construction and conversion to/from u32[] for now. Tested: qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- lib/Kconfig.debug | 8 + lib/Makefile | 1 + lib

[PATCH net-next v4 12/19] net: fcoe: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index d7597c0..9049197

[PATCH net-next v4 07/19] net: usnic: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index e082170..e0d12d4

[PATCH net-next v4 04/19] net: usnic: use __ethtool_get_settings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 5b60579..e082170 100644

[PATCH net-next v4 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 344 drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 177 insertions(+), 169

[PATCH net-next v4 08/19] net: bonding: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index fe0e7a6..ce8c026 100644 --- a/drivers/net/bonding

[PATCH net-next v4 16/19] net: core: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index f88a62a..3dd4bb1 100644 --- a/net

[PATCH net-next v4 03/19] net: usnic: remove unused call to ethtool_ops::get_settings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index f8e3211..5b60579 100644 --- a/drivers

[PATCH net-next v4 01/19] lib/bitmap.c: conversion routines to/from u32 array

2015-12-09 Thread David Decotigny
From: David Decotigny Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic way. Tested: unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- include/linux/bitmap.h | 6 lib/bitmap.c | 86

[PATCH net-next v4 10/19] net: macvlan: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 06c8bfe..a95b793 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c

[PATCH net-next v4 11/19] net: team: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 059c0f6..7cc98a7 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team

[PATCH net-next v4 13/19] net: rdma: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index 1152859..1820f26 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma

[PATCH net-next v4 17/19] net: ethtool: remove unused __ethtool_get_settings

2015-12-09 Thread David Decotigny
From: David Decotigny replaced by __ethtool_get_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 45 ++--- 2 files changed, 14 insertions(+), 35 deletions(-) diff --git a/include/linux/ethtool.h

[PATCH net-next v4 06/19] tx4939: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx4939.c index e3733cd..4a3ebf6 100644 --- a/arch/mips

[PATCH net-next v4 09/19] net: ipvlan: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index a9268db..63b3aa5 100644 --- a/drivers/net/ipvlan

Re: [PATCH net-next v4 12/19] net: fcoe: use __ethtool_get_ksettings

2015-12-09 Thread David Decotigny
://github.com/0day-ci/linux/commits/David-Decotigny/RFC-new-ETHTOOL_GSETTINGS-SSETTINGS-API/20151210-022123 > config: i386-randconfig-b0-12100240 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new

[PATCH net-next v5 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-14 Thread David Decotigny
From: David Decotigny History: v5 note: please see v4 bullets for a question regarding bitmap.c - minor fix to make allyesconfig/allmodconfig v4 - removed typedef for link mode bitmaps - moved bitmap<->u32[] conversion routines to bitmap.c . This is the naive implementation. I h

[PATCH net-next v5 12/19] net: fcoe: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index d7597c0..2d5909f

[PATCH net-next v5 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 344 drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 177 insertions(+), 169

[PATCH net-next v5 14/19] net: 8021q: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index fded865..e607fee 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -620,12

[PATCH net-next v5 17/19] net: ethtool: remove unused __ethtool_get_settings

2015-12-14 Thread David Decotigny
From: David Decotigny replaced by __ethtool_get_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 45 ++--- 2 files changed, 14 insertions(+), 35 deletions(-) diff --git a/include/linux/ethtool.h

[PATCH net-next v5 13/19] net: rdma: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index 1152859..1820f26 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma

[PATCH net-next v5 16/19] net: core: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index f88a62a..3dd4bb1 100644 --- a/net

[PATCH net-next v5 08/19] net: bonding: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index fe0e7a6..ce8c026 100644 --- a/drivers/net/bonding

[PATCH net-next v5 10/19] net: macvlan: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 06c8bfe..a95b793 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c

[PATCH net-next v5 15/19] net: bridge: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 8d1d4a2..d1022fd 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -36,10 +36,10

[PATCH net-next v5 11/19] net: team: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 059c0f6..7cc98a7 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team

[PATCH net-next v5 04/19] net: usnic: use __ethtool_get_settings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 5b60579..e082170 100644

[PATCH net-next v5 06/19] tx4939: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx4939.c index e3733cd..4a3ebf6 100644 --- a/arch/mips

[PATCH net-next v5 09/19] net: ipvlan: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index a9268db..63b3aa5 100644 --- a/drivers/net/ipvlan

[PATCH net-next v5 07/19] net: usnic: use __ethtool_get_ksettings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index e082170..e0d12d4

[PATCH net-next v5 01/19] lib/bitmap.c: conversion routines to/from u32 array

2015-12-14 Thread David Decotigny
From: David Decotigny Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic way. Tested: unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- include/linux/bitmap.h | 6 lib/bitmap.c | 86

[PATCH net-next v5 03/19] net: usnic: remove unused call to ethtool_ops::get_settings

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index f8e3211..5b60579 100644 --- a/drivers

[PATCH net-next v5 02/19] test_bitmap: unit tests for lib/bitmap.c

2015-12-14 Thread David Decotigny
From: David Decotigny This is mainly testing bitmap construction and conversion to/from u32[] for now. Tested: qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- lib/Kconfig.debug | 8 + lib/Makefile | 1 + lib

[PATCH net-next v5 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-14 Thread David Decotigny
From: David Decotigny This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by the new get_ksettings/set_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length), and removes

[PATCH net-next v5 18/19] net: mlx4: convenience predicate for debug messages

2015-12-14 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index 35de7d2..b04054d

Re: What now when we're [almost] out of ADVERTISED bits?

2015-11-30 Thread David Decotigny
yes, I will update+repost. On Sun, Nov 29, 2015 at 10:11 PM, Yuval Mintz wrote: >>>> there was a work by David Decotigny that should have solved the out >>>> of bits problem here [1]. Maybe it should be revived. >>>> >>>> [1] https://lkml.org/lk

[PATCH net-next v3 17/17] net: mlx4: use new ETHTOOL_G/SSETTINGS API

2015-11-30 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 323 drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 157 insertions(+), 168

[PATCH net-next v3 14/17] net: core: use __ethtool_get_ksettings

2015-11-30 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index f88a62a..3dd4bb1 100644 --- a/net

[PATCH net-next v3 15/17] net: ethtool: remove unused __ethtool_get_settings

2015-11-30 Thread David Decotigny
From: David Decotigny replaced by __ethtool_get_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 49 ++--- 2 files changed, 14 insertions(+), 39 deletions(-) diff --git a/include/linux

[PATCH net-next v3 16/17] net: mlx4: convenience predicate for debug messages

2015-11-30 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index 35de7d2..b04054d

[PATCH net-next v3 13/17] net: bridge: use __ethtool_get_ksettings

2015-11-30 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index ec02f58..e6de008 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -36,10 +36,10

[PATCH net-next v3 11/17] net: rdma: use __ethtool_get_ksettings

2015-11-30 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index 1152859..1820f26 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma

[PATCH net-next v3 12/17] net: 8021q: use __ethtool_get_ksettings

2015-11-30 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index fded865..e607fee 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -620,12

<    1   2   3   >