Re: [netsniff-ng] [PATCH 01/15] trafgen: Move applying dynamic elements to function

2016-07-27 Thread Tobias Klauser
On 2016-07-26 at 21:35:06 +0200, Vadim Kochan wrote: > Same code for applying dynamic elements is used in both places > for slow & fast path modes, lets move them into one inlined function. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are subscribe

Re: [netsniff-ng] Re: [PATCH 00/15] trafgen: Support dinc & drnd for proto fields

2016-07-27 Thread Tobias Klauser
Nice work Vadim! This looks good from a bird's-eye view, but due to the size of the changes it will probably take me some time to review it completely and give you feedback (with the exception of patch 1/15 which is a no-brainer and I already applied it). On 2016-07-27 at 13:04:45 +0200, Vadim Koc

[netsniff-ng] [PATCH] netsniff-ng: account skipped packets as 'seen' and 'dropped'

2016-07-27 Thread Paolo Abeni
The packets filtered out due to pkt_type are incoming packets effectively dropped and should be accounted as such. This patch explicitly accounts the skipped packets number in skip_packet() and add such number to the 'drop' and 'seen' counters in update_rx_stats(). Signed-off-by: Paolo Abeni ---

[netsniff-ng] Re: [PATCH 00/15] trafgen: Support dinc & drnd for proto fields

2016-07-27 Thread Vadim Kochan
I really missed one thing related to csum - so if I have proto field with dynamic function then csum will be calculated minimum twice - after packet is build and after all dynamic fields are applied, well I have no particular solution for this, but let me know if you want to have it fixed in this s