Re: [ModemManager] [PATCH] serial: report port-not-open in queueing commands via callback instead of just returning.

2011-11-30 Thread Jirka Klimes
On Monday 28 of November 2011 21:12:23 Nathan Williams wrote: This is a followup to my previous change here; the port-not-open situation is better treated as a manageable error condition rather than a programming error. - Nathan Applied, thanks. Jirka

Re: [ModemManager] Free up a couple of dangling GErrors.

2011-11-30 Thread Jirka Klimes
On Tuesday 29 of November 2011 17:33:24 Nathan Williams wrote: After my previous change I went around looking for GError objects that were being allocated but not freed, and turned up these two. - Nathan Applied, thanks. Jirka ___

device pointer usage

2011-11-30 Thread Arend van Spriel
Hi, We are working on a wireless device driver and we create a netdev for that. Currently, we get a NetworkManager message that there is no applicable device found for the wireless connection. Can someone explain how NetworkManager knows that a device is capable for use with a wireless

Re: Query regarding a NetworkManager error-code.

2011-11-30 Thread Jirka Klimes
On Wednesday 30 of November 2011 05:03:14 Ajay Garg wrote: Hi Jirka. I have been stuck in a peculiar situation. As I said before, after adding the '802-1x' settings. I am able to connect to the WPA/WPA2-Enterprise network via ActivateConnection dbus-api. However, if I pre-save the

Re: device pointer usage

2011-11-30 Thread Jirka Klimes
On Wednesday 30 of November 2011 10:18:56 Arend van Spriel wrote: Hi, We are working on a wireless device driver and we create a netdev for that. Currently, we get a NetworkManager message that there is no applicable device found for the wireless connection. Can someone explain how

[PATCH 6/7 v2] bonding: Log slave activation/deactivation

2011-11-30 Thread Thomas Graf
[Turns out this patch depended on a patch which I have not yet submitted. This is a respin with the dependency removed.] Signed-off-by: Thomas Graf tg...@redhat.com --- src/nm-device.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/nm-device.c

[ModemManager] [PATCH] mm_gsm_parse_scan_response(): Improve regex-construction error handling

2011-11-30 Thread Nathan Williams
This was the only code in ModemManager using g_error(), and not appropriately, I think. The codebase is still mixed on how to handle errors compiling regular expressions; other places in this file use g_assert(), while the rest of the code tends to report some kind of parse-failure error. Perhaps

[ModemManager] [PATCH] Fix two bugs with multipart SMS handling: signals and listing.

2011-11-30 Thread Nathan Williams
These errors slipped through my testing last time. (For ChromeOS development, I have rigged up a black-box ModemManager test system under autotest, which creates a fake gudev device and a fake modem that responds to AT commands to test this kind of thing. It might be interesting to adapt it into

Re: [ModemManager] [PATCH] Fix two bugs with multipart SMS handling: signals and listing.

2011-11-30 Thread Aleksander Morgado
(For ChromeOS development, I have rigged up a black-box ModemManager test system under autotest, which creates a fake gudev device and a fake modem that responds to AT commands to test this kind of thing. It might be interesting to adapt it into the MM build system somehow; right now it's

Re: [ModemManager] [PATCH] mm_gsm_parse_scan_response(): Improve regex-construction error handling

2011-11-30 Thread Aleksander Morgado
This was the only code in ModemManager using g_error(), and not appropriately, I think. The codebase is still mixed on how to handle errors compiling regular expressions; other places in this file use g_assert(), while the rest of the code tends to report some kind of parse-failure error.

Re: [ModemManager] [PATCH] Fix two bugs with multipart SMS handling: signals and listing.

2011-11-30 Thread Nathan Williams
BTW, I think you forgot the patches attached. You're right, of course. Sorry about that. This time for sure. - Nathan From f29a410f4763c1237da7699853579cc0be618a66 Mon Sep 17 00:00:00 2001 From: Nathan Williams n...@chromium.org Date: Tue, 22 Nov 2011 17:55:34 -0500 Subject: [PATCH] Fix

Re: [ModemManager] [PATCH] mm_gsm_parse_scan_response(): Improve regex-construction error handling

2011-11-30 Thread Nathan Williams
And this time with the patch. - Nathan On Wed, Nov 30, 2011 at 2:07 PM, Nathan Williams n...@google.com wrote: This was the only code in ModemManager using g_error(), and not appropriately, I think. The codebase is still mixed on how to handle errors compiling regular expressions; other

Query regarding a NetworkManager error-code.

2011-11-30 Thread Ajay Garg
Hi all. I am trying to activate a connection, using python-dbus apis. Following is the log that I get in '/var/log/messages'. Nov 24 13:52:12 ajay NetworkManager[1451]: warn invalid connection Auto MTNL (acfaf1bf82e3a1b6867357124f4e3cffe4963349): 'NMSettingWirelessSecurity' / '(null)' invalid:

Query regarding a NetworkManager error-code.

2011-11-30 Thread Ajay Garg
Hi all. I am trying to activate a connection, using python-dbus apis. Following is the log that I get in '/var/log/messages'. Nov 24 13:52:12 ajay NetworkManager[1451]: invalid connection Auto MTNL (acfaf1bf82e3a1b6867357124f4e3cffe4963349): 'NMSettingWirelessSecurity' / '(null)' invalid: 3

Query regarding a NetworkManager error-code.

2011-11-30 Thread Ajay Garg
Hi all. I am trying to activate a connection, using python-dbus apis. Following is the log that I get in '/var/log/messages'. Nov 24 13:52:12 ajay NetworkManager[1451]: invalid connection Auto MTNL (acfaf1bf82e3a1b6867357124f4e3cffe4963349): 'NMSettingWirelessSecurity' / '(null)' invalid: 3

Query regarding a NetworkManager error-code.

2011-11-30 Thread Ajay Garg
Hi all. I am trying to activate a connection, using python-dbus apis. Following is the log that I get in /var/log/messages. Nov 24 13:52:12 ajay NetworkManager[1451]: invalid connection Auto MTNL (acfaf1bf82e3a1b6867357124f4e3cffe4963349): NMSettingWirelessSecurity / (null) invalid: 3 I will

Query regarding a NetworkManager error-code.

2011-11-30 Thread Ajay Garg
Hi all. I am trying to activate a connection, using python-dbus apis. Following is the log that I get in /var/log/messages. NetworkManager[1451]: invalid connection Auto MTNL (acfaf1bf82e3a1b6867357124f4e3cffe4963349): 'NMSettingWirelessSecurity' / '(null)' invalid: 3 I will be grateful if

Query regarding a NetworkManager error-code.

2011-11-30 Thread Ajay Garg
Hi all. I am trying to activate a connection, using python-dbus apis. Following is the log that I get in /var/log/messages. NetworkManager[1451]: invalid connection Auto MTNL (acfaf1bf82e3a1b6867357124f4e3cffe4963349): 'NMSettingWirelessSecurity' / '(null)' invalid: 3 I will be grateful if

Query regarding a NetworkManager error-code.

2011-11-30 Thread Ajay Garg
Hi all. I am trying to activate a connection, using python-dbus apis. Following is the log that I get in /var/log/messages. NetworkManager[1451]: invalid connection Auto MTNL (acfaf1bf82e3a1b6867357124f4e3cffe4963349): 'NMSettingWirelessSecurity' / '(null)' invalid: 3 I will be grateful if

Query regarding a NetworkManager error-code.

2011-11-30 Thread Ajay Garg
Hi all. I am trying to activate a connection, using python-dbus apis. Following is the log that I get in /var/log/messages. NetworkManager[1451]: invalid connection Auto MTNL (acfaf1bf82e3a1b6867357124f4e3cffe4963349): 'NMSettingWirelessSecurity' / '(null)' invalid: 3 I will be grateful if

Re: 3GPP interface name in MM 0.6

2011-11-30 Thread Dan Williams
On Mon, 2011-11-28 at 17:15 +0100, Aleksander Morgado wrote: Hey, According to the DBus specs [1], no element within a DBus interface can start with a digit... so org.freedesktop.ModemManager1.Modem.3gpp is a bad name. :-/ I will temporarily fallback to use:

Re: network-manager-applet fails to compile against gnome-bluetooth-3.3

2011-11-30 Thread Dan Williams
On Sat, 2011-11-26 at 12:10 -0600, Daniel Drake wrote: On Fri, Nov 25, 2011 at 9:10 AM, Daniel Drake d...@laptop.org wrote: It looks like gnome-bluetooth used to specify dbus-glib includes/libs but no longer does so. Perhaps network-manager-applet compile should use the suggested includes

Re: ttyUSB* device for ModemManager

2011-11-30 Thread Dan Williams
On Fri, 2011-11-25 at 00:45 +0530, TechnoStab wrote: Thanks Dan, I am using ZTE MF100 3g modem. I can see udev rules for the same modem in /lib/udev/rules.d/77-mm-zte-port-types.rules. ATTRS{idProduct}==0031, ENV{.MM_USBIFNUM}==03, ENV{ID_MM_ZTE_PORT_TYPE_MODEM}=1

Re: ModemManager [PATCH 2/2] Take 3 of: Improvements to SIM PIN handling - Add EnabledFacilityLocks property

2011-11-30 Thread Dan Williams
On Wed, 2011-11-23 at 20:14 +0100, Aleksander Morgado wrote: Hey hey, I guess I don't have a problem with merging them, although strictly speaking they refer to different things - locks vs. the PINs needed to unlock those locks. Yeah, you're totally right... but at the end the PIN/PUK

Re: ModemCapabilities, CurrentCapabilities and firmwares

2011-11-30 Thread Dan Williams
On Fri, 2011-11-25 at 11:21 +0100, Aleksander Morgado wrote: Hey Dan ttuttle, The 0.6 API in MM has 2 properties named ModemCapabilities and CurrentCapabilities. The current ones will be the ones reported by +GCAP, but how do we know the modem ones? On a per-driver basis if the modem has

Re: [PATCH] core: check the iface index correctly

2011-11-30 Thread Dan Williams
On Wed, 2011-11-23 at 17:06 +0800, Gary Ching-Pang Lin wrote: If the iface name is invalid, the index is -1. Applied, thanks! Dan --- src/nm-device.c |2 +- src/vpn-manager/nm-vpn-connection.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: 3GPP interface name in MM 0.6

2011-11-30 Thread Joseph Gunn
On Wed, 30 Nov 2011 17:40:21 -0600 Dan Williams d...@redhat.com wrote: On Mon, 2011-11-28 at 17:15 +0100, Aleksander Morgado wrote: Hey, According to the DBus specs [1], no element within a DBus interface can start with a digit... so org.freedesktop.ModemManager1.Modem.3gpp is a bad