Re: [ModemManager] [PATCH] mm_gsm_parse_scan_response(): Improve regex-construction error handling

2011-12-02 Thread Dan Williams
On Wed, 2011-11-30 at 17:33 -0500, Nathan Williams wrote: > And this time with the patch. Pushed, thanks. Dan > - Nathan > > On Wed, Nov 30, 2011 at 2:07 PM, Nathan Williams wrote: > > This was the only code in ModemManager using g_error(), and not > > appropriately, I think. > > The codeb

Re: [ModemManager] [PATCH] mm_gsm_parse_scan_response(): Improve regex-construction error handling

2011-11-30 Thread Nathan Williams
And this time with the patch. - Nathan On Wed, Nov 30, 2011 at 2:07 PM, Nathan Williams wrote: > This was the only code in ModemManager using g_error(), and not > appropriately, I think. > The codebase is still mixed on how to handle errors compiling regular > expressions; other places in th

Re: [ModemManager] [PATCH] mm_gsm_parse_scan_response(): Improve regex-construction error handling

2011-11-30 Thread Aleksander Morgado
> This was the only code in ModemManager using g_error(), and not > appropriately, I think. > The codebase is still mixed on how to handle errors compiling regular > expressions; other places in this file use g_assert(), while the rest > of the code tends to report some kind of parse-failure error

[ModemManager] [PATCH] mm_gsm_parse_scan_response(): Improve regex-construction error handling

2011-11-30 Thread Nathan Williams
This was the only code in ModemManager using g_error(), and not appropriately, I think. The codebase is still mixed on how to handle errors compiling regular expressions; other places in this file use g_assert(), while the rest of the code tends to report some kind of parse-failure error. Perhaps t