Re: [patch] first pass at gnome-keyring support, baby.

2005-06-23 Thread Robert Love
On Thu, 2005-06-23 at 12:34 -0400, Dan Williams wrote: > Netapplet doesn't have problems because it doesn't talk to the card > much, it just does a few iwconfigs and some scanning. NetworkManager is > touching the card quite a bit, in regular intervals, and probably > exposes more bugs in drivers

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-23 Thread Dan Williams
On Thu, 2005-06-23 at 12:22 -0400, Robert Love wrote: > #1 sounds like me. I have the right firmware. It works in Netapplet > but it could just be behavioral differences that induce it in > NetworkManager more readily. > > I'll get backtraces next time it happens. I got some last night (not > s

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-23 Thread Robert Love
On Wed, 2005-06-22 at 22:19 -0400, Dan Williams wrote: > Quite right. At this time NM queries nm-applet for all networks when it gets > the NameOwnerChanged. What you propose sounds reasonable. We don't really > _need_ the key until we try to connect to the access point. Agreed. > [1] Actua

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-23 Thread Robert Love
On Thu, 2005-06-23 at 09:46 -0400, Dan Williams wrote: > So if we do lazy passphrase requests we'll have to make passphrase > requests from NMI pretty much like the current "Enter a new WEP key" > thing. ie, we can't connect to the access point until we have the > passphrase/key, and so we need t

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-23 Thread Peter Jones
On Thu, 2005-06-23 at 10:33 -0400, Bill Peck wrote: > Is there a technical reason why the keyring can't be unlocked by the > login? (Obviously the passwords would have to be the same) I know I'm > thinking in fairy land where we might have single sign on one day.. but > I can dream can't I? Well,

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-23 Thread David Zeuthen
On Thu, 2005-06-23 at 10:33 -0400, Bill Peck wrote: > Is there a technical reason why the keyring can't be unlocked by the > login? (Obviously the passwords would have to be the same) I know I'm > thinking in fairy land where we might have single sign on one day.. but > I can dream can't I? The ha

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-23 Thread Bill Peck
On Thu, 2005-06-23 at 09:46 -0400, Dan Williams wrote: > On Thu, 2005-06-23 at 00:11 -0400, Robert Love wrote: > > On Wed, 2005-06-22 at 23:49 -0400, David Zeuthen wrote: > > > > > So, I guess my point is that we shouldn't care too much about annoying > > > gnome-keyring dialogs at this point. Not

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-23 Thread Dan Williams
On Thu, 2005-06-23 at 00:11 -0400, Robert Love wrote: > On Wed, 2005-06-22 at 23:49 -0400, David Zeuthen wrote: > > > So, I guess my point is that we shouldn't care too much about annoying > > gnome-keyring dialogs at this point. Not that it doesn't matter, cause > > it does, however all that work

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-22 Thread Robert Love
On Wed, 2005-06-22 at 23:49 -0400, David Zeuthen wrote: > So, I guess my point is that we shouldn't care too much about annoying > gnome-keyring dialogs at this point. Not that it doesn't matter, cause > it does, however all that work is elsewhere really. Nod. We can do a lot better, though. Ri

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-22 Thread David Zeuthen
On Wed, 2005-06-22 at 22:20 -0400, Colin Walters wrote: > On Wed, 2005-06-22 at 22:02 -0400, Robert Love wrote: > > Attached patch adds support for gnome-keyring to nm-applet and stores > > the essid key encrypted in the keyring instead of cleartext in gconf. > > > > It is a first pass, but it see

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-22 Thread Robert Love
On Wed, 2005-06-22 at 22:20 -0400, Colin Walters wrote: > Offtopic, but IMO we should just get rid of that dialog (and the whole > keyring access control). It is a pretty small barrier versus a > compromised application, confusing to users, and it's also annoying. I'm not talking about the "Shou

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-22 Thread Colin Walters
On Wed, 2005-06-22 at 22:02 -0400, Robert Love wrote: > Attached patch adds support for gnome-keyring to nm-applet and stores > the essid key encrypted in the keyring instead of cleartext in gconf. > > It is a first pass, but it seems to work well [1]. > > One issue is it causes the gnome-keyring

Re: [patch] first pass at gnome-keyring support, baby.

2005-06-22 Thread Dan Williams
On Wed, 22 Jun 2005, Robert Love wrote: > Attached patch adds support for gnome-keyring to nm-applet and stores > the essid key encrypted in the keyring instead of cleartext in gconf. > > It is a first pass, but it seems to work well [1]. > > One issue is it causes the gnome-keyring "decrypt you

[patch] first pass at gnome-keyring support, baby.

2005-06-22 Thread Robert Love
Attached patch adds support for gnome-keyring to nm-applet and stores the essid key encrypted in the keyring instead of cleartext in gconf. It is a first pass, but it seems to work well [1]. One issue is it causes the gnome-keyring "decrypt your keyring" dialog to pop up as soon as the applet loa