shreemaan-abhishek merged PR #11076:
URL: https://github.com/apache/apisix/pull/11076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shreemaan-abhishek commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1541332469
##
t/plugin/key-auth.t:
##
@@ -23,6 +23,31 @@ use t::APISIX 'no_plan';
repeat_each(2);
no_long_string();
no_root_location();
+
starsz commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1540720522
##
t/plugin/key-auth.t:
##
@@ -23,6 +23,31 @@ use t::APISIX 'no_plan';
repeat_each(2);
no_long_string();
no_root_location();
+
+add_block_preprocessor(sub {
+my
shreemaan-abhishek commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1536768360
##
t/plugin/key-auth.t:
##
@@ -23,6 +23,31 @@ use t::APISIX 'no_plan';
repeat_each(2);
no_long_string();
no_root_location();
+
shreemaan-abhishek commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1535104890
##
t/plugin/key-auth.t:
##
@@ -23,6 +23,31 @@ use t::APISIX 'no_plan';
repeat_each(2);
no_long_string();
no_root_location();
+
shreemaan-abhishek commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1535103969
##
apisix/plugin.lua:
##
@@ -907,7 +907,7 @@ local function enable_gde()
if enable_data_encryption == nil then
enable_data_encryption =
shreemaan-abhishek commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1536768092
##
t/admin/consumers.t:
##
@@ -87,7 +87,7 @@ passed
"desc": "new consumer",
"plugins": {
shreemaan-abhishek commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1536767842
##
apisix/plugin.lua:
##
@@ -907,7 +907,7 @@ local function enable_gde()
if enable_data_encryption == nil then
enable_data_encryption =
shreemaan-abhishek commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1535104890
##
t/plugin/key-auth.t:
##
@@ -23,6 +23,31 @@ use t::APISIX 'no_plan';
repeat_each(2);
no_long_string();
no_root_location();
+
shreemaan-abhishek commented on code in PR #11076:
URL: https://github.com/apache/apisix/pull/11076#discussion_r1535103969
##
apisix/plugin.lua:
##
@@ -907,7 +907,7 @@ local function enable_gde()
if enable_data_encryption == nil then
enable_data_encryption =
moonming commented on PR #11076:
URL: https://github.com/apache/apisix/pull/11076#issuecomment-2014406380
> > Expected behavior is to not update
>
>
>
> By default `encrypt_fields` will be updated to true (only in the
`config-default.yaml`, the users still have the freedom to
shreemaan-abhishek commented on PR #11076:
URL: https://github.com/apache/apisix/pull/11076#issuecomment-2014324909
> Expected behavior is to not update
By default `encrypt_fields` will be updated to true, the users still have
the freedom to set it to `false`.
--
This is an
moonming commented on PR #11076:
URL: https://github.com/apache/apisix/pull/11076#issuecomment-2014285960
If a user upgrades APISIX from an old version to a new version, will this
configuration be updated? Expected behavior is to not update
--
This is an automated message from the Apache
shreemaan-abhishek commented on PR #11076:
URL: https://github.com/apache/apisix/pull/11076#issuecomment-2012205949
I suppose test cases are not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
shreemaan-abhishek opened a new pull request, #11076:
URL: https://github.com/apache/apisix/pull/11076
### Description
Fixes https://lists.apache.org/thread/30wf080qvrzokronrx283sy8x8kondqf
### Checklist
- [x] I have explained the need for this PR and the
15 matches
Mail list logo
