Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/3143944c30f340208be40e9452e2e5be2e4a33be#commitcomment-29574608
In src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
In src/main/java/org/codehaus/groovy/ast/tools/GenericsU
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/3143944c30f340208be40e9452e2e5be2e4a33be#commitcomment-29574669
In src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
In src/main/java/org/codehaus/groovy/ast/tools/Generic
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/a798866fcfd98f7b2cd46e948b37217a8349f609#commitcomment-29728201
Some tests failed. It seems that picocli 3.3.0 is not compatible with 3.2.0
https://travis-ci.org/apache/groovy/jobs
Github user remkop commented on the pull request:
https://github.com/apache/groovy/commit/a798866fcfd98f7b2cd46e948b37217a8349f609#commitcomment-29728904
Thanks for the heads up!
The test fails because of a change in the error message format. Iâll fix
it tonight and Iâll make
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/ec7b147b4b90c55e1d117f3bac63b060eeb79386#commitcomment-30043824
`UnlimitedConcurrentCache`'s `getAndPut` on 2.5 branch is not thread safe,
so the commit is only for the master.
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/ed3814a053eee8a4480c85c23485e161fd74c16a#commitcomment-30046088
Nice! The codebase is much cleaner than before :-)
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/35a3df1436b76f315a925f7d30479c8d092805c0#commitcomment-30151884
GROOVY-8741: Make single character GString behave like similar String in
'==' #782
---
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/groovy/commit/a7ebe87b8cb4ff7ce220a13af96788118d316006#commitcomment-30426446
In subprojects/groovy-test-junit5/build.gradle:
In subprojects/groovy-test-junit5/build.gradle on line 28:
Platfor
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/a7ebe87b8cb4ff7ce220a13af96788118d316006#commitcomment-30427238
In subprojects/groovy-test-junit5/build.gradle:
In subprojects/groovy-test-junit5/build.gradle on line 28:
Thanks Pasca
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/groovy/commit/a7ebe87b8cb4ff7ce220a13af96788118d316006#commitcomment-30427718
In subprojects/groovy-test-junit5/build.gradle:
In subprojects/groovy-test-junit5/build.gradle on line 28:
Great!
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/522fd4996b6314caa05d16590f3896bf750eb83e#commitcomment-30515521
I've merged the commit into https://github.com/danielsun1106/groovy-parser
with your information reserved :-)
http
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/fd21ad4e3b6d2a4297944d079ba8948e8d8e6052#commitcomment-30846491
Using Java 8 API causes the test failure when running on Java 7
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/fd21ad4e3b6d2a4297944d079ba8948e8d8e6052#commitcomment-30846605
True, I'll fix
---
Github user pditommaso commented on the pull request:
https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075266
Out of curiosity, what's the benefit of caching classes using as key the
source hash code instead of the class name?
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075542
e.g. GroovyShell evaluates same script with different file names, which
results in loading classes repeatedly and the classe
Github user pditommaso commented on the pull request:
https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075630
Oh, right! I was missing the the groovy shell gives to the same script
different file names. But in this case would not make mo
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075653
No one can assure Groovy users will not create GroovyCodeSource instances
with different names for the same source code. The
Github user pditommaso commented on the pull request:
https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075820
ð
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7d2d6319f694b87fc4e646d3d22679315e1411bf#commitcomment-31185553
In src/main/java/org/apache/groovy/ast/tools/ExpressionUtils.java:
In src/main/java/org/apache/groovy/ast/tools/Expressio
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7d2d6319f694b87fc4e646d3d22679315e1411bf#commitcomment-31185822
In src/main/java/org/apache/groovy/ast/tools/ExpressionUtils.java:
In src/main/java/org/apache/groovy/ast/tools/ExpressionU
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/f646e6e12abc3d1a9db0dcff74ff22ecadd986ca#commitcomment-18037282
In gradle/wrapper/gradle-wrapper.properties:
In gradle/wrapper/gradle-wrapper.properties on line 6:
We should disable t
Github user paplorinc commented on the pull request:
https://github.com/apache/groovy/commit/f646e6e12abc3d1a9db0dcff74ff22ecadd986ca#commitcomment-18069008
In gradle/wrapper/gradle-wrapper.properties:
In gradle/wrapper/gradle-wrapper.properties on line 6:
Travis builds for JDK
Github user paplorinc commented on the pull request:
https://github.com/apache/groovy/commit/f646e6e12abc3d1a9db0dcff74ff22ecadd986ca#commitcomment-18069445
In gradle/wrapper/gradle-wrapper.properties:
In gradle/wrapper/gradle-wrapper.properties on line 6:
Replaced it with JDK
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/f646e6e12abc3d1a9db0dcff74ff22ecadd986ca#commitcomment-18081357
In gradle/wrapper/gradle-wrapper.properties:
In gradle/wrapper/gradle-wrapper.properties on line 6:
TeamCity CI should
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/groovy/commit/e21d6226b9a4cc411fb0e7d24cf7b6023edc9002#commitcomment-18124607
Nice :+1: I thought nobody would ever fix these tests.
---
If your project is set up for it, you can reply to this emai
Github user paplorinc commented on the pull request:
https://github.com/apache/groovy/commit/ffc24888098019383272c66d90e746bb4139a74e#commitcomment-18176397
In src/main/groovy/lang/ObjectRange.java:
In src/main/groovy/lang/ObjectRange.java on line 384:
Would it be possible to m
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/ffc24888098019383272c66d90e746bb4139a74e#commitcomment-18186653
In src/main/groovy/lang/ObjectRange.java:
In src/main/groovy/lang/ObjectRange.java on line 384:
My preference is defini
Github user paplorinc commented on the pull request:
https://github.com/apache/groovy/commit/ffc24888098019383272c66d90e746bb4139a74e#commitcomment-18186791
In src/main/groovy/lang/ObjectRange.java:
In src/main/groovy/lang/ObjectRange.java on line 384:
I thought I removed all c
Github user paplorinc commented on the pull request:
https://github.com/apache/groovy/commit/a009d432a7daa83094d59181addb14f64d0f857a#commitcomment-18186811
In src/main/groovy/lang/ObjectRange.java:
In src/main/groovy/lang/ObjectRange.java on line 530:
Again, could you please m
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/380ae614ae4d979f00e6e362d210e2dd1295bdce#commitcomment-18187118
In build.gradle:
In build.gradle on line 142:
I noticed that this broke japicmp. I know we have that disabled at the
m
Github user melix commented on the pull request:
https://github.com/apache/groovy/commit/a903c9e330af224006380af0f56afa98c0cc6b64#commitcomment-18257989
In src/main/groovy/lang/ObjectRange.java:
In src/main/groovy/lang/ObjectRange.java on line 237:
This is a binary breaking cha
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/a903c9e330af224006380af0f56afa98c0cc6b64#commitcomment-18259964
In src/main/groovy/lang/ObjectRange.java:
In src/main/groovy/lang/ObjectRange.java on line 237:
You're right. Unfortuna
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/584d4d405061a08c317ea1297c2833f93445bcb7#commitcomment-18553681
In src/spec/test/SyntaxTest.groovy:
In src/spec/test/SyntaxTest.groovy on line 169:
I think we should delete these unus
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/584d4d405061a08c317ea1297c2833f93445bcb7#commitcomment-18561203
In src/spec/test/SyntaxTest.groovy:
In src/spec/test/SyntaxTest.groovy on line 169:
Thanks for pointing that out. I
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/584d4d405061a08c317ea1297c2833f93445bcb7#commitcomment-18598788
In src/spec/test/SyntaxTest.groovy:
In src/spec/test/SyntaxTest.groovy on line 169:
I removed the unused tags and sin
Github user baybatu commented on the pull request:
https://github.com/apache/groovy/commit/3ed1c5c48e97007c83404149764b1163dcaf39e3#commitcomment-18601444
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods
Github user fmamud commented on the pull request:
https://github.com/apache/groovy/commit/3ed1c5c48e97007c83404149764b1163dcaf39e3#commitcomment-18607071
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.
Github user baybatu commented on the pull request:
https://github.com/apache/groovy/commit/3ed1c5c48e97007c83404149764b1163dcaf39e3#commitcomment-18632930
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods
Github user melix commented on the pull request:
https://github.com/apache/groovy/commit/6a203d2ca24c521d116054636888198b8b0cf20e#commitcomment-18806770
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.j
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/6a203d2ca24c521d116054636888198b8b0cf20e#commitcomment-18806944
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyM
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/6a203d2ca24c521d116054636888198b8b0cf20e#commitcomment-18807157
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyM
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/9be5459c906ba106f235d40ebe0f25b7193a0467#commitcomment-18968136
In src/main/org/apache/groovy/metaclass/Realm.java:
In src/main/org/apache/groovy/metaclass/Realm.java on line 43:
I
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/9be5459c906ba106f235d40ebe0f25b7193a0467#commitcomment-18971653
In src/main/org/apache/groovy/metaclass/Realm.java:
In src/main/org/apache/groovy/metaclass/Realm.java on line 43:
feedba
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/9be5459c906ba106f235d40ebe0f25b7193a0467#commitcomment-18975680
In src/main/org/apache/groovy/metaclass/Realm.java:
In src/main/org/apache/groovy/metaclass/Realm.java on line 43:
>a
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/9be5459c906ba106f235d40ebe0f25b7193a0467#commitcomment-19181654
In src/main/org/apache/groovy/metaclass/Realm.java:
In src/main/org/apache/groovy/metaclass/Realm.java on line 43:
I just
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/3c074dc2058d4c5115f172094385d9efd302f3ce#commitcomment-19444132
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user jglick commented on the pull request:
https://github.com/apache/groovy/commit/716d3e67e744c7edeed7cbc3f874090d39355764#commitcomment-19509922
How does this relate to 09e9778e8a33052d8c27105aee5310649637233d?
---
If your project is set up for it, you can reply to this emai
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/716d3e67e744c7edeed7cbc3f874090d39355764#commitcomment-19510217
09e9778 is not enough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/d30f059bf6dff6d7badb328d8595cee41d56ce25#commitcomment-19840273
In
src/main/org/apache/groovy/util/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java:
In
src/main/org/apache/groovy/ut
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/d30f059bf6dff6d7badb328d8595cee41d56ce25#commitcomment-19840342
In src/main/org/codehaus/groovy/runtime/memoize/LRUCache.java:
In src/main/org/codehaus/groovy/runtime/memoize/LRUCache.jav
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/d30f059bf6dff6d7badb328d8595cee41d56ce25#commitcomment-19840394
In
src/main/org/apache/groovy/util/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java:
In
src/main/org/apache/groovy/
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/d30f059bf6dff6d7badb328d8595cee41d56ce25#commitcomment-19840860
In src/main/org/codehaus/groovy/runtime/memoize/LRUCache.java:
In src/main/org/codehaus/groovy/runtime/memoize/LRUCache.j
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/d30f059bf6dff6d7badb328d8595cee41d56ce25#commitcomment-19841462
In src/main/org/codehaus/groovy/runtime/memoize/LRUCache.java:
In src/main/org/codehaus/groovy/runtime/memoize/LRUCache.jav
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/d30f059bf6dff6d7badb328d8595cee41d56ce25#commitcomment-19848737
In
src/main/org/apache/groovy/util/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java:
In
src/main/org/apache/groovy/ut
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/d30f059bf6dff6d7badb328d8595cee41d56ce25#commitcomment-19848751
In
src/main/org/apache/groovy/util/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java:
In
src/main/org/apache/groovy/ut
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/ce12609009c6572247d8d194047aac6812753b92#commitcomment-21709694
In src/main/groovy/lang/Groovydoc.java:
In src/main/groovy/lang/Groovydoc.java on line 1:
Needs the normal Apache heade
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/ce12609009c6572247d8d194047aac6812753b92#commitcomment-21710945
In src/main/groovy/lang/Groovydoc.java:
In src/main/groovy/lang/Groovydoc.java on line 1:
OK. I will add it later :)
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21962912
test fails on travis, see:
https://travis-ci.org/apache/groovy/builds/227402483?utm_source=github_status&utm_medium=notif
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21963417
Thanks, I had forgot to test with antlr4 enabled.
---
If your project is set up for it, you can reply to this email and hav
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21966439
@danielsun1106 So is it a bug in the new groovy parser?
---
If your project is set up for it, you can reply to this emai
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21966548
I run the test locally, parrot can handle it properly.
---
If your project is set up for it, you can reply to this email an
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21969276
I created [GROOVY-8171](https://issues.apache.org/jira/browse/GROOVY-8171)
because there is a slight difference in behavior
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22218912
In src/main/org/apache/groovy/util/Maps.java:
In src/main/org/apache/groovy/util/Maps.java on line 11:
JDK9 added `Ma
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219095
In src/main/org/apache/groovy/util/Maps.java:
In src/main/org/apache/groovy/util/Maps.java on line 11:
Thanks for rev
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219131
In
subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java:
In
subprojects/par
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219142
In
subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java:
In
subprojects/parser
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219164
In
subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java:
In
subprojects/parser
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219191
In
subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java:
In
subprojects/par
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/dfd30db7d294233c2c737177aa1b13b6dfeadb8a#commitcomment-22583320
In gradle/wrapper/gradle-wrapper.properties:
In gradle/wrapper/gradle-wrapper.properties on line 10:
the file has not
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/6c4fa92328f48c9a0e2c85c4a26e65000dbd1088#commitcomment-22584566
API changed...
```
Build file '/home/travis/build/apache/groovy/build.gradle' line: 63
* What went wron
Github user melix commented on the pull request:
https://github.com/apache/groovy/commit/6c4fa92328f48c9a0e2c85c4a26e65000dbd1088#commitcomment-22584865
Sorry my bad, it's not an API change, it's just that I had the build scan
recipes plugin applied in an init script, so I didn't real
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/9c99898433c4f11e0bdd38ebab528ae0d6c6072a#commitcomment-22586490
weird... some tests failed, but they pass before upgrading gradle.
---
If your project is set up for it, you can reply to t
Github user GreatAss-69802 commented on the pull request:
https://github.com/apache/groovy/commit/8f6b7cdb7239e7e17b3fd42807558c0c85b50e3d#commitcomment-22993869
In src/test/org/codehaus/groovy/classgen/asm/sc/bugs/Groovy8240Bug.groovy:
In src/test/org/codehaus/groovy/classgen/asm/
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/517e771687c582e52fd56715d0225ec4e69ae0f4#commitcomment-23505994
org.codehaus.groovy.ast.LineColumnCheckTest.testLineColumnInfo fails.
As far as I remember, node position tests have been
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/a86a4f126914378c801441a2fff48917ae958cbb#commitcomment-24337323
Merge https://github.com/groovy/groovy-core/pull/504
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/0dd461d673db9dc6e9d13013e90936b0f067562b#commitcomment-24338239
Merge https://github.com/groovy/groovy-core/pull/579 with some tweaks.
---
Github user turbanoff commented on the pull request:
https://github.com/apache/groovy/commit/068ce3d445d0b5ce5c77517acb86e4cc11648b3b#commitcomment-25074716
In src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java:
In src/main/org/codehaus/groovy/classgen/AsmClassGenerator.j
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/068ce3d445d0b5ce5c77517acb86e4cc11648b3b#commitcomment-25079300
In src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java:
In src/main/org/codehaus/groovy/classgen/AsmClassGenerator.j
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/4f2f7817dc6369abe464d5ad5239054656a5b21f#commitcomment-25182623
sudo reqired will let travis ci instance get more system resource(e.g.
memory), I do not know why sudo was modified to fals
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/4f2f7817dc6369abe464d5ad5239054656a5b21f#commitcomment-25192975
Yes, I put a comment to that effect in the file yesterday. I changed it to
false to get the faster build times on 2_6_X and ma
Github user dsatish commented on the pull request:
https://github.com/apache/groovy/commit/b58342060031f517d6ba42a64dd3ddf392e820bb#commitcomment-25677068
In src/main/groovy/lang/Binding.java:
In src/main/groovy/lang/Binding.java on line 99:
Hi @jstrachan - is the below impleme
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/b58342060031f517d6ba42a64dd3ddf392e820bb#commitcomment-25679530
In src/main/groovy/lang/Binding.java:
In src/main/groovy/lang/Binding.java on line 99:
I think it is correct. An alterna
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7ea3047fdb65c9c15e80eecd6ba221c5fabbc578#commitcomment-25806906
In src/main/groovy/util/ProxyGenerator.java:
In src/main/groovy/util/ProxyGenerator.java on line 212:
Won't this be les
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7ea3047fdb65c9c15e80eecd6ba221c5fabbc578#commitcomment-25807434
In src/main/groovy/util/ProxyGenerator.java:
In src/main/groovy/util/ProxyGenerator.java on line 212:
OK. I'll revert
Github user patric42 commented on the pull request:
https://github.com/apache/groovy/commit/7ea3047fdb65c9c15e80eecd6ba221c5fabbc578#commitcomment-25808709
In src/main/groovy/util/ProxyGenerator.java:
In src/main/groovy/util/ProxyGenerator.java on line 212:
Hi Paul,
I
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7ea3047fdb65c9c15e80eecd6ba221c5fabbc578#commitcomment-25813402
In src/main/groovy/util/ProxyGenerator.java:
In src/main/groovy/util/ProxyGenerator.java on line 212:
Thanks Patric, th
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/e1ce4824186f62f5fb05a407da79b8da61bc87a4#commitcomment-26053152
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyM
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/e1ce4824186f62f5fb05a407da79b8da61bc87a4#commitcomment-26078737
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMet
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/f5d0236f93302cf8d1f49f35f1ddf1d0dd1c12e4#commitcomment-26080209
In build.gradle:
In build.gradle on line 188:
Just a reminder, it is generally undesirable to release artifacts into
m
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/e1ce4824186f62f5fb05a407da79b8da61bc87a4#commitcomment-26090087
In src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
In src/main/org/codehaus/groovy/runtime/DefaultGroovyM
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/29727ea0c0318304ded181aebfa8cce661d34c56#commitcomment-26193580
In src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java:
In src/main/org/codehaus/groovy/runtime/memoize/CommonCache
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/29727ea0c0318304ded181aebfa8cce661d34c56#commitcomment-26201603
In src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java:
In src/main/org/codehaus/groovy/runtime/memoize/CommonC
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/047c8f29b1f7a1a98b2b003e4d09c1cef05feb0e#commitcomment-26361555
Weird... The build costs much more time after this commit...
[26 min 14 sec] https://travis-ci.org/apache/groovy/builds/
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/047c8f29b1f7a1a98b2b003e4d09c1cef05feb0e#commitcomment-26370771
Let's watch it a few more times ...
---
Github user melix commented on the pull request:
https://github.com/apache/groovy/commit/a6c82ad08b85ae8746b982a1a19107e93bfdb568#commitcomment-26384969
:+1: I apparently missed that!
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/c89393104807cc49859f77ab86c62ab3c7e171e8#commitcomment-26387619
I reverted the commit on my fork, the build costs about 12 min
https://travis-ci.org/danielsun1106/groovy/builds/3190832
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/c89393104807cc49859f77ab86c62ab3c7e171e8#commitcomment-26389799
Adding classExcludes added the extra time? Perhaps it has a caching impact?
Or using the binaryCompatibilityCheck at all? Loca
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1972c21cb2ccade3109cf9befdbbc3ff9c7dad68#commitcomment-26458323
Does this look related? The latest CI build says:
[testStreamOf] (class: java_util_stream_Stream$of, method: call signature
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/1972c21cb2ccade3109cf9befdbbc3ff9c7dad68#commitcomment-26461453
yes, that looks very much like a result of my change... hmm
---
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/1972c21cb2ccade3109cf9befdbbc3ff9c7dad68#commitcomment-26461672
I have the tendency that the failure comes from not using asm 6 in this
build.
---
1 - 100 of 1501 matches
Mail list logo
