Re: [jclouds] cinder availability zones api + list call implemented (#560)

2014-10-08 Thread Jeremy Daggett
+ +import javax.ws.rs.Consumes; +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.core.MediaType; + +/** + * api for cinder availability zones + */ + +@Beta +@Extension(of = ServiceType.BLOCK_STORAGE, namespace = ExtensionNamespaces.ADMIN_ACTIONS)

Re: [jclouds] cinder availability zones api + list call implemented (#560)

2014-10-08 Thread Jeremy Daggett
+@Extension(of = ServiceType.BLOCK_STORAGE, namespace = ExtensionNamespaces.ADMIN_ACTIONS) +@RequestFilters(AuthenticateRequest.class) +public interface AvailabilityZoneApi { + + + /** +* List all availability zones +* +* @return all availability zones +*/ + @GET

Re: [jclouds] cinder availability zones api + list call implemented (#560)

2014-10-08 Thread Jeremy Daggett
+ * availability zone for cinder + */ +public class AvailabilityZone { + + public static Builder? builder() { + return new ConcreteBuilder(); + } + + public Builder? toBuilder() { + return new ConcreteBuilder().fromAvailabilityZone(this); + } + + public abstract

Re: [jclouds] cinder availability zones api + list call implemented (#560)

2014-10-08 Thread Jeremy Daggett
+ @Override + protected ConcreteBuilder self() { + return this; + } + } + + private final String name; + private final ZoneState state; + + @ConstructorProperties({ + zoneName, zoneState + }) + protected AvailabilityZone(String name,

Re: [jclouds] cinder availability zones api + list call implemented (#560)

2014-10-08 Thread Jeremy Daggett
+ private final String name; + private final ZoneState state; + + @ConstructorProperties({ + zoneName, zoneState + }) + protected AvailabilityZone(String name, ZoneState zoneState) { + this.name = checkNotNull(name); + this.state = checkNotNull(zoneState); +

[jira] [Resolved] (JCLOUDS-281) Missing Nova creating compute instance with Bootable Volume

2014-10-08 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-281. Resolution: Fixed Fix Version/s: 1.8.1 Missing Nova creating compute instance

Re: [jclouds-site] Update stale docs (#133)

2014-10-08 Thread Jeremy Daggett
@demobox Wow, this one was a little stale! LGTM thx --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/133#issuecomment-58409104

Re: [jclouds-site] Update stale BlobStore docs (#68)

2014-10-08 Thread Jeremy Daggett
Yes, closing. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/68#issuecomment-58409235

Re: [jclouds-site] Update stale BlobStore docs (#68)

2014-10-08 Thread Jeremy Daggett
Closed #68. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/68#event-175946587

Re: [jclouds-labs-openstack] openstack glance added option copy from to create image (#152)

2014-10-08 Thread Jeremy Daggett
@@ -47,6 +49,14 @@ public CreateImageOptions id(String id) { return this; } + /** +* @param url the url of the image to be copied into openstack +*/ + public UpdateImageOptions copyFrom(String url) { ```java public UpdateImageOptions copyFrom(URI source) { ...

Re: [jclouds-labs-openstack] openstack glance added option copy from to create image (#152)

2014-10-08 Thread Jeremy Daggett
@@ -47,6 +49,14 @@ public CreateImageOptions id(String id) { return this; } + /** +* @param url the url of the image to be copied into openstack +*/ + public UpdateImageOptions copyFrom(String url) { + headers.put(COPY_FROM.asGlanceHeader(), url); I would

Re: [jclouds-labs-openstack] openstack glance added option copy from to create image (#152)

2014-10-08 Thread Jeremy Daggett
@@ -131,5 +141,12 @@ public static CreateImageOptions owner(String owner) { public static CreateImageOptions property(String key, String value) { return CreateImageOptions.class.cast(new CreateImageOptions().property(key, value)); } + + /** + * @see

Re: [jclouds-labs-openstack] openstack glance added option copy from to create image (#152)

2014-10-08 Thread Jeremy Daggett
@@ -22,9 +22,10 @@ */ public enum ImageField { ID, NAME, CHECKSUM, MIN_DISK, MIN_RAM, IS_PUBLIC, PROTECTED, CREATED_AT, UPDATED_AT, DELETED_AT, - OWNER, LOCATION, STATUS, DISK_FORMAT, CONTAINER_FORMAT, SIZE, SIZE_MIN, SIZE_MAX, STORE, PROPERTY; + OWNER, LOCATION, COPY_FROM,

Re: [jclouds-labs-openstack] openstack glance added option copy from to create image (#152)

2014-10-08 Thread Jeremy Daggett
public static final String HEADER_PREFIX = X-Image-Meta-; + public static final String GLANCE_HEADER_PREFIX = x-glance-api-; This is a one off header that is used when creating an image as documented [here](https://github.com/openstack/glance/blob/master/glance/api/v1/images.py#L780).

Re: [jclouds-labs-openstack] openstack glance added option copy from to create image (#152)

2014-10-08 Thread Jeremy Daggett
@@ -33,4 +34,8 @@ public String asParam() { public String asHeader() { return HEADER_PREFIX + name().charAt(0) + name().substring(1).toLowerCase(); } + + public String asGlanceHeader() { This can be removed. --- Reply to this email directly or view it on GitHub:

[jira] [Assigned] (JCLOUDS-694) Support OpenStack Heat Stack API

2014-10-08 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett reassigned JCLOUDS-694: -- Assignee: Jeremy Daggett Support OpenStack Heat Stack API

[jclouds-labs-openstack] Support OpenStack Heat StackApi list() method (#159)

2014-10-08 Thread Jeremy Daggett
This PR adds support for the `StackApi` and listing stacks. This is a WIP. You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs-openstack openstack/heat Or you can view, comment on it, or merge it online at:

Re: [jclouds] opestack support vm console (#557)

2014-10-07 Thread Jeremy Daggett
Closed #557. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/557#event-175229018

Re: [jclouds] opestack support vm console (#557)

2014-10-07 Thread Jeremy Daggett
@inbarsto Thanks for the contribution! :+1: This feature has already been implemented as the Nova [Consoles Extension API](https://github.com/jclouds/jclouds/blob/1.8.x/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/ConsolesApi.java)! For additional info, refer to

Re: [jclouds-labs-openstack] Things in labs shouldn't live long enough to be deprecated. (#155)

2014-10-07 Thread Jeremy Daggett
+1 Thx @adriancole --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/155#issuecomment-58298834

[jclouds] Support Nova Block Device Mapping v2 Boot (#558)

2014-10-07 Thread Jeremy Daggett
This PR updates the `BlockDeviceMapping` class used when creating a new server to use the new [v2 format]( http://developer.openstack.org/api-ref-compute-v2-ext.html#ext-os-block-device-mapping-v2-boot). JIRA: https://issues.apache.org/jira/browse/JCLOUDS-281 You can merge this Pull Request by

Re: [jclouds-labs-openstack] fix return code for deleteIfEmpty (#154)

2014-10-07 Thread Jeremy Daggett
@@ -16,10 +16,13 @@ */ package org.jclouds.openstack.swift.v1.blobstore.config; +import static org.jclouds.blobstore.attr.ConsistencyModel.EVENTUAL; We pulled this out, then put it back in! --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] fix return code for deleteIfEmpty (#154)

2014-10-07 Thread Jeremy Daggett
+1 LGTM! Thx @adriancole --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/154#issuecomment-58306446

Re: [jclouds] bug fix keystone role api + bug fix host aggregates (#559)

2014-10-07 Thread Jeremy Daggett
@@ -47,6 +49,7 @@ */ @Beta @Extension(of = ServiceType.IDENTITY, namespace = ExtensionNamespaces.OS_KSADM) +@RequestFilters(AuthenticateRequest.class) There would have been no way to access this API without this line! :+1: --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] etag is content-md5 in swift. (#157)

2014-10-07 Thread Jeremy Daggett
+1 I have been meaning to do this... Thx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/157#issuecomment-58308115

[jira] [Commented] (JCLOUDS-281) Missing Nova creating compute instance with Bootable Volume

2014-10-07 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163077#comment-14163077 ] Jeremy Daggett commented on JCLOUDS-281: https://github.com/jclouds/jclouds/pull

Re: [jclouds] Support Nova Block Device Mapping v2 Boot (#558)

2014-10-07 Thread Jeremy Daggett
merging shortly --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/558#issuecomment-58310729

Re: [jclouds] JCLOUDS-743 - Remove vcloud providers that no longer support version 1.0 (#543)

2014-10-04 Thread Jeremy Daggett
@adriancole +1 Thanks for the cleanup! Is the plan to support version `5.1` or _newer_ going forward? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/543#issuecomment-57921853

Re: [jclouds] JCLOUDS-743 - Remove vcloud providers that no longer support version 1.0 (#543)

2014-10-04 Thread Jeremy Daggett
Closed #543. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/543#event-174202007

Re: [jclouds] JCLOUDS-743 - Remove vcloud providers that no longer support version 1.0 (#543)

2014-10-04 Thread Jeremy Daggett
SGTM! :+1: Pushed to master: cc35ae5 and 8c520d3 Pushed to 1.8.x: 0acc61b and 7e04f62 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/543#issuecomment-57922279

[jira] [Resolved] (JCLOUDS-611) Neutron LBaaS extension request

2014-10-03 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-611. Resolution: Done Changes pushed to [master|https://github.com/jclouds/jclouds-labs

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-10-03 Thread Jeremy Daggett
@fbrouille Personally, I close them once the work is pushed. I just resolved the issue in JIRA, so not to worry. We really appreciate the contribution, thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/146#issuecomment-57810495

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
import org.jclouds.s3.reference.S3Headers; -import com.google.common.collect.ImmutableSet; -import com.google.common.reflect.TypeToken; -import com.google.inject.Module; +import static org.jclouds.Constants.PROPERTY_RELAX_HOSTNAME; +import static

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
- ListenableFutureVoid enableBucketLogging( -@Bucket @EndpointParam(parser = AssignCorrectHostnameForBucket.class) @BinderParam(BindAsHostPrefixIfConfigured.class) @ParamValidators(BucketNameValidator.class) String bucketName, -

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
/** * Provides access to S3 via their REST API. - * p/ - * All commands return a Future of the result from S3. Any exceptions incurred during - * processing will be backend in an {@link ExecutionException} as documented in - * {@link Future#get()}. - * + * * @see a

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
/** * Retrieves the {@link org.jclouds.s3.domain.internal.BucketListObjectMetadata metadata} of -* the object associated with the key or -* {@link org.jclouds.s3.domain.internal.BucketListObjectMetadata#NOT_FOUND} if not +* the object associated with the key or

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
*/ - S3Object getObject(String bucketName, String key, GetOptions... options); + @Named(GetObject) [minor] FWIW `@Named(apiName:methodName)` has been an effective naming convention. In this case: `@Named(s3:getObject)` --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
@@ -26,7 +26,4 @@ @Override S3BlobStore getBlobStore(); - - @Override - S3AsyncBlobStore getAsyncBlobStore(); Nice! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538/files#r18411399

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
public abstract class BaseS3ClientExpectTest extends BaseRestClientExpectTestS3Client { protected static final String CONSTANT_DATE = 2009-11-08T15:54:08.897Z; - @ConfiguresRestClient - private static final class TestS3RestClientModule extends

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
} private void addGrantsToACL(AccessControlList acl) { String ownerId = acl.getOwner().getId(); acl.addPermission(GroupGranteeURI.ALL_USERS, Permission.READ); - acl.addPermission(new EmailAddressGrantee(StubS3AsyncClient.TEST_ACL_EMAIL), Permission.READ_ACP);

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
+import org.jclouds.blobstore.domain.StorageMetadata; +import org.jclouds.blobstore.options.CreateContainerOptions; +import org.jclouds.blobstore.options.GetOptions; +import org.jclouds.blobstore.options.ListContainerOptions; +import org.jclouds.blobstore.options.PutOptions; +import

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
+import org.jclouds.blobstore.options.PutOptions; +import org.jclouds.domain.Location; + +import com.google.common.collect.ForwardingObject; +import com.google.common.util.concurrent.ListenableFuture; +import com.google.common.util.concurrent.ListeningExecutorService; + +/** + * Adapter

Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)

2014-10-03 Thread Jeremy Daggett
+1 Looks good based on the other conversions I have done. Just a few minor comments, thanks @adriancole ! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57838532

Re: [jclouds] JCLOUDS-692 Remove the CloudSigma v1 provider. (#535)

2014-10-02 Thread Jeremy Daggett
Pushed to master f7aea98 and 1.8.x ba04fa0 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/535#issuecomment-57671144

[jira] [Resolved] (JCLOUDS-692) Remove the CloudSigma v1 provider

2014-10-02 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-692. Resolution: Fixed Remove the CloudSigma v1 provider

Re: [jclouds] JCLOUDS-735 Remove ninefold providers. (#534)

2014-10-02 Thread Jeremy Daggett
Pushed to master a32292f and 1.8.x 1d95d29 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/534#issuecomment-57674135

[jira] [Resolved] (JCLOUDS-735) Remove ninefold providers

2014-10-02 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-735. Resolution: Done Fix Version/s: 1.8.1 Remove ninefold providers

[jira] [Created] (JCLOUDS-738) Support OpenStack Ceilometer v2

2014-10-01 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-738: -- Summary: Support OpenStack Ceilometer v2 Key: JCLOUDS-738 URL: https://issues.apache.org/jira/browse/JCLOUDS-738 Project: jclouds Issue Type: New

[jira] [Created] (JCLOUDS-739) Support Nova Hypervisors Extension API

2014-10-01 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-739: -- Summary: Support Nova Hypervisors Extension API Key: JCLOUDS-739 URL: https://issues.apache.org/jira/browse/JCLOUDS-739 Project: jclouds Issue Type: New

Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron domain classes (#148)

2014-10-01 Thread Jeremy Daggett
Merging shortly... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57493886

Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron domain classes (#148)

2014-10-01 Thread Jeremy Daggett
Pushed to master 7557224 and 1.8.x 16e87b7 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57497942

Re: [jclouds] Refactor ssh properties (#532)

2014-10-01 Thread Jeremy Daggett
@Resource - @Named(jclouds.ssh) + @Named(SSH_LOGGER_NAME) No, it isn't a lazy question! I am not aware of any and that's why I added it. :) My opinion is that it provides more context than the string `jclouds.ssh`. That said, _should_ we have a single place where they are all

[jira] [Assigned] (JCLOUDS-716) Remove Rackspace First-Gen Cloud Servers

2014-09-30 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett reassigned JCLOUDS-716: -- Assignee: Jeremy Daggett Remove Rackspace First-Gen Cloud Servers

[jira] [Commented] (JCLOUDS-514) Need to be able to attach block volumes at instance creation in Nova

2014-09-29 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151909#comment-14151909 ] Jeremy Daggett commented on JCLOUDS-514: [~jasdeep] The plan is to support

Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron domain classes (#148)

2014-09-29 Thread Jeremy Daggett
I thought I had those changes in the previous commit. ?? Anyway... I removed the remaining unnecessary `@Deprecation` annotations. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57234856

[jclouds] Refactor ssh properties (#532)

2014-09-26 Thread Jeremy Daggett
This PR pulls out all String references into a new `SshProperties` class. You can merge this Pull Request by running: git pull https://github.com/rackspace/jclouds ssh-props Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/532 -- Commit Summary

[jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron domain classes (#148)

2014-09-26 Thread Jeremy Daggett
@zack-shoylev Let me know your preference on the deprecations. Thx! You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs-openstack fix/boolean-methods Or you can view, comment on it, or merge it online at:

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-25 Thread Jeremy Daggett
@@ -103,4 +104,14 @@ */ @Delegate OptionalSecurityGroupApi getSecurityGroupApi(@EndpointParam(parser = RegionToEndpoint.class) String region); + + /** +* Provides access to LBaaS version 1 features. +* +* h3NOTE/h3 +* This API is an extension that may or

Re: [jclouds-labs] Prefer isEmpty() to size() (#75)

2014-09-25 Thread Jeremy Daggett
@demobox Anytime! Pushed to master bec869d and 1.8.x 3451080 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/75#issuecomment-56834266

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+See the License for the specific language governing permissions and +limitations under the License. + +-- +project xmlns=http://maven.apache.org/POM/4.0.0; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation=http://maven.apache.org/POM/4.0.0

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+import org.jclouds.profitbricks.features.LoadBalancerApi; +import org.jclouds.profitbricks.features.NicApi; +import org.jclouds.profitbricks.features.PublicIpApi; +import org.jclouds.profitbricks.features.RomDriveApi; +import org.jclouds.profitbricks.features.SnapshotApi; +import

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+import org.jclouds.profitbricks.features.UserNotificationApi; +import org.jclouds.rest.annotations.Delegate; + +/** + * Provides access to ProfitBricks's Cloud Compute specific features. + * p/ + * As for the current moment ProfitBricks has only SOAP based API and REST is coming soon.

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+import com.google.common.collect.ImmutableSet; +import com.google.inject.Module; +import org.jclouds.compute.ComputeServiceContext; +import org.jclouds.profitbricks.config.PBComputeServiceAdapterContextModule; +import org.jclouds.profitbricks.config.PBComputeServiceContextModule; +import

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+ */ +public final class PBApiRequestParameters { + + public static final String SERVER = server; + public static final String STORAGE = storage; + public static final String DATACENTER = datacenter; + public static final String SNAPSHOT = snapshot; + public static final String

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+import org.jclouds.profitbricks.domain.server.AvailabilityZone; +import org.jclouds.rest.MapBinder; + +public abstract class BaseProfitBricksRequestBinder implements MapBinder { + + protected final StringBuilder requestBuilder; + + public BaseProfitBricksRequestBinder() { +

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+public class CreateDataCenterRequestBinder extends BaseProfitBricksRequestBinder { + + @Override + public R extends HttpRequest R bindToRequest(R request, MapString, Object postParams) { + checkNotNull(request, request); + + Object vdcObj =

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+ private String generateRequestPayload(AddFirewallRulesToNic rules) { + requestBuilder.setLength(0); + requestBuilder.append(ws:addFirewallRulesToNic); + for (FirewallRuleRequest rule : rules.getRequest()) + requestBuilder.append(request) +

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+ */ +package org.jclouds.profitbricks.binders; + +import com.google.common.base.Strings; +import javax.ws.rs.core.MediaType; +import org.jclouds.http.HttpRequest; +import org.jclouds.profitbricks.domain.OsType; +import org.jclouds.profitbricks.domain.server.AvailabilityZone; +import

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+import org.jclouds.profitbricks.domain.datacenter.update.UpdateDcRequest; + +public class UpdateDataCenterRequestBinder extends BaseProfitBricksRequestBinder { + + @Override + public R extends HttpRequest R bindToRequest(R request, MapString, Object postParams) { +

Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

2014-09-25 Thread Jeremy Daggett
+ * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package

[jira] [Created] (JCLOUDS-730) Investigate block device mapping support in Compute abstraction

2014-09-25 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-730: -- Summary: Investigate block device mapping support in Compute abstraction Key: JCLOUDS-730 URL: https://issues.apache.org/jira/browse/JCLOUDS-730 Project: jclouds

[jira] [Created] (JCLOUDS-731) Support Nova Block Device Mapping v2

2014-09-25 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-731: -- Summary: Support Nova Block Device Mapping v2 Key: JCLOUDS-731 URL: https://issues.apache.org/jira/browse/JCLOUDS-731 Project: jclouds Issue Type: New

[jira] [Assigned] (JCLOUDS-731) Support Nova Block Device Mapping v2

2014-09-25 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett reassigned JCLOUDS-731: -- Assignee: Jeremy Daggett Support Nova Block Device Mapping v2

[jira] [Closed] (JCLOUDS-730) Investigate block device mapping support in Compute abstraction

2014-09-25 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett closed JCLOUDS-730. -- Resolution: Duplicate This is a duplicate of [JCLOUDS-239|https://issues.apache.org/jira

[jira] [Commented] (JCLOUDS-239) Add an Extension to compute for disks/volumes

2014-09-25 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148294#comment-14148294 ] Jeremy Daggett commented on JCLOUDS-239: Nova has support for block device

Re: [jclouds] Support availability zone OpenStack parameter when launch nodes. (#519)

2014-09-24 Thread Jeremy Daggett
Pushed to master cf95033 and 1.8.x 7682f94 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/519#issuecomment-56679735

Re: [jclouds] Support availability zone OpenStack parameter when launch nodes. (#519)

2014-09-24 Thread Jeremy Daggett
Thanks again @RoadRoller ! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/519#issuecomment-56679799

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-24 Thread Jeremy Daggett
+ return expectedCodes; + } + + /** +* @return the pools for this HealthMonitor. +*/ + @Nullable + public ImmutableListPoolStatus getPools() { + return pools; + } + + /** +* @return the administrative state for this HealthMonitor. +*/ +

[jclouds-labs] Prefer isEmpty() to size() (#75)

2014-09-24 Thread Jeremy Daggett
You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs fix/isEmpty Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/75 -- Commit Summary -- * Prefer isEmpty() to size() -- File Changes --

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
@@ -103,4 +104,14 @@ */ @Delegate OptionalSecurityGroupApi getSecurityGroupApi(@EndpointParam(parser = RegionToEndpoint.class) String region); + + /** +* Provides access to LBaaS version 1 features. +* +* h3NOTE/h3 +* This API is an extension that may or

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
@@ -67,6 +67,8 @@ protected void configure() { URI.create(http://docs.openstack.org/ext/neutron/router/api/v1.0;)) .put(URI.create(ExtensionNamespaces.SECURITY_GROUPS), URI.create(http://docs.openstack.org/ext/securitygroups/api/v2.0;)) +

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+ return expectedCodes; + } + + /** +* @return the pools for this HealthMonitor. +*/ + @Nullable + public ImmutableListPoolStatus getPools() { + return pools; + } + + /** +* @return the administrative state for this HealthMonitor. +*/ +

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
@@ -0,0 +1,13 @@ +{ +vip: { +name: new-name, +description: new description, +pool_id: 61b1f87a-7a21-4ad3-9dda-7f81d249944f, +session_persistence: { +cookie_name: MyNewAppCookie, +type: APP_COOKIE +}, +

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+admin_state_up: false, +subnet_id: 8032909d-47a1-4715-90af-5153ffe39861, +tenant_id: 83657cfcdfe44cd5920adaf26c48ceea, +connection_limit: 50, +pool_id: 61b1f87a-7a21-4ad3-9dda-7f81d249944f, +session_persistence: { +cookie_name:

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+ * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+package org.jclouds.openstack.neutron.v2.domain.lbaas.v1; + +import java.beans.ConstructorProperties; + +import javax.inject.Named; + +import org.jclouds.javax.annotation.Nullable; + +import com.google.common.base.MoreObjects; +import com.google.common.base.Objects; +import

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-23 Thread Jeremy Daggett
+ /** + * Provides the administrative state for this HealthMonitor's Builder. + * + * @return the Builder. + * @see HealthMonitor#getAdminStateUp() + */ + public ParameterizedBuilderType adminStateUp(Boolean adminStateUp) { +

[jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread Jeremy Daggett
APIs that return `boolean` or `Boolean` should use the standard JavaBeans naming conventions. @zack-shoylev On the deprecations, should we state that it will be removed in 1.8.2, or 2.0? I just put the 2.1 in there as a placeholder until I got your feedback. WDYT? You can merge this Pull

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread Jeremy Daggett
Reopened #147. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/147#event-169248179

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread Jeremy Daggett
Closed #147. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/147#event-169248149

Re: [jclouds-labs-openstack] Correct boolean API signatures (#147)

2014-09-23 Thread Jeremy Daggett
@demobox I'm confused by your comment. These are just domain accessors that have been renamed. ?? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/147#issuecomment-56587740

[jira] [Created] (JCLOUDS-728) Support nested API @Delegate annotations

2014-09-23 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-728: -- Summary: Support nested API @Delegate annotations Key: JCLOUDS-728 URL: https://issues.apache.org/jira/browse/JCLOUDS-728 Project: jclouds Issue Type

[jira] [Created] (JCLOUDS-729) Nova ServerApi createImageFromServer should allow users to include metadata

2014-09-23 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-729: -- Summary: Nova ServerApi createImageFromServer should allow users to include metadata Key: JCLOUDS-729 URL: https://issues.apache.org/jira/browse/JCLOUDS-729

[jira] [Resolved] (JCLOUDS-720) Inconsistent Maven artifact IDs in jclouds-cli project

2014-09-21 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-720. Resolution: Fixed Fix Version/s: 2.0.0 Inconsistent Maven artifact IDs in jclouds

[jira] [Resolved] (JCLOUDS-719) Upgrade to Gson 2.3

2014-09-21 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-719. Resolution: Fixed Fix Version/s: 2.0.0 Upgrade to Gson 2.3

Re: [jclouds] Enforce that all interfaces are types via Checkstyle (#512)

2014-09-20 Thread Jeremy Daggett
+1 Please refer to the example in Effective Java 2nd Ed. **Item 4:** _Enforce noninstantiability with a private constructor_ It explains the rationale behind throwing this error. --- Reply to this email directly or view it on GitHub:

Re: [jclouds-examples] Simplify interface of Google examples and fix the name and comment of userName variable (#63)

2014-09-19 Thread Jeremy Daggett
@@ -26,7 +26,7 @@ namegoogle-examples/name properties -jclouds.version1.7.2/jclouds.version +jclouds.version1.8.0/jclouds.version @najtmar If you have run the examples successfully against `1.8.0`, then I would argue that this change is preferred over `1.7.2`. --- Reply to

[jira] [Commented] (JCLOUDS-611) Neutron LBaaS extension request

2014-09-19 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140866#comment-14140866 ] Jeremy Daggett commented on JCLOUDS-611: This issue can't be resolved until

[jira] [Reopened] (JCLOUDS-611) Neutron LBaaS extension request

2014-09-19 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett reopened JCLOUDS-611: Neutron LBaaS extension request --- Key

Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)

2014-09-19 Thread Jeremy Daggett
@fbrouille Thank you so much for this contribution! I can start reviewing this PR this weekend. :+1: --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/146#issuecomment-56204409

<    1   2   3   4   5   6   7   8   9   10   >