lgtm, thanks @googlielmo
merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1039#issuecomment-261552521
do you like to have that backported to 1.9.x?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1039#issuecomment-261553584
merged at master http://git-wip-us.apache.org/repos/asf/jclouds/commit/5a3cfe5d
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1039#issuecomment-261554233
ok backported to 1.9.x at
https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=1f1aceb8
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1039#issuecomment-261555183
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/190
-- Commit Summary --
* add release 1.9.3
-- File Changes --
M _includes/navbar.html (1)
M doap_jclouds.rdf (7)
A releasenotes/1.9.3.md (39)
M releasenotes/index
andreaturli commented on this pull request.
> +date: 2016-11-23 12:00:00
+release_notes: true
+permalink: /releasenotes/1.9.3/
+---
+
+1. [Introduction](#intro)
+1. [Credits](#credits)
+1. [Test Results](#test)
+
+## Introduction
+
+You can read the official announcement at [Apache jclouds 1.9.3
update README.md
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-examples/pull/90
-- Commit Summary --
* update blobstore-basics to use 2.0.0
-- File Changes --
M blobstore-basics/README.md (11)
M blobstore-basics/pom.xml (4)
M
@andreaturli pushed 1 commit.
56cbcbd fix typos in releasenetes for 1.9.3
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190/files/40db1882033cc39d75d1d5d060c49f33dbc0dbd3..56cbcbdad53ccdce1723703f069fb88d7b8
andreaturli commented on this pull request.
> +## Introduction
+
+You can read the official announcement at [Apache jclouds 1.9.3
released](http://markmail.org/thread/qlapnppmfbilje7p). To get started with
jclouds, please see the [jclouds installation guide](/start/install/).
+
+This is a bugf
@demobox can you have another shot at it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190#issuecomment-262810954
thanks @nacx, good spot!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190#issuecomment-262815836
@andreaturli pushed 1 commit.
7b48221 fix typos in releasenotes for 1.9.3
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190/files/56cbcbdad53ccdce1723703f069fb88d7b8ca1a7..7b48221eccf55ccfc92723945b9aac45708
thanks @demobox and @nacx, merging now!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190#issuecomment-262821539
Merged #190.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/190#event-871361747
andreaturli commented on this pull request.
> @@ -69,35 +73,47 @@
public static void main(String[] args) throws IOException {
- if (args.length < PARAMETERS)
+ String provider;
+ String identity;
+ String credential;
+ String containerName;
+ String endpoint
andreaturli commented on this pull request.
> Location location = null;
if (apiMetadata instanceof SwiftApiMetadata) {
location = Iterables.getFirst(blobStore.listAssignableLocations(),
null);
}
- blobStore.createContainerInLocation(location, c
andreaturli commented on this pull request.
>
// Init
- BlobStoreContext context = ContextBuilder.newBuilder(provider)
- .credentials(identity,
credential)
-
.buildView(BlobStoreContext.cl
andreaturli commented on this pull request.
> @@ -69,35 +73,47 @@
public static void main(String[] args) throws IOException {
- if (args.length < PARAMETERS)
+ String provider;
+ String identity;
+ String credential;
+ String containerName;
+ String endpoint
@andreaturli pushed 1 commit.
df0e785 address comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90/files/70f574af20bc8f30d5835d907411fe85ab259945..df0e785adec6ca32582aef2d942190cfb4370fa4
andreaturli commented on this pull request.
> @@ -138,6 +154,10 @@ public static void main(String[] args) throws
> IOException {
}
} finally {
+ // delete cointainer
+ if (blobStore.containerExists(containerName)) {
ok
--
You are receiving this bec
andreaturli commented on this pull request.
> @@ -51,6 +51,11 @@
google-compute-engine
${jclouds.version}
+
+ io.cloudsoft.jclouds.api
+ openstack-mitaka-nova
+ 1.9.3-cloudsoft.20160831
+
oh, don't know why it's there, I'll remove it right away
--
andreaturli commented on this pull request.
> // Create Container
- BlobStore blobStore = context.getBlobStore();
Location location = null;
not sure I follow, looking at the git history I can see this commit
https://github.com/jclouds/jclouds-examples/commit/8a0718e
andreaturli commented on this pull request.
>// note that you can check if a provider is present ahead of time
checkArgument(contains(allKeys, provider), "provider %s not in supported
list: %s", provider, allKeys);
-
- String identity = args[1];
- String credential = ar
@andreaturli pushed 1 commit.
7bbd5fc addressing more comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90/files/31184ff15c5d8aa6f2b2c7af0f10f17e811c33b0..7bbd5fc5d7f14d7ed12b76cadf37bf9757ff936e
Could you merge it please? Not at my laptop just now. Thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90#issuecomment-263021863
@demobox are you happy with the status of this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90#issuecomment-263066699
Closed #1039.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1039#event-873386517
thx @googlielmo
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1039#issuecomment-263231284
use same version used at
https://github.com/jclouds/jclouds/blob/5a3cfe5dbe5398ee6c81a21a279363c3caa51728/project/pom.xml#L236
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-karaf/pull/90
-- Commit Summary --
* Update pom.xml to match xmlb
@neykov why was that deleted?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/81#issuecomment-265585263
not sure why, but it is not in `master` can you re-open this PR, please?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/81#issuecomment-265689847
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/acc3533d)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/91#issuecomment-265787376
thx @neykov
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/91#issuecomment-265787422
Closed #91.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/91#event-887126792
andreaturli commented on this pull request.
> @@ -8,6 +8,7 @@ title: Get in touch!
We'd love to have your feedback, suggestions, and will be happy to help
with anything you need. Just get in touch!
+ https://lists.apache.org/list.html?jclouds.apache.org";>Browse and
participa
thx @neykov, sorry for being late in this discussion.
Just thinking aloud, would it be acceptable for you to donate the
https://github.com/neykov/vagrant-java-bindings to jclouds as well? I'm seeing
it as a maven submodule of jclouds-vagrant which is completely in sync with the
jclouds-vagrant
andreaturli commented on this pull request.
> +
+Building
+
+
+1. Vagrant bindings
+ * `git clone https://github.com/neykov/vagrant-java-bindings`
+ * `cd vagrant-java-bindings`
+ * `mvn clean install`
+ * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's
classpath
andreaturli commented on this pull request.
> + * `git clone https://github.com/neykov/vagrant-java-bindings`
+ * `cd vagrant-java-bindings`
+ * `mvn clean install`
+ * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's
classpath
+2. Vagrant provider
+ * `git clone https://
andreaturli commented on this pull request.
> + * `git clone https://github.com/neykov/vagrant-java-bindings`
+ * `cd vagrant-java-bindings`
+ * `mvn clean install`
+ * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's
classpath
+2. Vagrant provider
+ * `git clone https://
andreaturli commented on this pull request.
> + @Override
+ protected void configure() {
+ super.configure();
+ bind(new TypeLiteral>() {
+ }).to(VagrantComputeServiceAdapter.class);
+ bind(new TypeLiteral>() {
+ }).to(MachineToNodeMetadata.class);
+ bind(new Ty
This is the first PR for Packet API, to simplify the review process, and it
only adds the pom.xml and the domain objects, based on
https://www.packet.net/developers/api/
Those are the minimum set needed to support the jclouds abstraction.
You can view, comment on, or merge this pull request onl
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1048
-- Commit Summary --
* update Docker README
-- File Changes --
M apis/docker/README.md (13)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1048.patch
https://githu
@andreaturli pushed 1 commit.
ffc38da improve description for osx
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1048/files/ddb3b137a8188d0ddbc4678816fc4970d8b4b801..ffc38dad68844bf42d259e678191669c7920cc9a
Closed #1048.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1048#event-912317410
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/c2cda931) and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1d562d91)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.c
andreaturli commented on this pull request.
> + * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to
andreaturli commented on this pull request.
> +
+@AutoValue
+public abstract class IpAddress {
+
+public abstract String id();
+public abstract Integer addressFamily();
+public abstract String netmask();
+public abstract Boolean publicAddress();
+public abstract Integer cidr(
@andreaturli pushed 1 commit.
947df3e clean up domain objects
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/337/files/57019f3c36af2ebadc07b0633aff62e062a670ca..947df3e8ce4c315aaba458b9489385612a051913
@nacx is the more recent version on
[serviceMix](https://mvnrepository.com/artifact/org.apache.servicemix.bundles/org.apache.servicemix.bundles.jsch-agentproxy-jsch/0.0.9_1)
still not good for jclouds?
--
You are receiving this because you are subscribed to this thread.
Reply to this email dire
thanks for the reply, @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/commit/522e245582acb3595144f4b02208909e3b935564#commitcomment-20373985
I'd like to push out this PR to have feedback from osgi/karaf experts, as I'm
not
This PR:
- re-organize `feature.xml` to alphabetical order to simplify the review process
- bump osgi and karaf version
- add a new `modern-itests` maven module inspired by
https://github.com/fabric8io/kubernetes-c
@nacx @demobox this is an initial work to improve jclouds-karaf as some
apis/providers are missing . I'd appreciate your thoughts here
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/
looks better, @nacx ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/337#issuecomment-270927225
I think you are right, @nacx, we need to bump karaf version as well
modern-itests vs itests are just easier to read/write and they use the recent
capabilities offered by pax exam etc I've seen also better error messages and
less boilerplate code
When modern-itests will have all of the tests impl
Closed #337.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/337#event-916645302
thx @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/337#issuecomment-271420887
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/cb3ab1ca)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/337#issuecomment-271420829
ok I will open up the next PR with what you suggested. merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/337#issuecomment-271419271
- add ApiMetadata and ProviderMetadata
- add skeleton for PacketApi with ProjectApi only
- add XAuthTokenToRequest filter
- add HttpApiModule and ParserModule
- add ProjectApi feature with Mock and Live Tests
You can view, comment on, or merge this pull request online at:
https://github.com/jclo
andreaturli commented on this pull request.
> + @Override
+ public Builder toBuilder() {
+ return new Builder().fromApiMetadata(this);
+ }
+
+ public PacketApiMetadata() {
+ this(new Builder());
+ }
+
+ protected PacketApiMetadata(Builder builder) {
+ super(builder);
+
andreaturli commented on this pull request.
> + properties.put(TEMPLATE,
> "osFamily=UBUNTU,os64Bit=true,osVersionMatches=14.*");
+ properties.put(TIMEOUT_NODE_RUNNING, 30); // 5 mins
+ return properties;
+ }
+
+ public static class Builder extends BaseHttpApiMetadata.Bui
andreaturli commented on this pull request.
> + super(builder);
+ }
+
+ public static Properties defaultProperties() {
+ Properties properties = BaseHttpApiMetadata.defaultProperties();
+ properties.put(TEMPLATE,
"osFamily=UBUNTU,os64Bit=true,osVersionMatches=14.*");
+ p
andreaturli commented on this pull request.
> +
+public static Properties defaultProperties() {
+final Properties properties = PacketApiMetadata.defaultProperties();
+return properties;
+}
+
+public static class Builder extends BaseProviderMetadata.Builder {
+
+
andreaturli commented on this pull request.
> +import org.jclouds.location.suppliers.implicit.FirstRegion;
+import org.jclouds.packet.PacketApi;
+import org.jclouds.packet.handlers.PacketErrorHandler;
+import org.jclouds.rest.ConfiguresHttpApi;
+import org.jclouds.rest.config.HttpApiModule;
+
+i
andreaturli commented on this pull request.
> + @Override
+ protected void configure() {
+ install(new PacketComputeParserModule());
+ super.configure();
+ }
+
+ @Override
+ protected void bindErrorHandlers() {
+
bind(HttpErrorHandler.class).annotatedWith(Redirection.cl
andreaturli commented on this pull request.
> + @Override
+ protected void bindErrorHandlers() {
+
bind(HttpErrorHandler.class).annotatedWith(Redirection.class).to(PacketErrorHandler.class);
+
bind(HttpErrorHandler.class).annotatedWith(ClientError.class).to(PacketErrorHandler.cla
thanks @drigodwin, looks good to me, merging.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/341#issuecomment-271640066
Closed #341.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/341#event-917873067
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a3a6ef29)
Thanks @drigodwin!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/341#issuecomment-27164
@andreaturli pushed 1 commit.
a64d73b add pagination to Project API
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/340/files/4ce88bff4bb288d6d83351b28d941f4f8641d24e..a64d73b7b153ec3639450b5efc371a600eb09870
@nacx I'm adding pagination as well, agreed better sooner than later
re PublicKey I think it was a typo from my first PR, this provider is not using
them in the domain objects.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
@andreaturli pushed 1 commit.
2b4840b fix typo
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/340/files/a64d73b7b153ec3639450b5efc371a600eb09870..2b4840bf717719e31d448d60c315bb477bed50cd
@andreaturli pushed 1 commit.
0315649 test pagination
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/340/files/2b4840bf717719e31d448d60c315bb477bed50cd..031564949f567d96fdc7ac10d5c3b2d0c2a5c83c
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/340#issuecomment-271844332
ok thanks, merging!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/340#issuecomment-271874692
Closed #340.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/340#event-919140102
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/070fe653)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/340#issuecomment-271875353
lgtm, thanks @m4rkmckenna, merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/93#issuecomment-271901247
Closed #93.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/93#event-919297253
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/a9cffdd8)
Thanks @m4rkmckenna
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/93#issuecomment-27
Closed #342.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/342#event-919465570
thanks @drigodwin
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6103e810)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/342#issuecomment-271932
Sure @nacx see
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/784ee020)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/342#issuecomment-271992269
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/343
-- Commit Summary --
* add AddApiVersionToRequest filter
-- File Changes --
M packet/src/main/java/org/jclouds/packet/PacketApiMetadata.java (1)
M packet/src/main/java/
@andreaturli pushed 1 commit.
9930d64 address @nacx comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/343/files/595ce8b6bb7319c99c9a3df1e7b3e2e4a70d69b4..9930d64ab6373162bd9c5d0ae01be001887d4d5e
andreaturli commented on this pull request.
> +import static com.google.common.base.Preconditions.checkNotNull;
+
+@Singleton
+public class AddApiVersionToRequest implements HttpRequestFilter {
+
+private final String apiVersion;
+
+@Inject
+public AddApiVersionToRequest(@ApiVersion
andreaturli commented on this pull request.
>assertEquals(request.getHeader("X-Auth-Token"), X_AUTHORIZATION_TOKEN);
return request;
}
protected RecordedRequest assertSent(MockWebServer server, String method,
String path, String json)
throws InterruptedExcepti
@nacx happy with that version?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/343#issuecomment-272909654
thanks, merging!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90#issuecomment-273050187
Closed #343.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/343#event-925344400
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/dfd6804c)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/343#issuecomment-273050363
Closed #90.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90#event-925347966
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-examples/commit/5662aae4)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90#issuecomment-273051042
- add DeviceApi with Mock and Live Test
- add FacilityApi with Mock and Live Test
- add OperatingSystemApi with Mock and Live Test
- add SshKeyApi with Mock and Live Test
---
Notice this PR adds many files but because we carefully review already
`ProjectApi` and I copied the same structure for t
andreaturli commented on this pull request.
> +@ConstructorProperties({ "devices", "meta" })
+public Devices(List items, Meta meta) {
+super(items, meta);
+}
+}
+
+private static class ToPagedIterable extends
BaseToPagedIterabl
andreaturli commented on this pull request.
> + protected List getArgs(GeneratedHttpRequest request) {
+ return request.getCaller().get().getArgs();
+ }
+
+@Override
+protected IterableWithMarker
fetchPageUsingOptions(ListOptions options,
andreaturli commented on this pull request.
> +@ConstructorProperties({ "devices", "meta" })
+public Devices(List items, Meta meta) {
+super(items, meta);
+}
+}
+
+private static class ToPagedIterable extends
BaseToPagedIterabl
@andreaturli pushed 1 commit.
adf0108 address @nacx comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/345/files/ae7c3142f1df1ae7e68274806dc52a2095bdcd24..adf01080394858560a645c8114b2bd085f35868c
@andreaturli pushed 1 commit.
f47db43 make CreateDevice constructor private
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/345/files/adf01080394858560a645c8114b2bd085f35868c..f47db434033f1ac3a8caea5b76873fa40
andreaturli commented on this pull request.
> + assertEquals(size(devices), 5);
+ assertEquals(server.getRequestCount(), 1);
+
+ assertSent(server, "GET",
"/projects/93907f48-adfe-43ed-ad89-0e6e83721a54/devices?page=1&per_page=5");
+ }
+
+ public void testListDevicesWithOptio
601 - 700 of 1680 matches
Mail list logo
