Re: [PR] MDC and NDC availablity no longer depend on APR thread support [logging-log4cxx]

2023-11-21 Thread via GitHub
swebb2066 commented on PR #299: URL: https://github.com/apache/logging-log4cxx/pull/299#issuecomment-1821980162 > should these #if be reversed, such that if it has thread_local that takes precedence over APR? I have not yet sure that using thread_local instead of APR would make some

[jira] [Commented] (LOG4J2-1477) @NonNull support (for @NonNullByDefault or similar)

2023-11-21 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788573#comment-17788573 ] Matt Sicker commented on LOG4J2-1477: - I like this JSpecify draft, though it's a dra

[jira] [Commented] (LOG4J2-1477) @NonNull support (for @NonNullByDefault or similar)

2023-11-21 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788572#comment-17788572 ] Matt Sicker commented on LOG4J2-1477: - So far, they're just aliases forĀ {{javax.anno

Re: [I] Java 9 Module name wrong for slf4j 2.x (logging-log4j2)

2023-11-21 Thread via GitHub
aschepp commented on issue #1983: URL: https://github.com/apache/logging-log4j2/issues/1983#issuecomment-1821605633 Downgrade to 2.21.1 worked. Thanks for the quick help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] Sync and move Java EE modules to a new repo in `3.x` (logging-log4j2)

2023-11-21 Thread via GitHub
vy commented on issue #1966: URL: https://github.com/apache/logging-log4j2/issues/1966#issuecomment-1821571454 * [logging-log4j-jakarta](/apache/logging-log4j-jakarta) repository is created with [a website](https://logging.staged.apache.org/log4j/jakarta) * JEE modules are removed (#1981

Re: [I] Sync and move Java EE modules to a new repo in `3.x` (logging-log4j2)

2023-11-21 Thread via GitHub
vy closed issue #1966: Sync and move Java EE modules to a new repo in `3.x` URL: https://github.com/apache/logging-log4j2/issues/1966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Delete Java EE and Jakarta EE modules (logging-log4j2)

2023-11-21 Thread via GitHub
vy merged PR #1981: URL: https://github.com/apache/logging-log4j2/pull/1981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Delete Java EE and Jakarta EE modules (logging-log4j2)

2023-11-21 Thread via GitHub
vy commented on code in PR #1981: URL: https://github.com/apache/logging-log4j2/pull/1981#discussion_r1401079821 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/filter/HttpThreadContextMapFilterTest.java: ## @@ -16,183 +16,98 @@ */ package org.apache.logging.lo

Re: [PR] Work towards supporting Java 17 builds (logging-log4j2)

2023-11-21 Thread via GitHub
ppkarwasz commented on PR #1964: URL: https://github.com/apache/logging-log4j2/pull/1964#issuecomment-1821560341 @jvz, When you fix the tests under Java 17, can you close #1851 and fix apache/logging-parent#62 ? -- This is an automated message from the Apache Git Service. To respon

Re: [I] Java 9 Module name wrong for slf4j 2.x (logging-log4j2)

2023-11-21 Thread via GitHub
ppkarwasz commented on issue #1983: URL: https://github.com/apache/logging-log4j2/issues/1983#issuecomment-1821552286 @aschepp, Thank you for noticing. We use BND to generate both our OSGi and JPMS descriptors. The problem is caused by the multi-release nature of `slf4j-api` 2

Re: [I] Java 9 Module name wrong for slf4j 2.x (logging-log4j2)

2023-11-21 Thread via GitHub
ppkarwasz closed issue #1983: Java 9 Module name wrong for slf4j 2.x URL: https://github.com/apache/logging-log4j2/issues/1983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[I] Java 9 Module name wrong for slf4j 2.x (logging-log4j2)

2023-11-21 Thread via GitHub
aschepp opened a new issue, #1983: URL: https://github.com/apache/logging-log4j2/issues/1983 ## Description The module log4j-to-slf4j currently uses the following module-info.class: ``` module org.apache.logging.log4j.to.slf4j { requires java.base; requires org.

Re: [PR] Use parameterized logging instead of string concatenation (logging-log4j2)

2023-11-21 Thread via GitHub
ppkarwasz merged PR #1982: URL: https://github.com/apache/logging-log4j2/pull/1982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump org.postgresql:postgresql from 42.6.0 to 42.7.0 [logging-log4j-audit]

2023-11-21 Thread via GitHub
github-actions[bot] commented on PR #92: URL: https://github.com/apache/logging-log4j-audit/pull/92#issuecomment-1821233504 Changes are applied by CI in 08cbe3a0cf8cd37ab08aed0973e6c73473bc7592 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Bump org.postgresql:postgresql from 42.6.0 to 42.7.0 [logging-log4j-audit]

2023-11-21 Thread via GitHub
dependabot[bot] commented on PR #92: URL: https://github.com/apache/logging-log4j-audit/pull/92#issuecomment-1821233608 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor ver

Re: [PR] Bump org.postgresql:postgresql from 42.6.0 to 42.7.0 [logging-log4j-audit]

2023-11-21 Thread via GitHub
github-actions[bot] closed pull request #92: Bump org.postgresql:postgresql from 42.6.0 to 42.7.0 URL: https://github.com/apache/logging-log4j-audit/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Bump org.postgresql:postgresql from 42.6.0 to 42.7.0 [logging-log4j-audit]

2023-11-21 Thread via GitHub
dependabot[bot] opened a new pull request, #92: URL: https://github.com/apache/logging-log4j-audit/pull/92 Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.6.0 to 42.7.0. Release notes Sourced from https://github.com/pgjdbc/pgjdbc/releases";>org.postgresq

Re: [PR] MDC and NDC availablity no longer depend on APR thread support [logging-log4cxx]

2023-11-21 Thread via GitHub
rm5248 commented on code in PR #299: URL: https://github.com/apache/logging-log4cxx/pull/299#discussion_r1400635186 ## src/main/cpp/threadspecificdata.cpp: ## @@ -60,13 +60,16 @@ ThreadSpecificData& ThreadSpecificData::getDataNoThreads() ThreadSpecificData* ThreadSpecificData

Re: [PR] Delete Java EE and Jakarta EE modules (logging-log4j2)

2023-11-21 Thread via GitHub
ppkarwasz commented on code in PR #1981: URL: https://github.com/apache/logging-log4j2/pull/1981#discussion_r1400552958 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/filter/HttpThreadContextMapFilterTest.java: ## @@ -16,183 +16,98 @@ */ package org.apache.log

Re: [I] [MS4] Modernization #2 (logging-log4j2)

2023-11-21 Thread via GitHub
ppkarwasz closed issue #1706: [MS4] Modernization #2 URL: https://github.com/apache/logging-log4j2/issues/1706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [I] [MS4] Modernization #2 (logging-log4j2)

2023-11-21 Thread via GitHub
ppkarwasz commented on issue #1706: URL: https://github.com/apache/logging-log4j2/issues/1706#issuecomment-1820711658 After applying the Palantir formatter and all the [Migrate to Java 11](https://docs.openrewrite.org/recipes/java/migrate/java8tojava11) (Java 11 is the currently agreed bas

Re: [PR] LOG4J2-3672 Avoid invoking `DateFormatSymbols.getZoneStrings()` in `FastDateParser` (logging-log4j2)

2023-11-21 Thread via GitHub
tristantarrant commented on PR #1848: URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1820588317 @vy just to let you know that our application initial heap footprint went down from ~31MB to 25MB (we also disabled initialization of JMX) thanks to this. Thanks again. --

[jira] [Commented] (LOG4J2-1477) @NonNull support (for @NonNullByDefault or similar)

2023-11-21 Thread Greg Thomas (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788345#comment-17788345 ] Greg Thomas commented on LOG4J2-1477: - > I can make some aliases in the API to make

Re: [PR] Delete Java EE and Jakarta EE modules (logging-log4j2)

2023-11-21 Thread via GitHub
vy commented on code in PR #1981: URL: https://github.com/apache/logging-log4j2/pull/1981#discussion_r1400292319 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/filter/HttpThreadContextMapFilterTest.java: ## @@ -1,198 +0,0 @@ -/* - * Licensed to the Apache Softwar

Re: [PR] Delete Java EE and Jakarta EE modules (logging-log4j2)

2023-11-21 Thread via GitHub
vy commented on code in PR #1981: URL: https://github.com/apache/logging-log4j2/pull/1981#discussion_r1400163149 ## log4j-jeromq/pom.xml: ## @@ -30,7 +30,7 @@ ${basedir}/.. Log4j ZeroMQ using JeroMQ Documentation -/log4j-jpa +/log4j-jeromq Review Comment:

Re: [PR] Delete Java EE and Jakarta EE modules (logging-log4j2)

2023-11-21 Thread via GitHub
vy commented on code in PR #1981: URL: https://github.com/apache/logging-log4j2/pull/1981#discussion_r1400162350 ## src/changelog/.3.x.x/remove_jakarta_ee.xml: ## @@ -15,15 +15,12 @@ ~ See the License for the specific language governing permissions and ~ limitations under

Re: [PR] Delete Java EE and Jakarta EE modules (logging-log4j2)

2023-11-21 Thread via GitHub
vy commented on code in PR #1981: URL: https://github.com/apache/logging-log4j2/pull/1981#discussion_r1400160834 ## log4j-distribution/pom.xml: ## @@ -225,30 +225,6 @@ ${project.version} sources - Review Comment: No, it is not. But this is out of scop

Re: [PR] Delete Java EE and Jakarta EE modules (logging-log4j2)

2023-11-21 Thread via GitHub
vy commented on code in PR #1981: URL: https://github.com/apache/logging-log4j2/pull/1981#discussion_r1400160151 ## log4j-core/src/main/resources/Log4j-config.xsd: ## @@ -647,13 +647,9 @@ - - - Review Comment: Agree

Re: [PR] Delete Java EE and Jakarta EE modules (logging-log4j2)

2023-11-21 Thread via GitHub
vy commented on code in PR #1981: URL: https://github.com/apache/logging-log4j2/pull/1981#discussion_r1400158583 ## log4j-core-test/src/main/resources/Log4j-config.xsd: ## @@ -647,13 +647,9 @@ - - - Review Comment: