On Sat, 14 Jan 2012 09:57:56 +0100, Pieter Praet wrote:
> Full test coverage for getting, setting and removing options in
> notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config).
>
> ---
> +
> +# FIXME: Not the most robust nor portable solution here...
> +# Especially `hostname --do
I've just tried to compile notmuch, after having downloaded it a few
hours back, via: `git clone git://notmuchmail.org/git/notmuch`.
Unfortunately, even though I seem to have all needed dependencies in
place, during the build I ran into the following error:
lib/query.cc: In function 'int
_notmuch_t
On Sat, 14 Jan 2012 10:14:57 +0100, Pieter Praet wrote:
> On Fri, 13 Jan 2012 08:23:55 +, David Edmondson wrote:
> > On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote:
> > > Less code, same results, without sacrificing readability.
> >
> > +1, but why not replace non-branching `if' wit
On Tue, 10 Jan 2012 22:15:02 +0200, Jani Nikula wrote:
> I don't feel qualified to review,
Allow me to disagree: your feeling and reality appear to be disjoint ATM :)
Peace
--
Pieter
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmai
On Wed, 28 Dec 2011 08:29:58 +, David Edmondson wrote:
> As suggested by j4ni in #notmuch, rename
> `notmuch-jump-to-recent-buffer' as `notmuch-cycle-notmuch-buffers' and
> have it behave accordingly.
>
> Consider `message-mode' buffers to be of interest.
> ---
> emacs/notmuch.el | 42
On Thu, 12 Jan 2012 12:28:40 -0500, Austin Clements wrote:
> Quoth Pieter Praet on Jan 12 at 6:07 pm:
> > On Tue, 22 Nov 2011 22:40:21 -0500, Austin Clements
> > wrote:
> > > Quoth Jameson Graef Rollins on Nov 20 at 12:10 pm:
> > > > The open question seems to be how we handle the content encod
On Fri, 13 Jan 2012 16:06:17 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote:
> > Less code, same results, without sacrificing readability.
>
> Does this change correctly re-indent the line following the if/unless?
It does...
Or so I thought... I appear t
Less code, same results, without sacrificing readability.
---
emacs/notmuch-show.el | 20 +---
emacs/notmuch-wash.el | 47 +++
emacs/notmuch.el | 28 +---
3 files changed, 45 insertions(+), 50 deletions
On Fri, 13 Jan 2012 08:23:55 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote:
> > Less code, same results, without sacrificing readability.
>
> +1, but why not replace non-branching `if' with `when' as well?
I was planning to do that when the `unless' patc
When running the Emacs tests in verbose mode, only the first missing
prereq is reported because the `run_emacs' function is short-circuited
early:
#+begin_example
emacs: Testing emacs interface
missing prerequisites: [0] emacs(1)
skipping test: [0] Basic notmuch-hello view in ema
On Thu, 12 Jan 2012 21:34:29 +0400, Dmitry Kurochkin
wrote:
> On Thu, 12 Jan 2012 18:16:59 +0100, Pieter Praet wrote:
> > When running the Emacs tests in verbose mode, only the first missing
> > prereq is reported because the `run_emacs' function is short-circuited
> > early:
> >
> > #+begin_
On Fri, 13 Jan 2012 16:15:59 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 23:31:34 -0400, David Bremner wrote:
> > On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet wrote:
> > > To allow for expansion whilst keeping everything tidy and organized,
> > > move all defcustom/defface variables
To allow for expansion whilst keeping everything tidy and organized,
move all defcustom/defface variables to the following subgroups,
defined in notmuch-lib.el:
- Hello
- Search
- Show
- Send
- Crypto
- Hooks
- External Commands
- Appearance
As an added benefit, defcustom keyword args are now con
On Thu, 12 Jan 2012 23:31:34 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet wrote:
> > To allow for expansion whilst keeping everything tidy and organized,
> > move all defcustom/defface variables to the following subgroups,
> > defined in notmuch-lib.el:
> >
> >
On Thu, 12 Jan 2012 23:11:35 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:06:14 +0100, Pieter Praet wrote:
> > That would indeed have been the most sensible thing to do.
> >
> > Could someone (who -unlike me- has already submitted his/her public SSH
> > key for commit access) add somethi
On Thu, 12 Jan 2012 23:16:29 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:08:08 +0100, Pieter Praet wrote:
> > > > - The previous point is a bit of a counterargument to this, but in
>
> > > I couls separate it. I made is a single patch to avoid having a
> > > revision with broken emacs
Full test coverage for getting, setting and removing options in
notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config).
---
Please *do* take note of the FIXME in the last test!
test/config | 88 +
test/notmuch-test |1 +
On Thu, 12 Jan 2012 23:42:04 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet wrote:
> > Should have come before commit 1df71b55
>
> This doesn't seem like an especially helpful commit
> message. Editorializing is ok, I guess, but maybe keep it below the
> '---' ?
>
On Fri, 13 Jan 2012 05:05:35 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner wrote:
> > On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet wrote:
> > > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner
> > > wrote:
> >
> > > with differing hashes), this has the p
On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet wrote:
> > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner wrote:
>
> > with differing hashes), this has the potential of causing confusion
> > and/or quite some extra work when debuggi
Hi,
this is a followup to my mail from spring where i presented a partial
rewrite of the vim plugin using python. There weren't many comments back
then, so I hope there will be more now.
I've changed the filenames so my version now coexists with the current
vim plugin. You can find it in
git://g
101 - 121 of 121 matches
Mail list logo
