Re: [patch v5 2/6] lib: Let Xapian manage the memory for FieldProcessors

2017-02-19 Thread David Bremner
David Bremner writes: > It turns out this is exactly what release() is for; Xapian will > deallocate the objects when it's done with them. pushed the first two of this series to master ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmai

Re: read after free in notmuch new

2017-02-19 Thread David Bremner
David Bremner writes: > I haven't had a chance to really track this down, but it seems there is > a memory error in notmuch new (or a maybe false positive from valgrind). > > Attached is the log from running "make memory-test OPTIONS=--medium" on > current git master (0e037c34). > > It looks like

read after free in notmuch new

2017-02-19 Thread David Bremner
I haven't had a chance to really track this down, but it seems there is a memory error in notmuch new (or a maybe false positive from valgrind). Attached is the log from running "make memory-test OPTIONS=--medium" on current git master (0e037c34). It looks like we talloc the message_id string wi

[Tomi Ollila] Re: [PATCH 2/2] test: use gpgconf --create-socketdir if available

2017-02-19 Thread David Bremner
I'm pretty sure Tomi meant to complain publicly ;). --- Begin Message --- On Tue, Feb 14 2017, David Bremner wrote: > This enables the shortened socket pathes in /run or equivalent. The > explicit call to gpgconf is needed for nonstandard GNUPGHOME settings. 2½ comments inline: __> --- > tes

Re: [PATCH 2/2] test: use gpgconf --create-socketdir if available

2017-02-19 Thread Tomi Ollila
On Tue, Feb 14 2017, David Bremner wrote: > This enables the shortened socket pathes in /run or equivalent. The > explicit call to gpgconf is needed for nonstandard GNUPGHOME settings. 2½ comments inline: __> --- > test/test-lib.sh | 14 ++ > 1 file changed, 14 insertions(+) > > di