[PATCH v4 1/3] show: don't use hex literals in JSON output

2012-01-20 Thread Thomas Jost
On Fri, 20 Jan 2012 07:55:03 -0400, David Bremner wrote: > On Fri, 20 Jan 2012 10:39:23 +0100, Thomas Jost > wrote: > > JSON does not support hex literals (0x..) so numbers must be formatted as %d > > instead of %x. > > --- > > notmuch-show.c |2 +- > > 1 files changed, 1 insertions(+), 1 d

[PATCH v4 1/3] show: don't use hex literals in JSON output

2012-01-20 Thread Thomas Jost
JSON does not support hex literals (0x..) so numbers must be formatted as %d instead of %x. --- notmuch-show.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index d14dac9..91f566c 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -641,7

[PATCH v4 1/3] show: don't use hex literals in JSON output

2012-01-20 Thread David Bremner
On Fri, 20 Jan 2012 13:33:58 +0100, Thomas Jost wrote: > The most common gmime error codes are 1 (expired signature), 2 (no > public key), 4 (expired key) and 8 (revoked key). The other possible > value is 16 (unsupported algorithm) but obviously it is much more rare. > If this happens, the curr

[PATCH v4 1/3] show: don't use hex literals in JSON output

2012-01-20 Thread David Bremner
On Fri, 20 Jan 2012 10:39:23 +0100, Thomas Jost wrote: > JSON does not support hex literals (0x..) so numbers must be formatted as %d > instead of %x. > --- > notmuch-show.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Probably I'm just being lazy here, but can you explain why

Re: [PATCH v4 1/3] show: don't use hex literals in JSON output

2012-01-20 Thread David Bremner
On Fri, 20 Jan 2012 13:33:58 +0100, Thomas Jost wrote: > The most common gmime error codes are 1 (expired signature), 2 (no > public key), 4 (expired key) and 8 (revoked key). The other possible > value is 16 (unsupported algorithm) but obviously it is much more rare. > If this happens, the curre

Re: [PATCH v4 1/3] show: don't use hex literals in JSON output

2012-01-20 Thread Thomas Jost
On Fri, 20 Jan 2012 07:55:03 -0400, David Bremner wrote: > On Fri, 20 Jan 2012 10:39:23 +0100, Thomas Jost wrote: > > JSON does not support hex literals (0x..) so numbers must be formatted as %d > > instead of %x. > > --- > > notmuch-show.c |2 +- > > 1 files changed, 1 insertions(+), 1 dele

Re: [PATCH v4 1/3] show: don't use hex literals in JSON output

2012-01-20 Thread David Bremner
On Fri, 20 Jan 2012 10:39:23 +0100, Thomas Jost wrote: > JSON does not support hex literals (0x..) so numbers must be formatted as %d > instead of %x. > --- > notmuch-show.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Probably I'm just being lazy here, but can you explain why

[PATCH v4 1/3] show: don't use hex literals in JSON output

2012-01-20 Thread Thomas Jost
JSON does not support hex literals (0x..) so numbers must be formatted as %d instead of %x. --- notmuch-show.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index d14dac9..91f566c 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -641,7