[Numpy-discussion] Automatic formatters for only changed lines

2022-05-05 Thread Trevor Gross
Hey all, Matti pointed out to me that discussion of an autoformatter has come up before, with the decision that an entire codebase rewrite would be undesirable (ref: https://mail.python.org/pipermail/scipy-dev/2020-January/023927.html). As a result, tools/linter.py was added to only validate the c

[Numpy-discussion] Re: Automatic formatters for only changed lines

2022-05-05 Thread Stefan van der Walt
On Thu, May 5, 2022, at 12:00, Trevor Gross wrote: > I don't necessarily know that this should be enforced on CI off the bat > (though in the future it could be), but at least having the tool available > and easily usable would help to incrementally improve codebase style, and > remove the need

[Numpy-discussion] Re: Automatic formatters for only changed lines

2022-05-05 Thread Matti Picus
On 6/5/22 01:32, Stefan van der Walt wrote: On Thu, May 5, 2022, at 12:00, Trevor Gross wrote: I don't necessarily know that this should be enforced on CI off the bat (though in the future it could be), but at least having the tool available and easily usable would help to incrementally improv

[Numpy-discussion] Re: Automatic formatters for only changed lines

2022-05-05 Thread Stefan van der Walt
Hi Matti, On Thu, May 5, 2022, at 22:08, Matti Picus wrote: > This somehow runs when I do "git commit"? Do I need to add anything to > my git environment to pick up the hook? How do I turn it off if I find > it prevents progress or breaks? Do we need to add anything to the > documentation to wa