[Numpy-discussion] Adding fweights and aweights to numpy.corrcoef

2018-04-26 Thread Corin Hoad
Hello, Would it be possible to add the fweights and aweights keyword arguments from np.cov to np.corrcoef? They would retain their meaning from np.cov as frequency- or importance-based weightings respectively. Yours, Corin Hoad ___ NumPy-Discussion

Re: [Numpy-discussion] Adding fweights and aweights to numpy.corrcoef

2018-04-27 Thread Corin Hoad
ef is just rescaling the cov, so there is nothing special to add > except that corrcoef hands off the options to cov. > This was my understanding. I am currently just using my own copy of corrcoef which forwards the aweights and fweights arguments directly to np

Re: [Numpy-discussion] Adding fweights and aweights to numpy.corrcoef

2018-05-11 Thread Corin Hoad
Are there any further thoughts on this? If it's simply allowing corrcoef to hand off the keyword arguments to cov I can make a simple PR with the change. Corin Hoad On Fri, 27 Apr 2018 at 10:44 Corin Hoad wrote: > I seem to recall that there was a discussion on this and it w

Re: [Numpy-discussion] Adding fweights and aweights to numpy.corrcoef

2018-05-12 Thread Corin Hoad
The discussed changes are implemented in PR #11078 Corin On Fri, 11 May 2018 at 15:07 wrote: > On Fri, May 11, 2018 at 7:43 AM, Corin Hoad wrote: > >> Are there any further thoughts on this? If it's simply allowing corrcoef >> to hand off the keyword arguments to cov