[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097885#comment-15097885
]
Tomek Rękawek commented on OAK-3637:
Agreed on the complexity. However, I think the performance gain is
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097911#comment-15097911
]
Julian Reschke commented on OAK-3637:
-
We don't need a separate fixture. We can just require that if
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097934#comment-15097934
]
Tomek Rękawek commented on OAK-3637:
(y)
> Bulk document updates in RDBDocumentStore
>
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097897#comment-15097897
]
Marcel Reutegger commented on OAK-3637:
---
The _modCount is optional and a DocumentStore implementation
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097904#comment-15097904
]
Tomek Rękawek commented on OAK-3637:
[~mreutegg], thanks for the clarification. I updated the patch once
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097943#comment-15097943
]
Julian Reschke commented on OAK-3637:
-
Thanks. Will take it from here.
> Bulk document updates in
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098088#comment-15098088
]
Julian Reschke commented on OAK-3637:
-
Current changes in trunk: http://svn.apache.org/r1724598
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096281#comment-15096281
]
Tomek Rękawek commented on OAK-3637:
[~reschke], I've noticed that the bulk createOrUpdate() method
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096330#comment-15096330
]
Julian Reschke commented on OAK-3637:
-
OK, will have a look.
> Bulk document updates in
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063759#comment-15063759
]
Tomek Rękawek commented on OAK-3637:
[~reschke], thanks for the detailed review!
{quote}
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062157#comment-15062157
]
Julian Reschke commented on OAK-3637:
-
[~tomek.rekawek]: any chance you could update your patch to apply
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037556#comment-15037556
]
Julian Reschke commented on OAK-3637:
-
One more thing we should be careful with: creating too many
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037566#comment-15037566
]
Tomek Rękawek commented on OAK-3637:
Good point. In the new methods I marked statements with variable
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036018#comment-15036018
]
Julian Reschke commented on OAK-3637:
-
Tried the patches without changing the test...:
{{code}}
#
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035958#comment-15035958
]
Tomek Rękawek commented on OAK-3637:
Thanks for the comment. I removed the changes related to ResultSets
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035941#comment-15035941
]
Julian Reschke commented on OAK-3637:
-
That's a lot to review. It would be helpful if this patch only
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028383#comment-15028383
]
Tomek Rękawek commented on OAK-3637:
[~julian.resc...@gmx.de], could you review the patch? It can't be
[
https://issues.apache.org/jira/browse/OAK-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022202#comment-15022202
]
Tomek Rękawek commented on OAK-3637:
I've run the {{CreateManyChildNodesTest}} benchmark, using the
18 matches
Mail list logo
