[jira] [Commented] (OAK-3869) Refactor RecordWriter.write to always return a RecordId

2016-01-12 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094832#comment-15094832 ] Michael Dürig commented on OAK-3869: bq. losing some type safety Right. Though we never had the that

[jira] [Commented] (OAK-3869) Refactor RecordWriter.write to always return a RecordId

2016-01-12 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094883#comment-15094883 ] Michael Dürig commented on OAK-3869: See

[jira] [Commented] (OAK-3869) Refactor RecordWriter.write to always return a RecordId

2016-01-12 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094049#comment-15094049 ] Francesco Mari commented on OAK-3869: - I like the API of the class after your change. It looks more

[jira] [Commented] (OAK-3869) Refactor RecordWriter.write to always return a RecordId

2016-01-12 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094084#comment-15094084 ] Alex Parvulescu commented on OAK-3869: -- looks good, although you are some type safety which is not