[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-13 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572315#comment-15572315 ] Stefan Egli commented on OAK-4924: -- Created OAK-4935 to track this further > avoid CommitI

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-12 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568339#comment-15568339 ] Chetan Mehrotra commented on OAK-4924: -- bq. Which means that we can't prefilter async i

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-12 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568035#comment-15568035 ] Alex Parvulescu commented on OAK-4924: -- bq. Stefan Egli I think that usage is fine. Sim

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-11 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567829#comment-15567829 ] Chetan Mehrotra commented on OAK-4924: -- [~egli] I think that usage is fine. Similar wou

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-11 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565820#comment-15565820 ] Stefan Egli commented on OAK-4924: -- Agreed that EMPTY is used elsewhere too - I believe mos

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-11 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565740#comment-15565740 ] Alex Parvulescu commented on OAK-4924: -- I quite a lot of code in {{oak-core}} using {{E

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-11 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565616#comment-15565616 ] Stefan Egli commented on OAK-4924: -- The problem with {{EMPTY}} is actually that it is read-

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-11 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565620#comment-15565620 ] Stefan Egli commented on OAK-4924: -- or let's say it is meant to be read-only - it's not act

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-11 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565598#comment-15565598 ] Alex Parvulescu commented on OAK-4924: -- so does this cover everything? https://github.

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-11 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565579#comment-15565579 ] Michael Dürig commented on OAK-4924: +1 > avoid CommitInfo==null in contentChanged call

[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

2016-10-11 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565578#comment-15565578 ] Alex Parvulescu commented on OAK-4924: -- if it's just about using EMPTY [0], instead of