Re: [PATCH 3/3] message: Code independent of protocol stack

2011-01-13 Thread Denis Kenzior
Hi Faiyaz, >> Please keep this as an internal API (e.g. >> __ofono_message_path_from_uuid) and update ofono.h appropriately. > > Based on a comment in Patch 2/3, message.h and message.c are internal to > core and to me they look more of a utility/helper functions to sms.c > file (and in future cd

Re: [PATCH 3/3] message: Code independent of protocol stack

2011-01-13 Thread Faiyaz Baxamusa
Hi Denis: On 01/13/2011 10:20 AM, ext Denis Kenzior wrote: Hi Faiyaz, +static const char *message_state_to_string(enum message_state s) +{ + switch (s) { + case MESSAGE_STATE_PENDING: + return "pending"; + case MESSAGE_STATE_SENT: + return "sent";

Re: [PATCH 3/3] message: Code independent of protocol stack

2011-01-13 Thread Denis Kenzior
Hi Faiyaz, > +static const char *message_state_to_string(enum message_state s) > +{ > + switch (s) { > + case MESSAGE_STATE_PENDING: > + return "pending"; > + case MESSAGE_STATE_SENT: > + return "sent"; > + case MESSAGE_STATE_FAILED: > + return "

[PATCH 3/3] message: Code independent of protocol stack

2011-01-06 Thread Faiyaz Baxamusa
--- Makefile.am |2 +- src/message.c | 257 src/ofono.h |2 + src/sms.c | 258 4 files changed, 297 insertions(+), 222 deletions(-) create mode 100644 src/message.c