Hi Marcel.
> I do need another look at the RTNL magic and casting. That always drives
> my crazy when I look at that. In the meantime, please address these
> details first.
I have some RTNL unit tests ready if your're interested.
Also I hope I have closed most open issues from your review
in the
Hi Sjur,
> > > +static GSList *pending_requests;
> > > +static GIOChannel *channel;
> > > +static guint32 rtnl_seqnr;
> > > +static guint rtnl_watch;
> >
> > To be fair, you don't need both, the GIOChannel and the watch. You can
> > just add the watch and then unref the GIOChannel and set it to
Hi Marcel.
> > +static GSList *pending_requests;
> > +static GIOChannel *channel;
> > +static guint32 rtnl_seqnr;
> > +static guint rtnl_watch;
>
> To be fair, you don't need both, the GIOChannel and the watch. You can
> just add the watch and then unref the GIOChannel and set it to close on
> u
Hi Sjur,
> > You don't really have to play this append/remove game. You can just
> > append it after send_rtnl_req succeed. The read goes via the mainloop
> > anyway and we are a single threaded program. So the order is
> > guaranteed.
>
> I'm not sure about this. I need to keep track of what
> c
> From: Marcel Holtmann [mailto:mar...@holtmann.org]
>
> just to be clear. You want to name it like this? I am just asking here
> since I made a few proposals.
No worries :-)
The file is called caif_rtnl and exported functions are prefixed caif_rtnl,
I think that makes a lot of sense.
>
> > +#d
Hi Sjur,
> Makefile.am |2 +
> drivers/stemodem/caif_rtnl.c | 365
> ++
> drivers/stemodem/caif_rtnl.h | 40 +
> 3 files changed, 407 insertions(+), 0 deletions(-)
> create mode 100644 drivers/stemodem/caif_rtnl.c
> create mod
From: Sjur Brændeland
---
Changes from last patch-set:
o squashed previous patches for rtnl.c, rtnl.h and Makefile.am into one patch
o renamed rtnl.[ch] to caif_rtnl.[ch]
o renamed rtnl_init and rtnl_exit to caif_rtnl_*
o renamed rtnl_create_caif_interface to caif_rtnl_create_interface.
Makefil
