---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review29923
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated March 26, 2013, 9:49 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated March 25, 2013, 6:56 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated March 25, 2013, 7:51 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review29342
---
Does KRun know how to run www.google.com ? Doesn't seem to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review29219
---
tests/urldetecttest.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated March 13, 2013, 2:28 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated March 13, 2013, 2:38 p.m.)
Review request for Okular.
Changes
On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
Seems more appropriate for me. But one more thing, is reg1 still needed?
Jaydeep Solanki wrote:
Yes, because it prevents asdfhttp://www.google.com; from getting
detected.
I think that for this it is not necessary.
Because of \b in
On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
Seems more appropriate for me. But one more thing, is reg1 still needed?
Jaydeep Solanki wrote:
Yes, because it prevents asdfhttp://www.google.com; from getting
detected.
Azat Khuzhin wrote:
I think that for this it is not
On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
Seems more appropriate for me. But one more thing, is reg1 still needed?
Yes, because it prevents asdfhttp://www.google.com; from getting detected.
- Jaydeep
---
This is an
On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
Seems more appropriate for me. But one more thing, is reg1 still needed?
Jaydeep Solanki wrote:
Yes, because it prevents asdfhttp://www.google.com; from getting
detected.
Azat Khuzhin wrote:
I think that for this it is not
On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
Seems more appropriate for me. But one more thing, is reg1 still needed?
Jaydeep Solanki wrote:
Yes, because it prevents asdfhttp://www.google.com; from getting
detected.
Azat Khuzhin wrote:
I think that for this it is not
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated March 9, 2013, 8:13 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28579
---
It trims up to ascii characters.
Example: http://google.com/ф;
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated March 5, 2013, 1:26 p.m.)
Review request for Okular.
Changes
On March 3, 2013, 4:47 p.m., Albert Astals Cid wrote:
This is still detecting http://google.com) as something you can call open
link on. I'm not sure if http://google.com) is valid or not, but when you
click on the Go got 'http://google.com)' I am getting a Malformed URL
error.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28482
---
http://google.com) is not a valid URL.
Because host/port can't
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28459
---
This is still detecting http://google.com) as something you
On March 1, 2013, 6:33 p.m., Albert Astals Cid wrote:
Why the exceptions? Looks a bit weird to me.
Please elaborate.
- Jaydeep
---
This is an automatically generated e-mail. To reply, visit:
On March 1, 2013, 6:33 p.m., Albert Astals Cid wrote:
Why the exceptions? Looks a bit weird to me.
Jaydeep Solanki wrote:
Please elaborate.
Why would you want to detect google.com) as a url?
- Albert
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated March 2, 2013, 10:33 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated March 2, 2013, 10:39 p.m.)
Review request for Okular.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28357
---
Why the exceptions? Looks a bit weird to me.
- Albert Astals
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated Feb. 24, 2013, 1:55 a.m.)
Review request for Okular.
Changes
On Feb. 21, 2013, 3:29 p.m., Albert Astals Cid wrote:
ui/pageview.cpp, line 2185
http://git.reviewboard.kde.org/r/108614/diff/3/?file=114545#file114545line2185
This regexp still needs some tweaking, right now if i pass
holahttps://okular.org; it returns https://okular.org that in
On Feb. 21, 2013, 3:29 p.m., Albert Astals Cid wrote:
ui/pageview.cpp, line 2183
http://git.reviewboard.kde.org/r/108614/diff/3/?file=114545#file114545line2183
Mere looks, please put the static on front
oops!
On Feb. 21, 2013, 3:29 p.m., Albert Astals Cid wrote:
On Feb. 21, 2013, 3:29 p.m., Albert Astals Cid wrote:
ui/pageview.cpp, line 2185
http://git.reviewboard.kde.org/r/108614/diff/3/?file=114545#file114545line2185
This regexp still needs some tweaking, right now if i pass
holahttps://okular.org; it returns https://okular.org that in
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review27875
---
- Mailson Menezes
On Feb. 20, 2013, 2:21 p.m., Jaydeep
On Feb. 21, 2013, 3:29 p.m., Albert Astals Cid wrote:
ui/pageview.cpp, line 2185
http://git.reviewboard.kde.org/r/108614/diff/3/?file=114545#file114545line2185
This regexp still needs some tweaking, right now if i pass
holahttps://okular.org; it returns https://okular.org that in
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated Feb. 20, 2013, 2:21 p.m.)
Review request for Okular.
Changes
On Jan. 27, 2013, 7:02 p.m., Albert Astals Cid wrote:
ui/pageview.cpp, line 2775
http://git.reviewboard.kde.org/r/108614/diff/1/?file=109368#file109368line2775
Why did you decide that icon name?
Jaydeep Solanki wrote:
I had two options for goto icon, go_goto go_goto_page
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review27674
---
ui/pageview.cpp
On Jan. 27, 2013, 7:02 p.m., Albert Astals Cid wrote:
ui/pageview.cpp, line 2775
http://git.reviewboard.kde.org/r/108614/diff/1/?file=109368#file109368line2775
Why did you decide that icon name?
Jaydeep Solanki wrote:
I had two options for goto icon, go_goto go_goto_page
On Jan. 27, 2013, 7:02 p.m., Albert Astals Cid wrote:
ui/pageview.cpp, line 2775
http://git.reviewboard.kde.org/r/108614/diff/1/?file=109368#file109368line2775
Why did you decide that icon name?
Jaydeep Solanki wrote:
I had two options for goto icon, go_goto go_goto_page
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---
(Updated Feb. 17, 2013, 7:04 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review26271
---
ui/pageview.cpp
37 matches
Mail list logo
