Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-02-09 Thread Mike Christie
Boaz Harrosh wrote: > Mike Christie wrote: >> Boaz Harrosh wrote: >>> Remove the dark ages /* define debug_print */ in code, to use >>> a Kconfig option. With a system like Kconfig, in code, commented out, >>> configuration options are slavery and hard work. >>> (version control, manual edit ... n

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-02-09 Thread Boaz Harrosh
Mike Christie wrote: > Boaz Harrosh wrote: >> Remove the dark ages /* define debug_print */ in code, to use >> a Kconfig option. With a system like Kconfig, in code, commented out, >> configuration options are slavery and hard work. >> (version control, manual edit ... need I say more) >> >> I've

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-02-08 Thread Mike Christie
Boaz Harrosh wrote: > Remove the dark ages /* define debug_print */ in code, to use > a Kconfig option. With a system like Kconfig, in code, commented out, > configuration options are slavery and hard work. > (version control, manual edit ... need I say more) > > I've used an "int" config bit-mask

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-14 Thread Randy Dunlap
Boaz Harrosh wrote: > Remove the dark ages /* define debug_print */ in code, to use > a Kconfig option. With a system like Kconfig, in code, commented out, > configuration options are slavery and hard work. > (version control, manual edit ... need I say more) > > I've used an "int" config bit-mas

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Randy Dunlap wrote: > Boaz Harrosh wrote: >> Remove the dark ages /* define debug_print */ in code, to use >> a Kconfig option. With a system like Kconfig, in code, commented out, >> configuration options are slavery and hard work. >> (version control, manual edit ... need I say more) >> >> I've u

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Mike Christie wrote: > Boaz Harrosh wrote: >> Boaz Harrosh wrote: >>> Remove the dark ages /* define debug_print */ in code, to use >>> a Kconfig option. With a system like Kconfig, in code, commented out, >>> configuration options are slavery and hard work. >>> (version control, manual edit ... n

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Mike Christie
Boaz Harrosh wrote: > Boaz Harrosh wrote: >> Remove the dark ages /* define debug_print */ in code, to use >> a Kconfig option. With a system like Kconfig, in code, commented out, >> configuration options are slavery and hard work. >> (version control, manual edit ... need I say more) >> >> I've us

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Ulrich Windl wrote: > On 12 Jan 2009 at 17:33, Boaz Harrosh wrote: > >> --- a/drivers/scsi/iscsi_tcp.h >> +++ b/drivers/scsi/iscsi_tcp.h >> @@ -25,6 +25,12 @@ >> #include >> #include >> >> +#if (CONFIG_ISCSI_DEBUG & 2) >> +#define debug_tcp(fmt...) printk(KERN_INFO "tcp: " fmt) >> +#else >>

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Ulrich Windl
On 12 Jan 2009 at 17:33, Boaz Harrosh wrote: > --- a/drivers/scsi/iscsi_tcp.h > +++ b/drivers/scsi/iscsi_tcp.h > @@ -25,6 +25,12 @@ > #include > #include > > +#if (CONFIG_ISCSI_DEBUG & 2) > +#define debug_tcp(fmt...) printk(KERN_INFO "tcp: " fmt) > +#else > +#define debug_tcp(fmt...) > +#en

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Boaz Harrosh wrote: > > Remove the dark ages /* define debug_print */ in code, to use > a Kconfig option. With a system like Kconfig, in code, commented out, > configuration options are slavery and hard work. > (version control, manual edit ... need I say more) > > I've used an "int" config bit-

[PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say more) I've used an "int" config bit-mask so more areas of code can be