Re: [openib-general] [PATCH] sa_query: Add service record support

2005-07-05 Thread Roland Dreier
+#define IB_DEFAULT_SERVICE_LEASE 0x This doesn't seem to be used anywhere? + /* u16 resv; */ Can we just delete this comment? + query-sa_query.callback = ib_sa_service_rec_callback; This should probably handle a consumer passing in a NULL

Re: [openib-general] [PATCH] sa_query: Add service record support

2005-07-05 Thread Hal Rosenstock
On Tue, 2005-07-05 at 15:34, Roland Dreier wrote: +#define IB_DEFAULT_SERVICE_LEASE 0x This doesn't seem to be used anywhere? Right. It is a convenient define for a consumer using Service Records. I would prefer to leave it in there despite it not being used. +

Re: [openib-general] [PATCH] sa_query: Add service record support

2005-07-05 Thread Roland Dreier
Hal Right. It is a convenient define for a consumer using Service Hal Records. I would prefer to leave it in there despite it not Hal being used. OK, that's fine. Hal It does map to the actual SR layout and path record indicates Hal where the reserved fields are. Hal Is

Re: [openib-general] [PATCH] sa_query: Add service record support

2005-07-05 Thread Hal Rosenstock
On Tue, 2005-07-05 at 16:33, Roland Dreier wrote: Hal Right. It is a convenient define for a consumer using Service Hal Records. I would prefer to leave it in there despite it not Hal being used. OK, that's fine. Hal It does map to the actual SR layout and path record

[openib-general] [PATCH] sa_query: Add service record support

2005-06-30 Thread Hal Rosenstock
sa_query: Add service record support Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/ib_sa.h === --- include/ib_sa.h (revision 2757) +++ include/ib_sa.h (working copy) @@ -1,5 +1,6 @@ /* * Copyright (c)

[openib-general] [PATCH] sa_query: Add service record support

2005-06-28 Thread Hal Rosenstock
sa_query: Add service record support Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/ib_sa.h === -- include/ib_sa.h (revision 2732) +++ include/ib_sa.h (working copy) @@ -1,5 +1,6 @@ /* * Copyright (c)