Re: [Integrated] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-02-03 Thread Guru Hb
Changeset: aa91ebbb Author:Guru Hb Date: 2020-02-03 08:51:25 + URL: https://git.openjdk.java.net/jfx/commit/aa91ebbb 8237944: webview native cl "-m32" unknown option for windows 32-bit build Reviewed-by: kcr ! modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-30 Thread Kevin Rushforth
On Wed, 29 Jan 2020 15:36:52 GMT, Guru Hb wrote: >> Marked as reviewed by kcr (Lead). > >> the -m32 option seems to be ignored by the compiler: >> cl : Command line warning D9002 : ignoring unknown option '-m32' >> >> However, I agree it is better to conditionally remove it. > "-m32" required f

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-29 Thread Guru Hb
On Wed, 29 Jan 2020 12:57:41 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > Marked as reviewed by kcr (Lead). > the -m32 option seems to be ignored by the compiler: > cl : Command line warning D9002 : ignoring unknown option '-m32' > > However, I

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-29 Thread Kevin Rushforth
On Wed, 29 Jan 2020 12:58:00 GMT, Guru Hb wrote: >> cl : Command line warning D9002 : ignoring unknown option '-m32' >> >> post fix for "https://trac.webkit.org/changeset/242724/webkit"; makes use of >> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. >> '-m32' flag is

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-29 Thread Guru Hb
> cl : Command line warning D9002 : ignoring unknown option '-m32' > > post fix for "https://trac.webkit.org/changeset/242724/webkit"; makes use of > cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. > '-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-29 Thread Guru Hb
On Tue, 28 Jan 2020 23:42:08 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm line 2300: > >> 2299: >> 2300: if (architecture() eq "x86_64" && shouldBuild32Bit() && (isJava() >> &&

Re: RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-28 Thread Kevin Rushforth
On Tue, 28 Jan 2020 09:50:27 GMT, Guru Hb wrote: > cl : Command line warning D9002 : ignoring unknown option '-m32' > > post fix for "https://trac.webkit.org/changeset/242724/webkit"; makes use of > cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. > '-m32' flag is gcc

Re: RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-28 Thread Kevin Rushforth
On Tue, 28 Jan 2020 21:03:01 GMT, Johan Vos wrote: >> cl : Command line warning D9002 : ignoring unknown option '-m32' >> >> post fix for "https://trac.webkit.org/changeset/242724/webkit"; makes use of >> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. >> '-m32' flag

Re: RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-28 Thread Johan Vos
On Tue, 28 Jan 2020 09:50:27 GMT, Guru Hb wrote: > cl : Command line warning D9002 : ignoring unknown option '-m32' > > post fix for "https://trac.webkit.org/changeset/242724/webkit"; makes use of > cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. > '-m32' flag is gcc

RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-28 Thread Guru Hb
cl : Command line warning D9002 : ignoring unknown option '-m32' post fix for "https://trac.webkit.org/changeset/242724/webkit"; makes use of cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. '-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn't recogn