FX doesn't always warn you (as it would mean putting thread checks
everywhere).
The first trace however shows that the change to the TextArea did not
originate from the FX thread.
--John
On 19/12/2023 18:17, Frank Delporte wrote:
Thanks John, quick test with this change indeed seems to solve
On Mon, 18 Dec 2023 15:51:01 GMT, Jose Pereda wrote:
>> This PR fixes an issue when a new `TableColumn` is added to a `TableView`
>> control with fixed cell size set, where the `TableRowSkinBase` failed to add
>> the cells for the new column.
>>
>> A test is included that fails before applying
You are right: the weak references are not suitable in this case.
These cases are clearly bugs in the skins, we should log them (unless already
logged); I don’t think we need new APIs.
See
https://bugs.openjdk.org/issues/?jql=text%20~%20%22skin%20cleanup%22%20AND%20project%20%3D%20JDK%20AND%20c
Thanks John, quick test with this change indeed seems to solve the problem!
Platform.runLater(() -> searchAction.appendAnswer(token));
I totally missed this and I didn't notice anything in the logs that was
pointing in this direction.
Best regards
Frank Delporte
Want to have coding-fun?
On Tue, 19 Dec 2023 12:24:14 GMT, Johan Vos wrote:
> As for the memory leak issue: there were several. The first commit in this PR
> fixed a clear memory leak, but the one that is still left is not described in
> the issue. It occurs because whenever the SystemMenuBar is shown after it was
> n
On Mon, 18 Dec 2023 13:18:02 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one addition
On Tue, 19 Dec 2023 09:59:32 GMT, John Hendrikx wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix more memoryleaks due to listeners never being unregistered.
>
> Would it be an idea to do deterministic clean-up?
>
On Mon, 18 Dec 2023 13:18:02 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one addition
On Mon, 18 Dec 2023 13:18:02 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one addition
It looks like you are manipulating a property that is bound to a UI
control on an external thread.
Property manipulations that are tied to controls that are part of an
active (visible) Scene **must** be done on the FX thread.
Try:
StreamingResponseHandler streamingResponseHandler = new
On Mon, 18 Dec 2023 22:00:28 GMT, Kevin Rushforth wrote:
> I did a build with GTK 3.22 (so it compiles the new code, does the dlsym, and
> does the runtime check) and verified that there are no regressions when
> running on an older system (Ubuntu 16.04).
That sounds good.
> If we decide that
On Mon, 18 Dec 2023 13:18:02 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one addition
Hi, while experimenting with a ChatGPT-like user interface, I found a crashing
JVM with different types of errors when streaming the response towards a
TextArea. This is probably caused by too fast refreshes of the text as pieces
of content are received within the same milliseconds:
19/12/202
13 matches
Mail list logo