On Thu, 13 Oct 2022 04:25:19 GMT, Alexander Matveev
wrote:
>> - Added support for JAR and JRT protocol to AVFoundation platform.
>> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
>> primary used to playback these formats for JAR and JRT protocols.
>> - Added ability to
On Thu, 13 Oct 2022 04:25:19 GMT, Alexander Matveev
wrote:
>> - Added support for JAR and JRT protocol to AVFoundation platform.
>> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
>> primary used to playback these formats for JAR and JRT protocols.
>> - Added ability to
On Thu, 13 Oct 2022 22:24:06 GMT, Andy Goryachev wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8287822: [macos] Remove support of duplicated formats from macOS [v3]
>
> tests/manual/media/FXMediaPlayer/src/f
On Thu, 13 Oct 2022 22:23:08 GMT, Andy Goryachev wrote:
>> Related question: Can `uri` itself be null?
>
> so the logic seems to be either a "jar", or else it's a file, right?
> is it possible to be something else (i.e. the resource is missing
> altogether)? or some other condition?
Yes, when w
On Thu, 13 Oct 2022 04:25:19 GMT, Alexander Matveev
wrote:
>> - Added support for JAR and JRT protocol to AVFoundation platform.
>> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
>> primary used to playback these formats for JAR and JRT protocols.
>> - Added ability to
On Tue, 11 Oct 2022 21:41:55 GMT, Kevin Rushforth wrote:
>> tests/manual/media/FXMediaPlayer/src/fxmediaplayer/media/FXMedia.java line
>> 97:
>>
>>> 95: uri =
>>> FXMedia.class.getResource("/fxmediaplayer/media").toURI();
>>> 96:
>>> 97: if (uri.getScheme().equ
> - Added support for JAR and JRT protocol to AVFoundation platform.
> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
> primary used to playback these formats for JAR and JRT protocols.
> - Added ability to FXMediaPlayer sample to generate playlist for JAR and JRT
> prot
On Wed, 12 Oct 2022 22:57:51 GMT, Andy Goryachev wrote:
>> Spelling fixed and javafx.base and javafx.graphics is removed. I do not
>> think that we need to worry about javadoc, since we do not generate it for
>> this app.
>
> This is just a suggestion, really, especially if it is in test code.
On Wed, 12 Oct 2022 22:36:09 GMT, Alexander Matveev
wrote:
>> Also minor: you can shorten the command lines by removing `javafx.base` and
>> `javafx.graphics` from the list of added modules, since `javafx.controls`
>> transiently requires them.
>
> Spelling fixed and javafx.base and javafx.gra
> - Added support for JAR and JRT protocol to AVFoundation platform.
> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
> primary used to playback these formats for JAR and JRT protocols.
> - Added ability to FXMediaPlayer sample to generate playlist for JAR and JRT
> prot
On Tue, 11 Oct 2022 21:19:05 GMT, Kevin Rushforth wrote:
>> modules/javafx.media/src/main/native/jfxmedia/Locator/Locator.cpp line 73:
>>
>>> 71: if (javaEnv.clearException())
>>> 72: return NULL;
>>> 73:
>>
>> minor: would it make sense to wrap return in { }, line 67 and 72?
>
> A
On Tue, 11 Oct 2022 15:37:15 GMT, Andy Goryachev wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8287822: [macos] Remove support of duplicated formats from macOS [v2]
>
> tests/manual/media/FXMediaPlayer/src/f
On Tue, 11 Oct 2022 21:07:34 GMT, Kevin Rushforth wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8287822: [macos] Remove support of duplicated formats from macOS [v2]
>
> modules/javafx.media/src/main/java/co
On Tue, 11 Oct 2022 00:01:18 GMT, Alexander Matveev
wrote:
> - Added support for JAR and JRT protocol to AVFoundation platform.
> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
> primary used to playback these formats for JAR and JRT protocols.
> - Added ability to FXM
On Tue, 11 Oct 2022 00:01:18 GMT, Alexander Matveev
wrote:
> - Added support for JAR and JRT protocol to AVFoundation platform.
> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
> primary used to playback these formats for JAR and JRT protocols.
> - Added ability to FXM
On Tue, 11 Oct 2022 15:44:46 GMT, Andy Goryachev wrote:
>> - Added support for JAR and JRT protocol to AVFoundation platform.
>> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
>> primary used to playback these formats for JAR and JRT protocols.
>> - Added ability to FXM
On Tue, 11 Oct 2022 00:01:18 GMT, Alexander Matveev
wrote:
> - Added support for JAR and JRT protocol to AVFoundation platform.
> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
> primary used to playback these formats for JAR and JRT protocols.
> - Added ability to FXM
- Added support for JAR and JRT protocol to AVFoundation platform.
- Removed H.264/MP3 and AAC support from GStreamer platform, which was primary
used to playback these formats for JAR and JRT protocols.
- Added ability to FXMediaPlayer sample to generate playlist for JAR and JRT
protocols for
18 matches
Mail list logo
