Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). Marked as re

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). > > Will wai

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). Marked as re

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 23:19:56 GMT, Andy Goryachev wrote: > It's just weird - allowing core classes to override yet denying this freedom > to the app dev. I don't think these classes should have existed. They don't add any functionality and could have been specialized constant implementations.

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 23:36:56 GMT, Nir Lisker wrote: > Saves upkeeping 2 copies. this should be a standard operating procedure, in my opinion. - PR Comment: https://git.openjdk.org/jfx/pull/1294#issuecomment-1821864861

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). CSR is neede

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). Is the const

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). so the app d

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). No, they wou

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). The question

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). `DateTimeStr

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `DateTimeStringConverter` and > `DateTimeStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). Sorr

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:47:36 GMT, Andy Goryachev wrote: > Are we going to make all these private at some point? They are going to be made package-private so that they are not public API while still can be read by subclasses. There's no "internal protected" visibility that would be ideal here.

Re: RFR: 8314597: Deprecate for removal protected access methods in converters

On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote: > Deprecating for removal `getDateFormat()` in `DateTimeStringConverter` and > `DateTimeStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). Are

RFR: 8314597: Deprecate for removal protected access methods in converters

Deprecating for removal `getDateFormat()` in `DateTimeStringConverter` and `DateTimeStringConverter` after it was removed already in `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` (and subclasses). - Commit messages: - Deprecate protected methods Ch