[Openocd-development] [patch 2/2] thumb2 disassembly for Load halfword

2009-07-22 Thread David Brownell
More ARMv7-M disassembly: A5.3.8 Load halfword, unallocated memory hints Plus update comment; "A5.3.13 Miscellaneous operations" is covered by previous code. Compile-tested; I don't have code that currently emits these LDRxH operations. --- For the record, remaining not-recognized instru

Re: [Openocd-development] [patch 2/2] thumb2 disassembly for Load halfword

2009-07-23 Thread Øyvind Harboe
Both committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://www.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [patch 2/2] thumb2 disassembly for Load halfword

2009-07-23 Thread Andreas Fritiofson
I noticed there are a few checks for (rt == 0xf) even though that case is handled with an early return at the top of the function. Maybe those checks should just go? /Andreas Index: src/target/arm_disassembler.c === --- src/target/a

Re: [Openocd-development] [patch 2/2] thumb2 disassembly for Load halfword

2009-07-23 Thread David Brownell
On Thursday 23 July 2009, Andreas Fritiofson wrote: > I noticed there are a few checks for (rt == 0xf) even though that case > is handled with an early return at the top of the function. > > Maybe those checks should just go? Yes, they should. They're leftovers. > /Andreas > > Index: src/targ

Re: [Openocd-development] [patch 2/2] thumb2 disassembly for Load halfword

2009-07-23 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://www.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development