Nack.
1. Do the same changes for AmStart and AmStop.
2. The below check is not required once validation is done at amfd:
> + if ((res != 0) && (comptype->saAmfCtRelPathCleanupCmd[0] != '/')) {
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:osafde...@gmail.com]
> Sent: 0
Nack.
In general, not only instantiate, but other clc commands has to be validated at
amfd.
Logic should be
if (saAmfCtSwBundle is configured), then clc commands should not start with /.
Else
if (saAmfCtSwBundle is not configured), then clc commands should start with /.
Thanks
-Nagu
> -Ori
osaf/services/saf/amf/amfnd/amfnd.cc|4 +-
osaf/services/saf/amf/amfnd/cbq.cc |4 +-
osaf/services/saf/amf/amfnd/ckpt_updt.cc| 18 +-
osaf/services/saf/amf/amfnd/comp.cc | 11 +-
osaf/services/saf/amf/amfnd/compdb.cc |6 +-
osa
Summary: amfnd: errors reported by valgrind (V2) [#716]
Review request for Trac Ticket(s): 716
Peer Reviewer(s): Hans N, Nagendra
Pull request to:
Affected branch(es): default, opensaf-4.4.x
Development branch: default
Impacted area Impact y/n
-
Ack.
Thanks,
Ramesh.
On 1/27/2014 7:04 PM, mathi.naic...@oracle.com wrote:
> osaf/services/saf/clmsv/nodeagent/main.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>
> During opensaf startup, when clmna talks to CLMS, the MDS send may timeout
> in some situations, there is a
Ack
Thanks
-Nagu
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: 24 January 2014 11:56
> To: hans.nordeb...@ericsson.com; gary@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [devel] [PATCH 1 of 1] amfd: fix out-of-bounds read from no
Summary: logsv: Fix updating of log root directory when check-pointing lgs
config [#711]
Review request for Trac Ticket(s): #711
Peer Reviewer(s): mathi.naic...@oracle.com
Pull request to:
Affected branch(es): 4.4
Development branch: <>
Impacted area Impact
osaf/services/saf/logsv/lgs/lgs_imm.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Fix updating of lgs_cb when logRootDirectory is check pointed.
diff --git a/osaf/services/saf/logsv/lgs/lgs_imm.c
b/osaf/services/saf/logsv/lgs/lgs_imm.c
--- a/osaf/services/saf/logsv/lgs/lgs_imm.c
Summary: logsv: Fix checkpoint version handling [#688]
Review request for Trac Ticket(s): #688
Peer Reviewer(s): mathi.naic...@oracle.com
Pull request to:
Affected branch(es): 4.4
Development branch: <>
Impacted area Impact y/n
--
Summary: clm: avoid double free during send timedout [#727]
Review request for Trac Ticket(s): #727
Peer Reviewer(s): ramesh.bet...@oracle.com
Pull request to: <>
Affected branch(es): 4.4, default
Development branch: <>
Impacted area Impact y/n
-
osaf/services/saf/clmsv/nodeagent/main.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
During opensaf startup, when clmna talks to CLMS, the MDS send may timeout
in some situations, there is a double free in the case when send timesout.
The patch avoids theis double free.
diff --g
osaf/tools/safimm/immcfg/imm_import.cc | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/osaf/tools/safimm/immcfg/imm_import.cc
b/osaf/tools/safimm/immcfg/imm_import.cc
--- a/osaf/tools/safimm/immcfg/imm_import.cc
+++ b/osaf/tools/safimm/immcfg/imm_import.cc
Summary: IMMTOOLS: fix double freeing memory in immcfg [#749]
Review request for Trac Ticket(s): 749
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.4.x, default(4.5)
Development branch: default(4.5)
Impacted area Impact y/n
ack, only code review/BR HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 24 januari 2014 07:26
To: Hans Nordebäck; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: fix out-of-bounds read from nodelist array [#719]
osaf/ser
Hi AndersBj,
Reviewed the Patch.
Ack.
/Neel.
On Friday 24 January 2014 10:32 PM, Anders Bjornerstedt wrote:
> Summary: IMM: Clarify that completed-callback isa meaningsless for appliers
> (#748)
> Review request for Trac Ticket(s): 748
> Peer Reviewer(s): Neel
> Pull request to:
> Affected bran
Hi AndersBj,
Reviewed the patch.
Ack
/Neel.
On Friday 24 January 2014 09:00 PM, Anders Bjornerstedt wrote:
> Summary: Correct misleading comments in saImmOm_A_2_12.h and saImmOm_A_2_13.h
> (#747)
> Review request for Trac Ticket(s): 747
> Peer Reviewer(s): Neel
> Pull request to:
> Affected bran
Ack
Thanks
-Nagu
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: 13 January 2014 13:01
> To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com;
> gary@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [devel] [PATCH 1 of 1] imported
osaf/libs/core/common/daemon.c | 2 +-
osaf/services/saf/amf/amfd/ndfsm.cc | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
amfd to exit immediately upon receiving local amfnd down [#728]
Today amfd exits when the /etc/init.d/opensafd script invokes osaf-amfd clc-cli
script. Th
Summary: v2.0: amfd to exit immediately upon receiving local amfnd down [#728]
Review request for Trac Ticket(s): #728
Peer Reviewer(s): Hans/Nagendra
Pull request to: <>
Affected branch(es): opensaf-4.4.x, default
Development branch: <>
Impacted area Impact
19 matches
Mail list logo
