Please find my comments inline
Thanks,
Minh
On 7/4/2014 9:48 PM, Zoran Milinkovic wrote:
> Hi,
>
> Find my comments on ntfsv_sanamet_clone_strptr cases inline.
>
> -Original Message-
> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
> Sent: den 2 juli 2014 07:50
> To: Anders Widell;
Please find comments inline
Thanks,
Minh
On 7/4/2014 9:48 PM, Zoran Milinkovic wrote:
> Hi,
>
> Find my comments inline started with [Zoran].
>
>
> -Original Message-
> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
> Sent: den 2 juli 2014 07:50
> To: Anders Widell; mathi.naic...@or
Ack with:
Amf PR doc update for SU creation in locked state and deletion in unlocked
state if sg/node admin state is locked-in or node is absent.
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:hans.fe...@ericsson.com]
> Sent: 04 July 2014 15:41
> To: Praveen Malviya
> Cc: o
Hi,
Find my comments inline started with [Zoran].
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: den 2 juli 2014 07:50
To: Anders Widell; mathi.naic...@oracle.com; Hans Feldt;
praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [d
Hi,
Find my comments on ntfsv_sanamet_clone_strptr cases inline.
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: den 2 juli 2014 07:50
To: Anders Widell; mathi.naic...@oracle.com; Hans Feldt;
praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.n
> -Original Message-
> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 4 juli 2014 13:44
> To: Hans Feldt; Hans Nordebäck; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [PATCH 1 of 1] amfd: allow admin commands before cluster timer
> expiry [#62
Thanks for your review. I will incorporate these changes. Is this an Ack then?
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:hans.fe...@ericsson.com]
> Sent: 04 July 2014 16:47
> To: Nagendra Kumar; Hans Nordebäck; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net
>
Ack, comment inline
/Hans
> -Original Message-
> From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
> Sent: den 23 juni 2014 14:14
> To: Hans Feldt; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 4 of 4] amfnd : inform AMFD to send error
Ack with minor comments inline
/Hans
> -Original Message-
> From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
> Sent: den 23 juni 2014 14:14
> To: Hans Feldt; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 2 of 4] amfd : send error repo
Ack, only code review. See inline for minor comments
/Hans
> -Original Message-
> From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
> Sent: den 30 maj 2014 07:52
> To: Hans Feldt; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] a
Ack, minor comments inline. Not tested
/Hans
> -Original Message-
> From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
> Sent: den 9 juni 2014 16:09
> To: Hans Feldt; nagendr...@oracle.com; Hans Nordebäck
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1]
Just review, see inline
/Hans
> -Original Message-
> From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
> Sent: den 30 juni 2014 12:48
> To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] amfd: allow admin
osaf/services/saf/amf/amfd/su.cc | 19 ---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/su.cc b/osaf/services/saf/amf/amfd/su.cc
--- a/osaf/services/saf/amf/amfd/su.cc
+++ b/osaf/services/saf/amf/amfd/su.cc
@@ -1361,9 +1361,21 @@ stat
Summary: AMF #911 part 2
Review request for Trac Ticket(s): <>
Peer Reviewer(s): AMF devels
Pull request to: <>
Affected branch(es): default
Development branch: <>
Impacted area Impact y/n
Docsn
Build sys
14 matches
Mail list logo
